From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E3F3C7EE2A for ; Mon, 23 Jun 2025 03:16:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D629F6B00AD; Sun, 22 Jun 2025 23:16:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D136D6B00AF; Sun, 22 Jun 2025 23:16:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C28D06B00B0; Sun, 22 Jun 2025 23:16:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AF8106B00AD for ; Sun, 22 Jun 2025 23:16:37 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 332211D920A for ; Mon, 23 Jun 2025 03:16:37 +0000 (UTC) X-FDA: 83585202834.05.8C20A64 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf15.hostedemail.com (Postfix) with ESMTP id 7C40FA000C for ; Mon, 23 Jun 2025 03:16:34 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750648595; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7dVp6D821nNIzmFgZi5bwQULxU5Jc575Q0Xchw0W8/0=; b=U4eegDUGSSsxtS8eQV+vsJRrvU0/U2+YPnplOiqELaYep8AmB+1sasL9NCxxuoV2P0+Wox hAGfH9AXl2FsIvV3F1sjXeFYOVI/IpWdW5rG4QmsCQxTFuI/Igm1s29STzYtyqyYL+GV8l HE2BXnGdsqgnPfhJOQV1tKbonEIg+dM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750648595; a=rsa-sha256; cv=none; b=UkJYeqS4+neBFkXUIbVipKQbrrIUfykGwUtsWI53CyDSEUkz70Yio7i6FHqICEH7BVR+np RQ6MASc0Dr/Yquk1p38QDIIDqPUfP8rz5gtQyAuhYkOTdeWS9Do2qUwJvPBf5F3XgrzIFc mG+E+fT1sjwMw7u3Mk1/36XB18BRRe0= X-AuditID: a67dfc5b-681ff7000002311f-55-6858c7100f23 Message-ID: Date: Mon, 23 Jun 2025 12:16:32 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: kernel_team@skhynix.com, damon@lists.linux.dev, Andrew Morton , linux-mm@kvack.org, Yunjeong Mun Subject: Re: [PATCH 3/3] samples/damon: fix bugs for damon sample for start failures Content-Language: ko To: SeongJae Park References: <20250622162935.51108-1-sj@kernel.org> From: Honggyu Kim In-Reply-To: <20250622162935.51108-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLLMWRmVeSWpSXmKPExsXC9ZZnoa7A8YgMgylNUhZz1q9hs3jy/zer xb01/1ktDn99w+TA4rFpVSebx6ZPk9g9Tsz4zeLxYvNMxgCWKC6blNSczLLUIn27BK6M3mWL mAr2S1d8mfqLqYHxjmgXIyeHhICJRM/7/Uww9vGG7cwgNq+ApcSsLXPAbBYBVYn2o5NZIOKC EidnPgGzRQXkJe7fmsEOYjMLzGSUeHOKB8QWFgiTmLhiOxtEXERidmcb2BwRAUWJc48vsoLY QgJGEgfnbADrZRNQk7jychLYDZwCxhL9H64yQfSaSXRt7WKEsOUltr8FuYcL6M4FbBL9Jxew QBwtKXFwxQ2WCYyCs5DcNwvJ7llIZs1CMmsBI8sqRqHMvLLcxMwcE72MyrzMCr3k/NxNjMBA X1b7J3oH46cLwYcYBTgYlXh4E3giMoRYE8uKK3MPMUpwMCuJ8B5yCssQ4k1JrKxKLcqPLyrN SS0+xCjNwaIkzmv0rTxFSCA9sSQ1OzW1ILUIJsvEwSnVwOjF42Tm4Pl70uKUDck2xh+nVOi9 +M5zQv1m/69vJw5VszeuerPgwaToiI/TtnBMe/t9/cyGvi7nLV+nSWyymyB184H0kd7qqYYL d7dEMfo4WX+r3ria7S57Nkv52ne5c+Y13F7Ptf/fTtvMjed7Uvwt5y7P2BPJ1BNi+uaE6m6G GRMCnnzUvLpSiaU4I9FQi7moOBEArtq7pXACAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLLMWRmVeSWpSXmKPExsXCNUNLT1fgeESGwe99vBZz1q9hs3jy/zer xeG5J1kt7q35D2R9fcNk8XvbCjYHNo9NqzqBxKdJ7B4nZvxm8XixeSajx7fbHh6LX3xgCmCL 4rJJSc3JLEst0rdL4MroXbaIqWC/dMWXqb+YGhjviHYxcnJICJhIHG/Yzgxi8wpYSszaMgfM ZhFQlWg/OpkFIi4ocXLmEzBbVEBe4v6tGewgNrPATEaJN6d4QGxhgTCJiSu2s0HERSRmd7aB zRERUJQ49/giK4gtJGAkcXDOBrBeNgE1iSsvJzGB2JwCxhL9H64yQfSaSXRt7WKEsOUltr+d wzyBkW8WkjNmIVkxC0nLLCQtCxhZVjGKZOaV5SZm5pjqFWdnVOZlVugl5+duYgQG8rLaPxN3 MH657H6IUYCDUYmHd4V3RIYQa2JZcWXuIUYJDmYlEd5DTmEZQrwpiZVVqUX58UWlOanFhxil OViUxHm9wlMThATSE0tSs1NTC1KLYLJMHJxSDYxXklwneVmuM43yX7Axy1tuT6yPK/elW/cX T06Lelyt5lZjm65eNuvuQm3fB2EX2iVPaZpXvGnc6PiPtU69MFzSlS24aWLc9xAbn5Vffta4 zbEr/iTE/uVU6k6b1ZZZ7PprfQTUuBy43q7bUvVkZhnL9qerBPKvHtXlv7rIxFW4d4697h1G FSWW4oxEQy3mouJEAAjiNFNgAgAA X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 7C40FA000C X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: c1ws8r6hatkg4ee3uuuzdoxnsxsedo1t X-HE-Tag: 1750648594-64163 X-HE-Meta: U2FsdGVkX19GpbD6r/7S34pFRYk4rct2Hw3unbJe+vNZ/30xbpT5Q2umFY6HmuiuWAxWS/xIWo+mJ+BqblV5dmgn+N89WXwLGFK4rSA5RFd40zA8ibUuCbOm0LK+eEM6ru6Tfl3abFhXqbVGfwZNfjY36ATqGBSjKdBRimqJ9cKgTuo28/YgcRR8PVXyo+j3/ZQS97gycRQ23qlBWQcBhW64V5lRUHfTV8pkThGwIAiMcH03OzFWh3RFRBOVHaZ4X4rvPNGJA2i9N9wheQv1i+TlYct0RyRdubUVDm4KOppLdc3citca6eb0eueYaMOVETQWbcCRhHSGP4H2n54mrvbXtCq7XJMyccK3Yb8l2wdsfaiagFyhHnAzfNoA48cYOdDIwZcH5KEkm3USdRHtYF3wr51Nls9BziM1OP/loZ/nDjOIiMafGRDgVQo5/O6tmjth3YbzCa7XCrLYhJhxrs2lhXHibNYsVfwnsqhywyZKK5dJXbNkzfulyHtw9wyOf+93kLg/0/JEoy7BjWYEJN0qJXQ2fPaJvFckOkAu+L8AOmunvRnc5MiB3WaTTTooNCXNDMq6csHf26QkCVjSm1Nje0x8kHilcdX3X1zolttrkxzcqy7BsxEoipqemqwhrWRDL6PYarIIXToo8G2ngoeP07tAfZ8PdQPyB+8UMF7DT/GU7Hy1TtNOkpbXJ3StrZ7bwwq7++aes3uPVcwiQR9MGbs2P9Z06fhaW2hT+UwFv9VMyg2hebIVC7nWCr5Pz8iZi9ju4JfIK9UJxLCI/CXg0ObODbY/XSnmA/Fac8liMEGfRiCJ6Z4JPEyxsAMmt8Ozk1SOf71EyL9jhywvck6ye2YpzbtDJOhDmMfJOkki++IJ/sLhdTY9cZJmxY73+zefmeBr+PzEz6gyiult/tVYEQgq6HMVBMLMlXMNSdL2CiA5rSDwoIlYylvafOnNsqWOwA/jXgl69/9yRdp qkvTc7eI XYLI2MzV+L2Hr+VaUoJwfRKUDjOFToTBvE+AeXbUPZDRkTPaCc5fI3Ijt/TEEWrqc2eDitZCAvUp1+ndSEqSNx1dOgCPz5M5KK7ZJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi SeongJae, On 6/23/2025 1:29 AM, SeongJae Park wrote: > Hi Honggyu, > > On Sun, 22 Jun 2025 21:09:25 +0900 Honggyu Kim wrote: > >> The damon_sample_{wsse,prcl,mtier}_start() can fail so we must reset the >> "enabled" parameter to "false" again for proper rollback. >> >> In such cases, setting Y to "enabled" then N triggers the following >> crash because damon sample start failed but the "enabled" stays as Y. >> >> [ 2441.419649] damon_sample_prcl: start >> [ 2454.146817] damon_sample_prcl: stop >> [ 2454.146862] ------------[ cut here ]------------ >> [ 2454.146865] kernel BUG at mm/slub.c:546! >> [ 2454.148183] Oops: invalid opcode: 0000 [#1] SMP NOPTI >> ... >> [ 2454.167555] Call Trace: >> [ 2454.167822] >> [ 2454.168061] damon_destroy_ctx+0x78/0x140 >> [ 2454.168454] damon_sample_prcl_enable_store+0x8d/0xd0 >> [ 2454.168932] param_attr_store+0xa1/0x120 >> [ 2454.169315] module_attr_store+0x20/0x50 >> [ 2454.169695] sysfs_kf_write+0x72/0x90 >> [ 2454.170065] kernfs_fop_write_iter+0x150/0x1e0 >> [ 2454.170491] vfs_write+0x315/0x440 >> [ 2454.170833] ksys_write+0x69/0xf0 >> [ 2454.171162] __x64_sys_write+0x19/0x30 >> [ 2454.171525] x64_sys_call+0x18b2/0x2700 >> [ 2454.171900] do_syscall_64+0x7f/0x680 >> [ 2454.172258] ? exit_to_user_mode_loop+0xf6/0x180 >> [ 2454.172694] ? clear_bhb_loop+0x30/0x80 >> [ 2454.173067] ? clear_bhb_loop+0x30/0x80 >> [ 2454.173439] entry_SYSCALL_64_after_hwframe+0x76/0x7e > > Thank you for finding and fixing this! > >> >> Since it's just a sample module, no need to add it to stable tree. > > I agree this is not a real bug. But, even a bug in DAMON unit test was > deserved to get a CVE id. Hence I'd suggest adding at least Fixes: tag here, > and let stable kernels maintainers to decide whether to pick this up to stable > kernels or not. I can help backporting if needed. > > If you agree, I think we could add > > Fixes: b757c6cfc696d ("samples/damon/wsse: start and stop DAMON as the user requests") > > If we want to make stable kernel maintainers' life easier, we would better to > split this into three patches, for each module, and add appropriate Fixes, as > below. Spliting this into three patches is okay. > > For wsse, > Fixes: b757c6cfc696d ("samples/damon/wsse: start and stop DAMON as the user requests") > > For prcl, > > Fixes: 2aca254620a8 ("samples/damon: introduce a skeleton of a smaple DAMON module for proactive reclamation") > > For mtier, > > Fixes: 82a08bde3cf7 ("samples/damon: implement a DAMON module for memory tiering") > > Could you please do so? If we do, then this patchset has to come before "enabled" renaming patch. In addition, I remember mixing stable and non-stable patches together in the same patchset isn't welcomed by Andrew or other stable tree maintainers. So I might be better to split those three fix patches into a separate patchset. The only thing that bothers me in that case is writing cover letter for simple 2 or 3 patches as they are relatively simple. But it isn't that hard so can manage those in the next spin. > >> >> Signed-off-by: Honggyu Kim >> Cc: Yunjeong Mun > > Regardless of your agreement on adding Fixes: > > Reviewed-by: SeongJae Park > > > Thanks, > SJ Thanks, Honggyu > > [...]