From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A8E6C77B60 for ; Fri, 28 Apr 2023 13:48:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 009096B0071; Fri, 28 Apr 2023 09:48:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFAC86B0072; Fri, 28 Apr 2023 09:48:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC2ED6B0074; Fri, 28 Apr 2023 09:48:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CB5AE6B0071 for ; Fri, 28 Apr 2023 09:48:14 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 548461C67F7 for ; Fri, 28 Apr 2023 13:48:14 +0000 (UTC) X-FDA: 80730928908.14.B5301F4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id E517520020 for ; Fri, 28 Apr 2023 13:48:11 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SFwY5LaZ; spf=pass (imf03.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682689692; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jmGtCEfUXv1Vp+ULFOpSFCFJecVFUn3MtTRtzSJL8k0=; b=pLjS2trWAj32QiSwCRcDfJPABeURjgsLeqyEg/b8DHZCLDLZ12yln5vUwNNlceGlOT5cL/ rViY3s1o20n6JA5xhjQ3Nv0WUB1TLN5JZA4+JH7GODhmj5qIN3c++nGbFFHKnHG2LRIbDq oIs0y64x2dX4ktlna/l6/zkkw/yOGEs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682689692; a=rsa-sha256; cv=none; b=A/kq9TkKWmDxpyyq5rA3/OmN4L1CtDwOI9qu/+kxfpXGpCeCJp8Z373tqSSPqD9HRgS5c+ hUiEaAmvIxbEkShV2rddyhZWXM0jPTzHdwFINUQj4HSsnxOwy9Spal1rOivXwaEX/tKrPN OgYhVE6qbfu9uJQoxhHDBbgvuB+2qCs= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SFwY5LaZ; spf=pass (imf03.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682689691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jmGtCEfUXv1Vp+ULFOpSFCFJecVFUn3MtTRtzSJL8k0=; b=SFwY5LaZzuen+qEKaEyIGwRRyXlauDx9L99P+lXpcb7Gs/DxeM7SQlMljKylKbq2pI8Kes 0zEvwloj9p2Q8Gv8Z4gykPhLIdiBG9TuD4sO8otOHw5o4aLkCH9P0jr9fE672PswU1bbFp 0kDIny9uRW9myvmNng37R/+eS8OdyII= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-571-cusKzC8OOniqqFfu4XJL-g-1; Fri, 28 Apr 2023 09:48:09 -0400 X-MC-Unique: cusKzC8OOniqqFfu4XJL-g-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-94f2d9389afso941159666b.2 for ; Fri, 28 Apr 2023 06:48:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682689688; x=1685281688; h=content-transfer-encoding:in-reply-to:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jmGtCEfUXv1Vp+ULFOpSFCFJecVFUn3MtTRtzSJL8k0=; b=l16/nd7QRsHKqrMw0j56Rvd44DOFSwHkepFeD7UoGN3lNgT263lFBsHabP3DUPcN3V XHJYUY0unU2a3MOb2vn/YOqYR2xdNdswPLtThJbI5+vauXjMzuhBo5v20Sr4dyv8Aocf ipIp7HYFV+zXYsJO+OVUEl/7w4ZL9jGI+KN98T1b2tuNkNv8vJIAeS7vwPkfpbAmWyvf HXSe/WHZBRg2GAmT2bM6f1OW/fX/cxxl8k9n7bIzXB/aV42AQ53PMxa0VztcsKQKH/BK tawnR//9y5jNSoe1UXfscEHfuflygD086amCWiEbNH0/nP1yeAGY3Z+vEBoYu8KMxOvg 6KPA== X-Gm-Message-State: AC+VfDzWYmKKEIJAg2KQiVK8HM41q80Oh/6C8DudXvgDof+mql0WJEmw ONs3ZB1f9olEqpjhUsxlFjiM7Di08YBGikZZajRH0hWKWGPR3iSZgGN0RkQ2Vc0CCr+VfR7HGwD z93fFgGB+QV8= X-Received: by 2002:a17:907:7fa1:b0:94e:fe77:3f47 with SMTP id qk33-20020a1709077fa100b0094efe773f47mr7109104ejc.67.1682689688503; Fri, 28 Apr 2023 06:48:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5t1ePMr3EFTQiRFXhOYJ5rDjHjJLZ/nUd7rk/dh2ocoIyXuYny0i8hZmcckTd67WikHzfiIg== X-Received: by 2002:a17:907:7fa1:b0:94e:fe77:3f47 with SMTP id qk33-20020a1709077fa100b0094efe773f47mr7109082ejc.67.1682689688144; Fri, 28 Apr 2023 06:48:08 -0700 (PDT) Received: from [192.168.42.222] (194-45-78-10.static.kviknet.net. [194.45.78.10]) by smtp.gmail.com with ESMTPSA id g23-20020a170906395700b0094f16a3ea9csm11169383eje.117.2023.04.28.06.48.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Apr 2023 06:48:07 -0700 (PDT) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: Date: Fri, 28 Apr 2023 15:48:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Cc: brouer@redhat.com, lorenzo@kernel.org, linyunsheng@huawei.com, bpf@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Paolo Abeni , Andrew Morton , willy@infradead.org Subject: Re: [PATCH RFC net-next/mm V2 1/2] page_pool: Remove workqueue in new shutdown scheme To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , Ilias Apalodimas , netdev@vger.kernel.org, Eric Dumazet , linux-mm@kvack.org, Mel Gorman References: <168262348084.2036355.16294550378793036683.stgit@firesoul> <168262351129.2036355.1136491155595493268.stgit@firesoul> <871qk582tn.fsf@toke.dk> In-Reply-To: <871qk582tn.fsf@toke.dk> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: E517520020 X-Rspamd-Server: rspam09 X-Stat-Signature: dmfzbc6pgrxjsh4cofti87apy9da5grq X-HE-Tag: 1682689691-634218 X-HE-Meta: U2FsdGVkX1+qMpEoe+jifHu1H5FupreEhf2eU8Ta/jcvfndF3MQV5wtXl+QTndxbjfdLHtgDr1ZnHHHjdCj0c2tUvJChedGD/fe3ViagiYauskzQQJhbADxLbet/ZHNJiT1qkQWgo86SvEay9VYgnNcikEL4C9qDASSElCALCZqm5tJ3HujyzwXktweHb5leDW1ZZtQxuWlrVv9GpcJVwKiV47kcAo3FJ0Cvt6R60l4dLQxsqu5eeuEUy7XZStLf0GDp8uUex225Gku+TOpNrFrQgu6n6ubCc500mqTPgR73AOM8SIwG1kiRIOE5X5zkmr+W+cb3iuMJLCBI5c3n+EQpQkwSDmL+HUkTXwUYxO/Sn0JaGxw3VpYbWLQCPpBeYe0R+yzaQiSduv36QD71aDnnNiL907+QtE2is1LcL7aV0IzvUsHpUemHHnD2aIa5fTwg4EoWo3mKoFjzksCzwA6eCAp7R+4keW2N13Dvy47MJTvsTkmbdzyaIYwr0pwZ22jA8aq9bJVNSlFP+PZz3tM4ogpda4APUQ36cb7vZSj0rO2iestmzdPsQgxC7/MIQK0WhEEzY3Lj8sTruKZZs1VM1nwaA1bTYCdS46M81oA83oZkyjLz/GUoSo9eNXrQHRhb50PBYYuoNF8xpL6UPYIW+O4yogNr28DiDYO82YTpbWrGR6rFkHXHh73ysd/7yZ+mB/KD0S8oOqQ0I+iecEU0Tx2CK8zD1+N9v491K8IgtuFl8VoOhmsqlAHbW2aoEqdJWWr6gLYpJy5kq8yL4ZNAvYrXW4uMC4azlaJeL/WnkQ/PYii794AIgghVM1S2Iu3jta8zsVbPYWf6VIM3wt0vO5h7TuOPmBYywsxFrXsFxjOZk+ayrLgC+j5Ox7VYUOAtnUK7SY9dzc/j1EPpbgKZnLsHqn3LTffaREwqZBZjxHnbF+zRl0GMMffdacaphnLkL/v4ex1K+RaEo02 P9wQXEtO z3SQ5TkKE6lAYKzfZwq5ecdtar/QO0k86upNLgZbOy6YavJIoYGmcOpem3RV+fbe28wyMVdbOA027UrqeNBnz6CsZBdjW3zta/9xPtixyx7zRGiAr6+fGUpPl0HS8QWcgPKYqk1aVNIYtitaEaQo0rS/PmsV4ytSKf/0btsxOMw0n10J6dY24kBYMfUCrg0LEpwamlfpwVEsHTZ7RP8Jsf7uBwgVjVd7BvZGX2H1zw4YZTDUJE9fxJMJ23GdfBMNpmSaYUkUHHXTTR2yMJufzxJDCyxlDRAXsnJDNOM8S1gG7Zc9Pc40gh9bWFtZA0spo39emfOVWwPfq3oy66fOAyv2/9xze30sScJnMUDDM8nxqYUO8DWkMIKzuZuW9SloIUNdA/qSpPME+A6qkcSv3yTJt/oHo6wsu58PDKzLOTPUHs1KDPZzRte/apAZ3nPGVkWtToRKLTIxGvu/TYCOWyDJ1AfeVdv15K81MdVmT5yhuaaM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27/04/2023 22.53, Toke Høiland-Jørgensen wrote: >> @@ -490,11 +508,15 @@ void page_pool_release_page(struct page_pool *pool, struct page *page) >> skip_dma_unmap: >> page_pool_clear_pp_info(page); >> >> - /* This may be the last page returned, releasing the pool, so >> - * it is not safe to reference pool afterwards. >> - */ >> - count = atomic_inc_return_relaxed(&pool->pages_state_release_cnt); >> - trace_page_pool_state_release(pool, page, count); >> + if (flags & PP_FLAG_SHUTDOWN) >> + hold_cnt = pp_read_hold_cnt(pool); >> + >> + release_cnt = atomic_inc_return(&pool->pages_state_release_cnt); >> + trace_page_pool_state_release(pool, page, release_cnt); >> + >> + /* In shutdown phase, last page will free pool instance */ >> + if (flags & PP_FLAG_SHUTDOWN) >> + page_pool_free_attempt(pool, hold_cnt, release_cnt); > > Since the assumption is that no new pages will be allocated once the > PP_FLAG_SHUTDOWN is set (i.e., hold_count can not increase in the case), > I don't think it matters what order you read the hold and release counts > in? So you could simplify the above to just: > >> + if (flags & PP_FLAG_SHUTDOWN) >> + page_pool_free_attempt(pool, pp_read_hold_cnt(pool), release_cnt); > and drop the second check of the flag further up? > > You could probably even lose the hold_cnt argument entirely from > page_pool_free_attempt() and just have it call pp_read_hold_cnt() directly? > I unfortunately think we have to keep this approach. The purpose is to read out data from *pool, such that it is safe to call page_pool_free_attempt() even when *pool memory have been freed. I believe there is a race window between atomic_inc_return() and freeing in page_pool_free_attempt(). (As we have tracepoints in this critical section we might even be able to increase the chance of the race) Imagine two CPUs freeing the last two PP pages. Hold=2 which means when release_cnt reach 2 inflight is zero. CPU-1 : release_cnt 1 = atomic_inc_return(); CPU-1 : gets preempted (or runs slow bpf-prog in tracepoint) CPU-2 : release_cnt 2 = atomic_inc_return(); CPU-2 : page_pool_free_attempt(pool, 2, release_cnt=2); CPU-2 : find no-inflight -> calls page_pool_free(pool) CPU-1 : page_pool_free_attempt(pool, 2, release_cnt=1); CPU-1 : *use-after-free* deref pool->pages_state_hold_cnt >> } >> EXPORT_SYMBOL(page_pool_release_page);