From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78EF1C7115C for ; Fri, 20 Jun 2025 14:47:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F28EE6B008A; Fri, 20 Jun 2025 10:47:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F00326B008C; Fri, 20 Jun 2025 10:47:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEE7D6B0092; Fri, 20 Jun 2025 10:47:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CBFD56B008A for ; Fri, 20 Jun 2025 10:47:07 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1CA7A5D512 for ; Fri, 20 Jun 2025 14:47:07 +0000 (UTC) X-FDA: 83576056494.23.4E72C70 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by imf20.hostedemail.com (Postfix) with ESMTP id 3CE3A1C000E for ; Fri, 20 Jun 2025 14:47:03 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="bRpEi/lY"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf20.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750430824; a=rsa-sha256; cv=none; b=k93GjUQlrejnuIa8DvdRb86UgxH4NaZaQD1ddnTqVyP9POr03lvA4N2aRR4/f38h01kz7f y+/M2VTXVOor8rF89av2jXWtMqo8AXPbMCLt2l7bLlnjnnif2ZQiY3j2VUi1+xV3jOeivE 0g/VVUN8NGBrSJSdpeIJquH2G6VOfzI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="bRpEi/lY"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf20.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750430824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pcJGWDAWpUkaiN4KiMVJhKT++8E1GdPM8R94/2ekR7g=; b=wRwsSyhdeguDLWhWWSg3sSGnVNDTOMEwdUBB/wEmG9J8q0zfBAE6ChpJKwkVDQwMI/+xBg UDjLahZoWT5bmWM7fr1Ik/i+rOJAeaeRZyOmFxcucTw+MckElpuaxENkD22Xw/yzfBGJBD DNwgBY7VhSiu/ZonFO8xyvOHqpfDXH8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750430825; x=1781966825; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=uMrGWGMdwOjXA/gFwRMq0UddnW5BcepqPgO6zhU2dBE=; b=bRpEi/lYdtnJaTBCX2vYTjWCAUSKwcEO9NuVb/6JFWlu2wspxzkdJS6h 4P40H5zJYgHMYuZj+R4lVX47U3viqI0qyyuW7wRJ89Mm4p75sQ+dFpvOL Nzv2USOUdIiyaaOVkNTDnttKjGOv4AH+FU2k9/TWBR7cVrQ/j8dLM+cW2 itgPCobk/l0xIC5MP9+CztG9rt4hZ9vM+lyVyqzu9leyH1/LyyUo5qIVi zX87mZzh1J2V1JDCydX0zvgnYzv2E8dpCLUGJKOoxTptcBYki3ctSdEe9 1lRx5dJ2VcCTPlVwo2M7vdRp743r7fq5YmSKsf45S5D2HqLdb0mybgQ6W g==; X-CSE-ConnectionGUID: OqIalpgkQnOeP3riQXV+IQ== X-CSE-MsgGUID: VsJGfXv/TtubZG39pGO8pA== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="52578642" X-IronPort-AV: E=Sophos;i="6.16,251,1744095600"; d="scan'208";a="52578642" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2025 07:47:03 -0700 X-CSE-ConnectionGUID: gZ+ODNqfRW2YFnRzwlctmA== X-CSE-MsgGUID: ubiI9QOCQx+7RNyCe1ijcg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,251,1744095600"; d="scan'208";a="155315112" Received: from aschofie-mobl2.amr.corp.intel.com (HELO [10.125.108.136]) ([10.125.108.136]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2025 07:47:01 -0700 Message-ID: Date: Fri, 20 Jun 2025 07:47:00 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv6 08/16] x86/traps: Consolidate user fixups in exc_general_protection() To: "Kirill A. Shutemov" , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Ard Biesheuvel , "Paul E. McKenney" , Josh Poimboeuf , Xiongwei Song , Xin Li , "Mike Rapoport (IBM)" , Brijesh Singh , Michael Roth , Tony Luck , Alexey Kardashevskiy , Alexander Shishkin Cc: Jonathan Corbet , Sohil Mehta , Ingo Molnar , Pawan Gupta , Daniel Sneddon , Kai Huang , Sandipan Das , Breno Leitao , Rick Edgecombe , Alexei Starovoitov , Hou Tao , Juergen Gross , Vegard Nossum , Kees Cook , Eric Biggers , Jason Gunthorpe , "Masami Hiramatsu (Google)" , Andrew Morton , Luis Chamberlain , Yuntao Wang , Rasmus Villemoes , Christophe Leroy , Tejun Heo , Changbin Du , Huang Shijie , Geert Uytterhoeven , Namhyung Kim , Arnaldo Carvalho de Melo , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org References: <20250620135325.3300848-1-kirill.shutemov@linux.intel.com> <20250620135325.3300848-9-kirill.shutemov@linux.intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250620135325.3300848-9-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 3CE3A1C000E X-Rspamd-Server: rspam10 X-Stat-Signature: ekr8rbe8jggp7rx1r8kswckzyt96hm81 X-HE-Tag: 1750430823-996641 X-HE-Meta: U2FsdGVkX18ajyd82LyI869EskvQq2sl4WD3EZLh5BkT+sWaw5MJGqcnfF8w4xEV/tVbYeoWeDakJANmanJEmc/pBRT3Os6ScVEsiM/brNrBS8Yy1ZMdaNxXCPNTBKPpi6YPAPZGiS2lI4ZQzyt8VnKwzHAaUq3TD519kNHPLENa6RbJ0f4Z0H4GVapmU8rlutUQigdJXMIGT4Em7O9ndKjan1qwCHtTAQBrVJevmggLWKwc5GbSbTAzjokdsv4LOPVhrDuTG5iXvfIM0u/vsPmvQYZhG8pJfh7xMX2aouOQRn6JQkmF7oFLp+Zgsdw7AAK3lFDgkjoOGib5uPPDsU/XFckseNV+ugHO17nB8Ua8RD45R1CnOuq8aJmC+F9uqIOlPOdOogoS72fnL/sXm3K8yl45mb0CsPlVOWQ2xNqm2SSBGXJ2eJWtzIWMB88Fr27cM+0vMRwLPXY7MzhS4wAX5GY1RjuQtLmBCyY9Aj2ZShh7EzSb39zRtkEG0hiN6jiipZVC16os19OZKcEH4IrAfZlSS88eA7F2LjCeTu0ZEOvInppDLxV7liKEveH+BxpsYyZU2sypEVsd4/uXy+AfQTk7Br604hI2+sKJfexdyYI7swR0rnkjZk1yuefMqfhJ0fd4PTSrswsJYHDY6l4yJVF4qNdkyK7CPDSrkiJz5nQT7NFPcds3fjLv8I2C3CzmClEuFhpEW8ymi0eKzyrTaaBDm2ystAfWXsK1v+hH+sS5dlTHrmGTgfyHn5ioLzV0AeveIveRVnJ/S9bMF/F1DIifftgaIT09azb+ekg8rJPGZMMbZc83TITbZpCyFyme6HnE5is4ZUtwcWuEIebTE8QcRDBFiuSBneuMVMfj4m9V7kz/MNG/SwR2moDXsnHMtRhEU2BCgng86hC0wfKmkUP6HTEYbQAvqPeg2886EOZrLVxUGk0C4Lo0cqLO4SK0Vix/PsGkVg6TX97 ZyC+RITW i7mbkQ1LA1vnrZWXWgArk3xCXpMWHB+z7R0Ub5eYtWMefV4HNgLeTm2pWKcwhH48f1BqZeFt4kfzlfuw+U3T0IC7BYLrA6gYPqI0dos93ZhqsvpRatFpCpNZODUwMwKStxC448zCucz1fPKZS6i/RnPkEu5KUk+aZXlcrgg8gW0Xf/4+MGN8CDQ3/TybAvYmCP4iak+Nx2i1MNCjheCq77azOPiCr8P7OvWhTWVv1HkbF+PfZkzst1Nt3c7Sog5IPcjBjxop+IV7Ou5glRP5j/r6Dr+0YWlNu2JMgZm7FONadT/WDTYkiVVhqEgYteVI0j6SijUSFhYKdkDTpeihvAJ+8nzKm6Re8mLcX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/20/25 06:53, Kirill A. Shutemov wrote: > @@ -819,6 +814,9 @@ DEFINE_IDTENTRY_ERRORCODE(exc_general_protection) > if (fixup_vdso_exception(regs, X86_TRAP_GP, error_code, 0)) > goto exit; > > + if (cpu_feature_enabled(X86_FEATURE_UMIP) && fixup_umip_exception(regs)) > + goto exit; I'd move the cpu_feature_enabled() check into fixup_umip_exception() just to make the exc_general_protection() code easier to look at. It'll force an extra (cheap) CALL, but this is a super cold code path anyway. With that: Acked-by: Dave Hansen