From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4CE2C433F5 for ; Fri, 27 May 2022 01:48:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 233138D0003; Thu, 26 May 2022 21:48:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2150B8D0002; Thu, 26 May 2022 21:48:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FAD38D0003; Thu, 26 May 2022 21:48:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F1D4F8D0002 for ; Thu, 26 May 2022 21:48:13 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B78F68D5 for ; Fri, 27 May 2022 01:48:13 +0000 (UTC) X-FDA: 79509837666.09.FDBA9C7 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf01.hostedemail.com (Postfix) with ESMTP id 7D7FE40044 for ; Fri, 27 May 2022 01:48:08 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4L8SP73f2NzDqND; Fri, 27 May 2022 09:47:55 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 27 May 2022 09:48:00 +0800 Subject: Re: [PATCH] mm: use PAGE_ALIGNED instead of IS_ALIGNED To: CC: , , Muchun Song , Andrew Morton References: <20220526140257.1568744-1-bh1scw@gmail.com> From: Miaohe Lin Message-ID: Date: Fri, 27 May 2022 09:48:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220526140257.1568744-1-bh1scw@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Stat-Signature: nnxu5ujyo79hfs7zjw5nbr7k94xc8utm X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7D7FE40044 X-HE-Tag: 1653616088-431487 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/5/26 22:02, bh1scw@gmail.com wrote: > From: Fanjun Kong > > The already provides the PAGE_ALIGNED macro. Let's > use this macro instead of IS_ALIGNED and passing PAGE_SIZE directly. > > Signed-off-by: Fanjun Kong Reviewed-by: Miaohe Lin Thanks! > --- > mm/sparse-vmemmap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c > index f4fa61dbbee3..49cb15cbe590 100644 > --- a/mm/sparse-vmemmap.c > +++ b/mm/sparse-vmemmap.c > @@ -200,8 +200,8 @@ static int vmemmap_remap_range(unsigned long start, unsigned long end, > unsigned long next; > pgd_t *pgd; > > - VM_BUG_ON(!IS_ALIGNED(start, PAGE_SIZE)); > - VM_BUG_ON(!IS_ALIGNED(end, PAGE_SIZE)); > + VM_BUG_ON(!PAGE_ALIGNED(start)); > + VM_BUG_ON(!PAGE_ALIGNED(end)); > > pgd = pgd_offset_k(addr); > do { >