From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 540A0C54E69 for ; Fri, 15 Mar 2024 09:39:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C56DC8010E; Fri, 15 Mar 2024 05:39:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C05CA800B4; Fri, 15 Mar 2024 05:39:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF5488010E; Fri, 15 Mar 2024 05:39:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A072D800B4 for ; Fri, 15 Mar 2024 05:39:45 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 447CD1C12E0 for ; Fri, 15 Mar 2024 09:39:45 +0000 (UTC) X-FDA: 81898776330.23.15D1BF2 Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 51EAF1C000E for ; Fri, 15 Mar 2024 09:39:41 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=C3aFG4x4; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf21.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710495583; a=rsa-sha256; cv=none; b=oS6J/Tk1VVzZkS/2B3AtoTrjz4h692y84vZcpCQP5spyXzBt0yPINuCTHcchcz+e1r+YS4 mY5kxz9HK65l3bJTRzzWtK/XM64LD7tOQjixA+j8iziUH+vK5Lrr8FLD57ZJp02VAzF7tk MvGm0+9BOF0thCX7+r3d93t5yUw1VIs= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=C3aFG4x4; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf21.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710495583; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CckLzddbXrBA7tLsEPMXeJY8BUpksVSkSO2q/7+hZh8=; b=MaP2vLkE98Cb5xP0TqUgZNI4Dpi9wo9yx8ZNziLpQ4p+MahFQlapBHDQCm+PQki5W4HA/a YvfDNq0ODsIUjC5sFZo38BkU8qs6vqffmGld30MPfsO1X1SOHajAcocmWYtZpP/YNuUKH7 z+gR+2kxiWhaGruaLHgW74ul1NrPInE= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1710495578; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=CckLzddbXrBA7tLsEPMXeJY8BUpksVSkSO2q/7+hZh8=; b=C3aFG4x4tNEvGPHs1KxnXwdn/ijgYtHBcxTkoe6NKiiY6DWl/YP8qacGSBe/2Qq7ydeT8N4OdaAwNUsP/LRS/AcFrEY5PzCp+nJqQV7f2fWGc6tEIvgB3y8XGwj1NT7AsGWkgVtTKPU7UAAxUmwFgiUfl8JmIzMSWJOEP8EIeWg= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0W2W4c5I_1710495576; Received: from 30.97.56.65(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W2W4c5I_1710495576) by smtp.aliyun-inc.com; Fri, 15 Mar 2024 17:39:37 +0800 Message-ID: Date: Fri, 15 Mar 2024 17:39:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm/compaction: add and use for_each_populated_zone_pgdat() helper To: Luis Chamberlain Cc: akpm@linux-foundation.org, jhubbard@nvidia.com, vbabka@suse.cz, mgorman@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, dave@stgolabs.net, p.raghav@samsung.com, da.gomez@samsung.com References: <20240314005436.2962962-1-mcgrof@kernel.org> <20240314005436.2962962-3-mcgrof@kernel.org> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 51EAF1C000E X-Stat-Signature: 6qmazni31s3d8fhq84q6947rac1yuqdz X-HE-Tag: 1710495581-680107 X-HE-Meta: U2FsdGVkX19Ai0LzOuaedPNesCRjQJjFFg/9MGZRQ+qaDC+Ronri4JFSPnJAbwq7i1FlvYHajc/sqI+bnAx2ZIJMIed7wVeL4iy8pADLOwKOBPCP9qPXjoU/kjgiWPZFMuMHwNnV5Do3ITQq53h/QvoBgsgSvrad/ScUYv00LuvY+sBnPENWM2vgypKiznGpWzzVZ+Ooi6U+eyS2kBVJ3UMV3i950O42YJ1/TH1uIjKIFaRv/4ZNZvCf+t59/vk5Xzww6Br5c9piOUQA20Kki4hYSm0lFzw3VAYr9AdHNFCGJcYSe7k9tKM2PTpfVxsR0FG5J7rbCpuSCWUcexBssQnnhcmigZlNu+BkL2i/kNXet1TAFtDEdA7agRdTd592+UMA+9uGKRJtYcWz6DuyiX5/+FYHHQrMLU9YGYGpv4KpLRj1K6e0UZ/I18qx4ShTHyKbUZiVh7jgVa3QRxB/H32yrSPtQQbZAwm9TTKcJKmwkje74NNAa6YqXrQLyf5LmAMCw0vt/VK7i97Ie6tNDHlJu1zUbd3Z2NA+2u3MzHFTQwzfxATvjVx7Xo5MDpoi2SOY2ETm+zGAQ92+VWWpRkQuJhvRjkJNxRzuso2zDNOn75HZQLECykRRk0HkWvp1xm6UoXf7UlpPqx6YTiC+twMNekq8iiApSIeQzeP3vlE9lOx+6MPW2zCwn/DOtcj0agRMxRQi9QM5q6lGa4rdDriSwvUOxnFv5QtdJUoh6p7m52BB1Gw1lOXUjHND5kK6tvvVtunbJkbZxCL+sdJX4kkuci0T2GcAae/GiZ5QuobgaNY2KZKH3i7OFPG+PDTqeHG7mxDuUCkrsZMYi1WrDDSBAC8C/t3qSOgB/0K/+0vEG+1VFT8l8lodSpca+fA4ZVrFxMa976eSfiE1UBcHzvSPj4Bx74Pb4mHvTrQ+PeX3okz9ICDqgeYDE+6qoBlp/f95DCpB00G88w2FYtW ayRtB14K L4CKv/0p4tfxRJLav0ACfHDyzB+jDmTnPdJhluX7Skd6prVG4MRiI0RrQTWZpSIbe/aCLk80+TKLDlXqXW9czidj0brzVPth9EPfGhfVa4gyBN2GWWYcBaF25GiJYG623HPX7LHfIOkecahdXB+n4f3Yw7QnAlC36huqAgedHs+Gyxemxv1Utl3dgWeNl4koSKJOjA5M3efQweJwMyGwO9r8uvrUTKUqRbKx8BaN7lCCZC4WoXlnqIAxbKpwE8f0eKZYTrd063l9MYojOZQA+2/rZ9Wkgt4qnV41u4NadEhzHkP7bZxIxvG0E6VsfQd4rJJUl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/3/15 13:38, Luis Chamberlain wrote: > On Thu, Mar 14, 2024 at 03:19:45PM +0800, Baolin Wang wrote: >> >> >> On 2024/3/14 08:54, Luis Chamberlain wrote: >>> We can just wrap most of the work done on fragmentation_score_node() >>> into a pgdat helper for populated zones. Add the helper and use it. >>> >>> Signed-off-by: Luis Chamberlain >>> --- >>> include/linux/mmzone.h | 8 ++++++++ >>> mm/compaction.c | 9 ++------- >>> 2 files changed, 10 insertions(+), 7 deletions(-) >>> >>> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h >>> index a497f189d988..1fd74c7100ec 100644 >>> --- a/include/linux/mmzone.h >>> +++ b/include/linux/mmzone.h >>> @@ -1597,6 +1597,14 @@ extern struct zone *next_zone(struct zone *zone); >>> ; /* do nothing */ \ >>> else >>> +#define for_each_populated_zone_pgdat(zone, pgdat) \ >>> + for (zone = pgdat->node_zones; \ >>> + zone; \ >>> + zone = next_zone(zone)) \ >>> + if (!populated_zone(zone)) \ >>> + ; /* do nothing */ \ >>> + else >> >> I think this will break the original logics, since the next_zone() will >> iterate over all memory zones, instead of only the memory zones of the >> specified node. > > Definitely, thanks, so we'd need something like this in addition: > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 34b729fc751b..bd11d33ea14d 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -1568,6 +1568,7 @@ static inline struct pglist_data *NODE_DATA(int nid) > extern struct pglist_data *first_online_pgdat(void); > extern struct pglist_data *next_online_pgdat(struct pglist_data *pgdat); > extern struct zone *next_zone(struct zone *zone); > +extern struct zone *next_zone_pgdat(struct zone *zone, struct pglist_data *pgdat); > > /** > * for_each_online_pgdat - helper macro to iterate over all online nodes > @@ -1600,7 +1601,7 @@ extern struct zone *next_zone(struct zone *zone); > #define for_each_populated_zone_pgdat(zone, pgdat) \ > for (zone = pgdat->node_zones; \ > zone; \ > - zone = next_zone(zone)) \ > + zone = next_zone_pgdat(zone, pgdat)) \ > if (!populated_zone(zone)) \ > ; /* do nothing */ \ > else > diff --git a/mm/compaction.c b/mm/compaction.c > index 015126803017..96434f6fc1ad 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -2152,7 +2152,6 @@ static unsigned int fragmentation_score_node(pg_data_t *pgdat) > { > unsigned int score = 0; > struct zone *zone; > - int zoneid; > > for_each_populated_zone_pgdat(zone, pgdat) > score += fragmentation_score_zone_weighted(zone); > diff --git a/mm/mmzone.c b/mm/mmzone.c > index c01896eca736..043a6dc16c05 100644 > --- a/mm/mmzone.c > +++ b/mm/mmzone.c > @@ -43,6 +43,18 @@ struct zone *next_zone(struct zone *zone) > return zone; > } > > +/* > + * next_zone_pgdat - helper magic for for_each_zone() per node > + */ > +struct zone *next_zone_pgdat(struct zone *zone, struct pglist_data *pgdat) > +{ > + if (!zone || !pgdat) > + return NULL; Seems unnecessary, you already accessed them before calling next_zone_pgdat(). Otherwise, looks good to me. > + if (zone < pgdat->node_zones + MAX_NR_ZONES - 1) > + return ++zone; > + return NULL; > +} > + > static inline int zref_in_nodemask(struct zoneref *zref, nodemask_t *nodes) > { > #ifdef CONFIG_NUMA