From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55BB3C83F2E for ; Thu, 29 Aug 2024 14:38:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1B336B008C; Thu, 29 Aug 2024 10:38:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF24E6B0092; Thu, 29 Aug 2024 10:38:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 993216B0093; Thu, 29 Aug 2024 10:38:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7B86E6B008C for ; Thu, 29 Aug 2024 10:38:10 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 291EF140F68 for ; Thu, 29 Aug 2024 14:38:10 +0000 (UTC) X-FDA: 82505537940.16.7EC42DD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id AF5C8C0025 for ; Thu, 29 Aug 2024 14:38:07 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VY7h5128; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724942198; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OsCX0ZyOxWwSEV2gyoydMLj2nN0vlKj1gl2mA+dgOIY=; b=iiqK3uLPs4A9iUsk9lNbR9dPHSCmlE3NHwG4llAMGgKVZR5/2CRo2U4lGdtw9OXhLXZKxC AOm2ye1ZEfIlrOksca7j2usurbdlcMsDmg/wJ0/HHJLal4zLGuFBLiLY5YR0/aPJAdYFA8 +u+xtw9E63AgBcFIf1BTMfAFX0DYlEI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724942198; a=rsa-sha256; cv=none; b=gtGSulusCrnlx/vufdDNSLXXPEt3KQUCBTeVEjlTU7ybFh/ptzs/AmtET6AJptAQzQGkac 5zHxC7IY+pkILtT9PMgPlZvebFgkE/eyZpPk8LfPGr3W6vgIxqrZWpzquqiz5pX0M6H89U q75oqRngh4Ru7XkQINUp80fg3IlRphQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VY7h5128; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724942286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OsCX0ZyOxWwSEV2gyoydMLj2nN0vlKj1gl2mA+dgOIY=; b=VY7h5128sP+eJkKtkYYJJTpW0e6Wcsv3aMpixv2JIyFrxf+MsJB+3clhEgSESO71lNs9z3 gH1ex3+uJimupJ07R23GB5zutZrNKbRqvNIbYzG1MFS2DFGUzt/KjqLHpPxK+N1LWvbjds TUR8FEF0INObdzQ14IwNJBn+sTBhV8g= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-17-ounvPsG0MReTiHhkGf3D1w-1; Thu, 29 Aug 2024 10:38:05 -0400 X-MC-Unique: ounvPsG0MReTiHhkGf3D1w-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4280645e3e0so7349655e9.1 for ; Thu, 29 Aug 2024 07:38:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724942284; x=1725547084; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OsCX0ZyOxWwSEV2gyoydMLj2nN0vlKj1gl2mA+dgOIY=; b=EWBap2V18VMHwpoLfyPMLTQ53/cqGz0gVnzRu8a19pOAlkd80DC3ikdFsS6Opc2Wwg hyujsqSFTdyC8HxeYoxpLiJYBNv/nbGakCJGGrmi+AN4tKZkOGdVhEBwyg+FnIMe7QAu zut87OEQM4yS6VgXHwiRTXa5RfQJDW6LfBCJ3gl1lianR6OTHvHxccdBdY1O1qBrDZ1h c1KMhyKVyuQEeu/kYd77a/+gLNyTkKTR8bCXnFy9IVPygflTwZu62KHRmiYzsRKJMsaJ JpCgq979Hh1Fb6kUCAijZJaBXftrtS9BsbZi/fNZY1MNLiZyzsGv3L60r5uU4ecDw8PF 3PbA== X-Forwarded-Encrypted: i=1; AJvYcCXPMbb0F4Nq/1/amvDF59FvG+CsVZqc+Klrsl2cddrCigZi4WIiFGZDGVkojooLm4/uBhm6NtU42A==@kvack.org X-Gm-Message-State: AOJu0YyLLgShOAXouam2fna3k6FxkBIpu77LBMsz8ZoOJEVQkzXP47Mk bpMMuf2JDJxeLIZqDHxPRps5tWY7l8g1re4EhH9d0G580/4u/lkesL+KvKTRf47+1mDboxntBrX GR+R/JTJ0gxcOrKVqFvxYgXa+tj/B3ZkhpyycxIaa9nSEYmak X-Received: by 2002:a05:600c:3596:b0:426:629f:154e with SMTP id 5b1f17b1804b1-42bb02d970dmr19969335e9.30.1724942284323; Thu, 29 Aug 2024 07:38:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHRpyGTsRQlxPkowSA5gXPZRCPCgPVQClP0RB72O4ew2XXmZ1TW0z28Qq5ZkWK2DfgaNfnwOw== X-Received: by 2002:a05:600c:3596:b0:426:629f:154e with SMTP id 5b1f17b1804b1-42bb02d970dmr19968375e9.30.1724942283356; Thu, 29 Aug 2024 07:38:03 -0700 (PDT) Received: from ?IPV6:2003:cb:c711:c600:c1d6:7158:f946:f083? (p200300cbc711c600c1d67158f946f083.dip0.t-ipconnect.de. [2003:cb:c711:c600:c1d6:7158:f946:f083]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3749ee413a8sm1587922f8f.6.2024.08.29.07.38.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Aug 2024 07:38:02 -0700 (PDT) Message-ID: Date: Thu, 29 Aug 2024 16:38:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [LTP] [linux-next:master] [mm/migrate] b28dd7507f: ltp.move_pages04.fail To: Cyril Hrubis Cc: kernel test robot , Claudio Imbrenda , Ryan Roberts , lkp@intel.com, Vasily Gorbik , Jonathan Corbet , "Kirill A. Shutemov" , Matthew Wilcox , Linux Memory Management List , Sven Schnelle , Zi Yan , Gerald Schaefer , oe-lkp@lists.linux.dev, Andrew Morton , Christian Borntraeger , Alexander Gordeev , ltp@lists.linux.it, Janosch Frank References: <202408211026.636ade1a-oliver.sang@intel.com> <767d1908-dc30-42ae-9a8a-d2ad42a4d491@redhat.com> <8bde28af-3401-4d72-b821-d8cf01bbcd64@redhat.com> <4c190c79-401e-43a9-a4d1-e64f78110e0b@redhat.com> <8a16ac0e-4a3f-48cc-a118-ea05c23d5d2b@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: AF5C8C0025 X-Stat-Signature: dqyug5oifqbex88pdsm5pwwfk7kk15ig X-HE-Tag: 1724942287-348253 X-HE-Meta: U2FsdGVkX1/CL5+md/TGLmlkGIY8YzXyA2QEksOflb8EvNmi+7tRUWWdsXHgFt+u7xdO3Dry5sDHik2UozohNdse8McXKGru6NkIjWVN3XmJj5n9TRdCThEvTdoeqEzS5DYiHt1ptyYsYOrdzS04noK4o87kk6nyoRW5vY2jwg7ux17lmVa9yowC/0M7YW+rf8XORVY7tvF95ip/v12BHJUeC4iQwjQ6YhbAf1Qhhn9C2iGwyMBp2SCY+fxKq2JOOSJM2TrQ23w/vkk27F9AwSDOs209nNGK494mWPiT3JureZhSfDQWAvvra4Rii/1sAxo0+ylBQU1Ye4jHLjAqBQ53adYAXCk7hGdBHb5TBDZ+7oCQ9SljprsFMpCjptoDECutOyCE/527ABfzkdvLAnwhUCtAGsBvgnX21JCc5+NPOe21v2G9YZAerpHg2tKvrbGD+Q1f37pO2fG4QEDtNYQaylJVnq9DJLw/Z/9Wb7aQVSofW1LdlHv4wGcoRLSwI6FcFtgLDAdoruYtfl7wN9ZeC2UBW8L3fquXD1V0fHOq5owUUCHxmldLpONSrqamCOmhKBkE/amiv85vy+9WeZ/Vh2fhm3HhToi0Qv8pmgBaDt1deyi42kNKpFd/K/Ib1f+YlR+QXj016RTJopkrW99b6mpKUJwgO74eW1wmVhvVKlHF6xDQVrbYJDGRQGsH9LI7QezM1FvpAkGcaazyTsYS8SkUgOV6sBfi37P0Vdmgpc4UgASY2iOfi4mg0NAumVXporlxJQ+n+tyCYiV/5cuIDEIdPq9x7Yd1L92pD9P9eewrXMWY/xI5hDn0aq+Cumr2Qm8brPcodC3H0bTazm8lOPKuLEm7zzkvPDV6jn3JisUnnobUNtE5JEX6sKlpwuPgx2py2cqWqyXxD9D4y0FlASqS/I+HOzBEOJ1o9YfzavTdgFZ74lPbfvNa9FyAODH+rtFDeHmRMyVZd1Q lIytdCs/ nVxaXBArKUAbtvhsLxLPYsHdbAdswpHpj09rolb2T5ntQeb5EwGNLFWdg0rINMpUIUNrmpfBq2BUyyxUWiMeYJkX8KMXSCyWp6wfhm+jxLLe1hiwZKO60z9meg48rde2xfmRfZqaqRtZnznDTtdOZbG2tzTS9IO73WGQt74gX0f0Nh74WW8tljsVdI6AjkcNulWbw7rbiMuBVOU2DwrtEyn8rrVLM98IkWUdWR7S50XfZggTkX72q0O4XTl9zDb9gfUDUDC/sy5gtalDvSHGGN6hl3KpnBtljd3FMDADqQJgVjXbqCTachvTA7z+0E4MrLn8dxSb7T3agBhMmecqZnNF44tGwRoNVXNofDUkTIKMS1roFC4w6VcaFnObYfYhLNcsSfB4aDnhrXJx4aQpgH2V2YiWCmL1MLWGdPzMVqnQYCYJO2TRQ7x8DlaxrzwfLnACz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.08.24 16:31, Cyril Hrubis wrote: > Hi! >>>>> Also I think there is a third case that we do not cover either, what >>>>> happens when we pass an address that is not mapped at all, e.g. NULL? Do >>>>> we get EFAULT as well? >>>> >>>> Yes, that's documented as EFAULT and should behave that way. I can >>>> extend the test to handle that as well. >>> >>> Ideally the test should be ported to the new test API as well, but I can >>> do that later on the top of your work. >> >> I tried, and it all looked easy, until I realized that these tests use a >> share code-base: >> testcases/kernel/syscalls/move_pages/move_pages_support.c >> >> That is also written using the old API. I assume mixing APIs might not >> work as expected ... > > The tst_resm() and tst_brkm() calls are redirected proplery in the case > that the test runs with a new API so generally it should work fine as > long as the cleanup callback is set to NULL for the tst_brkm(). That > was one of the design decision we took years ago, because we knew that > we are not going to reimplement thousands of tests instantly and that > the old and new API would have to live alongside for a decade. Ah, the "NULL" is the magic bit. > > I glanced over the code and I do not see anything in the > move_paves_support.c or in the kernel/lib/numa_helper.c that would break > when executed under the new library test. Okay, good. I can send a follow up to convert that file once the fix/extension was reviewed. -- Cheers, David / dhildenb