From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5CDBE7716B for ; Wed, 4 Dec 2024 15:41:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B80D6B0083; Wed, 4 Dec 2024 10:41:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 03F7F6B0088; Wed, 4 Dec 2024 10:41:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFB0B6B0089; Wed, 4 Dec 2024 10:41:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C08D56B0083 for ; Wed, 4 Dec 2024 10:41:17 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2EA441C7697 for ; Wed, 4 Dec 2024 15:41:17 +0000 (UTC) X-FDA: 82857690426.29.3128D4E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf14.hostedemail.com (Postfix) with ESMTP id 9ABB210001A for ; Wed, 4 Dec 2024 15:40:58 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ykL9vsVr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XK6qJgnD; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ykL9vsVr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XK6qJgnD; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733326865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=reoOQBgkrA4sZl3NYvbkPNgWXCt4Gy/cJQyTHRwW5FM=; b=zloB3Xpg1T+pTd6oOWjmCa4w5fdeTTzYhuBCR105SYatBcqjH2Eszrlx8AGvhJoyXAiCwT aPaIopEzLzetoTqCf3vegED1K1Hc95HWoOkv8oYCMW3t56j9Wz419JJylFtxwXt6cbr4Cb sDU5wdVpinKVNtY7R6Rg6t90GVsWlfA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ykL9vsVr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XK6qJgnD; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ykL9vsVr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XK6qJgnD; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733326865; a=rsa-sha256; cv=none; b=fFuUUWPJSoDzkwrY6XRiR9TF4kK6ib6IsTxXMm+pZZNqWmuWdTAhnlGh8OJXP5tP7LAarF UdThQUy/gtI3tp50PyzDWgfi5yMuULIkaMeOpiEt3blqIzqeM920ekoVi6JpBtzieKENly Y/8njIbHo1IdAU1AB6GHPV83v7VQukY= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DD0E52118E; Wed, 4 Dec 2024 15:41:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733326872; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=reoOQBgkrA4sZl3NYvbkPNgWXCt4Gy/cJQyTHRwW5FM=; b=ykL9vsVrnInFTiF9JAa/o7ISOzsKwCTNoSzsQl3boxALf4BYA2YQd/En26/4qCX40zop5e kG+DAPfrFmdaRzCgPpjeJ6XxEz+1+sS4CMz6Ftg4Cop1CwHZYvReW7+UySZC3Z/Fv535Y+ YNy5EOQXoiVEfxxXzu/BMvKhpzxaNVI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733326872; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=reoOQBgkrA4sZl3NYvbkPNgWXCt4Gy/cJQyTHRwW5FM=; b=XK6qJgnDOEvqvFbyMCgq4D3G6qQlL+fDQozOTjMp3rDSHnH6c0lR7EwD8UWQ/vb9RfMoM4 HsZaUKij7HvEaFCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733326872; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=reoOQBgkrA4sZl3NYvbkPNgWXCt4Gy/cJQyTHRwW5FM=; b=ykL9vsVrnInFTiF9JAa/o7ISOzsKwCTNoSzsQl3boxALf4BYA2YQd/En26/4qCX40zop5e kG+DAPfrFmdaRzCgPpjeJ6XxEz+1+sS4CMz6Ftg4Cop1CwHZYvReW7+UySZC3Z/Fv535Y+ YNy5EOQXoiVEfxxXzu/BMvKhpzxaNVI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733326872; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=reoOQBgkrA4sZl3NYvbkPNgWXCt4Gy/cJQyTHRwW5FM=; b=XK6qJgnDOEvqvFbyMCgq4D3G6qQlL+fDQozOTjMp3rDSHnH6c0lR7EwD8UWQ/vb9RfMoM4 HsZaUKij7HvEaFCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BAE48139C2; Wed, 4 Dec 2024 15:41:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id g3tELRh4UGfYYgAAD6G6ig (envelope-from ); Wed, 04 Dec 2024 15:41:12 +0000 Message-ID: Date: Wed, 4 Dec 2024 16:41:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: avoid zeroing user movable page twice with init_on_alloc=1 To: Zi Yan , Geert Uytterhoeven Cc: linux-mm@kvack.org, Andrew Morton , David Hildenbrand , "Matthew Wilcox (Oracle)" , Miaohe Lin , Kefeng Wang , John Hubbard , "Huang, Ying" , Ryan Roberts , Alexander Potapenko , Kees Cook , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org References: <20241011150304.709590-1-ziy@nvidia.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Stat-Signature: q5g3zrzhw3yp4n8ga4mz68k36zg6zko7 X-Rspamd-Queue-Id: 9ABB210001A X-Rspam-User: X-HE-Tag: 1733326858-7285 X-HE-Meta: U2FsdGVkX18gyBbERpP8cc3bOFnbbikHKEE0YNY7AC/Iyr0LpSXWjG+MdQzzdcDGSHDAt2cm1aX8HS5pCEO/8NINNP3YT+FjUu0plHNJtQmPJDZc1PLAkL7MWrieRgVEQIolMxS+18lF1U95z/a4zqWUY6r+Ye151+cmRpvNWjENhi/iKnLWxVbtqde5E86ANKMj6Te+N4VZ1nZ7FKRC+R8kfvW+Yub1oAKMEtq/QVjqrMayNB19pU2hkwST1ecnSePHJVvfHM/TITM5oIZ/VM89rJs1t+NGOpEqHw6MhZpXrW39YZifpMp2T6kZgDqWgppp601mH0DdV+7yfk+2moIuMSwfiSGkeq7LRQyzD/nATxvZRpiRBXgmS2Mp4Lf5cXdemzLotp5sdL2G52CAhhSyxKnyODj7sCIlJPrUEz74byGe6rGTR+eQJckZP3XSYPQuysXh4aOQ0kbZR+YY9eSV9fJfRywpFu0pwC+fEvdSP+bazCzZOq3fZF7p9pbei2Feu5ec8oymunTCk1IsjFq0ilzDC6DpmbWyOcc977K5aN3BIL6xNxpxk6BeXwP/VyF4cKRfkefH6+UE+xl5ysHGIY6MeSfnyQFNu1Ab4F9OAJoRwBsOnbENpNXWbYDbUqy4vdh/Z4vA36lFU8TSE69XX8RHPZviRCb32C8f/gEgj9zhyEwNqq3+PUOeAiHMB9xRdZs6N4CsmscYfK2EDl+KPhSQZYpbYE1BaKKdJ3hFS6pu/Ths4feHsyh14G4NX/qrJLoYBgM+IGrtKaFJt2eXSuJtzwBq8wWwsVRClAzc596YTN0h5dOmG7hrQsnoMVNc0Tub4CeJWU2Ji+zS5Ul1w08SDyNLTH4R8eAH9jnPbtm3VEPjnXwx6Cy7Raml9k3yUAI4lp4/hpj7Sq1ZSvzrRgr3IrDy72FyZQZVGmyjhO7loKqa91q+pDn6N/dUEzfeWxymeCTHpQ8utnR PKvcu18Y YLJOpK47yQXgo6xwggi0iQp/Ro8ibjnanUj8hh75GU0Mi0Ibt5ArxXdSxhXs+fTK6WSQ1xwFDvNbIuh6gmflRM5YMLDDJ0UpHdTKE9akJ5TnoXM9EypZFEXPSJ8N/4VDo0ixbPicz7ISZSMrYoVH27caindGmHvhcX4dz5BqTQgFz941kHcErtNWB791fifqvpCaDYKSQuEIA8tpDWxnXidDTxDZlD0Zm+teGUKo4TNZbORXfUTtoFBONaB8biCK148Th6IBv5u0Q/opHS3Ae6DqkSXucV68JtNEbg4zvZTYzIdDPfeIe9ImMY3RaggfL7phqV3BxInAMNnRZJdo0mNuejg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/4/24 16:24, Zi Yan wrote: > On 4 Dec 2024, at 5:41, Geert Uytterhoeven wrote: > > The provided config does not have THP on, so the changes to mm/huge_memory.c > and mm/memory.c do not apply. > > Can you try the patch below and see if the machine boots? Thanks. Hmm looks like mips has some involved clear_user_page() in arch/mips/include/asm/page.h So maybe the clearing done as part of page allocator isn't enough here. > > diff --git a/include/linux/highmem.h b/include/linux/highmem.h > index 6e452bd8e7e3..bec9bd715acf 100644 > --- a/include/linux/highmem.h > +++ b/include/linux/highmem.h > @@ -224,7 +224,13 @@ static inline > struct folio *vma_alloc_zeroed_movable_folio(struct vm_area_struct *vma, > unsigned long vaddr) > { > - return vma_alloc_folio(GFP_HIGHUSER_MOVABLE | __GFP_ZERO, 0, vma, vaddr); > + struct folio *folio; > + > + folio = vma_alloc_folio(GFP_HIGHUSER_MOVABLE, 0, vma, vaddr); > + if (folio) > + clear_user_highpage(&folio->page, vaddr); > + > + return folio; > } > #endif > > > Best Regards, > Yan, Zi >