From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CEB3C369AB for ; Tue, 15 Apr 2025 10:26:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D10022800BE; Tue, 15 Apr 2025 06:26:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CBBC62800BD; Tue, 15 Apr 2025 06:26:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B37292800BE; Tue, 15 Apr 2025 06:26:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 94A8F2800BD for ; Tue, 15 Apr 2025 06:26:31 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 389BE121044 for ; Tue, 15 Apr 2025 10:26:32 +0000 (UTC) X-FDA: 83335899024.08.681B2B8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id A4C8A40006 for ; Tue, 15 Apr 2025 10:26:29 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Kv7YHAyu; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744712789; a=rsa-sha256; cv=none; b=umdbf+QQjyqKeRGZVe9Bd3dLlaoN40EhLW8K47wTcyBR5pT7KGlP/X7BhXwGT9O+StK2ri UZ5RpL//EeEqvnb/AXsAFFRzXOEhT03jjejAUaDhOgzZehJs5VczOn06MnTpq+ATN/j5O5 6rmGzlma0vSJfM24sViqx/uWgwlAdVg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Kv7YHAyu; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744712789; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UrrhGT5Gcob9BTGzr2CD8/3jRNAWfBLuW+8hpF8MEGQ=; b=CdFoy9LH5pESQKfFsy3tQyPc8ZHhj5+y4JMeZnBtllBX0PUJu/7SJZe5OmNx64QCgFRkZH 2MQr6Z5gxA2oK/lKgQAqF0Q3DjhSeJQ1VnEaXVqc9P/AKysl9rWifYNxg1/iTI0VoYFru6 saluatxw1ex7hziyNcR1cvL4/JarzQw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744712789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UrrhGT5Gcob9BTGzr2CD8/3jRNAWfBLuW+8hpF8MEGQ=; b=Kv7YHAyuHijCCi/5zSKPdYKubzPprkSYT9e469/T+uuPNWC/zFR6kY/XulZm7M78U/Fn/v uYm0UW2E070HpeHeKmsrkJFlNKMspMyFRgxkRjY/dxfwl0TcvfELn7ZgxZd6fy9J4UbSLS QqVg71VhxTyirLkEkYBVw90gdTDqYIU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-444-UlihWgk-OnKU1yZkavFHuA-1; Tue, 15 Apr 2025 06:26:27 -0400 X-MC-Unique: UlihWgk-OnKU1yZkavFHuA-1 X-Mimecast-MFC-AGG-ID: UlihWgk-OnKU1yZkavFHuA_1744712786 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43947a0919aso36665475e9.0 for ; Tue, 15 Apr 2025 03:26:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744712786; x=1745317586; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UrrhGT5Gcob9BTGzr2CD8/3jRNAWfBLuW+8hpF8MEGQ=; b=DMISRXk6tk03UlOjepLuNiDNItQoRRRVIDof/536L82++0DoAVYLnyxSRG4Khgih0P muwuHNLlLiU0UFXX5bAowsvQkLbXMYfTmDrFwa+FtLAfwjXYDBJf86LUTH1Ka8tBUq2o cwbGJsKNingMip9V+X3L00WlXcBDZfAnl3Sb0rmyhzKcy3ttZM6khsutDyqrbc4bMk9q YLjqyUaH8f9i2N7CYh+nEBrHXN3IaLpqAeFkMdMtJnUnIBIfFY3uIroXlKeubBi+I4OA kh61s4pQY9gMNJ3TuHUrTkfPX36CjPJb7N8r5gLhl3Z0+XOcwpYw11QbtMLbkKkYPIV2 kWsQ== X-Forwarded-Encrypted: i=1; AJvYcCX0Rjtr/CWvizmS8CHWMcAxWhcrZSyQrvBWHuTKCg7I/bjjjXKHqGylksFtC5SIbXL/nX48776GPA==@kvack.org X-Gm-Message-State: AOJu0YxmUE88IMA3+91EXVQ8lcvj2YLSlPTW3Y1s7a3DLzTHtf3Qdqre O6TkSEHS9O2eT8Nnvd7QciEOLl2Hw0oTOE2AKh1lqh7RQGfVH2EpeHH6Q0HgIsn14G+enVD2RUt W5D8J1QDi5mW4PxPkgNyJ5CkdBIAgbOViJEq3fYNZk4I+NcXr X-Gm-Gg: ASbGncsj6tTjJuvfgf6DI+Ag48V6dHGp05QLqntVL8BkgwWUeKXVVV8dMRzMw1qA+Ra 7ZM87BtNSfULdUcFHdC+jL2ozLIOZPmfT3E6W0mVuqB9a+DJaMhsA2NvWoT4aLSXJ4WzBiMrhrY 3ZPNglaJ51trAKeO3c4UrEu/OUsyEmhLpImJF6t5tef6vLXH7bKyg97v9K4+oITJbEfH4AtMswX Ev5o5ZMw436aUdVTaH0iOi86etPrAwGvMiBZNMDRyj3277lXc/Q+t8mhWPVMrPd1H2QghmIlz/p EOqpnTuUcqso1o68aOqPVYyI9lfmJnaRnR0rjKgqgCxKES8CbOsqWhT2rHJ8BScyDeFQ816VlJn etm1bCdR7WsVIF9KbTKeTCaThNEH/cbK2PbmuJQ== X-Received: by 2002:a05:600c:1f94:b0:43c:fb95:c752 with SMTP id 5b1f17b1804b1-43f3a925de9mr166657895e9.3.1744712786540; Tue, 15 Apr 2025 03:26:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEkSNL3bL+vlpLjIQ1Sj1OhgO8KknvRKF1XH3coI6Bsky7fFcyM55bBvuS3dLrpwgxOcnEoVA== X-Received: by 2002:a05:600c:1f94:b0:43c:fb95:c752 with SMTP id 5b1f17b1804b1-43f3a925de9mr166657645e9.3.1744712786145; Tue, 15 Apr 2025 03:26:26 -0700 (PDT) Received: from ?IPV6:2003:d8:2f02:2900:f54f:bad7:c5f4:9404? (p200300d82f022900f54fbad7c5f49404.dip0.t-ipconnect.de. [2003:d8:2f02:2900:f54f:bad7:c5f4:9404]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f233a2f08sm202941995e9.12.2025.04.15.03.26.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Apr 2025 03:26:25 -0700 (PDT) Message-ID: Date: Tue, 15 Apr 2025 12:26:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/swap: set active flag after adding the folio to activate fbatch To: Lorenzo Stoakes , Jinjiang Tu Cc: akpm@linux-foundation.org, yangge1116@126.com, linux-mm@kvack.org, wangkefeng.wang@huawei.com References: <20250411082857.2426539-1-tujinjiang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1SDEP3HF6gjl6KSBrq7Zzym4St6kEU-7ut6TzZh_V64_1744712786 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A4C8A40006 X-Stat-Signature: 8kuxsb8rqjn7yahgfy3dthb4difaw7si X-HE-Tag: 1744712789-276078 X-HE-Meta: U2FsdGVkX1/RboqGUS6PVkP9thiEjY56S2kBKL6Kvc47bzUTGVKb7jUX16TieeJ+kKSVqJOvOXuSyFVJ/Z8ncDhqjdLEFFStiiS1h5CfYub5Gc1W9nBGgM10/iododp1mLnmn6YpadG0gq5EuBeJR03v9DRVAH7rECYHPRBQ7sKVL8PD4w1uVpoh8kK5TkxIck8uzTJ1m8vYrjUu8NV83B26fP4Ua1W0Po69943+rlNhBUdJu5QWkYIVWw4C3Suua4rJPfUsqmIqtKhYtFE3x+RKJ3w9eyiOsG2AaNFZBuw12CCoDMtRfK04K5r+bblrTvfNIl7Ee48Yjkbg5MauRFLznFHZvRRIgD7u6L0PErMUmGgshaX2G127NP89rRn7lpbhLniA9m9BFMuO1IYN2iSM0TmuZiyOidLQT7Z7z1yMNx0pR5Thd1WEgAUxy1lzb/Ki1H5lM0nOFgj2zO1cNHF8bUQ/iAaZ/T3msNPUosiPdcyNxJebYN8sKwhrjlQp4r13WwEcSHDLVkfbEMbr1p/mQIveqjL0sKhsRHgRO6F5LLp9uf/RTj70M7TjxiG8DMom/WJAM9tLjEwFl7690lHfyuyDJnj3x9iReNky31PZpPU4HWPJaKLzabm+L2GM0i7qAdulcsuA1ArAZCcH14GbOyWYqpQdRO6rs8bcxooEHaOAwYLNsDm2RXvMYA+D+gEb2XfzTX6shceDJ1NRxQS2la/Ra0KlbmKLbyTRTzavNUaKBu9uA5yk28lG4I4e0n26cdXsHg+l/Q0blNhE4RtSMDdEDxfGqzoWVnLPpk+SATUG1dt0XFFcwvED/zmzE5WGdZX3W0heIVeNdwJL1NCYw0r1wUFIG8Ni/Te/9HDf5NMr7K/olF15dq9cYDJ2epm70ZIMzs6DW2ujTR+TkAvuzUuJQ6VN7ZrIcXDnvKTEr1E9tLJ4Wu/OgBOGMQav5G/hpnwfDL9pdvwYDCH qkyZgcUm HzRCjn57jit+bLgoatap5zdL+JwIvwqtNVqzHvGRARDWDAcziaOOxVQeCB7zUZG40BVqrmf6kQYBU3SJkyNHfg53v49BP/mdAgUASMrocQzpnjFaDYhLJb85RWFFzE04dbJxUHZlk/On8dIpT4yoq3DSbSOyJ0Yk9ZZ+DishrrSS5aCcLNugkBKuGVMF1VfYwYLfFP9kvAUEu2BdvWQivI7uJwwIbmIFZTH8qNzyuLQyKZ/qbHZ7UmohN8QLuEx5EvEOL04EicwtPeJVy/oMGAjwEDOUj+bfAOWX2hDZpBE7G8LJFySHNLWeKSov3CbhLTy44/e6O++AHtVrT7pGuj6YqF2JF2hdpxjNszeFRlqDhvhbiQ1zFlToa+SQUib5+0qdS02igANytDCoVLbgNdhOYvg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.04.25 13:47, Lorenzo Stoakes wrote: > Hi, > > Andrew - could we drop this from mm-new until this gets fixed? Thanks! > > This patch is currently breaking mm-new, which now does not boot with > CONFIG_DEBUG_VM. > > It seems like you're underflowing the folio batch? > > Stack trace below: > > [ 0.773399] ------------[ cut here ]------------ > [ 0.773400] mem_cgroup_update_lru_size(ffff88817e801440, 1, -1): lru_size -1 > > This is line 1321 in mm/memcontrol.c (actually had to comment out the > VM_BUG_ON() as it otherwise mangles output, fun! But if not removed obviously > the kernel just halts): > > void mem_cgroup_update_lru_size(struct lruvec *lruvec, enum lru_list lru, > int zid, int nr_pages) > { > struct mem_cgroup_per_node *mz; > unsigned long *lru_size; > long size; > > if (mem_cgroup_disabled()) > return; > > mz = container_of(lruvec, struct mem_cgroup_per_node, lruvec); > lru_size = &mz->lru_zone_size[zid][lru]; > > if (nr_pages < 0) > *lru_size += nr_pages; > > size = *lru_size; > if (WARN_ONCE(size < 0, > "%s(%p, %d, %d): lru_size %ld\n", > __func__, lruvec, lru, nr_pages, size)) { > VM_BUG_ON(1); <------------------------------------- here > *lru_size = 0; > } > > if (nr_pages > 0) > *lru_size += nr_pages; > } > > So, nr_pages = -1, size = -1. > > So I guess the problem is that mz->lru_zone_size[zid][lru] value is now negative > on delete? So we're underflowing the folio batch? > > This is called from the always-inlined update_lru_size() which simply passes > nr_pages in... > > [ 0.773415] WARNING: CPU: 2 PID: 92 at mm/memcontrol.c:1318 mem_cgroup_update_lru_size+0xa1/0xb0 > [ 0.773423] Modules linked in: > [ 0.773425] CPU: 2 UID: 0 PID: 92 Comm: 9 Not tainted 6.15.0-rc1+ #8 PREEMPT(voluntary) > [ 0.773426] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Arch Linux 1.16.3-1-1 04/01/2014 > [ 0.773427] RIP: 0010:mem_cgroup_update_lru_size+0xa1/0xb0 > [ 0.773429] Code: 00 00 00 00 eb ae c6 05 6f 39 77 01 01 90 89 f1 48 89 fa 41 89 d8 48 c7 c6 80 a7 22 82 48 c7 c7 6a 66 7c 82 e8 c0 23 dc ff 90 <0f> 0b 90 90 eb c9 66 0f 1f 84 00 00 00 00 00 90 90 90 90 90 90 90 > [ 0.773430] RSP: 0018:ffffc900002aba80 EFLAGS: 00010096 > [ 0.773431] RAX: 0000000000000040 RBX: ffffffffffffffff RCX: 0000000000000000 > [ 0.773432] RDX: 0000000000000002 RSI: ffffc900002ab938 RDI: 00000000ffffdfff > [ 0.773432] RBP: ffff88817e801498 R08: 00000000ffffdfff R09: ffffffff82b18528 > [ 0.773433] R10: 0000000000000003 R11: 0000000000000002 R12: 0000000000000002 > [ 0.773433] R13: 00000000ffffffff R14: 0000000000000001 R15: 0000000000000001 > [ 0.773435] FS: 00007f5e47c3e880(0000) GS:ffff8882e085a000(0000) knlGS:0000000000000000 > [ 0.773437] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 0.773438] CR2: 00007f5e475fb2f0 CR3: 000000017e802000 CR4: 0000000000750ef0 > [ 0.773438] PKRU: 55555554 > [ 0.773439] Call Trace: > [ 0.773442] > [ 0.773443] lru_activate+0x121/0x320 > [ 0.773447] ? __pfx_lru_activate+0x10/0x10 > > This indicates that the move_fn() below is in fact lru_activate(). > > With inlining I can't precisely say what ultimately calls > mm-cgroup_update_lru_size(), but given the negative sign being the problem, it > seems almost certain to be lruvec_del_folio(): Agreed. Maybe we are calling lruvec_del_folio() although we should not ... I don't immediately see the issue, I'll try to understand what exactly is going wrong here. Thanks for digging into the issue! -- Cheers, David / dhildenb