From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC9F6C5478C for ; Sat, 2 Mar 2024 07:58:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 392DB6B0085; Sat, 2 Mar 2024 02:58:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 341086B0088; Sat, 2 Mar 2024 02:58:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E3556B008A; Sat, 2 Mar 2024 02:58:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0762B6B0085 for ; Sat, 2 Mar 2024 02:58:21 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A35B71C0733 for ; Sat, 2 Mar 2024 07:58:20 +0000 (UTC) X-FDA: 81851346360.04.9C8D53E Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by imf17.hostedemail.com (Postfix) with ESMTP id 0018340018 for ; Sat, 2 Mar 2024 07:58:17 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dkF5QGR8; spf=none (imf17.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 198.175.65.20) smtp.mailfrom=binbin.wu@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709366298; a=rsa-sha256; cv=none; b=4QyodSWg4M27eijJoEz8YREg1DvTZ+ZlMLfiXDGGwQlB4QhCLsaWKdKh4bnQVY/gJnz8kE aczZcGGEFOkJqlZkUubVIjjEv3+RQkgz3+M85BjCzH1whqknmgZciCPniBSRuEL0cXpR/s zP3aFutBLSPZTdUV5YXXRQxywiKCfIM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dkF5QGR8; spf=none (imf17.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 198.175.65.20) smtp.mailfrom=binbin.wu@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709366298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YDrECk4VDuD+nz7Xwra+0BsbhB6M5sRjoJkdYkMjLUY=; b=1hcxZmdV/VxGwTkmIEdFLOsWibIwpriZki/DAtclz5+gfbiSQz+aWpc+JpmjDBbiuVbWZd 4FW1zyNPoznoX4HgHdo6jcfQEqSrfljc/BfviVRxbC1XkIPzXzVPfwa5mmMfBnpL2aHQle EMJBAudvdTCLVZ4pOQteicC5jYFVzkI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709366298; x=1740902298; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=vZbc6IDCxYIzD6imxHYIKCytFzfBvyP0Kq3E+nLkKjQ=; b=dkF5QGR8wIfJajr/8gQp9V2dXgPCww/bhQc9N1i9SoTAyUJXT2SRsiZ1 WfF5rBtM//R+a7sTMCbqBGodYPFMUAmVxnEA+ihk9yOUsckm0SQB4GXVE q914GK32ACfOTUnXhfhzma2baQhbl+vQOF9d7SaD2ueVGbQnRjMe6C+N8 M8UlRWOuoAGx2TRS3BQ0KWEDZnnTNqmUNfR+WSjTV+4yNcuVbbt0D59sH CYMibnNtsXXbXn2q+W9ujfJr8ImrSsuAJLZtS2i5gNbG/kf5cI20ZfJt/ paviHsA1j2f6vXJy54671XKi9qPssIuQcOHnSYVM1uXc5P+KlZQHICtud Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11000"; a="3797734" X-IronPort-AV: E=Sophos;i="6.06,199,1705392000"; d="scan'208";a="3797734" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2024 23:58:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,199,1705392000"; d="scan'208";a="8367762" Received: from binbinwu-mobl.ccr.corp.intel.com (HELO [10.125.242.247]) ([10.125.242.247]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2024 23:58:10 -0800 Message-ID: Date: Sat, 2 Mar 2024 15:58:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v5 18/29] KVM: selftests: TDX: Add TDX MMIO writes test To: Sagi Shahar Cc: linux-kselftest@vger.kernel.org, Ackerley Tng , Ryan Afranji , Erdem Aktas , Isaku Yamahata , Sean Christopherson , Paolo Bonzini , Shuah Khan , Peter Gonda , Haibo Xu , Chao Peng , Vishal Annapurve , Roger Wang , Vipin Sharma , jmattson@google.com, dmatlack@google.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org References: <20231212204647.2170650-1-sagis@google.com> <20231212204647.2170650-19-sagis@google.com> From: Binbin Wu In-Reply-To: <20231212204647.2170650-19-sagis@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0018340018 X-Stat-Signature: gfa5rjnzrms83bkqjx8k35tuukrw93xw X-Rspam-User: X-HE-Tag: 1709366297-332339 X-HE-Meta: U2FsdGVkX19qcmEuB6k+ENOJmH4kFXoMyjW83neZ786nhhHwbjQAUkpBlihxs6hO4C+BQ7b2R1qQne/bbRTzjfrPMwceqlYJyGXjGJKXQH97FSW1wAAzx2ymFPKCvdIFzQ74apRH3NU/FO1LcyHhicAH3kycOAwLqofJhdIWLYhGym8NN9Eh2h9ihG2i+NgmQtqTKVLmpRuzntggR6zACvvx7JPPtdShKVrDfiGlgERa7mVtyCUwu9aClMYFFe5ElYQARQyQaU9hvcgRI4DbCvK/SeVeA3fU3WQHW6CmLqSPDb6RYNN5FWQoM8Oq4jT1AztEjEcz7EwTFOYdvAqr403E3OpQ9AUnhd+ZI4Gjra+fcm9MJo87ps8Ucnpn7erOI4Zonw4Hisii190efMvN14xoZ9xvSaOLFbCsuLl4mm0E/Qw+EVpN2+vR7nBlQUuVlpzjq20vdfaQe31xfvd1gSnQL650Zb31ZJ0EuWLwxHZ983BUoX2VASax7penjmetK5q62Xo9Hv8MD/l3ncOj8pKr6HhtT2bmdtBqpiIGm8FQxfNWs3ibGIim/fMpe7wKDU3Gc+deCOGj9wtqx3k0bKbZfXHjA568qo9MvlT169hHiQNVHP63GwvwQCErjR4ik8vEmnadYTHXEHr0YUz03uijXku0SNF/U4RReeIkw161qwqxwOIboWfx26+tFl6NvJx7PC9Tj/+shiX6LSG3jQJ4NxXq1mTGU7qQhd1iG91WepIkx0edz+qzL2fJX7VjxwvbbeKcZKOBOU2AGlv38lx3i6jPH270VtGAbuM8oeyh/e70RutKyB7fcuedDU8xM0I5EfGxa5ECRA4GpfMk6XSVIz+vK5DNFGE4X0aZ5iXXoPOxVXYkHQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/13/2023 4:46 AM, Sagi Shahar wrote: > The test verifies MMIO writes of various sizes from the guest to the host. > > Signed-off-by: Sagi Shahar > Signed-off-by: Ackerley Tng > Signed-off-by: Ryan Afranji Patch 17 and 18 test the part that guest has received the #VE caused by MMIO access, so calls the td vmcall to kvm to do the emulation. Should the generation of #VE due to MMIO access be covered as well? > --- > .../selftests/kvm/include/x86_64/tdx/tdx.h | 2 + > .../selftests/kvm/lib/x86_64/tdx/tdx.c | 14 +++ > .../selftests/kvm/x86_64/tdx_vm_tests.c | 85 +++++++++++++++++++ > 3 files changed, 101 insertions(+) > > diff --git a/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h b/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h > index 13ce60df5684..502b670ea699 100644 > --- a/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h > +++ b/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h > @@ -25,5 +25,7 @@ uint64_t tdg_vp_vmcall_instruction_wrmsr(uint64_t index, uint64_t value); > uint64_t tdg_vp_vmcall_instruction_hlt(uint64_t interrupt_blocked_flag); > uint64_t tdg_vp_vmcall_ve_request_mmio_read(uint64_t address, uint64_t size, > uint64_t *data_out); > +uint64_t tdg_vp_vmcall_ve_request_mmio_write(uint64_t address, uint64_t size, > + uint64_t data_in); > > #endif // SELFTEST_TDX_TDX_H > diff --git a/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c > index b19f07ebc0e7..f4afa09f7e3d 100644 > --- a/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c > +++ b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c > @@ -143,3 +143,17 @@ uint64_t tdg_vp_vmcall_ve_request_mmio_read(uint64_t address, uint64_t size, > > return ret; > } > + > +uint64_t tdg_vp_vmcall_ve_request_mmio_write(uint64_t address, uint64_t size, > + uint64_t data_in) > +{ > + struct tdx_hypercall_args args = { > + .r11 = TDG_VP_VMCALL_VE_REQUEST_MMIO, > + .r12 = size, > + .r13 = TDG_VP_VMCALL_VE_REQUEST_MMIO_WRITE, > + .r14 = address, > + .r15 = data_in, > + }; > + > + return __tdx_hypercall(&args, 0); > +} > diff --git a/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c b/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c > index 48902b69d13e..5e28ba828a92 100644 > --- a/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c > +++ b/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c > @@ -885,6 +885,90 @@ void verify_mmio_reads(void) > printf("\t ... PASSED\n"); > } > > +void guest_mmio_writes(void) > +{ > + uint64_t ret; > + > + ret = tdg_vp_vmcall_ve_request_mmio_write(TDX_MMIO_TEST_ADDR, 1, 0x12); > + if (ret) > + tdx_test_fatal(ret); > + > + ret = tdg_vp_vmcall_ve_request_mmio_write(TDX_MMIO_TEST_ADDR, 2, 0x1234); > + if (ret) > + tdx_test_fatal(ret); > + > + ret = tdg_vp_vmcall_ve_request_mmio_write(TDX_MMIO_TEST_ADDR, 4, 0x12345678); > + if (ret) > + tdx_test_fatal(ret); > + > + ret = tdg_vp_vmcall_ve_request_mmio_write(TDX_MMIO_TEST_ADDR, 8, 0x1234567890ABCDEF); > + if (ret) > + tdx_test_fatal(ret); > + > + // Write across page boundary. > + ret = tdg_vp_vmcall_ve_request_mmio_write(PAGE_SIZE - 1, 8, 0); > + if (ret) > + tdx_test_fatal(ret); > + > + tdx_test_success(); > +} > + > +/* > + * Varifies guest MMIO writes. > + */ > +void verify_mmio_writes(void) > +{ > + struct kvm_vm *vm; > + struct kvm_vcpu *vcpu; > + > + uint8_t byte_1; > + uint16_t byte_2; > + uint32_t byte_4; > + uint64_t byte_8; > + > + vm = td_create(); > + td_initialize(vm, VM_MEM_SRC_ANONYMOUS, 0); > + vcpu = td_vcpu_add(vm, 0, guest_mmio_writes); > + td_finalize(vm); > + > + printf("Verifying TD MMIO writes:\n"); > + > + td_vcpu_run(vcpu); > + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); > + TDX_TEST_ASSERT_MMIO(vcpu, TDX_MMIO_TEST_ADDR, 1, TDG_VP_VMCALL_VE_REQUEST_MMIO_WRITE); > + byte_1 = *(uint8_t *)(vcpu->run->mmio.data); > + > + td_vcpu_run(vcpu); > + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); > + TDX_TEST_ASSERT_MMIO(vcpu, TDX_MMIO_TEST_ADDR, 2, TDG_VP_VMCALL_VE_REQUEST_MMIO_WRITE); > + byte_2 = *(uint16_t *)(vcpu->run->mmio.data); > + > + td_vcpu_run(vcpu); > + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); > + TDX_TEST_ASSERT_MMIO(vcpu, TDX_MMIO_TEST_ADDR, 4, TDG_VP_VMCALL_VE_REQUEST_MMIO_WRITE); > + byte_4 = *(uint32_t *)(vcpu->run->mmio.data); > + > + td_vcpu_run(vcpu); > + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); > + TDX_TEST_ASSERT_MMIO(vcpu, TDX_MMIO_TEST_ADDR, 8, TDG_VP_VMCALL_VE_REQUEST_MMIO_WRITE); > + byte_8 = *(uint64_t *)(vcpu->run->mmio.data); > + > + TEST_ASSERT_EQ(byte_1, 0x12); > + TEST_ASSERT_EQ(byte_2, 0x1234); > + TEST_ASSERT_EQ(byte_4, 0x12345678); > + TEST_ASSERT_EQ(byte_8, 0x1234567890ABCDEF); > + > + td_vcpu_run(vcpu); > + TEST_ASSERT_EQ(vcpu->run->exit_reason, KVM_EXIT_SYSTEM_EVENT); > + TEST_ASSERT_EQ(vcpu->run->system_event.data[1], TDG_VP_VMCALL_INVALID_OPERAND); > + > + td_vcpu_run(vcpu); > + TDX_TEST_ASSERT_SUCCESS(vcpu); > + > + kvm_vm_free(vm); > + printf("\t ... PASSED\n"); > +} > + > int main(int argc, char **argv) > { > setbuf(stdout, NULL); > @@ -905,6 +989,7 @@ int main(int argc, char **argv) > run_in_new_process(&verify_guest_msr_reads); > run_in_new_process(&verify_guest_hlt); > run_in_new_process(&verify_mmio_reads); > + run_in_new_process(&verify_mmio_writes); > > return 0; > }