From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 292DDC5321D for ; Mon, 26 Aug 2024 19:49:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEE7D6B0082; Mon, 26 Aug 2024 15:49:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A9DC86B0085; Mon, 26 Aug 2024 15:49:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9481C6B0088; Mon, 26 Aug 2024 15:49:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 753376B0082 for ; Mon, 26 Aug 2024 15:49:53 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 25919A5416 for ; Mon, 26 Aug 2024 19:49:53 +0000 (UTC) X-FDA: 82495437066.10.5BBCCB9 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf19.hostedemail.com (Postfix) with ESMTP id A16241A0009 for ; Mon, 26 Aug 2024 19:49:50 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LVRgFvaZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6FnshH6F; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LVRgFvaZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6FnshH6F; dmarc=none; spf=pass (imf19.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724701721; a=rsa-sha256; cv=none; b=BAtGaut8qWrfgHaXq5PMeJcqzJyFfdy3cVAK6wBa/hdZ/xovJfXQ/uh3f3g2H+NbsrZHnE 9huQMxsT9a3m16I5So3OSrSXXyK14iOEdxpmoLngmKqaGExUTv1N1mQh9u3Pe5tRr72x7I x51MB/LcIsZlUQKhtwProUuLiTuUVbY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LVRgFvaZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6FnshH6F; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LVRgFvaZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6FnshH6F; dmarc=none; spf=pass (imf19.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724701721; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LHL39kTG08YAxQMF/S9M2pxd2nii1+KP2CGwq8hsDyY=; b=1oSqofKiAGEsfa46nV4kMeNCK/0MSflSQzMAgMv7Jxmhcxyr6Wk/hqjHOhc594qUPHN+ds F6BI8Idp3adnfnlB1TBX+Rzwat4Tt7u3IhgiPFyVcPsXrSBLgSgedJk6PjXAQz3PRtbpSU ijJkYzwvGAIVO6U4UaXCdZPi3aH5bKc= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 573481F8AE; Mon, 26 Aug 2024 19:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1724701488; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LHL39kTG08YAxQMF/S9M2pxd2nii1+KP2CGwq8hsDyY=; b=LVRgFvaZ5KhSBxTDq+9nsjE2ye/+asmWgrQSl+ivIAfw5suRUrDzZ6s1U59/D99vcWrzR0 7rVgMefnUwZY6L9Tl3eIAcFVq8WcDNH8Y8Um0n6Tjb+QEE4EnUkZXf4S6vXIoC8jrrAjy0 JkA/lfoMkFUrdI1uR0WmcnP2KTagr+0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1724701488; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LHL39kTG08YAxQMF/S9M2pxd2nii1+KP2CGwq8hsDyY=; b=6FnshH6Fa4xbK+FcNhJpseuikBI8EAxgNTkd8/bFCIYGHuwqosnct6YSWBHm2+eGXyXycI Fpd2E03wK5zCtJCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1724701488; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LHL39kTG08YAxQMF/S9M2pxd2nii1+KP2CGwq8hsDyY=; b=LVRgFvaZ5KhSBxTDq+9nsjE2ye/+asmWgrQSl+ivIAfw5suRUrDzZ6s1U59/D99vcWrzR0 7rVgMefnUwZY6L9Tl3eIAcFVq8WcDNH8Y8Um0n6Tjb+QEE4EnUkZXf4S6vXIoC8jrrAjy0 JkA/lfoMkFUrdI1uR0WmcnP2KTagr+0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1724701488; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LHL39kTG08YAxQMF/S9M2pxd2nii1+KP2CGwq8hsDyY=; b=6FnshH6Fa4xbK+FcNhJpseuikBI8EAxgNTkd8/bFCIYGHuwqosnct6YSWBHm2+eGXyXycI Fpd2E03wK5zCtJCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 354E21398D; Mon, 26 Aug 2024 19:44:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VAVYDDDbzGbgOgAAD6G6ig (envelope-from ); Mon, 26 Aug 2024 19:44:48 +0000 Message-ID: Date: Mon, 26 Aug 2024 21:44:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Reenable NUMA policy support in the slab allocator Content-Language: en-US To: cl@gentwo.org, "Matthew Wilcox (Oracle)" , Johannes Weiner , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Yang Shi Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@kernel.org References: <20240819-numa_policy-v1-1-f096cff543ee@gentwo.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240819-numa_policy-v1-1-f096cff543ee@gentwo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A16241A0009 X-Stat-Signature: sq6a8qtkc8dkx6f8datgqwhf9xtucx37 X-Rspam-User: X-HE-Tag: 1724701790-267682 X-HE-Meta: U2FsdGVkX1+pK89Kky011hpeCo0rhxp3fAg3sRsdaZeVoN+hlw3yW3lx/m2CZODv208aPJvKSNmAhbKxfUT0UXt7BAO5mE4FGxcWTyfp2i/iX+PsOqOnXYFLUnOdXk5P5rvtO/bI3ezVlYYEyTYVGgiXx+Wi+VKCDlXJUGkLrTtcuGkMAOJDGdsWBUSgJ0rZPngKD/WrfO8o+tz9pi6YVC7DqVEgNRAK8F3hlrb6L8P0N9jtw2kNz50UmN8HNpZjI7yKGODJBmR1Rif5tjXcaL3ORFHHO0WMcqK2XrxzHUXxWN2Ok6QPgp/AoVaWbh5WSYNZdUH3hJGnkfa0/clhRAZj3t1AqNIC6WnDx2744Gcztp8/UyyV+k3ryRT/U02APHSCgmkz0kuYdB065jiL5hObs8dbP0af9xMCiN7IC7I8Apu5JB4H3iO8MHmzyCBHiu4ioyuNo8rv7DpPwF/zK7pBCzaJ2Xwpz9MWwc6ShKbF45oYvqYYmWy6psDteT6KDym75s4gLLWg46kb6G+Hz1adrRaSqSUE8j5Oz7sCOpmfC+SviW8sgL+pCqWwGXh3SloYrRhM5Ff5xgzcDGZ8Gfh9ZgVagbW7+C4z7ZjSFzXsbkcI7fydAu0eUyTHX8sOFs/CMAmSior3sT7PiXUnQTvCz5k0xz5l7mbSqTRRgoEaqJbhZjefQDywZ+SlQjZareL/8y+NhZdIEWkBUcxNdzZwDd9aaBZ4UGYSWIUFtL2y+cOJNAzH2tfElw2YCNqVh5TRpDUq+BEhLEAnI2+hsQT5P3e2fiUldPDC8fNBLneW1HYg2bpnDtSC6EKDNGJ9cW0JERwS22oPFg75Dc2wKWD0zo1O9jnDIR15BKuzdsTtUK5sqFRogtxFemWz1waDG0fou35E6mtgXZ4qGFhExvXReochFTZqd2I4+KjhyhsKuYGFL9CUi4DTgjbHNu96WN2qYOyXI4VramaTJ0V l75FmbUi 2lslTTV0k/1Jb62LUjVHV3NGqa8QA98VoaiH+bY/HrZECQmOnoI37nrhBsr6b/kguop2ZMX8qaZEisa8QWfAcGCjv0dFbGUZLc1hlz7KouBVfaVHuvStMPygm5W+psEVZcpj64iwHAdlaQVrusmerSlz9DZiRSOOYWK628VfW3FDlnFxWbFz87kp4dKg9cjg+740X3CJn2Y5jYO1c8ttbOu5zwh45qz5wWuEXbJ43zej1WtEEWRCCZwoCsrDsiJeVzJXNpVFCZrc5puGQ+n9TI0AoNvusaokaRBAArfvNziBJKhSENpyvAwoNkcEvZ0Evq02dMrg6osmE+UZ7NG+BsIgOZ4gm3cN54Q+GkYM/pxeyLwVlezzJpxLyuL6kNSxE09P5qCMv477L3BCrcNTV9vvnFDhIo7Xpv95AY+KRC3Va3LDVA5fCSh2Rbl6M0jHyih8+A19P/W/pDEc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/19/24 20:54, Christoph Lameter via B4 Relay wrote: > From: Christoph Lameter > > Revert commit 8014c46ad991 ("slub: use alloc_pages_node() in alloc_slab_page()"). > > The patch disabled the numa policy support in the slab allocator. It > did not consider that alloc_pages() uses memory policies but > alloc_pages_node() does not. > > As a result of this patch slab memory allocations are no longer spread via > interleave policy across all available NUMA nodes on bootup. Instead > all slab memory is allocated close to the boot processor. This leads to > an imbalance of memory accesses on NUMA systems. > > Also applications using MPOL_INTERLEAVE as a memory policy will no longer > spread slab allocations over all nodes in the interleave set but allocate > memory locally. This may also result in unbalanced allocations > on a single numa node. > > SLUB does not apply memory policies to individual object allocations. > However, it relies on the page allocators support of memory policies > through alloc_pages() to do the NUMA memory allocations on a per > folio or page level. SLUB also applies memory policies when retrieving > partial allocated slab pages from the partial list. > > Fixes: 8014c46ad991 ("slub: use alloc_pages_node() in alloc_slab_page()") > Cc: stable@kernel.org I'm removing this as (unlike the stable tree maintainers) I try to follow the stable tree rules, and this wouldn't apply by them. Also it's a revert of 6.8 commit, so the LTS kernel 6.6 doesn't care anyway. > Signed-off-by: Christoph Lameter Thanks, added to slab/for-next > --- > mm/slub.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index c9d8a2497fd6..4dea3c7df5ad 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2318,7 +2318,11 @@ static inline struct slab *alloc_slab_page(gfp_t flags, int node, > struct slab *slab; > unsigned int order = oo_order(oo); > > - folio = (struct folio *)alloc_pages_node(node, flags, order); > + if (node == NUMA_NO_NODE) > + folio = (struct folio *)alloc_pages(flags, order); > + else > + folio = (struct folio *)__alloc_pages_node(node, flags, order); > + > if (!folio) > return NULL; > > > --- > base-commit: b0da640826ba3b6506b4996a6b23a429235e6923 > change-id: 20240806-numa_policy-5188f44ba0d8 > > Best regards,