From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64BF2C282EC for ; Tue, 18 Mar 2025 12:03:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B81A280002; Tue, 18 Mar 2025 08:03:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96860280001; Tue, 18 Mar 2025 08:03:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82EC7280002; Tue, 18 Mar 2025 08:03:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6511A280001 for ; Tue, 18 Mar 2025 08:03:53 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E8BD71CBAAC for ; Tue, 18 Mar 2025 12:03:54 +0000 (UTC) X-FDA: 83234537988.08.EB8763D Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf13.hostedemail.com (Postfix) with ESMTP id 0DD552002D for ; Tue, 18 Mar 2025 12:03:52 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GyMpamJB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of jiahao.kernel@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=jiahao.kernel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742299433; a=rsa-sha256; cv=none; b=vKYHQJEd2LyKi+aC1zDuxRWjy8Ae8LSoXNsBM+70qFY7EO3O7/HYVEbgrxsyewjXoqlPTv plYFeizO4THrdy4QACSFOwftLQvIrDNEZNrBtb2kb9ovn1NoX3bjaVvMhtpxSBR+gQltn6 l4lThMUh982McCmypfmE+J3H1cj/dr8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GyMpamJB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of jiahao.kernel@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=jiahao.kernel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742299433; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g286AmrqJFZCIXU6diWj4M9nrpngO7iRskShEc5/HSI=; b=eiAqTNM9gK3LaebfK6tRGc8PTU2zvCqeGGCqtM3WbLgaPULW+52xT/k21mdTJVWso1DW7Z edRUVydG3UtGJwCpoSFqpY39DEFFFJlsIpM9vaWvGqulZsHz0qsMRSg3qd06qcUHPp3Rui TJLPLYVqBoWGnlFT08WfftDX2lsTKkI= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-223a7065ff8so6035875ad.0 for ; Tue, 18 Mar 2025 05:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742299432; x=1742904232; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=g286AmrqJFZCIXU6diWj4M9nrpngO7iRskShEc5/HSI=; b=GyMpamJBGCj8fKITj0TpmU96OToVKSk0qhyf0vMg5CW3CC7OVdLU3x5AY6N5rEx6Hy oXPbeEBomK4+Uc31ZlrCdDCAPTpqj+9BECWuNwcjgu+I43xoetCGlCNXzQqJCMenAm4t YgjHCj3K90UzvDlGLRBl8d0AgMfH8viWfXAX8gs0NMfdAAj6o+On09fs6ujTppvO/Kob I4i/CH/vleQEiwYm80qteqR8QRS+yRS/QiDOSyl5a8kQWIwf+LILLk4iFN5aXhBoZtJs maJalLNLlW6BZ4+119jYHDQk6r3lNPKyFtdXtffRYsSKOFaAAiOPSXm3GAjz55R2zJdf qdCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742299432; x=1742904232; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=g286AmrqJFZCIXU6diWj4M9nrpngO7iRskShEc5/HSI=; b=FPZIfIqLj+LJFyl9WREV31mjFpzJ0RUcOy/8h065yoqXnceIoNd2NuMmexfNrFxdQZ gGFhUkrn5xh31KucBDZaEanULQXeOcZCV5SIea26SjzKpvU9WA050W0LxTeIOdw/6qYz gMOfnMPuv9T8WlqAtSAcxF6LDKJuIYy0UJurlAwnp4OYOWserdLW5bvhmphUwsqlDs7T okhBqK5rI5D1AIknbLdwG/6+/CZ2zB23zgCMD9VQUyRn3+l1nMaxgr/7eEhYdq4msB4D yphQ1Fv2YKbHPI4lsJisqWy8QbLBpdjKHm0zKDZ3KT4vQFq7PFlJTYfuwEKShS/E5W51 9ElQ== X-Forwarded-Encrypted: i=1; AJvYcCVSDZ182iEvVUWxAk72woKpSHLY77Mu4uZ2VnvL+/hf0eY33UsdEsRmGB8F1XBHdyGdOw9drkeEfw==@kvack.org X-Gm-Message-State: AOJu0YzmOztiO0I1AG8zdxfUyQLkDyvpvka5CuCG4rSvbC0NxhDOmU8D kIBh5UHajZAKGqKY3CQmMCyLpAoXe3HzAUD/9GZp/X3PjQ//N9S2 X-Gm-Gg: ASbGncsTOgHSw0C8TQmLXRPCHaGrcVyMqFHzEsB3c0/RGwaf1hO/9ZZfdeBL0f0Wwp6 SpUwV9BDnbiLlQaPZHp/Y1hSJM2vY9CjyqVBUdtgcEy7MIsl477WZY0V5z3lHnhCFkXxgSnlJ4L DzwefS4lriJrIfZZ/sN+tRH4Cy7THCqeMnwb5e34oGZx+azfrH10UgKB2LCbhhGmJDiDmgx/VZM tWmD3quMEMZd+9ZyqF8HuORZfk0xdVaoZX1wMwD6fdwELSaxVBPnvWbFEBwXgcTRlHajvYGrRfc VElo28eyC8E8+Bnx0iBCVq3cOOEJWzogxinDrPi03thuBIfYAF7hpfSBV29S2aeS X-Google-Smtp-Source: AGHT+IEUry7uNBfZfrQXJDmQ4UWuDItAhEZlRZebCkdsdMrUuE7/GeKzZVaB0DmYQEiGHfspFpm1bw== X-Received: by 2002:a17:903:1a26:b0:224:c46:d166 with SMTP id d9443c01a7336-225e0b18f50mr251057845ad.40.1742299431758; Tue, 18 Mar 2025 05:03:51 -0700 (PDT) Received: from [10.125.192.74] ([103.165.80.178]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c68884fcsm92974765ad.16.2025.03.18.05.03.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Mar 2025 05:03:51 -0700 (PDT) Message-ID: Date: Tue, 18 Mar 2025 20:03:44 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 1/2] mm: vmscan: Split proactive reclaim statistics from direct reclaim statistics To: =?UTF-8?Q?Michal_Koutn=c3=bd?= Cc: hannes@cmpxchg.org, akpm@linux-foundation.org, tj@kernel.org, corbet@lwn.net, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Hao Jia References: <20250318075833.90615-1-jiahao.kernel@gmail.com> <20250318075833.90615-2-jiahao.kernel@gmail.com> From: Hao Jia In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 0DD552002D X-Rspamd-Server: rspam05 X-Stat-Signature: 7xaxdn8qffkpxbwk9ebow375rdy9ydmh X-HE-Tag: 1742299432-522182 X-HE-Meta: U2FsdGVkX1+QznjUoVjfr2H3SBt5FV0Lq3m+Vu3kiotWa29JNaBGEHMGxNgACBJ/aYHDZFEHE7w6EijVv4FsfTKB0/5yBVqO1rhodAMoUNYj5OquIRtBub0Ho6qR2q+pzAjEWI05w1FR7l1sJATDUuXJSupmWvsmarygruFEdCshPRrk8S++NoAE3EJQNmuzqIWIvuDI7CnKZSfFJAEV5ERIamCt5FAfIcd4r+7xZ0U48Q0SUTgIQLYGxd9P/sZkSNF4U2PMmIYoJdgZVq6kevu5hXzWJh3zK3lYxmG5WZ1Cyp/GYEZObop0933d/KkeBFCAuJtAoZQ246XTCqGNajVdxV2wLsESmLFhVtaKtT9wX9RkAYGcKJTjH1hPguoAbTPwiR6P7qCXVV+6mztm08Tx2+uWdK8C+lSVgOUPFOryD+nHPP/gSaLlwkQX2nMGBsprVTuXQGGXgiANruuDR0ET1Hwf1GA1+eWIMa30UgikcO16hZo4TeR0opue6U28BOKZot4j2YHVDey/Zf/EodvVznrMgCaTDSJNUxxHcesm1OwQ8E/OGCijgckCOqVpQ8h73qgoSPpFSJnosrnJyJuldgrzgyW+jJzonSnsaIic8gsJFtNanAJF1iPCz2kUzXl6+0pa8Btwl5LNdhqWYXmY9wlG+0ZfzIlviP9UrGGH7JQXcB4JjyObOhu08tn8ZWO6uZ9wfhUtgLTHhu7jxCiSDNYss9MODP4VEEoBkCyWxY+RC4bvBLJ+t2chsHZTObG8qqwzEuk87u9kB/mQA3NJZC66yK+qgnNGn7uUULy2ePa2B12vlO48rK+SOk07q61nPvjqbwp7zJkGo6D5Tr3jMrPP6p4OwNdSqllGxsA64LOybNAxbh7rnx+9g1XqfFI8jO7KKwrO8qLokU7rNuoTYjmR46c046qpmN1FzLkEkXPt2CROKZLYjfkaUsBQuyIaS0Gh6OxEjZmJiFY zFF8yVcx dGBHJIFB7UeTGUaN0y3lfEBCV/78QW5mimsc7ljgUuj4VjOe8CVss34HoudtFTgWoRYP0mGHPi/gpVINs4I1RCP6RlPFIHuz7dp99Eb29LQkcLsLnMwu09A090kbAuq59BdgFhVFmsYlBS2RV5pv1qzRLfxhFrlvCDfT637jZM+2yBe5ROvV7fZn7u/tPBHaiStxunqSKGNdVoqEomk+f9uACjDMD7AEJYu9fdagfS+FntPxgYF00RCiVwEUE8/rc96dewVdO5csML2Dc1VAW0tQziTBfBBQGigl8plqpUc/DG7V70jzY3CbS67pFuZgzJk3VyHmg4ZW3TcWYvb3by3oo/XDVrfKZtIbOM6dYbDCEG/Oh4qPX7ZDO7jkZa+meaRQjmSJerGgXNKWswpU2R/tkI/A1WcSzHin0wKDPFImxG42JLkOoWg/Z+rfcqBCOJY8cAsO/m4L2LefCxr8qzDhZGC2SGAFfkOws6hx+rlQjIBEsbMM1vDKZrT0pDKvqoCzo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/3/18 18:17, Michal Koutný wrote: > Hello. > > On Tue, Mar 18, 2025 at 03:58:32PM +0800, Hao Jia wrote: >> From: Hao Jia >> >> In proactive memory reclaim scenarios, it is necessary to >> accurately track proactive reclaim statistics to dynamically >> adjust the frequency and amount of memory being reclaimed >> proactively. Currently, proactive reclaim is included in >> direct reclaim statistics, which can make these >> direct reclaim statistics misleading. > > How silly is it to have multiple memory.reclaim writers? > Would it make sense to bind those statistics to each such a write(r) > instead of the aggregated totals? I'm sorry, I didn't understand what your suggestion was conveying. Are you suggesting that the statistics for {pgscan, pgsteal}_{kswapd, direct, khugepaged} be merged into one? In our current scenario, userspace proactive reclaimers trigger proactive memory reclaim on different memory cgroups. Tracking statistics related to proactive reclaim for each memory cgroup is very helpful for dynamically adjusting the frequency and amount of memory reclaimed for each cgroup. Please correct me if I've misunderstood anything. Thanks, Hao