From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B43FD2E02B for ; Wed, 23 Oct 2024 09:11:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 924A36B007B; Wed, 23 Oct 2024 05:11:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 885D16B0082; Wed, 23 Oct 2024 05:11:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FF466B0088; Wed, 23 Oct 2024 05:11:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 48B0F6B007B for ; Wed, 23 Oct 2024 05:11:51 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 21E0B1C28B6 for ; Wed, 23 Oct 2024 09:11:31 +0000 (UTC) X-FDA: 82704298782.13.F1C82A2 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf21.hostedemail.com (Postfix) with ESMTP id B2E2E1C0023 for ; Wed, 23 Oct 2024 09:11:15 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lVcI31Cn; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PVc6G93g; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lVcI31Cn; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PVc6G93g; dmarc=none; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729674657; a=rsa-sha256; cv=none; b=SdEo8UjYE3iZBHaaDkUEg1YgWKoTsDO4hWCMBQ/hKpiE429CtGX37MtdjUlfOFYRt5L915 f35wOxLIqqqm5NFPsRpX6OkdaPC8/q61Ma7TggsJ+XqPREA9xzpwYsLHemdhLuWegPryJb /vDGLnyJL3YbnmhSGCma7zWb2bDDMnU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lVcI31Cn; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PVc6G93g; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lVcI31Cn; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PVc6G93g; dmarc=none; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729674657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cVzGJfddetG2OWmpzk6SpET1KPK32seRPwPUmrODCPk=; b=xpn4SbB6WnJAXVSDA6X26u+U5PWe5jkyVj0ilTsdfUQizUbZPbCrgJD0COfuOJVZqI9/R8 JSJ1gV5LnrI7a6ewcnOH1UzJUvDikzLYnvdjoRrHaE9AWuFFctF58Pn7e8MdZ/PXltf0J9 tk7s1P7fw1WdiDv0Thq12rElppQheOg= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 97A611FD91; Wed, 23 Oct 2024 09:11:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729674706; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=cVzGJfddetG2OWmpzk6SpET1KPK32seRPwPUmrODCPk=; b=lVcI31Cn//YfzPOXQs53egqFqTEwSMKmKHKBa3krZeyxSgSvhkOMnkFEKZ18CKTgYBU63D 7oS5xhGpfN7HbYYf2ST1bZQpIn4+l9VbEVu2f1OImHpAXHAEloDApFjiGut9SOrQuYHtq5 Rg3AUtYkQlMKh5ZGoQU0bB0TuCe+fDM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729674706; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=cVzGJfddetG2OWmpzk6SpET1KPK32seRPwPUmrODCPk=; b=PVc6G93gJm1JeNbNzrE8NFEGIuKsiqbnvEPymKZ/9EMiE+LGIH/6q5/RClLgC3eFaJzW1W eI6lHVUrWUc0qVBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729674706; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=cVzGJfddetG2OWmpzk6SpET1KPK32seRPwPUmrODCPk=; b=lVcI31Cn//YfzPOXQs53egqFqTEwSMKmKHKBa3krZeyxSgSvhkOMnkFEKZ18CKTgYBU63D 7oS5xhGpfN7HbYYf2ST1bZQpIn4+l9VbEVu2f1OImHpAXHAEloDApFjiGut9SOrQuYHtq5 Rg3AUtYkQlMKh5ZGoQU0bB0TuCe+fDM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729674706; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=cVzGJfddetG2OWmpzk6SpET1KPK32seRPwPUmrODCPk=; b=PVc6G93gJm1JeNbNzrE8NFEGIuKsiqbnvEPymKZ/9EMiE+LGIH/6q5/RClLgC3eFaJzW1W eI6lHVUrWUc0qVBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 82CCA13A63; Wed, 23 Oct 2024 09:11:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0J+QH9K9GGf0JgAAD6G6ig (envelope-from ); Wed, 23 Oct 2024 09:11:46 +0000 Message-ID: Date: Wed, 23 Oct 2024 11:11:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH hotfix 6.12 1/8] mm: avoid unsafe VMA hook invocation when error arises on mmap hook Content-Language: en-US To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Peter Xu References: From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Queue-Id: B2E2E1C0023 X-Rspamd-Server: rspam01 X-Stat-Signature: iz48pbnctju8yyhmx7n3iouzyc1tzu9o X-HE-Tag: 1729674675-800630 X-HE-Meta: U2FsdGVkX18RnGKCml+DCk9xgSUdOH2D3incwBVXxHa5C5RZD1eGHqNNyoXxXsseR8Ul3AbAjLee9f1iMrAwZ85xrFQNIWue9XNeMEpcFWGo2ieEkppoLn3hODzas6pBwdCqpPVyDC8e3iGpNgIaUlw+CuTTfL/inpip78jWYRFJCwqPGKdiOTy00CrES0q+XHWnEbG6se9AtGdahji7OruE+UbvZhvU4crnmiOnKehjB0k2asufvy9CnyqebZBvkQsgywK06W6pPJWiZSuIOCdqIIxdqV2B2CEh5dTa81FGQ0R28RzgJKXPYXI+0K4Q0zye8f1FNFBBISfXArBdadtUl+KJ56iytXDcLA2XKF2YAdJGIfo3pluGH8cYYX4Gy/M4ePHEWFhtbfVmohno+FtYOaOMk3r6J4TEAksuQzJ96pqQpqy1+VoZic8eNMmWeIo/a1kxrLb1ivIS5RZ8f0l5Bf2gs5kLyWc/Ho6Iexr2N1M1vj/NjZ/XN8GNsxpv6056iGKoqoh4d0kWOVkMxEl2/ozUquqSdFQtVir7GKPgqupkjyf0QEVsxs1izDLFzbXW6bdeDRkwsMRnQPFrsEdsqw07RR9wVxcwzarNpWXzqT/6VeH01QkvGKfwpZ+wAb9wFYkDFC57tAg0jcPWUGBDR6uMh9ZMCqbaAh/e8X0DH50IN/tp9xmOVpJxsdlGMsigcOJbIUe/YW1lvmO6MjWpl1CXiQaUB8DmLgA0alpsoYzhluiOtx0pCG553oPBhlDoGTsRpECXFKWGJadXYFZkIrHTK+rrFlYNLaPkj0PexqO4R9j8F066tAS+d8E1oTpinNRYRFzj94pWZmVqO6tsCkeBy584PtOlX2orJCkjPCjFKlJPj42gjqDYFfCUgbT/Vt1CzURhfAnmGxzjGnIpddvhKNLRIGf4m85CvyZ28MsBcBO5A58z2LfzktSjrPSwZSozCmZus4xuxnC HyJ6WWPw dgp2kHoKqe0f1zDMTfCnJ7IcqIHgAYCAg/qQIK5lrZyq4kF05tOnq5kz60a5zOVEQGnIO5i9vBa+wHRmTnSh4OwYJZ2Z+GMeBplRRj4VTOHJkh1aT0rNd/btd9e5WEVEgdPy8uAOPDb1/8q+jas3uL58Yk6m9j52n9homlDapj7Ssk4NIwdjZPzIDbIH4hDidQlek0jvRnbNdb4snym0q3/5ez7V0hqe6PjtjBud2jEAb5cnC+UHP3HE1PMWx8n64SUX6dAObFUFYuworFzewjVei2I0nnXMLbZpzo+kdFQ82Bx1Z1fAd1EuskWtwVcFy7uDiNz1N5K9DuA1GUoWIBAW8sSdbVzBfTN9DEtAidwtqM5I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/22/24 22:40, Lorenzo Stoakes wrote: > After an attempted mmap() fails, we are no longer in a situation where we > can safely interact with VMA hooks. This is currently not enforced, meaning > that we need complicated handling to ensure we do not incorrectly call > these hooks. > > We can avoid the whole issue by treating the VMA as suspect the moment that > the file->f_ops->mmap() function reports an error by replacing whatever VMA > operations were installed with a dummy empty set of VMA operations. > > We do so through a new helper function internal to mm - mmap_file() - which > is both more logically named than the existing call_mmap() function and > correctly isolates handling of the vm_op reassignment to mm. > > All the existing invocations of call_mmap() outside of mm are ultimately > nested within the call_mmap() from mm, which we now replace. > > It is therefore safe to leave call_mmap() in place as a convenience > function (and to avoid churn). The invokers are: > > ovl_file_operations -> mmap -> ovl_mmap() -> backing_file_mmap() > coda_file_operations -> mmap -> coda_file_mmap() > shm_file_operations -> shm_mmap() > shm_file_operations_huge -> shm_mmap() > dma_buf_fops -> dma_buf_mmap_internal -> i915_dmabuf_ops > -> i915_gem_dmabuf_mmap() > > None of these callers interact with vm_ops or mappings in a problematic way > on error, quickly exiting out. > > Reported-by: Jann Horn > Fixes: deb0f6562884 ("mm/mmap: undo ->mmap() when arch_validate_flags() fails") > Cc: stable > Signed-off-by: Lorenzo Stoakes Reviewed-by: Vlastimil Babka