From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C544BC83F03 for ; Wed, 9 Jul 2025 08:57:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 359456B00B1; Wed, 9 Jul 2025 04:57:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 331586B00B2; Wed, 9 Jul 2025 04:57:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21F5A6B00B6; Wed, 9 Jul 2025 04:57:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 087AD6B00B1 for ; Wed, 9 Jul 2025 04:57:53 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 952B1C03BF for ; Wed, 9 Jul 2025 08:57:52 +0000 (UTC) X-FDA: 83644123584.07.E3E261C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf07.hostedemail.com (Postfix) with ESMTP id 00C3040004 for ; Wed, 9 Jul 2025 08:57:49 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=FjXj5UgC; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=dOHyD4Km; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=FjXj5UgC; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=dOHyD4Km; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752051470; a=rsa-sha256; cv=none; b=apk/C6/rotO6JQtZUQ65b5Kl1mX8IQ2EloI+jilnzG6rLPGkEc36dX7ic6d4hnJg39in6x RscEuDB+34vBfvU3xPcLDuMGCahVGYmynpUYZbqxLeQVQaIBTiOphfQkzYpHngkfEiaAVh s7Jo6zlgi3VQc9jE1Bcvo1V4J5Q5RI4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752051470; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i3/KfFmJ/KQlDJwZFSHjk1Sh8bR1AS+rGvKU6PYdcEE=; b=WdtOr2ih2jNAzrjwn56+sEFySEysaujrIaFArQrMymesSLXjG0d1fxxjlRNeSWrJYQeogG /ov6rHa1dPj9Bq3VmrCohbOF1Q5NuSA67EJdPyu/K3jf9r3MLgzSzaa+BFA3a7sbyyf81F 0+EnHZUUZtRKWIhsweLv8qLse8zuv1U= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=FjXj5UgC; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=dOHyD4Km; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=FjXj5UgC; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=dOHyD4Km; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 296921F45B; Wed, 9 Jul 2025 08:57:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1752051468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=i3/KfFmJ/KQlDJwZFSHjk1Sh8bR1AS+rGvKU6PYdcEE=; b=FjXj5UgCcFHU4w3IRARtLNsaR1AN8UatYm2EppFXfu8U8THcXW69J718U72ehggGacRu2+ M+mdq4Kxt97VK+Twl+Rxy6g9QBR+IiEdaMM+dm1N6/kEzfEHWM+9MXfMWpJEjjCYjIksQo bwTMtzIy2C4SkbuB21YbK4KTwozryBg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1752051468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=i3/KfFmJ/KQlDJwZFSHjk1Sh8bR1AS+rGvKU6PYdcEE=; b=dOHyD4KmEYb900NDDEsMahLq4Q8+8XDz9duBxlD3TUm4GwTnY5wVuALEi7Xj5wPdcPHfbE F7zJXAoUlDRJQGBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1752051468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=i3/KfFmJ/KQlDJwZFSHjk1Sh8bR1AS+rGvKU6PYdcEE=; b=FjXj5UgCcFHU4w3IRARtLNsaR1AN8UatYm2EppFXfu8U8THcXW69J718U72ehggGacRu2+ M+mdq4Kxt97VK+Twl+Rxy6g9QBR+IiEdaMM+dm1N6/kEzfEHWM+9MXfMWpJEjjCYjIksQo bwTMtzIy2C4SkbuB21YbK4KTwozryBg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1752051468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=i3/KfFmJ/KQlDJwZFSHjk1Sh8bR1AS+rGvKU6PYdcEE=; b=dOHyD4KmEYb900NDDEsMahLq4Q8+8XDz9duBxlD3TUm4GwTnY5wVuALEi7Xj5wPdcPHfbE F7zJXAoUlDRJQGBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E231613757; Wed, 9 Jul 2025 08:57:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 3/TFNQsvbmiOAwAAD6G6ig (envelope-from ); Wed, 09 Jul 2025 08:57:47 +0000 Message-ID: Date: Wed, 9 Jul 2025 10:57:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 7/8] fs/proc/task_mmu: read proc/pid/maps under per-vma lock To: Suren Baghdasaryan , Lorenzo Stoakes Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, david@redhat.com, peterx@redhat.com, jannh@google.com, hannes@cmpxchg.org, mhocko@kernel.org, paulmck@kernel.org, shuah@kernel.org, adobriyan@gmail.com, brauner@kernel.org, josef@toxicpanda.com, yebin10@huawei.com, linux@weissschuh.net, willy@infradead.org, osalvador@suse.de, andrii@kernel.org, ryan.roberts@arm.com, christophe.leroy@csgroup.eu, tjmercier@google.com, kaleshsingh@google.com, aha310510@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20250704060727.724817-1-surenb@google.com> <20250704060727.724817-8-surenb@google.com> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 00C3040004 X-Stat-Signature: 1kftfx55as8hza3cy4hharghhfccrfmt X-HE-Tag: 1752051469-9350 X-HE-Meta: U2FsdGVkX1+iBrZlt+wdNnq3i7uAkjcBjh7kuuy3Kt9Mw0fNsSDQ8aSgqxkftuIu2hTL5SPPRYnwnjdnqlLOYWJ0NjEE6bFfNU6V+nTX1TQxAOvbCFShq/Xt+5NuQaU5TfX6YqWG7sYA0wSAuCKwx/jt/hHLnrGR9v3JdwWFLeHYbnaTIjOZhnX8OUtdkmRXBgNswktaIGr+T4CMROJi1ZPytI3RMTWLXxMtI/tTbltG9bdletw2U058TVFmDlRiDvT58Plvj98a7zf2bZzaqG6waLDtvhb4YR1+h4o1NZDXSmlI01LMyIuddddXC5HIXsJ4TFmAgJRKk/f8kAxf4q3HVZByCQbZAv+lXyFKn8VI26tfeNJkhNP0T0DfvByXtMhzfqPytFd1ac2rwkL87LN+OTtDV5EHbwsDG5Wr3zDgh7uvloFRPMAMcXhRgvnudVGxj7FVu2Dv/9eC1Hl4epcNtcLnNno0dCDt/ugSo/fl8QA3vzM0OmA8lX/TMbXqn2JslbgObE2FRC3CiQzv5XQph9PTDR2lTUGSx8xXjGbtNGtbh+N75B2KMlYTnfLir6WExerykrZXdmD6zZIo2pwe2rTqTaaz/Pkq3K6giv3Z/fLg+HGljZ7IaQggRIwdqq+9lQSng/+x8ay8LGxtid35fLIyT6xJYOa5HaPbSKWx7wAFk0qhFreTJ8aE10NH/fiiZoo1uSLtxt3SdEsSZ2sE4VBzw7ZI3O+iVmvSXXnf76ni72bpw6OOICJ8UEJJUwz89PCEmZc4lxarWR7KYBPtrP6eZfX7+lPmmrb8WWjJJ4ud/2DZo5SbsRRvEfkXVnP7M4fGAQPKxDNDkjshSZVxrFclSmXGDbFnPA2ndiziHklDJZaEb5bqGi/peApyNZhYBErfVYaepwsBdSsMPN0D10jpOmGJ8EH9XlStV+BLliOSKobZGLxhUS79bzXORZdHgySxLbTtSy4mAR3 zQlbxgNy 8VXeQDslcWmzroOyEoNSF3v7FF4SyJguUQpc/rmKZJFuM5rZzPUk2rWJtHEIoK16YgfoQxKu8wxFq9C4I8jaqg5gFuizwAiGy9oFIOSegABvcxh1uZj1kErkBUJH2xzI9xh5JiHFCuCeS9kzkyojeVcswvTwFOvUFyvjMXx6/LlCu84GKQEaUf3pniiMZaRGlgGe6vjU0/PQFRTj6qSHn/stfq/zpnQeBKOdRPjmxOfaMHplyoAJ6tcrM0wYqBaZZz0hJCNJ5kzVNKaAxHLN0mvuw2pvY6FAhKio1pyskbAPID/kuZ9x2U3TK295Kby4Jz6/XgAG8R3wBp4h4A6TkTIUB36uKsZSIHPZp/aA1J4rkuPJO6JTYEzHtVziZ5Z6jJOKN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/8/25 01:10, Suren Baghdasaryan wrote: >>> + rcu_read_unlock(); >>> + vma = lock_vma_under_mmap_lock(mm, iter, address); >>> + rcu_read_lock(); >> OK I guess we hold the RCU lock the whole time as we traverse except when >> we lock under mmap lock. > Correct. I wonder if it's really necessary? Can't it be done just inside lock_next_vma()? It would also avoid the unlock/lock dance quoted above. Even if we later manage to extend this approach to smaps and employ rcu locking to traverse the page tables, I'd think it's best to separate and fine-grain the rcu lock usage for vma iterator and page tables, if only to avoid too long time under the lock.