From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCDE3C43334 for ; Fri, 17 Jun 2022 03:08:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44DBD6B0071; Thu, 16 Jun 2022 23:08:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4011A6B0073; Thu, 16 Jun 2022 23:08:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C4C06B0074; Thu, 16 Jun 2022 23:08:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1C1596B0071 for ; Thu, 16 Jun 2022 23:08:16 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DF96B202C9 for ; Fri, 17 Jun 2022 03:08:15 +0000 (UTC) X-FDA: 79586244150.01.D2BE78C Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf31.hostedemail.com (Postfix) with ESMTP id 3BD9520042 for ; Fri, 17 Jun 2022 03:08:15 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6D2A912FC; Thu, 16 Jun 2022 20:08:14 -0700 (PDT) Received: from [192.168.0.146] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5B9533F73B; Thu, 16 Jun 2022 20:08:11 -0700 (PDT) Message-ID: Date: Fri, 17 Jun 2022 08:37:39 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH V3 0/2] mm/mmap: Drop __SXXX/__PXXX macros from across platforms Content-Language: en-US To: Christophe Leroy , "linux-mm@kvack.org" Cc: "hch@infradead.org" , Andrew Morton , "linux-kernel@vger.kernel.org" References: <20220616040924.1022607-1-anshuman.khandual@arm.com> <1fe37a32-f11b-fbc4-7fca-46dcc89b50c4@csgroup.eu> From: Anshuman Khandual In-Reply-To: <1fe37a32-f11b-fbc4-7fca-46dcc89b50c4@csgroup.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf31.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655435295; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kRObWzl+gBKuUaW4sxO2GBoIXfwm68XgkdQN2E8klLg=; b=oKU1dizLpXTMqP2baNyAxyF3zq1/WI/i+IPe+pxHSYH+PYgY14LBkudff/V0FpOdzN3qie jH/XPE+sm6se9ySu3TzR+xUIrDQKXcAwmGfCxx3KcrdQBqDPritSaYFYIU4wLO1b3gDlYy r+96w78WPj9LzS2UqseBeaF+i2T/BT8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655435295; a=rsa-sha256; cv=none; b=z48AciXmSr5XImy6NP/AlPeBo8KB6VHW2X20bSNBz42r+XbegUYplcM3zkirRTHoJnmnrY 6owMSEO/3djX4D9RVacLd9XiJ4yTFbJQOgmge1NKn4MDf0NzLy+N2DAUgFtpBO6LugMKEA XAKz/fm2MXulpPhhOczMQ6EGOh3Vodg= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3BD9520042 X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf31.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com X-Stat-Signature: bey6m98cnrce4u5oeb7u5ceob9ii39dw X-HE-Tag: 1655435295-922622 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/16/22 10:52, Christophe Leroy wrote: > > > Le 16/06/2022 à 06:09, Anshuman Khandual a écrit : >> __SXXX/__PXXX macros is an unnecessary abstraction layer in creating the >> generic protection_map[] array which is used for vm_get_page_prot(). This >> abstraction layer can be avoided, if the platforms just define the array >> protection_map[] for all possible vm_flags access permission combinations. >> >> This series drops __SXXX/__PXXX macros from across platforms in the tree. >> First it makes protection_map[] array private (static) on platforms which >> enable ARCH_HAS_VM_GET_PAGE_PROT, later moves protection_map[] array into >> arch for all remaining platforms (!ARCH_HAS_VM_GET_PAGE_PROT), dropping >> the generic one. In the process __SXXX/__PXXX macros become redundant and >> thus get dropped off completely. I understand that the diff stat is large >> here, but please do suggest if there is a better way. This series applies >> on v5.19-rc1 and has been build tested for multiple platforms. > > Maybe this patch could be split with one patch per architecture. All you > have to do for that is to guard the generic protection_map declaration > with #ifdef __S000 , then the architectures can be migrated one by one. > >> >> The CC list for this series has been reduced to just minimum, until there >> is some initial agreement. > > Agreement with who if people don't know this series exists ? > > I think you should keep the architecture lists in copy allthough you > don't include individual maintainers/reviewers for now. Sure, will do. > >> >> - Anshuman >> >> Changes in V3: >> >> - Fix build issues on powerpc and riscv >> >> Changes in V2: > > I guess V2 was only sent to linux-mm as well ? Too bad. I was in a dilemma, whether to first arrive at something more acceptable or just engage all stake holders from the beginning. I understand your concern and hence will copy architecture mailing lists from next time onward.