From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22A60C021B8 for ; Tue, 4 Mar 2025 17:52:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 850B06B0082; Tue, 4 Mar 2025 12:52:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 800E56B0083; Tue, 4 Mar 2025 12:52:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A3076B0085; Tue, 4 Mar 2025 12:52:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4B8026B0082 for ; Tue, 4 Mar 2025 12:52:01 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F0507C0439 for ; Tue, 4 Mar 2025 17:52:00 +0000 (UTC) X-FDA: 83184612000.12.DC0FE04 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by imf26.hostedemail.com (Postfix) with ESMTP id 1CAD8140006 for ; Tue, 4 Mar 2025 17:51:57 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=KRsqW7fG; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf26.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741110718; a=rsa-sha256; cv=none; b=PoW6WeaV0zMZqop+tdET/ydGMdDRpFPOgKREFJHe87CwzrP9W8dAW57vybYElLBINOZzy2 5Fj7RDS4ado0vGLDnFS9tlaDcOKJDpC49mT7MVF/C0Ggj2xHDP3F4mPXEPIS5omt70BZh+ x2JurIe91QNVCCK7UZSTBf35koiflwM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=KRsqW7fG; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf26.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741110718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ubdJSUvqT1ObTw4JV6KPGYlo+PfeRdeGPrJj84f2kHM=; b=aHkTWWiK3z7wqUm3ZzikXWCfcQtzBQ9EIQ7FaGJQJNk9nnYoatVzSi3vEUsORic8z4rz8c SF/Gu0S2uMx3RbWiMxnxHv06c0IJY7o9WSp6ptOomeO4JYrJ+DuMT9iwxkFW6rY58H0AeT qQDd+xmjBKa26TNWnXOHV5X2B5+34YE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741110718; x=1772646718; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=TUZ1PEKuDlaVu2H/sWtLP74hzoT82EHUfDQolb2ZQtA=; b=KRsqW7fGJtsg4UmcS5ODu3Vv2iG9vM2zI01TrdQJH5JYyw4kcTtdZ2bv FaMHDYi5F2w2fiPPcPy6uqAN+WQjzbIJK3Ocd6T1Jx2sdA7ohooXx6ADV T46MIOtz/HJW923DrpMY3UwM5j6UgzQjgUOkr9fj5SYqpPHHK/7iMTET3 49DqJG9sJLd8Oc/2L/fKFzP5eMagWPCYmMUnwjKMZY71HaCsJ1oqE3OQH 99duPDY6gb74qt6mnwyTq7I0uFD5NDuMoHw9y9ApQTLnbw7vpepk47GlT fRh6AqkkyIxp4w4ghUY7El+CkN2QLHGZoffna+sEorXnKYsjR95ooZOFm w==; X-CSE-ConnectionGUID: zgi06VDbQHWJT/Ld63Vanw== X-CSE-MsgGUID: 7GA9mNvCTPm6jitYo8XqpQ== X-IronPort-AV: E=McAfee;i="6700,10204,11363"; a="45694103" X-IronPort-AV: E=Sophos;i="6.14,220,1736841600"; d="scan'208";a="45694103" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2025 09:51:30 -0800 X-CSE-ConnectionGUID: JNDFc07+RKqO30qmaDOe2g== X-CSE-MsgGUID: hQgU/ItRTCKMx3iawgtrFw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="118956267" Received: from kinlongk-desk.amr.corp.intel.com (HELO [10.125.109.94]) ([10.125.109.94]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2025 09:51:30 -0800 Message-ID: Date: Tue, 4 Mar 2025 09:51:48 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 11/13] x86/mm: do targeted broadcast flushing from tlbbatch code To: Brendan Jackman , Borislav Petkov Cc: Rik van Riel , x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, mingo@kernel.org References: <20250226030129.530345-1-riel@surriel.com> <20250226030129.530345-12-riel@surriel.com> <20250303114618.GBZ8WWihMDjf-oy8P0@fat_crate.local> <7e1ca8c7-6f3e-44dc-9dd8-bd273a03a83e@intel.com> <20250304141134.GIZ8cKFom3W0ChHiXk@fat_crate.local> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1CAD8140006 X-Stat-Signature: f6ocbfci9r3neew93wsqffb4afkj5bui X-HE-Tag: 1741110717-632257 X-HE-Meta: U2FsdGVkX1+wSniEnklr9/AlEyMXHsCqrCa95berB0yRRU6B5HKS48ATM6M34SH9gWTDY6MkntxfGXdTcQTWmOXTvknHXWQvcikiOceblwytWD3g6R7GeQZCPhT588XIxLBWhFbo0jkoIPf9D2ir6+0a1qTlt3ZU3fEAMFipw1JcaJW19beELCYNnLfVjJVn/WWFWxWWjSN4OlXJ2Gal3OEwfLFGkq+KGHN2IQFV66vZOroomoedBWAjc0Ly20GJfhctEGuGsk3YXmvs2x7Hs6PFO6NwPSK0JAulGuwqQy5+mCi23Oe2693ERAn5Dt+3KKLJxAm648FGZIvCxSaIGCCqlrVMUy5gxsqhuGtaM7lBSRXgBugz09jwrV87sNl+X/f1X/IYhtMM9q6nY6Eo2JR7YAmNf/2VXEh7btEzyippvRhui0HiRuvDaHeoCvorCFl5RorEpv8Cekw8sfP8gh9AZnkAoMadtroFL7n3SFvjxBpwMenMAtf8tXuWhGwySXwK7MWvbuHZprKvpbcIJD2sLIHd+pVtvvC3aoqq8sm1zTqx1AAXrs00qy2+sy7n2ENWuVN2ctqP9SJfEybKBGoyVq154h0mRB98/eUSp+/7BGBTtHsMHr24RYt1BQjBHvjUNhg3ER7+l++gB5l8cWQ2cyfCAc42862m9Q08ZVINZYk7QfYvgaBilNB4xgtdDD1hKvaAYgbjHtUF8AHmRqclBVrxFwVnsmZP2SmLBtVONmIpiPNtAeHgX/NYX1y34fSwONMAQ/5bZksTXRUjMM2MYXm/cs5JilNpaEs/eoXxs3l3FFHvG33lAboyTc2vHKCMq/TjwVA5znl/eClh4kR0Ln4vXjj0dH5HdaPer/szw/YcT5vJroofR7yuYkyYG7Vf61s5MU04SVOu5fphEgnv3BCwPWGl0LH5I1wIYV7Ahgbrh1atxmAMehShxmnU2HZhB6Zlrxu+pG58voE X8u8OM8r cPBEf6DBC5j3A2O6nN0zzdEmRcQaYmmb/lX/hEskG413FHKPMQZKSJ0V2alKbxd8JJB3UsCVf12roqIq/N4dOg8dEF0GNMbDV4Cj9o3tSEnungm8TUSCLkNdl2s8HQkfqjAYtX5PB20B9+fBiJpMwh+9cgrjmOtENqhQc6UI6WVtk+lVNyoRALeeOpYzATA8wWeZPsGwzkkOliS7t6WwZeP00ocVz7eoRKKNonNF/VFBKpGHkw67FBo5rnmqjpYduI4UhkQdeRqQf6De8YsrJglj5Z1dUEiPuGLgO9nmvPcaEYOlDdqltHr9b90xdQR9f/5sw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/4/25 07:33, Brendan Jackman wrote: > On Tue, Mar 04, 2025 at 03:11:34PM +0100, Borislav Petkov wrote: >> On Tue, Mar 04, 2025 at 12:52:47PM +0000, Brendan Jackman wrote: >>> https://lore.kernel.org/all/CA+i-1C31TrceZiizC_tng_cc-zcvKsfXLAZD_XDftXnp9B2Tdw@mail.gmail.com/ >> >> Lemme try to understand what you're suggesting on that subthread: >> >>> static inline void arch_start_context_switch(struct task_struct *prev) >>> { >>> arch_paravirt_start_context_switch(prev); >>> tlb_start_context_switch(prev); >>> } >> >> This kinda makes sense to me... > > Yeah so basically my concern here is that we are doing something > that's about context switching, but we're doing it in mm-switching > code, entangling an assumption that "context_switch() must either call > this function or that function". Whereas if we just call it explicitly > from context_switch() it will be much clearer. I was coming to a similar conclusion. All of the nastiness here would come from an operation like: INVLPGB => get scheduled on another CPU TLBSYNC But there's no nastiness with: INVLPGB => switch to init_mm TLBSYNC at *all*. Because the TLBSYNC still works just fine. In fact, it *has* to work just fine because you can get an TLB flush IPI in that window already. >>> Now I think about it... if we always tlbsync() before a context switch, is the >>> cant_migrate() above actually required? I think with that, even if we migrated >>> in the middle of e.g. broadcast_kernel_range_flush(), we'd be fine? (At >>> least, from the specific perspective of the invplgb code, presumably having >>> preemption on there would break things horribly in other ways). >> >> I think we still need it because you need to TLBSYNC on the same CPU you've >> issued the INVLPGB and actually, you want all TLBs to have been synched >> system-wide. >> >> Or am I misunderstanding it? > > Er, I might be exposing my own ignorance here. I was thinking that you > always go through context_switch() before you get migrated, but I > might not understand hwo migration happens. Let's take a step back. Most of our IPI-based TLB flushes end up in this code: preempt_disable(); smp_call_function_many_cond(...); preempt_enable(); We don't have any fanciness around to keep the initiating thread on the same CPU or check for pending TLB flushes at context switch time or lazy tlb entry. We don't send asynchronous IPIs from the tlbbatch code and then check for completion at batch finish time. There's a lot of complexity to stuffing these TLB flushes into a microarchitectural buffer and making *sure* they are flushed out. INVLPGB is not free. It's not clear at all to me that doing loads of them in reclaim code is superior to doing loads of: inc_mm_tlb_gen(mm); cpumask_or(&batch->cpumask, &batch->cpumask, mm_cpumask(mm)); and then just zapping the whole TLB on the next context switch. I think we should defer this for now. Let's look at it again when there are some performance numbers to justify it.