From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B403C5AE59 for ; Wed, 28 May 2025 07:31:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C49C86B0089; Wed, 28 May 2025 03:31:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFA7E6B008A; Wed, 28 May 2025 03:31:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC2786B008C; Wed, 28 May 2025 03:31:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8D4FB6B0089 for ; Wed, 28 May 2025 03:31:16 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 37B3F14057B for ; Wed, 28 May 2025 07:31:16 +0000 (UTC) X-FDA: 83491495752.02.0D18FE0 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf17.hostedemail.com (Postfix) with ESMTP id 8C88B4000C for ; Wed, 28 May 2025 07:31:13 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="Q3/36YLo"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8GtYJkOY; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="Q3/36YLo"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8GtYJkOY; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748417474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3cLvsiR5HGJqXLAU8I0S9Yms2OS7UD/1yznj6XcMooQ=; b=CCZrKwrOBY9oQ/dcN8xEZbENJNkFENPlwOmul0g7itPc5ondphBQyKSV8cQ6r5YgM4691I /ngEKXc8z3Dqjx2pJrh2fHY8wgcmQh+6k2B0hQfT2ZaLj0+GCrZ7WU9QkM8EKHD7N9ioEA vecgtriC4/tJykOHtKkXzIGYDK6Long= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="Q3/36YLo"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8GtYJkOY; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="Q3/36YLo"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8GtYJkOY; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748417474; a=rsa-sha256; cv=none; b=imYEuSFhOd2f7GbfTiWLNidhQsgpeX16ssy5n8x8v7gOoZYw72M+SaEXFFGD0+NVvb3rmN rVheFt2hMRRTBKQUpuzqpOpRizuDmxFUDJoP+ljKyvy1Lz2feQoWMBeuIEfeYEmnL4KWps P9xyFNQxkpghIgMR6qB6vAPpWOY04pY= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7FE2D21BD7; Wed, 28 May 2025 07:31:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748417471; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3cLvsiR5HGJqXLAU8I0S9Yms2OS7UD/1yznj6XcMooQ=; b=Q3/36YLo82PZshOTF1jFfx5SGtO/T+YZyRTOrd/OtUQF+A30JTtTayHHIf09NHtvj1Mpew aU440zEP42bbdGdGdHSOIepfn/hPBaWafK46lth47Q9TYWsK1+bJj/CIPSaZimUW87nOUk yxtQmase0bFQTfPV6t9LHS+QNTjlarc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748417471; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3cLvsiR5HGJqXLAU8I0S9Yms2OS7UD/1yznj6XcMooQ=; b=8GtYJkOY6PSQRAY+v/vmltoXBVqg+gTfRtE9OcFh5thPho0Lq3wGfzcjQqDk8X5Fh++Df8 +/5Z/pDCGmHIXBBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748417471; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3cLvsiR5HGJqXLAU8I0S9Yms2OS7UD/1yznj6XcMooQ=; b=Q3/36YLo82PZshOTF1jFfx5SGtO/T+YZyRTOrd/OtUQF+A30JTtTayHHIf09NHtvj1Mpew aU440zEP42bbdGdGdHSOIepfn/hPBaWafK46lth47Q9TYWsK1+bJj/CIPSaZimUW87nOUk yxtQmase0bFQTfPV6t9LHS+QNTjlarc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748417471; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3cLvsiR5HGJqXLAU8I0S9Yms2OS7UD/1yznj6XcMooQ=; b=8GtYJkOY6PSQRAY+v/vmltoXBVqg+gTfRtE9OcFh5thPho0Lq3wGfzcjQqDk8X5Fh++Df8 +/5Z/pDCGmHIXBBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 54B92136E3; Wed, 28 May 2025 07:31:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id grFXFL+7NmhNRgAAD6G6ig (envelope-from ); Wed, 28 May 2025 07:31:11 +0000 Message-ID: Date: Wed, 28 May 2025 09:31:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6] mm: Add CONFIG_PAGE_BLOCK_ORDER to select page block order To: Juan Yescas , David Hildenbrand Cc: Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, tjmercier@google.com, isaacmanjarres@google.com, kaleshsingh@google.com, masahiroy@kernel.org, Minchan Kim References: <20250520225945.991229-1-jyescas@google.com> <28a2881d-fd33-44d9-a212-adeb8600e15b@redhat.com> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: mpmnb1ihrsr76sehnqibkzdx6gp77tip X-Rspamd-Queue-Id: 8C88B4000C X-Rspamd-Server: rspam11 X-HE-Tag: 1748417473-288665 X-HE-Meta: U2FsdGVkX18IwDGcJRuMnAtN/8QZ+tXlfa+naj7kYcdSbMWpWk48gArkFy97zq47+scB3JgmBrkGbq9ufqydDy0fkNEvBNnwXpma66kR/WSiRbBos+BBq6HALk/BX18jUD5Gl1aoZsi5E7AdheV4VM7KD879yx5D2PlSrMjdjjCAkuPVfroHPk0BVA2F+qq2vEqmfqRJ3KiwmOPaZFfJsVwkAm1G5oCKEaexVVXmVQabTO55Yx9WW6UE4c4cBf884WSw9oM0qq3dxX9jtwfqmhusmud4Od9Y9134UiI0dQiI08UhL51VU53PpYCJOKfptEsnJFrtfd2hV6/m7oPPkSQ4i0MOaqWAFqBdq+PzvlgMvC4iQwQTCktOizrtpUSwdMN+r0t1XVWuO6eBV9OqM8VXRzkM6re6RO2q3UZgtj4al0MlG8R7hGzsefUtKg3mZq1PWLV83Qt0CDmFx88XKoW3n8A2h/24yaaOHyzursTkNcOPyIMLicQ+NeYhezkAuhelOEoR9rFVeytva0cgbRyAFbRGSPd1rVRTwVahsO9erL4ncSrtC9yZvSY/sKBLdDQWo0JQtZJHi6KsCeQM4lWQ+vkFXZOiprCG+jjrdZOMfovmjIjAxDXiGBXQ55q30M8+8lpIb5fZghuxfmGrd7R/2FVodV2K3KMt0RpyQq06X/fW2zRffW8yz6keEi2mYKVOtPoNQCWIGDFySenwTNkUMetEU1nTkZw8LdpIBvtvnAsJhMQQdFXR6HJK9ShY/8ndli+mrZMkp5CP9L+xZo6cowJYImjTamtwka82fTpVvUWBzrnqPmbNQznfGt/qkHW+kmLj/t8hLd+C4ChKdHNRlZSKBdkc5XEVJw2Pw9rday6qs47UUlkpk/dvezqG+OVrvWL3wuie5lgOakjgcjBp4G3sSYGS7ioRY8oLCK57X0fVGMsfPTOs437xX3Ph8R4mDuqmwS/Aubfz9qF pJTRNIto iVzyZh6jQ8WWyfzmYZ6ExOqWExCD367oRRO6GWzeiap/rmN83LfKY1nwZerwQNNB6t9E9ZzDbt5/LXke0b3bYN6nATB8Qdl4d50nkR5N7dLsZ798uUfRIn+PgZ/2SJQaGayWZRGeYVPo+3D04yq4xfU7Yj9EjOIUKf+NkdEFtYkLF4fSIXzfRQF3a0OsJrNr3oVdlokF2vuFF1LNQwM8SK1xbWEO8OsXMkNK/Ou86GCy6GFr2N9FLUHsj0kcX5DuLCplJchxhVbMDYVNhnSzxnXIhB/d5vrxqN70/YBTHa2LpJFgfxcpL6H5AeAbtJShCcm+yQQl7UA+gJVpCHrV7IkQEdT+I0quXtt1u20uhgZKABVhwKD71hTtmXfr2jHRO4ZmDwKPKe3USUPTPHiYjUhsXug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/21/25 18:51, Juan Yescas wrote: > On Tue, May 20, 2025 at 11:47 PM David Hildenbrand wrote: >> > -#define pageblock_order MIN_T(unsigned int, HUGETLB_PAGE_ORDER, MAX_PAGE_ORDER) >> > +#define pageblock_order MIN_T(unsigned int, HUGETLB_PAGE_ORDER, PAGE_BLOCK_ORDER) >> > >> > #endif /* CONFIG_HUGETLB_PAGE_SIZE_VARIABLE */ >> > >> > #elif defined(CONFIG_TRANSPARENT_HUGEPAGE) >> > >> > -#define pageblock_order MIN_T(unsigned int, HPAGE_PMD_ORDER, MAX_PAGE_ORDER) >> > +#define pageblock_order MIN_T(unsigned int, HPAGE_PMD_ORDER, PAGE_BLOCK_ORDER) >> >> Wait, why are we using the MIN_T in that case? If someone requests 4 MiB, why would we reduce >> it to 2 MiB even though MAX_PAGE_ORDER allows for it? >> > I don't have the context for that change. I think Vlastimil might know > why it is needed: > > That change was introduced in this patch: > https://lore.kernel.org/all/20240426040258.AD47FC113CD@smtp.kernel.org/ Well the intention was always that pageblock order should be lowered to pmd order when THPs are enabled as then compaction/anti-fragmentation can better help them being successfully allocated. And when it turned out this was not true without having also CONFIG_HUGETLB_PAGE enabled, I considered it a bug. At the time there was not a proposal to make the pageblock order fully configurable, so it was just about having the best possible heuristic. Now we could let the new config override that, but since the main intention here is to make pageblock order smaller and not larger, it doesn't seem that urgent. But if we go that way we should make sure the defaults (user doesn't override MAX_PAGE_ORDER) still result in pageblock_order match PMD_ORDER with hugepages/THPs enabled, and not become accidentally larger. > Thanks > Juan > >> >> Maybe we really have to clean all that up first :/ >> >> -- >> Cheers, >> >> David / dhildenb >>