From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B5A5C02198 for ; Tue, 18 Feb 2025 11:45:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05E9A28011F; Tue, 18 Feb 2025 06:45:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 00E4028011A; Tue, 18 Feb 2025 06:45:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA35128011F; Tue, 18 Feb 2025 06:45:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AD10328011A for ; Tue, 18 Feb 2025 06:45:32 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5070580FB9 for ; Tue, 18 Feb 2025 11:45:32 +0000 (UTC) X-FDA: 83132885304.30.4B16951 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id D2937C000E for ; Tue, 18 Feb 2025 11:45:29 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O9Iszghl; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739879129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jHCRDL3N6ULifpYh9V9jXw9NcsVelDBQD1Fd1IVvKV4=; b=8nODH75xCsj0sRjGN0nwyetpanhehLKaEEsWwGkPb4yE9BO/yd18ihGa8WCAjBpE4220xW uKKPN3R1XatKOcVZdAhBNnWOyyfMEudH0aeQf3zKZnIXTA+xNSVBuHheFUgnwNcWPphJM1 iv24GhIltI2LS5yNO+wXJyLLhfDLVbQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O9Iszghl; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739879130; a=rsa-sha256; cv=none; b=LCcWZLATd13IRSM0s7QPTQp2nCTyI7gpvj5WrBHqhgsO5HTzbm/ZpP1J7/Grt0b0CtidRN E5ZBQ+ES3TcaV9NyYOfB8j3aAeaphlHg/8eeFgQB0pYjGNr3KLng0eOSehOZJhxxiqnoOi 3BemGuKhC21qEk1bdDC0LyYrxRPcDdM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739879129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jHCRDL3N6ULifpYh9V9jXw9NcsVelDBQD1Fd1IVvKV4=; b=O9IszghlZfbbanA/nMmowaAqwNRz+6dpiisLc0zx4UEqn3GQW+RzSi42DWrv+VP4I8plKC OHc4unscc/585MWqpxNmAo+c4xXJwY3Zev5VdG4UBJ0HWPae7ImQmXTQfCXHL1OGuBWgUx LWIRgUf5IfwjzlOWe550GA9NQo1WK34= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-163-NF9ReFn4NFm9b-eVFy3S5A-1; Tue, 18 Feb 2025 06:45:25 -0500 X-MC-Unique: NF9ReFn4NFm9b-eVFy3S5A-1 X-Mimecast-MFC-AGG-ID: NF9ReFn4NFm9b-eVFy3S5A_1739879125 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-38f2726c0faso4985679f8f.0 for ; Tue, 18 Feb 2025 03:45:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739879124; x=1740483924; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=jHCRDL3N6ULifpYh9V9jXw9NcsVelDBQD1Fd1IVvKV4=; b=UIwVN3rvGiYQ6Cw9XCyXJq+wsBleEkzQaFrTKTfhn+CTLogd1HO87NyEdvSLkPtAR0 n/o9OoNXMawem9TfmJag9vmEBC+DPeiFqAf2HVQSzQwL86LAg9wSyA4IivlWb34xlXn1 yyPM818QkOXy0Dx8CY6oVlCkN1/RANWrk/7jbszZMj21OrNeYUisc+MDvaLfaQlNRLj/ x5rk5iGYXKLRRfcgNsiLkYZe6ZYjtnbNyzrqxmHcVKbK6Gw3r1whlQmJZ/XdRJVz+oxJ 3SqjIK/xdMznc+3QgSX6Xf0v4fKuTtxQzDOXbvZgrXTR6yktWfAwM+iToO0TSabHnkyL 43Nw== X-Gm-Message-State: AOJu0YyzTDYMMvXWn53bQ3vsHKlAgwK0xlvrYQnXpnUd1dQTrYQclYWw 5gJpDVRhgfGjG58n7YOBQysK+y/qqlUgqZIUqKPhmvC7fki0C5RgQacHZHhwmCaMjcNun8IPNbN 3X2/+Vi4p13lW1tCRubs6BC56/nRkVVECrz/tNpt8YO2t+B9Q X-Gm-Gg: ASbGncsMB/Pcg6TiNLFndcCVg1TJ8bBEMlLLSYLQKd9TiOmbxxOzeSDjkBYiqD/fR3q kvvKPaUxLKyWlJRk6FPePzccL2Ve+oaWkIqxnAKc2hXby5Igl3Tmi3UGWqq56QXAaqT4NpX/yiQ YW+QrPAGaD1xb09hK5AdUb7ma93gy5HVvrtiQI9ObUU2Xckbfmvk/ZP7lKNKt0E0hsG6NREdBL/ 1uEkUFdLwlBH4qp4gxFL8wLrvLv2ffsHv2PgLjEVoK9w+0v/QWwv7WK8xG67TRQl3cltherEZRg 4S2ml/IEz2Cjs9wnJN1MRJrQy3WL/L70BxwgvRC+rwcrSD/7Gcrx1XaSfPIAfnsxnenk5lOua8a 4CSN85yA3ZERV1MRqqpbGz3IB0F5gYSsA X-Received: by 2002:a5d:64cc:0:b0:38f:4fcf:d295 with SMTP id ffacd0b85a97d-38f4fcfd742mr3662922f8f.29.1739879124699; Tue, 18 Feb 2025 03:45:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IEsFXXMwCROy1d+x8L7bQgHNOWiWB5gC6PdvAD/2PVCCKaRqrUGaEoHc5Js+VvCyBvaSCkafA== X-Received: by 2002:a5d:64cc:0:b0:38f:4fcf:d295 with SMTP id ffacd0b85a97d-38f4fcfd742mr3662893f8f.29.1739879124157; Tue, 18 Feb 2025 03:45:24 -0800 (PST) Received: from ?IPV6:2003:cb:c70d:fb00:d3ed:5f44:1b2d:12af? (p200300cbc70dfb00d3ed5f441b2d12af.dip0.t-ipconnect.de. [2003:cb:c70d:fb00:d3ed:5f44:1b2d:12af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4395cf084d5sm123622275e9.1.2025.02.18.03.45.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Feb 2025 03:45:23 -0800 (PST) Message-ID: Date: Tue, 18 Feb 2025 12:45:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3] mm/hugetlb: wait for hugetlb folios to be freed To: yangge1116@126.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, muchun.song@linux.dev, osalvador@suse.de, liuzixing@hygon.cn References: <1739878828-9960-1-git-send-email-yangge1116@126.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <1739878828-9960-1-git-send-email-yangge1116@126.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: C47QH1dTtBXHSCqdQ6cnXOHN8FHh3TH-r2hYGCr37B4_1739879125 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D2937C000E X-Stat-Signature: wt7u4jhcjeaaomdmqgnxubafiw81pety X-HE-Tag: 1739879129-861049 X-HE-Meta: U2FsdGVkX1+C3c+iN13oP1TJl3nr8L7Qfc4c18fhwiSdQLO0IOf2xXYBT7060C3aRiWlJsazaBle949iFHIZCjUknqXkQ46faEGqS0nUu8uORcm9lY/opCcsb5syU4OQWwLf+04JoekWUfhqOALds91tk/kgHtfwN+YuGFOQbdSAmjWPO0HTL0FlnX7FbYUECFM0NkjrW/rM53MyqzJ4SxND2YaINTBjYMIWY70mUTwbk7EImGcRe8QchIO5NZoVnL/6ny/OdEbbAP4LYrCYnoEwr5x6zBoIDCV76jjbYVCezxBeo2TxhodzfJIWwbEH3SpQKTUd/l1cWuebmXjpI3Anm6VYgZZRtgCH99roeGMV7I31icaqzAf3c68zKpq6vTJnoNEUEmR80y5rbekg25yfo8a6CJIJ7qHReNzp5JR0c7EpDlg34xQi/2TVK/TeVxJ4h6jEZJsEM8PZkscX1u2A9SB+ZL2+wFZKZwUs45FDOZOp6D7cGWsmw8ErYQrc4JF5Iek9SINjaMGQt/cGaVYjMMjNtflrHTUMWQuqPndiuvljP+qQch1d8KsRg02o00H9vToRDHAwhGH/a2c+ifwINMg2xm9ZkIDJtmLaxmHFxk57nmPEkrCRIE8BNer2NNrWMFkKBvDHMBULrkdW0fVYDAtR4ZRnHV/GxuSeQAvcqaLHKDWoIDwxEVgkhp4Wvdk4s8Ys+qnwCHakue1JB8VbQYfpcXQp2XSZYwlQ3O/SlrA5rrGB4YAyxu/evBY4fjI9m+QMU9/ULdhjr8lRMMKAcW4RiLylwt2CU+EJjZvDCBIfKOTi1O48kzC1V6lEpjS9Ay+XS5ITbL6JcJGGpH8sFbvTnXNXDsQXUZKJJIc/v1qDvApy2I1978osfB+2vE0b3bUdhhVyEpfUCcBTGteXI1Q7LaaprkM9Y8r+tdXBo3ooKXcm85L7Y2g0juldm6sqARXgwPyqw8/pxH7 M4/0UCLt UzqgGFHPKVbblIEZiAQd8wNWe/+Nw+OjWNaXa6L5ryuqomjL+gse71lzvTns2wCUWjaH37kZFXfm5vzFOkoQ/Nawk8j3jkEK2uxG3n5fey0nabIqLYEVrgEaLUZS/TReeITUaphD8mzOX9v4ViMm3gN+/JW/c1oS6l0DS/cw9ABQa8LUp+ZrdNXypAlIlxtDlR6nTxQqdKoYbAYWR7/09mLWZKXKSIQEHwjZtpk9J6XxW585JZV3w97Jg45baSC5+RU76hVC3VkYzmxdvHOChwCCxRSIJPkM1XMOy1fVS8t7KckAeKGjhvZ+9fjTHS3z4MSCIw1jHuYP3QSaPA8+4csOwPQj+1GyXzjgAuLFM+Awtnzv5CPPPAq2vEOR0oCUSx8sr4zCAtJIBRXdlVO+1zRXLIOCrcZOb7rTf182rYJSOWV+IS5nausvWTeK/9qBGic72x26yJxV/SMPCm/blLRa2qzEPg1sYtor9SCG2iWdMla6ogRUwoEi3Ew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000274, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.02.25 12:40, yangge1116@126.com wrote: > From: Ge Yang > > Since the introduction of commit c77c0a8ac4c52 ("mm/hugetlb: defer freeing > of huge pages if in non-task context"), which supports deferring the > freeing of hugetlb pages, the allocation of contiguous memory through > cma_alloc() may fail probabilistically. > > In the CMA allocation process, if it is found that the CMA area is occupied > by in-use hugetlb folios, these in-use hugetlb folios need to be migrated > to another location. When there are no available hugetlb folios in the > free hugetlb pool during the migration of in-use hugetlb folios, new folios > are allocated from the buddy system. A temporary state is set on the newly > allocated folio. Upon completion of the hugetlb folio migration, the > temporary state is transferred from the new folios to the old folios. > Normally, when the old folios with the temporary state are freed, it is > directly released back to the buddy system. However, due to the deferred > freeing of hugetlb pages, the PageBuddy() check fails, ultimately leading > to the failure of cma_alloc(). > > Here is a simplified call trace illustrating the process: > cma_alloc() > ->__alloc_contig_migrate_range() // Migrate in-use hugetlb folios > ->unmap_and_move_huge_page() > ->folio_putback_hugetlb() // Free old folios > ->test_pages_isolated() > ->__test_page_isolated_in_pageblock() > ->PageBuddy(page) // Check if the page is in buddy > > To resolve this issue, we have implemented a function named > wait_for_freed_hugetlb_folios(). This function ensures that the hugetlb > folios are properly released back to the buddy system after their migration > is completed. By invoking wait_for_freed_hugetlb_folios() before calling > PageBuddy(), we ensure that PageBuddy() will succeed. > > Fixes: c77c0a8ac4c52 ("mm/hugetlb: defer freeing of huge pages if in non-task context") > Signed-off-by: Ge Yang > Cc: Acked-by: David Hildenbrand > > +void wait_for_freed_hugetlb_folios(void) > +{ > + flush_work(&free_hpage_work); BTW, I was wondering if we could optimize out some calls here by sensing if there is actually work. In most cases, we'll never ever have to actually wait here, especially on systems without any configured hugetlb pages etc ... It's rather a corner case that we have to wait here on most systems. -- Cheers, David / dhildenb