From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09AABC83F22 for ; Wed, 16 Jul 2025 13:41:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E76B6B00A6; Wed, 16 Jul 2025 09:41:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BF026B00B0; Wed, 16 Jul 2025 09:41:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D4EF6B00B1; Wed, 16 Jul 2025 09:41:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6E02B6B00A6 for ; Wed, 16 Jul 2025 09:41:33 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1578A12DC91 for ; Wed, 16 Jul 2025 13:41:33 +0000 (UTC) X-FDA: 83670240066.16.04AAB15 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 5E422A0026 for ; Wed, 16 Jul 2025 13:41:27 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O7MUohVV; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752673290; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DSCVr707M4//bs71t2yhWnQaxP7JI/FIas88eCQrl50=; b=fYYBRpydFkFJNcKD7F7cYEBicsmx1zawP5N7Yopvf8dsO8brcEw6mdSELHwE6SzC+hZQew vCRNCLLZ/24Xp15vPkPAAjntevjQRTIaPSKAbvTNUfptwvdVB9E9ejvivC5F4oT9pzfXoC GwubuJAmRm1RVGyl1dr7r5p13OFxEX4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O7MUohVV; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752673290; a=rsa-sha256; cv=none; b=BimINimge54fHVKnpo78jEafMtvznWmTCj/MvyJgH+LHZmFKxI11HNaEcJMVMbKDkbLSw4 tRT/IZBohZoQMZJVKNy2MMAdtHWBBCefD9/7pNE7i+wbvbN/5xEZnz6ocx23SC9NT1AKzu 9ScGToJm5UusC/gltHnkdSabsibHBMQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752673286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DSCVr707M4//bs71t2yhWnQaxP7JI/FIas88eCQrl50=; b=O7MUohVVrBNBH+aMchJInua/JlKAM+rY7SNHST/p9e6v3BklfUAMaHa+wNtqUbfI5XU4eU /1JIrKLBj4NHFySsCyjutz3Tra1Evj06LgeIsPYw8rV4PjhIhv4rP7skmuUJoFxOvcH7n0 0eTjTTIv5aho57LTFl3ZAPynoBLLZFQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-7akK69GMN8C78PxccKAp9A-1; Wed, 16 Jul 2025 09:41:23 -0400 X-MC-Unique: 7akK69GMN8C78PxccKAp9A-1 X-Mimecast-MFC-AGG-ID: 7akK69GMN8C78PxccKAp9A_1752673282 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-455e918d690so5860955e9.1 for ; Wed, 16 Jul 2025 06:41:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752673282; x=1753278082; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=DSCVr707M4//bs71t2yhWnQaxP7JI/FIas88eCQrl50=; b=oarRHHuqo0wz3XdAAmUql7J4RVnuhJoJGdYG3f9chY2rI8lBYIHFytehk6Y2GqOEBh Np+78/YeICIod0O3Qa1s3ir9191YleR5YGfSzwvwviD4pvbtdxR767QFbwkJqFxIF6Ep VoeXifFkVsPhHMB6fxtB0CN2Z7Ehngo5JtbVjd2EJQ9/1CoHFIUvoXYq83Gxmrwdc2Wo tUrvNm4siJWsxHYjPfCziRE8Wjnmsrypj92AJJOZ5DwIg205+x/Sb51b1l+BKwOo7jdb h5B8lCXII4vDRlkHfr4sqSg/8sMNI84dAEtd0DFlmUWXLHbOEHZmq8abi8HUKcJNTljn tqTA== X-Forwarded-Encrypted: i=1; AJvYcCUEAYjpCIFtMHC3Cr5peiz4KORHcg1zCNmPvtE6urRrSaDlRvgs7CYyYIyQYZNoouazyYDJEEXzFg==@kvack.org X-Gm-Message-State: AOJu0YyYiiCVMBEv2CTpxPnz01GK1S69prnwIpfaJHUuOK8zMpd/ak6a wIfBDh9M239JLBZ7N7qElBqHfw6IL/QJW+a0juzyhF3u7ZVlF14NJe9e9TnP56F5K5BouLPc19x 0HCG9Xih2i9jqEu0l0reShj1t6WDa+ANALL7mJGoQY+c2F/nT8msw X-Gm-Gg: ASbGncv2cn8UgKTPeRs68n4bmOE+H9o5G0nONVHWRWGICHTFS8Tqu/kdPRyTeXwGaFy KTp/Q3cwTyJxV0IOS/nYf/zeAvzh+/WBDto7Fn7DLKPVJtaPER7+IEz917luJk5WAGg6LYhMHFk ZalOA5jQZn/pmdBVDTZWOGlwV3Tzm8W53ExlaO6Igld+8TwvryXViXxxuE/UAuzGBV6iuFJHRtA 2GiPhJDixMIqyKMnoXAEa4dwtNeUo1PN/Ldr6KnrwNzKd/30YmykLmGSnXEIhGbcQ4v0UWqxbpN RYvpFhjwjLUnvXoxdvRPU5l+n1z/fkcXQ19aCS4JUW8vSThYz/xLFHPJhxjcl+3FX5mfDtGRnbE RUQAvX8snNoGmWf5/UiepSYn8SewEka2btY+H+GDlWuxSVgXDeGTaK4cJLGYWHoTFDIU= X-Received: by 2002:a05:600c:548c:b0:456:22f8:3aa1 with SMTP id 5b1f17b1804b1-45625e124d7mr69996945e9.2.1752673282197; Wed, 16 Jul 2025 06:41:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHJRzt4ZrxBpUrSXpkAxQ6hUJtt2LBR2xIpZnBXJ0UGI0iPwXmQCb3pqZ+bPkU+QpfZagZCZQ== X-Received: by 2002:a05:600c:548c:b0:456:22f8:3aa1 with SMTP id 5b1f17b1804b1-45625e124d7mr69996615e9.2.1752673281743; Wed, 16 Jul 2025 06:41:21 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1d:ed00:1769:dd7c:7208:eb33? (p200300d82f1ded001769dd7c7208eb33.dip0.t-ipconnect.de. [2003:d8:2f1d:ed00:1769:dd7c:7208:eb33]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4562e81a6f1sm21719265e9.21.2025.07.16.06.41.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jul 2025 06:41:21 -0700 (PDT) Message-ID: Date: Wed, 16 Jul 2025 15:41:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] mm/mseal: rework mseal apply logic To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jeff Xu References: <1d6abf27d8eac0001f8ad47b13f0084ceaa6657b.1752586090.git.lorenzo.stoakes@oracle.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <1d6abf27d8eac0001f8ad47b13f0084ceaa6657b.1752586090.git.lorenzo.stoakes@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: A_N4qRN0F-yKtXSLSdO18D8GBCoyAbJlXvP8WGqfcRA_1752673282 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: prcfiwk871iyua37z5aapaptgecsqmbi X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5E422A0026 X-Rspam-User: X-HE-Tag: 1752673287-525166 X-HE-Meta: U2FsdGVkX18sCw07f+N2mx8cj/Uq8PwdVzMMsHCHUuL5lJueBo48khM8w1PZyyXQRC5J+Ff3fEZMv6w731m/xEufvXXzP1BYHkQNn9I6leHVkaiWCjIi6okpN+EtOZDqpYkdQO2xiWk7nzp9GWjJZnKpTOPP6++bK0nNlOwrqqaYFiJIcMa2e6EhMKRAXmj7PX7TZzxndffEE2bq9T9x5Psy2MbWz2Bg40p60YU3HXja3ttfP/24xqxQ+1XxRPTZtfFPI/Vx9y4fZ1/KOsitdkDNl4VOPuoOXXJPmuz0OqPf9Pt6CUqeJiFiPnodg8VzofzcNioUk/kpko/yRWW/Pt/EAFKUQkWqW8wekguthLQIMOLesbJNWZfnJb0O4wvEfF+Tru69XDA6X4gN5sRifDs04xwJAW2mDxDv7eJ9xl1G9hR7qOWh0QMJzw4+4UnLQ7jtU1N7dspio/K+HrAA8m2bu8b7wTXU+Xasc9JzVmRw0hZu272IuXzAICSHAHg+SVf34z+aDDZ6W1dl44xTbiY7OSe07ammgxmg4mTxP+ALs5jwfC95n/2ouwjrcP8teK6RmsziQ2xsM3YUJR27k8YxbJvQbBxWT/EVu1j+3h798ZZOsYMQUCP/h5cHzDNQg3VR1FpBZQMEiTT0IWcpNdXJbxsR6F0C8QeAeo2OpGWtJpJ0usXHSWEPilyaCyBhCFS6gfZOr2Ah2os/SUM8g5MnSJqWauxmd352SGrw/oFkrltiLu2JhyGsqJHh8P4NoltOtdRRCkcg6uqABseoVvpxIg3qzp8vIC68+DAIguBP+mqt5+/xDLYKmJTf9C4+P7TkqkwqrLvRFczrMoQRWzaQ5xxE1SPWaG9R7A5OXbYtt2iI81kAUtc01J/O0nLBh0Bb53SDEz3xJB3E6kHhnvuaBKteKpeNeF2NtiaeOno/EC7VZD0clOz1nfD9bQLPxzkSCbfaY2wUB9+O/yP sK/KcCug qVju9RdRmigEFBooieNT07IRP1WnsRXQffivPbb82nfe5k6VoX/KthSf2ikWi3dB4WbdkYBNgixlAeJNKWlyNkkH/JjCyntmZvN1IydI0BEoIDeZBwNjVyYiQpXqA1tF+LyTOJPH0IqYz5XjX+RFibJmmakDQq6BOVY5xdjHYdygjnPC2wP/0W7m45XMoQM4c5GTEUsQxaojT2OQlydgiNPjY95b8Tn4D30pGvIIgZ3Ki3S2/b8Y9J3ncCDYcomuw8auLEcO5s2c+YIpqWG0eE0mrK/3dcYe+HdSmddNNhc4lUc7DtaNRBYgW5AGFoZv+/xm8xpA9XA+oyJl1MTRrAmA9pBB8IC30h4yhptNcmZZgO5dLxwnNYsqJl6JIWJWersxPDdsBLMkbdLF3tSbwln1pTQTZ5HTlbi3tSwDrv0jBJrZ0WylxjYoATmUnwOC9CPYsCpsE0FURNeM6iAyR8AztN1LJAW5imUVQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.07.25 15:37, Lorenzo Stoakes wrote: > The logic can be simplified - firstly by renaming the inconsistently named > apply_mm_seal() to mseal_apply(). > > We then wrap mseal_fixup() into the main loop as the logic is simple enough > to not require it, equally it isn't a hugely pleasant pattern in mprotect() > etc. so it's not something we want to perpetuate. > > We remove some redundant comments, and then avoid the entirely unnecessary > and slightly bizarre invocation of vma_iter_end() on each loop - really > what we want, given we have asserted there are no gaps in the range - is to > handle start, end being offset into a VMAs. This is easily handled with > MIN()/MAX(). > > There's no need to have an 'out' label block since on vma_modify_flags() > error we abort anyway. > > And by refactoring like this we avoid the rather horrid 'pass pointer to > prev around' pattern used in mprotect() et al. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes > Reviewed-by: Pedro Falcato > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb