From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B31D1C00140 for ; Wed, 24 Aug 2022 12:07:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34740940008; Wed, 24 Aug 2022 08:07:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D0C1940007; Wed, 24 Aug 2022 08:07:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17150940008; Wed, 24 Aug 2022 08:07:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F3D70940007 for ; Wed, 24 Aug 2022 08:07:23 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C19B7160C1C for ; Wed, 24 Aug 2022 12:07:23 +0000 (UTC) X-FDA: 79834361166.28.D5EE32D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 5E2B42003D for ; Wed, 24 Aug 2022 12:07:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661342842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GxnRXP3RguFvbPSiu8OUfcU51eWu1AtG0yKdh8CNvVg=; b=DnPGea1mnTlYHZQzzWkbGqmECcpdSnKks8rAenfjWy+XdqyMHEmqFgystguehfrJWBcjZZ jLQ/Vh1BslTDRoOU5aJvOPZRk9gxJa4BkqfBD7xqel3AL9+dsCVJz9L265vPL/7WZ0WFy4 imN6CiElVXZe6QIgvd1I55AcJ3iLdjE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-164-JVMOuKc2NYy_ALA4Kvi7vg-1; Wed, 24 Aug 2022 08:07:19 -0400 X-MC-Unique: JVMOuKc2NYy_ALA4Kvi7vg-1 Received: by mail-wm1-f72.google.com with SMTP id i132-20020a1c3b8a000000b003a537064611so9318857wma.4 for ; Wed, 24 Aug 2022 05:07:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=GxnRXP3RguFvbPSiu8OUfcU51eWu1AtG0yKdh8CNvVg=; b=oS5ja8sXCRRiCwL7eaOCQ+kfGHOfpr3QdauY/ZqPQ4MhRmEBsrSYDRI0eF8NItwW2z w6PzgcPi0vrx2x5wzgbtGxoiadgOX1uJAEXIZJKDu2331QrDqhUZzRwbnqy3D/wIb11v FT+5Suki/S0YngqQUkdz0VXqgCxY++gT1OlAzfJYBBy0nekklQXuz7wYPHJvnijaWVU/ tMDHTtAVWmqdLdOF2sooUMwHmpGeG2veeT15anVOlZd69IIsWawyrPhkTiFYqUtcQAg5 vhe0/o+oT2h6nLrJQc4q/3eGfQgxfrXZvDDwcOsrdpYK6knm2jfO+5fRWOOmY3yiTHrL oa/g== X-Gm-Message-State: ACgBeo2vnTEsuCgXILrlKpvbgD9Uf/Mz33uwDzvSQz5MiN1ApBnFRlCd aWPzawH3E3tOtpbs0WrNkL6k24OGy7/ViMeMM8ekH2hYe18JuGl9OEWggJ7gxhD0t3WGOIsnyJo aFU/pm+PmWk4= X-Received: by 2002:a05:600c:224c:b0:3a6:7234:551 with SMTP id a12-20020a05600c224c00b003a672340551mr5067901wmm.27.1661342838314; Wed, 24 Aug 2022 05:07:18 -0700 (PDT) X-Google-Smtp-Source: AA6agR639hMzp6ZFXLyIqU69ORi9tC0j+TlDvshm0qaW3e26apU9cKbC2QDY6Xwk9ygijRceU7J8yw== X-Received: by 2002:a05:600c:224c:b0:3a6:7234:551 with SMTP id a12-20020a05600c224c00b003a672340551mr5067876wmm.27.1661342837939; Wed, 24 Aug 2022 05:07:17 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:c500:5445:cf40:2e32:6e73? (p200300cbc707c5005445cf402e326e73.dip0.t-ipconnect.de. [2003:cb:c707:c500:5445:cf40:2e32:6e73]) by smtp.gmail.com with ESMTPSA id h21-20020a05600c351500b003a60ff7c082sm1792432wmq.15.2022.08.24.05.07.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Aug 2022 05:07:17 -0700 (PDT) Message-ID: Date: Wed, 24 Aug 2022 14:07:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [RFC] s390: kernel BUG at include/linux/mm.h:1529! To: Brian Foster , linux-s390@vger.kernel.org Cc: linux-mm@kvack.org, Jason Gunthorpe , Gerald Schaefer References: From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661342843; a=rsa-sha256; cv=none; b=UPrWliUGojy/w49Ngfk8qJrbye2kGVMTrJRqNIZDGlKaMsy+gBbd/vWWjKupxOFlbxOtmQ mwZlKjOu9hKjMygpZiLeSdntWFxQncFsK0pWGaHWGAD1XKWcktjSTwZjhijLoCbGejn/wW eU4y11+7uGmxS5pOJhQy/r3qgXPsbVU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DnPGea1m; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661342843; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GxnRXP3RguFvbPSiu8OUfcU51eWu1AtG0yKdh8CNvVg=; b=gh1ooy2rKvJd0mHl3uIHIoE9VAhT1YE8pVQS2HH9dMbz9XbKiV5mrPySEbEhS1VKILcm20 YCJKDGgMtPaH7vzgMr9pQPCG+VicYHdDIInYPfUgMb0m26k+7q2t6P4GTjm51JmqbWYQ0x jGI/D6kaGqLa7eVLq229VXxGslUt4+g= X-Rspam-User: X-Stat-Signature: 1m4f4zuah3nftozuge9zt1b8njompcnu X-Rspamd-Queue-Id: 5E2B42003D Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DnPGea1m; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam01 X-HE-Tag: 1661342843-534709 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.08.22 14:03, Brian Foster wrote: > Hi all, > > When running a fuzzer workload to test an unrelated patch[1], I've been > reproducing the VM_BUG_ON() splat below[2] on s390x. I've narrowed the > problem down to a deterministic reproducer. The code for that is also > appended below[3]. > > The splat occurs because during fork() we end up down in > copy_present_pte() -> page_try_dup_anon_rmap() -> > page_needs_cow_for_dma() for a !is_cow mapping, so copy_page_range() > didn't acquire the ->write_protect_seq seqlock as expected. After > digging into this a bit, I _think_ this boils down to a bug in the s390 > arch fault code dealing with a write fault to a !VM_WRITE mapping.. > > The sequence of events implemented by the reproducer that leads to this: > > 1. Create a shmem segment and attach it SHM_RDONLY. This causes > do_mmap() to set up a !VM_WRITE mapping, but also clear > (VM_MAYWRITE|VM_SHARED) on the mapping because the backing shmem file is > read-only. > > 2. Take a write fault on the mapping in kernel mode (via getrlimit() in > this case). The write fault ultimately causes getrlimit() to fail with a > bad access error, but not before the generic fault code creates an > anon_vma mapping for the page. > > This occurs because first do_dat_exception() calls handle_mm_fault() > with FAULT_FLAG_WRITE via the following logic: > > access = VM_ACCESS_FLAGS; > ... > if (access == VM_WRITE || is_write) > flags |= FAULT_FLAG_WRITE; > ... > if (unlikely(!(vma->vm_flags & access))) > goto out_up; > ... > fault = handle_mm_fault(...); > > So the FAULT_FLAG_WRITE fault proceeds because is_write is true and > ->vm_flags has read or exec permission (but not VM_WRITE). This > eventually gets down into do_cow_fault() -> finish_fault() -> > do_set_pte(), the latter of which calls page_add_new_anon_rmap() because > this is a write fault to a !shared mapping. > > Note this is immediately followed by a do_protection_exception() that > uses access = VM_WRITE and thus fails the above check and returns with > VM_FAULT_BADACCESS. So I think this ultimately DTRT wrt to failing the > syscall to userspace, but the do_dat_exception() handling sets up an > unexpected situation for fork().. > > 3. fork() -> dup_mm() comes across this mapping with ->anon_vma set (so > vma_needs_copy() returns true), but is_cow_mapping() returns false > because VM_MAYWRITE is cleared. From there we fall down into the page > table copying path described by the BUG splat. > > This problem doesn't occur on x86 seemingly because we don't call into > handle_mm_fault() for a write fault to a !VM_WRITE mapping, which is > specifically checked in access_error(). Therefore, something like the > patch below[4] seems to prevent the problem on s390. However, the access > checking logic looks wonky enough to me that I wonder whether it > warrants a closer look from s390 experts. For example, does this code > need to care about any flags/context beyond write or read faults vs. > write or !write mappings? I don't have enough context to reason about > it. Could somebody more familiar with these two s390 exception variants > chime in? > > Finally, note that so far I've only really tested the patch against the > reproducer. I'm happy to try and form it into a proper patch and test > further after some feedback... thanks. > > Brian > > [1] https://lore.kernel.org/linux-s390/20220816155407.537372-1-bfoster@redhat.com > [2] BUG splat: > > kernel BUG at include/linux/mm.h:1529! > monitor event: 0040 ilc:2 [#1] SMP > Modules linked in: rfkill sunrpc ghash_s390 prng xts aes_s390 des_s390 libdes sha3_512_s390 sha3_256_s390 vfio_ccw sha512_s390 mdev vfio_iommu_type1 vfio xfs libcrc32c virtio_blk virtio_net net_failover failover dm_mirror dm_region_hash dm_log dm_mod pkey zcrypt > CPU: 1 PID: 1401 Comm: shmem-fork-test Not tainted 6.0.0-rc2+ #20 > Hardware name: IBM 8561 LT1 400 (KVM/Linux) > Krnl PSW : 0704c00180000000 0000000014928240 (copy_pte_range+0xa40/0xe58) > R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:3 CC:0 PM:0 RI:0 EA:3 > Krnl GPRS: 000003ff85b80000 000000000000000c 0000000000000000 000003ff85b80000 > 0000000091c5f31f 0000000087d70640 000000008160e800 00000372024717c0 > 000003ff85b80000 0000000000000000 00000000831c9c00 0000000091c5f31f > 00000000823ada00 0000000087d70640 00000000149279c2 0000038000773880 > Krnl Code: 0000000014928232: c0e5fffff48f brasl %r14,0000000014926b50 > 0000000014928238: a7f4fd43 brc 15,0000000014927cbe > #000000001492823c: af000000 mc 0,0 > >0000000014928240: b904005b lgr %r5,%r11 > 0000000014928244: a7f4ffde brc 15,0000000014928200 > 0000000014928248: e310f0e80004 lg %r1,232(%r15) > 000000001492824e: a7f4ff17 brc 15,000000001492807c > 0000000014928252: ec3800091c7c cgij %r3,28,8,0000000014928264 > Call Trace: > [<0000000014928240>] copy_pte_range+0xa40/0xe58 > ([<00000000149279c2>] copy_pte_range+0x1c2/0xe58) > [<000000001492e258>] copy_page_range+0x510/0x770 > [<00000000146f3896>] dup_mmap+0x47e/0x6c0 > [<00000000146f3b52>] dup_mm+0x7a/0x278 > [<00000000146f5a48>] copy_process+0x1298/0x1a48 > [<00000000146f62fe>] kernel_clone+0x5e/0x3c0 > [<00000000146f6742>] __do_sys_clone+0x5a/0x68 > [<00000000146f67e0>] __s390x_sys_clone+0x40/0x50 > [<0000000014f68dac>] __do_syscall+0x1d4/0x200 > [<0000000014f78c22>] system_call+0x82/0xb0 > Last Breaking-Event-Address: > [<0000000014927a46>] copy_pte_range+0x246/0xe58 > Kernel panic - not syncing: Fatal exception: panic_on_oops > > [3] minimal reproducer: > > #include > #include > #include > > int main() > { > int id; > void *p; > > id = shmget(IPC_PRIVATE, 4096, IPC_CREAT); > p = shmat(id, NULL, SHM_RDONLY); > getrlimit(RLIMIT_AS, p); > fork(); > return 0; > } > > [4] RFC patch: > > diff --git a/arch/s390/mm/fault.c b/arch/s390/mm/fault.c > index 13449941516c..c12722da1558 100644 > --- a/arch/s390/mm/fault.c > +++ b/arch/s390/mm/fault.c > @@ -418,6 +418,8 @@ static inline vm_fault_t do_exception(struct pt_regs *regs, int access) > fault = VM_FAULT_BADACCESS; > if (unlikely(!(vma->vm_flags & access))) > goto out_up; > + if ((flags & FAULT_FLAG_WRITE) && !(vma->vm_flags & VM_WRITE)) > + goto out_up; > > if (is_vm_hugetlb_page(vma)) > address &= HPAGE_MASK; > Heh, we might have identified this independently just recently: https://lore.kernel.org/all/20220816113359.33843f54@thinkpad/T/#u Can you take a look if that proposed small change also fixes the issue? -- Thanks, David / dhildenb