From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96E3DC83F01 for ; Thu, 31 Aug 2023 15:28:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 217EC900004; Thu, 31 Aug 2023 11:28:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C8368D0001; Thu, 31 Aug 2023 11:28:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B743900004; Thu, 31 Aug 2023 11:28:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EF2F48D0001 for ; Thu, 31 Aug 2023 11:28:10 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9C2FEA031B for ; Thu, 31 Aug 2023 15:28:10 +0000 (UTC) X-FDA: 81184780740.15.485B76E Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf27.hostedemail.com (Postfix) with ESMTP id C76C04000E for ; Thu, 31 Aug 2023 15:28:08 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf27.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693495689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B5DibzGdYsPExRJnNalRLjhKX/eiS3PoCIsrjNoiGAo=; b=p/gIKEg6mDrJ/cB6vwiPse1e5Z2OlPLLWU98HiAPv5zvUJEMbQEiwquqt4yN1+QelL3M6M zTSXiHVETRgqaZqoCJ4hTXchShHgkoe6zr6baAP3kvzI6877AsttR/b1sMCwLvVTJwkYui mxK5/nY7wFFd2PhYFRBao1snDiWbz5s= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf27.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693495689; a=rsa-sha256; cv=none; b=XSxP1GoK7y0m10K1VraSsiVHqkl0ZjyUAT4eWAIKkQQ2obr1iRQ6sTgSiTzFjBZcKIMmca 84+y6XwCPYJ7i5q68CwJ4oU7XJ6x9msXvqeEeHkncvoqqEryvkwnKjdAHM7pxvjxwUikqx Ggb7S/m+mD89/OryTH4G4ahVQYoZdUI= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2FC93C15; Thu, 31 Aug 2023 08:28:47 -0700 (PDT) Received: from [10.1.32.135] (XHFQ2J9959.cambridge.arm.com [10.1.32.135]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7933C3F64C; Thu, 31 Aug 2023 08:28:07 -0700 (PDT) Message-ID: Date: Thu, 31 Aug 2023 16:28:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 10/14] mm: Allow non-hugetlb large folios to be batch processed Content-Language: en-GB To: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org References: <20230825135918.4164671-1-willy@infradead.org> <20230825135918.4164671-11-willy@infradead.org> From: Ryan Roberts In-Reply-To: <20230825135918.4164671-11-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C76C04000E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: hj41yun1yjp1u5ecu9znx71kmhcz3mjx X-HE-Tag: 1693495688-243852 X-HE-Meta: U2FsdGVkX192Edm5xqf7KWT0Zg2vrXi+S1SdFpG7HBCOe+YqBPkL0UHm+o38IqDS2PouevEicL+8CBUjuZHrbtJt7l51qoiZN7bJyyyD4XCNneROOU7HwbtyqL3YZt9SXHYl8S22QZwQ58HsDrywr5Yw75KI69mDHaCZA0eqZjhpvnf4nYk7zlDqg329JeGNItXWg+OqYccrhsNwl8sehvLumNG10a/jh4L3xLmlGWet/SYLH/zA5SuXtFEhpynKF+kP8KaadLZcqYfIzW/xp3PL5ulXDCsyDrEl/35f98WwS0pVJ61wBgD9Jb1EOdut/7Yy0OI3u+vZ8UWHxbqMdeBlVoSGbTTBihyCx19lm87ie2ymwe5xkeZetKwe6kThionk36c5z72u7aNaek/eNs4Ehje62gCFi969ybjfQLK4oNO92tXLMRUY5iYVfwgJ69sb0IAuM7Smg7SnnMML5RPaFlTOxozPeu6xCIC7c8LUD1xtnY+73efPZh2qmmlyOk1WFFMquhYeBO7/ZwPmQcXiCNHQ+TTZwx+lm3XMY2N0QjbFveIkgon6euib81QMzM5xp2VrcCWY6uN78RkJDmoNPK8V79hN0ZTVabNmpMaZmnnPhyxOaW2YFKCy93vBHuxqmNj4lFjmCJLV+6rAwsVil3QBG3C2ocuMjwF9b7MWnlTwtbmPzySgm3LTxfvyy3rJkrOVHlYN2/6GXsznWc/cCDDAyrwBtogmysbuKcZ4Y3h6JMBW3LHwPMV2j07qn+TbwnVNvp5Ne7ETraY1cZtoKocAox5LvwGzSRdkrHcVkNsqiQCNcYsS57qPP13EV8p49vcQJntSPHrgJTLPz1Cd5l4BWeJ1le788DNypsVq9lq1GLf7EOxMM2MYMW0vRfcEvQpdxzysx/hIqlKJwvRZFY4mhp9X7Qzi+inTwJ2g3KMHhqWE4qwElyWYB792SRGZSVC+bG7KUdioDN6 yE4ikgKk Q6TYxZ79wRBZe1ZaK6xJ9EmSxIaBTa6femh5FIOBePYclSlJbevvSZ5vXnjsRcdObioYLdWv/pG7HxItkSYUTpKHOuDR0/BRnbrg0yunyFxSHmCiWdmqSv25ju/N5Gwte4hdYfHVlf81L8ekqdn3WMKOTMxzOmX0Qq58cdPQkoWopPtREtbhAk4EL3/yTcJQ11Ys0GFUhMz0VifF0IvghxhyLmOS7UGWoOigHELfZPLY2N3WNDTPBTcYMoq76Iw61Cv2v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25/08/2023 14:59, Matthew Wilcox (Oracle) wrote: > Hugetlb folios still get special treatment, but normal large folios > can now be freed by free_unref_folios(). This should have a reasonable > performance impact, TBD. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Ryan Roberts > --- > mm/swap.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/swap.c b/mm/swap.c > index 21c2df0f7928..8bd15402cd8f 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -1000,12 +1000,13 @@ void folios_put(struct folio_batch *folios) > if (!folio_put_testzero(folio)) > continue; > > - if (folio_test_large(folio)) { > + /* hugetlb has its own memcg */ > + if (folio_test_hugetlb(folio)) { Ahh I see, you special case hugetlb here. You can disregard my comment about hugetlb in the previous patch. > if (lruvec) { > unlock_page_lruvec_irqrestore(lruvec, flags); > lruvec = NULL; > } > - __folio_put_large(folio); > + free_huge_folio(folio); > continue; > } >