From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EAC6E77180 for ; Mon, 9 Dec 2024 14:22:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A74978D0069; Mon, 9 Dec 2024 09:22:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A25418D0058; Mon, 9 Dec 2024 09:22:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C56B8D0069; Mon, 9 Dec 2024 09:22:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6F8118D0058 for ; Mon, 9 Dec 2024 09:22:54 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A6F6841375 for ; Mon, 9 Dec 2024 14:22:39 +0000 (UTC) X-FDA: 82875635556.27.2E68E62 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 5D44BC001E for ; Mon, 9 Dec 2024 14:22:13 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VUGQkSPA; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733754148; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mrc3k+K/yTD9d27E3LfzBWeCtSATx6WkPMaFyVBe5Dk=; b=ZYrUVHF2xkRdlYz0q7yhVlVYkaCfT3b5d6HC2UrOcYPWh8pg0c+pJ6qZFpWh6KlIZvkfKT CBGb1tVin1DwzCaebL5mYouWHNEzqim8HLMgexjaZWWld1DJD0SVx3m9YN3OwVlzw077qo m05vk5HxSKQraUicheLs+9idCjbGOKE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733754148; a=rsa-sha256; cv=none; b=iGFr70IsOxOniXEoQOyb4h0r5GyemnrEUBdELHyufxzvtP5a68ww6byLszOGkUMLZt21sv JyPwBSyGLaegSIWFD4pee+ta+FJLyZW5ZInw8qPF2RUdJXCPFsfXvLN8q4upxW/KUAuEZH qcT3TvvNKv1wio+njgOk1ggniGpP7FQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VUGQkSPA; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733754156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Mrc3k+K/yTD9d27E3LfzBWeCtSATx6WkPMaFyVBe5Dk=; b=VUGQkSPADTikdlqcBpK2Uto1ioQAA4/QCk6+CEV8T2WAOfIZI7h65s86gC5EKILjYUTX9v yUcv0yQqFFPdRtcjsiaE2+vL5BlQkLTraFJZ8KS7BmIOTMxuB3YVg1ugPJ9iJDAdE8o5Tf i0noJoj3iPmK+PedvMfepot8YkKynaA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-215-0lQKbOAAPwWALOZK1boY6w-1; Mon, 09 Dec 2024 09:22:35 -0500 X-MC-Unique: 0lQKbOAAPwWALOZK1boY6w-1 X-Mimecast-MFC-AGG-ID: 0lQKbOAAPwWALOZK1boY6w Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-434ed70b74eso15894225e9.1 for ; Mon, 09 Dec 2024 06:22:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733754154; x=1734358954; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Mrc3k+K/yTD9d27E3LfzBWeCtSATx6WkPMaFyVBe5Dk=; b=G++ITxex7jaV1lkATK3zDwYkcRYTLpba2aJM97VYY8lFijfsDimpWah7E89RpB3xvZ qc0ChJWUdUSwJfZHZgnfxKiXylwrix9e2hRoTkS+CONr9xOjzoeio4dfVks8fnmq5dl6 dKNW+0/EaaDJkIlywSjBqJEfcerUl5c0y4gVdkWvpJSxD/WxTKycekVKeanz1IsBg0QO Rb2+2IC7ylocRYbKWzjZ2rhOeY9+eFAvvP+cUOupuZWA7g+R4MlI6jem3kjkAg7TWDA0 lqd13zQIQT/KjthkasxwPV0DLO8jtppyF+2DfCVgAMilRXZEA8a+DpocXUb/nCCJztsc KCbA== X-Forwarded-Encrypted: i=1; AJvYcCUg2A7N+eztqqz2tulEl4LOKnSQ6D1/rDSGyKQ6B7jbyy/6Q+G6tdtJJ0yDpbFNtMGHjaWBbr0HTA==@kvack.org X-Gm-Message-State: AOJu0YzioJJqTVm6HlUUCmDCkWLzp1qdgeq4Et+6jYoGlupBiMlUQ1ur Mfr9tDLMgwV0IDZHBRTJiV9zJajyn7cIS8nt1xLrKbLfitWrSqAqMfWyB1zmzsOjiaGYYybth5M AGcmoI5bDjggOOzC8aG0kyWoB4+n5W118mBEWj4IyTSHgYCxb X-Gm-Gg: ASbGncuYoasQlKz1B3q4BEnVY1kVZas7He9H9vahnWZcShGAyrUaMvx8CFP9pJAphZC 7tvNLuqg1t0cTXFYMwfhP/fkehSZ84bHoflxUo0M3KJM3dIhAz5XqVulmVQwQbyDy0vSgO6yzpJ mkN94wOijrCghoVcYaeuswn67yjDD2oDbF27z2LrcmaoDeMEch8E/mhjjGbeArVE0vbBijqXLm7 D1Bn4UrahOMEUgJXOuZrAPWy8+oWk0+IMyp22Ch5GVuJUTLSmhpgMl0dorgTbf0sE+1gYAGKq0l HXwBkRwU X-Received: by 2002:a05:6000:1f83:b0:385:faf5:eba6 with SMTP id ffacd0b85a97d-3862b331626mr11671069f8f.1.1733754154462; Mon, 09 Dec 2024 06:22:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IHEVggv+QrPgNi5/mUpTV5M0JPuQqNJyYGPboXbEyB99ijiLiFn2Iz70GdrlEAnpYfKWwp8ig== X-Received: by 2002:a05:6000:1f83:b0:385:faf5:eba6 with SMTP id ffacd0b85a97d-3862b331626mr11671041f8f.1.1733754154087; Mon, 09 Dec 2024 06:22:34 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3862190966bsm13527404f8f.75.2024.12.09.06.22.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Dec 2024 06:22:32 -0800 (PST) Message-ID: Date: Mon, 9 Dec 2024 15:22:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: remove an avoidable load of page refcount in page_ref_add_unless To: Mateusz Guzik Cc: yuzhao@google.com, akpm@linux-foundation.org, willy@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20241207082931.1707465-1-mjguzik@gmail.com> <94d0dcbe-2001-4a9c-a767-b337b688b616@redhat.com> <606fbf9a-c9ba-4f08-a708-db38fe6065ce@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6usKz9wJP4UdIId_y2jqEe9YcJHA6-2h_1BakUIvgAE_1733754154 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: qmj47mnjxq74fkmtbkxn6s5m44q585x6 X-Rspamd-Queue-Id: 5D44BC001E X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1733754133-600466 X-HE-Meta: U2FsdGVkX19zvRyV92/u+kDg3nwK8wiXKJP/M8xZyAAgA/WVS0UhFpW6j0/SgEZLigbGTyja8lotCyC5y978bneNVxvfU2qwEx7nt29hRh/3VFXZrQRbNx634rxNW96jesQK1HNqQiqw6OrLnfVl+9lAekxLpmEzjPKibxZogtKgk09roDheZXqDqB8pzhfPTYgzerMu5DczxrXatmJj4BoxXIpwHJhJ1SnYiCNlJzPHlK0C59MhP5fKg5uIiSpTEL+pammZGrzc5ZbynHBhu0XiVsh0lTXmWFLvhI+/vuuNCu4Z0JkQvDXV708bnppxykHaGbbO4oSanmP0Pzz9LfEIpfJAYkFhXuInHJn99zHGoKIukEFLyBGX7/QWlkAm4VtrzDyQLeB8jW1jvALhfexEjQagiglBkDB0/YVnKYt9tWGCUJAHoeuszoc/6Wt5vGbhI9UbakN3a/dWZxD8GbPFXEQCkOtn5eCZxLqJemXMM8+y3BoPUHkv9q0wIY9nMu6f59yJMeshDDnvfbYAUB0R/L6Pi7sQSJDXeZJOS5H/Z1EiVS+YOTqYjBaQfrGrL/nB5+IBAeYhruiGj73dQWE6rqfKxGmEwKj4XapNfsnSOKPRxN3gBZJRsIxgs6MciACKGYnmkbpj75om9w4bKL80k5uvYAc68VfK12fBXao7d1hy1RW+8nV0EcIioxp21Tte3M4an7oJ4CrlTH/dDaqmj1xGp4KuNQVp+1XNJBiv+NYcm3XLOg8nfGGm5gn2i9+wcq8O71K8dbf95W+u0QZxs4puZV8bydOtE9/NebprCCfiWwS5d+xBD/9hvkknvqRqBLQFHpyWFn1xey+QNjkvrKv+aILf3s9llL93UAGvVGvITkNko85i10Bdlfq/Uyy9ToqJtiTV6DI8MpjTExArOmbFzVsW3W+2JEc+VrluMioGa22V+E8YBksR9417LLta15MNQ4MUkqpWo5R m6KlzcqT VodJHuCpk/gUhtV4r0UMNwoFLt1ZX6wO540EqNp8xKOF/DFbDSdsV5gs/xeH7VDyzAenXYURfhKhmXL2P1BfegmJr80S2m4H5M9VYMprGlft5GZfBuNCbRnD3iHnKpsmFQ14hcUzzJhkgqVp2i8rkNoQAOSXIpViefXvw9yRtCJdQyT7n9a+bUYuk8TUkpNPugW2Rtu5UN1Y3HgbY1pv1hEKf7x7+I8jkXxZ1fH0WiRp9uvyyK/n+uqW8NUS0+oafaJOJE7WpKn1vZnZhoVY3L+jCB4m0EhCwO3KvMGfBxOuzPTySAUfykI4bdVBFzUVjPcFY1mSU+8AFxiG7CcNBYZ0SpoiOm5lBbxFA9+UrUnp2eijTdL71Ewirg6lrJyiSVmMXEa3CZXaqlYdRK24Gx1YV4bTwZAHUrg0H/ukawWMPuZwxdiwLsS6gV8ue2msq4WAv6Xd4cH9WU8gZOQhBOPoTAmhS+BDORIFR60vWMHNzVTzcsIGgseT7hIJqz0wtd/etEUhL8ZNBd+xYN96GUXKKmY3uzikKg7LREfmRjmd6sZfoM3Aps70auw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.12.24 13:33, Mateusz Guzik wrote: > On Mon, Dec 9, 2024 at 11:56 AM David Hildenbrand wrote: >> >> On 09.12.24 11:25, Mateusz Guzik wrote: >>> On Mon, Dec 9, 2024 at 10:28 AM David Hildenbrand wrote: >>>> >>>> On 07.12.24 09:29, Mateusz Guzik wrote: >>>>> Explicitly pre-checking the count adds nothing as atomic_add_unless >>>>> starts with doing the same thing. iow no functional changes. >>>> >>>> I recall that we added that check because with the hugetlb vmemmap >>>> optimization, some of the tail pages we don't ever expect to be modified >>>> (because they are fake-duplicated) might be mapped R/O. >>>> >>>> If the arch implementation of atomic_add_unless() would trigger an >>>> unconditional write fault, we'd be in trouble. That would likely only be >>>> the case if the arch provides a dedicate instruction. >>>> >>>> atomic_add_unless()->raw_atomic_add_unless() >>>> >>>> Nobody currently defines arch_atomic_add_unless(). >>>> >>>> raw_atomic_fetch_add_unless()->arch_atomic_fetch_add_unless() is defined >>>> on some architectures. >>>> >>>> I scanned some of the inline-asm, and I think most of them perform a >>>> check first. >>>> >>> >>> Huh. >>> >>> Some arch triggering a write fault despite not changing the value is >>> not something I thought about. Sounds pretty broken to me if any arch >>> was to do it, but then stranger things did happen. >> >> Yeah, it really depends on what the architecture defines. For example, >> on s390x for "COMPARE AND SWAP" the spec states something like >> > [snip] > > Well in this context you need to do the initial load to even know what > to CAS with, unless you want to blindly do it hoping to get lucky, > which I'm assuming no arch is doing. > > Granted, if there was an architecture which had an actual "cas unless > the value is x" then this would not hold, but I don't know of any. > [such an extension would be most welcome fwiw] Apparently, we prepared for that via arch_atomic_add_unless(), which has no users. > > Assuming you indeed want the patch after all, can you sort out adding > a comment to atomic_add_unless yourself? ;) I presume you know the > right people and whatnot, so this would cut down on back and forth. > > That is to say I think this thread just about exhausted the time > warranted by this patch. No hard feelz if it gets dropped, but then I > do strongly suggest adding a justification to the extra load. Maybe it's sufficient for now to simply do your change with a comment: diff --git a/include/linux/page_ref.h b/include/linux/page_ref.h index 8c236c651d1d6..1efc992ad5687 100644 --- a/include/linux/page_ref.h +++ b/include/linux/page_ref.h @@ -234,7 +234,13 @@ static inline bool page_ref_add_unless(struct page *page, int nr, int u) rcu_read_lock(); /* avoid writing to the vmemmap area being remapped */ - if (!page_is_fake_head(page) && page_ref_count(page) != u) + if (!page_is_fake_head(page)) + /* + * atomic_add_unless() will currently never modify the value + * if it already is u. If that ever changes, we'd have to have + * a separate check here, such that we won't be writing to + * write-protected vmemmap areas. + */ ret = atomic_add_unless(&page->_refcount, nr, u); rcu_read_unlock(); It would bail out during testing ... hopefully, such that we can detect any such change. -- Cheers, David / dhildenb