From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F30E5D3C53F for ; Mon, 21 Oct 2024 06:38:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B19E6B0083; Mon, 21 Oct 2024 02:38:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 661386B0088; Mon, 21 Oct 2024 02:38:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DAD76B0089; Mon, 21 Oct 2024 02:38:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2C9676B0083 for ; Mon, 21 Oct 2024 02:38:56 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 039BB1A16B7 for ; Mon, 21 Oct 2024 06:38:28 +0000 (UTC) X-FDA: 82696656378.11.0D54E83 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2065.outbound.protection.outlook.com [40.107.244.65]) by imf09.hostedemail.com (Postfix) with ESMTP id BD91414000D for ; Mon, 21 Oct 2024 06:38:42 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=OPzHIXy+; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf09.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.244.65 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729492623; a=rsa-sha256; cv=pass; b=dgHRuFtHShRQucw8UZmLPYdUzhPgCaY2qYsCQlp/vDLB7QPAI4BhDNU4rVXLOJsuDLpucQ lqSEuOAUt2HcUWHnf0pZnaDi0+JBgCl5A6n85ZBEXLPaiB4uXNyjVmr068ejBMK49IQOLF TKVzCK4/UmENJJSAUiAnaMc66OsPCGU= ARC-Authentication-Results: i=2; imf09.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=OPzHIXy+; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf09.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.244.65 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729492623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h4UxLUXITKs0amY6LqOzntXZ2H7+ajZJFQo10auQEyg=; b=cqfmYGTbb0uF6+fM+3lGkXZlIIIP/dOX5RudjEbk8VclffQAdxBc4TKsZn4OMbMIEQ9eOx ebvm9QxsFiUbXc4D6HtTyeoxV5bbny64WLSxg+YgQoQONVI5J85iuMPBrr9W/qqyajgmnr MKWxlRFmErtPsopmD93icrZggO62wuo= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VMEQi9M59c6AxhmYbm3dnW/UUHXKqRCsK6PLn4+vGXx9qFSuUBBg8caZtyRzBlxmBLtgevwgawv9W7dVNE51spXiy6T1eUAppZ3PV1oGfKX6wuBc4RIUh2cpDS8wCcnnAMQ2/GEHKXSQ0k+GuzDv5B+1OAHGoJXp4ZahV+yYPB6LXgDI0HUvOtoP2w/sfv+kS7EwVfkCY2cEFHMTo4pV1Bls8OfW78E2Aiccxkqsw+kNng40VuI37Cqq9AJSzmULMzstwBY+97M3+BzPxBzkivW1gow7L0z36x+p0558Apr3cMrAmnMzVbtC8pKWSQrMjaGu1j8WX2MoBRgni85XYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h4UxLUXITKs0amY6LqOzntXZ2H7+ajZJFQo10auQEyg=; b=UYP701Sw5xKBrBQ1yeCZx+Nrf77VH8ZdeyaWBtnhj2zwFUXDl6NEVEJucBJ2tZ9qzEyGJsYUtBzAgjPRDrwWbCONtszub4JJY4eoPzlcdXe8rmzprvovTMCihM9/VvQliG3rLNRD2nma3W87oLGwycwHrptLUKKLPXGkTFsjEY4y8KR8p12vd3e1F/dEwCGk2pGJvaxGoY/AsRcoQ62bUahjXbtxPNcE3hGC6WU4LLw1rySis3XXBgCE1NHqTnCKoRK9Q36VXSwCAVO3XG9UN+l5FTvOahy9iTziuw49Bf4Q1ZSSeMxt8XjUIrmCDS/hHbE653ZIjtPNb/Z/0PL9uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h4UxLUXITKs0amY6LqOzntXZ2H7+ajZJFQo10auQEyg=; b=OPzHIXy+ZVi91JmMz6OPM1cCfi+nYaUZow49bOB8pu/HxZgkwMKSZQACVcqPvpEPCt9B0D/uiiHwnkyCf/ee5SXWSbzh3VUucz4N/0q0uQaa9wB1RU6kkW19oYBdosUzEp6uMzlfNaPOneF6wilKMoxDs6kZHxgMFmAelfhUj6mT23ZjNg61NmsOsGLfvNTiG/DRq3QMUMPGYg+PBdgv273EqalWpJPzWxZBY99IPl0O3xeddpJ3rV0aG8Z527jgwm1YqeviTBzjcL42jxScw76lbgWk9/2b53b/cBPegyv5/+OhaWWPX7pQ06tJRPgw68nF8VgDdZJEo6mLUQu3PA== Received: from SJ0PR12MB5469.namprd12.prod.outlook.com (2603:10b6:a03:37f::16) by DS0PR12MB6608.namprd12.prod.outlook.com (2603:10b6:8:d0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.28; Mon, 21 Oct 2024 06:38:49 +0000 Received: from SJ0PR12MB5469.namprd12.prod.outlook.com ([fe80::ff21:d180:55f2:d0c0]) by SJ0PR12MB5469.namprd12.prod.outlook.com ([fe80::ff21:d180:55f2:d0c0%6]) with mapi id 15.20.8069.027; Mon, 21 Oct 2024 06:38:48 +0000 Message-ID: Date: Sun, 20 Oct 2024 23:38:47 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm/gup: stop leaking pinned pages in low memory conditions To: Alistair Popple Cc: Andrew Morton , LKML , linux-mm@kvack.org, David Hildenbrand , Shigeru Yoshida , Jason Gunthorpe , Minchan Kim , Pasha Tatashin References: <20241018223411.310331-1-jhubbard@nvidia.com> <87y12ibbew.fsf@nvdebian.thelocal> <142152a5-d265-4aa5-b103-dede882f9715@nvidia.com> <87ttd6atxi.fsf@nvdebian.thelocal> Content-Language: en-US From: John Hubbard In-Reply-To: <87ttd6atxi.fsf@nvdebian.thelocal> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR05CA0032.namprd05.prod.outlook.com (2603:10b6:a03:c0::45) To SJ0PR12MB5469.namprd12.prod.outlook.com (2603:10b6:a03:37f::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR12MB5469:EE_|DS0PR12MB6608:EE_ X-MS-Office365-Filtering-Correlation-Id: ef88dde7-ee55-4698-9072-08dcf19b04eb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dVdub0dVbERtREh3WFhiR2I0WWdjcTl1S2NpcEdnTmcxalhnNXpaTXBUV0J4?= =?utf-8?B?cjdhVUI3R25iR3lKOGN4bWhUb3JUVjdyNjMySWNmQ2dFSjVGVEhoM1lpcXhC?= =?utf-8?B?R0dNaUo1WWRoQ3hjQzVhMjJOK0dtN2MwWVc3c2ZwZktCZDJ2c1k3TVk2S0Nh?= =?utf-8?B?TW41YXBmNUx5UHlHL0VLNERSV0hjeU4vRW1MUkorZi9nZENqZzNxYkhoN2ts?= =?utf-8?B?WFBWbVlNT2RFNC96VHVNVE9FdXFUQ2J1SmRLRlZxaFVJK051Yno4ZjhITW9q?= =?utf-8?B?aFVrbzNxWDhCSHhwc3A4TzhXMENZN1hwTHg0ckhBK21Qcy90U0c1NkhSZDNX?= =?utf-8?B?K01yMVVwWmxmbXloQnZtMFR6VUQvZjFBcXpjV1d0a2Z6anNuWWw3aXZBZ2tw?= =?utf-8?B?eHR5UVRIUzFqV3Vzc1hTalVxKys1RUpVTGFkNFZGdVBVajFib2grbk01TXhk?= =?utf-8?B?TFpvckwvSlpOZFhXbUZmZTFDNGNQcDB4T0FOTTJ3MWFjQVUrYlpNTmRGU3lN?= =?utf-8?B?ZkdzbG1KUlVWcjJ0MDVWc01RZ0c2TEVuWmdVY3R1bVFTQ0V2OWNZeFY4cnBx?= =?utf-8?B?N09ZdU5mWkk2aEZmSzNZbG5POEl5UEhHZ09meSs4UUhTalgxNUEyaVp3Znpa?= =?utf-8?B?RExqMml0L3JSSjJ6OCtKZFJVazlZUWtzbXQzNmo0b1BZcldqK3FNTWNCcS9N?= =?utf-8?B?dXpZWlFtckVkR3Z4d0JnRDRPdGJIbzhMV0xoNWVZSnZhcG9Ddm1QUE5lSGsr?= =?utf-8?B?ZE9aUml3QXJaWTJiR0NUeDQ4VnlkcjdLNkFmOURuSGdRR1BBQSt2eFFlMWph?= =?utf-8?B?VDUwUm1idEJsVGx5TTdzN1FGQjBOSkpVdWhDMFpOdmZNODlMTU9KTytBODQ3?= =?utf-8?B?MjVsVTF5ZmxVdTRDbUk1RHkwUzZBYTlXa1hsdms3aXdkK05NRnoxb2ZBUkRo?= =?utf-8?B?OGRtbVJvTkVkN1dVM2JVTW5NK3g5Q2dSSUxDWU1WVmp6clQ0alFLd3VMcVhL?= =?utf-8?B?NUtmOHJCT0lGaHdsMjRReG9IcTJIcTU5TnhWcnREZG14dlZUYVFxUlFKcEVY?= =?utf-8?B?ZFVqWnMwZiticXBOc1NWVDJ5eXh4ZnY2S0xRNDhPbGhMQUU2dDZrTGtNRUZn?= =?utf-8?B?ck5GZUJJMm1TSjlRcnVpR21WWjlhSitwVmJOaFdGQnF2VnpkSEF5MFFtcEpV?= =?utf-8?B?R2VXRWF3cGlPVmVJOUZvQ3Q3Z0JLNU13UnoyNWVzYW1hS1BKa01FQlZIR082?= =?utf-8?B?dTFLVE8rWk91dVRFYXdqZXVoaVpwa1V3L24rOXBqbi9lSEVXUXBYZVNOem5q?= =?utf-8?B?Y2U1c2p4UmJNQ3loZURzc25rU0IxVUd3d0trQk5ldm1heXB1eE11L1BHNFRT?= =?utf-8?B?L0l4ZUpoRjVOeXRiNzVicDBmdUNOWkg1cVFPSzRsdXYzYjZKdFlYR0JBa3lE?= =?utf-8?B?aE8yeHdLaXNHNmxMSmFCa1ZsNGdIbUF0MXJpdVErcEN4aE5MTFRPREE0NE9V?= =?utf-8?B?dHNpNjJDdG9jWFdqY2licTF4VWRqUFJLNXIxdkpjNDYvVC9oMnlRQm9FV2ow?= =?utf-8?B?YWs2TDZhRnJpUXdEdUhYMklFOFZ0akg0Z0N4RmpWUlhNcnlaL3VnQ0p1ZWt4?= =?utf-8?B?a0lITkdxMUl4Q1VlYWZxdnZoL0R1c0RKNjFqMVdOcE1lRUdJQ3J3anREeTZZ?= =?utf-8?B?TkpVVVUrMkZBSUtvS0NPQnhxelhSRWNablFTcXdIYjFnbzQrcGM1YlZKeExK?= =?utf-8?Q?N2agNfEIiP44xYEuoXcOGYZOkl2UiacYZOhXAak?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR12MB5469.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(10070799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WFJmNHJKK3gvNER2YVhLb0gyMlBRNldKQk5GcHUxVXdtODFyUm1EM3lrdHNS?= =?utf-8?B?OFRuell2U3BzM0wzZExFeWRWelU4VDZvZWN5S1lIOG9LUkEzS1NwVXhKS3Rx?= =?utf-8?B?UENacUhXNlozSzUrQ2l1cUVDc0xCYUVReldTSEprZmxpSzd5UU5ZVXhNZCtP?= =?utf-8?B?NkZ5VEdHdUc1YkRtSUcrOWFLN1lFWVlWZ0RyZWlaVU9SSzlReG5GcTlWQXpq?= =?utf-8?B?bi95NkRJa2dRa3pzVGpsUVpBc0xZWjV2NnRJeFpXVkovSTVYR3VCbDRQbDVR?= =?utf-8?B?Q0VhVnNGSEptTWVOb1pnNk13QW52REhmWUxsa2hKNFdpVlRZeDBoREUxMzZX?= =?utf-8?B?QlJjZlEzb3g4amNyVWEzOTBEM3haamNRcEkrUTJIT0JweEw4RSsxeERDaXJu?= =?utf-8?B?THdKYTNRSUZldHdTMjMzTG9Da3hVV2xUNEpsVkRleW5STjdkUjg5S3ZRUmNa?= =?utf-8?B?cmpDN245KzVPQ0tjV0hyb3ZGTnhuOFNVcytYeGNVcmtFNUhOK3ZtUi92NE5Z?= =?utf-8?B?TVFpNzZIZFZPd0R0TEh1ZXlXT3d6ejZHcUkzc0I4MmM4ZVJCNkZzTUVzdnlO?= =?utf-8?B?WW95S1kvOGFob1UyTjM4WnkwVThkWERVcjJnM1lHeW9JUUFtKzNjMjRWYmhP?= =?utf-8?B?TVZ6cXArTUZoS3dWdm5sN3lBbC9oSEp4OHhxMWNYa0g3ejB3Vm9zZ1RlQThX?= =?utf-8?B?TkFzME9YTXV5RjgrSGNJOWgvcTN1VW9JZmxVZ0prMDBEZXVHNlNUQ1kvNjI4?= =?utf-8?B?UFlFYVJQMnVtengzbDkvWVZnWlI5V0lTVHV6NEhZWWF1NWw2N2thUDlCTmZo?= =?utf-8?B?R25BTmpzTlZCMk45K3Y1b3Q5L0E2Wk9xL1A0STNwa3hjd0RDNVpNbFJ6Umc1?= =?utf-8?B?WWV6WEZMeUxPU1FwMHJUN0JyL2FIZkViVEFjTzJVTlFYM1F0VHdnK2JoUWRy?= =?utf-8?B?bzhuWWh4TUZvZFJUNkMwQ0dhdnR1RlprQ09Mb1FMdzFwN2YvT1FTUlNYWXNT?= =?utf-8?B?R1gyc1dIeG9hSURMak1taHdMNTIrTmszaUQ2bFRoekFKTm9tTHd0Z25RZ1NX?= =?utf-8?B?Zm5kQjRkTHh4UVZTSSs2ek54RngvTHArZ0E0RjJwSmhqMVRQK3U2S3V2S0Qx?= =?utf-8?B?YnY5Si8vZ3gvemtrRDJzUVRnYmJDQlZOeFk3ZDJVWWVYdGRoekoxNEZ6RWg1?= =?utf-8?B?azlIR1pjckNPSTZEUjl0cnVVbnJkUGRjWGJ6dmRRSnFqMXhvb2ErZThFMGpB?= =?utf-8?B?djhuNFVkalFiQVVZaHdXYUt4M1BrbnQ4QVdETWNMcEVoUS9BUG00RUI1bkkw?= =?utf-8?B?aSsvOWk0aVVSRWhTT2pEZWVyUlA2UmlHMnNqbTFhNkF5OFFDcWp3WVAvVStu?= =?utf-8?B?SE95eWVEZ0hLYVJoc1U0V2tRdUk4MzBFNjhyUUpEbzhlUmFJMjliSHRxdkM3?= =?utf-8?B?Q3o3dlY0WmxRODVxcUNsN3IrSXhIUVF4QnBZaWNnSklLelBNN2xVSHpQdk5z?= =?utf-8?B?NGthNUlGZ2c4NkZESzFDelh5SkRQU2lRbzBiMGVzOElFV05lK1RuMkFvdkhD?= =?utf-8?B?bzBhek5JOVlXTHFQeXF4VTgzbVlCdGxNSk12N2NHQWNzNUVJaXhoRGhoSlZl?= =?utf-8?B?L1ZvUGNpMDV5TjROOUFnVnZtR3FQd2k1UElzSHFVUEVSbUxYSnpZL1lnNG1t?= =?utf-8?B?MmM1bitNUWpQVlVoNGVPdEZ2OSs3eHlEMytKbldCTXdZRTBkUEN1bEdYR3hY?= =?utf-8?B?WmRzdmVwNjh3cnF0bXlWZnZTYTRJUkE1bkprazFWVlhaWURlcE9nVEJRMHpE?= =?utf-8?B?RFRKS2xZYnJaZlU4aEpQS1EyOS9qQkhsVWVCQm5meml5YjJKcFZNSWY5amJW?= =?utf-8?B?WjA1N0x1b1pwK0tFNDVvSzlWazlkTEtkTStSKy9SWGk5QStqZmZ1VmQ4QTBD?= =?utf-8?B?NEh3ZTBnT21UWnJUV3FyZUF0Q1N5alltUEZwTkZWZzlFYjIvUVdtdWhKdXlq?= =?utf-8?B?aldEclNsNWNMeWxnQ05OSTI1TG4rcmJXN0pGaFpBbHE5bjQ3VGtocWNXMHB5?= =?utf-8?B?K1lEZWp1VmdXR1BFeDBtZEkzbllQbDNYbFhUNUpOdWtJMU0xZHFWYlBaSkxl?= =?utf-8?B?clMvdVpTTjhUQnhxTjIybXJyVmRpQTVqQTJqcGtmNjNiTVpncURjYUx4SlJj?= =?utf-8?B?alE9PQ==?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef88dde7-ee55-4698-9072-08dcf19b04eb X-MS-Exchange-CrossTenant-AuthSource: SJ0PR12MB5469.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2024 06:38:48.5551 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9mYmau8/pgmhShb4qQvb1Zcd06UmEhmeDcwqy73+Ei+utGvx7I/x1arxp8Y4LU90rvQhMJq16saPNgoFI/6Y/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6608 X-Rspamd-Queue-Id: BD91414000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: fmm964qgbwetysj6kekgjpzwusqf6egm X-HE-Tag: 1729492722-751120 X-HE-Meta: U2FsdGVkX1+WZSa6VEjVGO745OFG7XOUJ+ZtOu29/HK4cfCNRzB2TJdNGJ5w6Svow5++h9e7yfeQsq/3qE7F2pie2LuG46bNt523tX0oXOCntN/vvuwsqDrUdb6fS5E88BuauTLH3gWox+lsUUheUDOeIgWNRMbZ7KMUf26cIP9A6eaAqewSbMdo/SYFvz6QLQBOdYpe0e/UJ4+kfXQTIrzCErD11X/AiSxz27MOgfAbshson03pCJ0eJlkeanPQiNC5mAtakW4RGMH6kS/QG3ZEfK+d3EY/rYsLiOx5eyU8xStdYVJnNITjt2rJmsU+wg/P6hhBEb1I9KmZAvZaRDFD0UduJgIe3vfonibpEKhFF3YxXGM1H2974lfq4tE62LIy0qs1dHC9cGdSgtmyZVgrcNkpmaJX9Bu5nF3fpRanvQQRe1TvJoNYYwxEYtriuSPopUZdCaq6frIyhTh1aZ3a2Gu3eJqjayIKCsdq9E6vT9Dtypmx3mf3GkbcsD60JYwX8jy9Pq9mkEvpbvEMU+okorge0d219cKXp1hn+HXZMF7Euykfh8qYr9GbXGxyG62KB/yRImXpRa7qExbK3dTbJFNsHCOF66bZxSkQeU0KCPVXaE1BJVXqgW6xZaoE6HWCZCuZ4XgK8Ot8BhjQxVBeQMvqIYvEPXOW0Myd1A3jyVrqf8U/A43hFTbBMxLL0DCrEeLwv7QigMeSeHiO+CMyqVrrHKM/heZ+8/38IHB753wRmfoKpixGZk6eiM8CMxFXa+52yy/FyfAUMCEW+WUbF47N4xsSPYGigjqYr8rYUvF8Hu0fk/hkHYaoHKtwzEh7sbMEsrYYqzXUbeynkve9ag1RIF/SdZ+2Z0H6UzmS8PolN7pfAYPUgjitZlqsrMxuqUI0xRCo9ciVSjQNA1hkxB/pzBOL0BpROqoAnKYhNvXB25FU3I/5Zis/y0V1ixtsoJQmpyMCTwUbuNA IaloaSvP FO4eqlGeWtBMee/YPB8GxCM4que6fipZSV9dxY6IqzGDMTF0M0Z58zNZNIHHjQqE36z/D94NTbdTK2ybFxkf3aQS85fo/e0hFAh8AMX9dHTeV5RQUHV8v4/obWoBGk0GL3ZdsdU8bdKy/ZUQQRzUY3jMMYPgw+G80IP8vvEsmPYbE/cfW/djdRz11mAzy8GIe5CDjVGqpg7McJfF1egjfT8QLOgT3W2Aao5l3Vy1LmL4QAeLq+kjvaOHChWnarmuhsOsyHqCTSiIBosY1s+6zIz/Ve6meYZMv4WIbFGoGur3awfG9GIktiHfmCLgE2siQ36JFxbfkxRLLVrmIjNPLKuGFsg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/20/24 10:39 PM, Alistair Popple wrote: > > John Hubbard writes: > >> On 10/20/24 4:26 PM, Alistair Popple wrote: >>> John Hubbard writes: >>> [...] >>>> @@ -2437,8 +2440,10 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages, >>>> long i, ret; >>>> folios = kmalloc_array(nr_pages, sizeof(*folios), GFP_KERNEL); >>>> - if (!folios) >>>> + if (!folios) { >>>> + unpin_user_pages(pages, nr_pages); >>> ie. Doesn't this unpinning need to happen in >>> check_and_migrate_movable_folios()? >> >> It already does. >> >> check_and_migrate_movable_folios() calls >> migrate_longterm_unpinnable_folios(), which unpins if errors occur. > > Right you are. > > Reviewed-by: Alistair Popple Thanks for the review! > > As an aside for future clean-ups we could probably get something nicer > if we reversed the process of pin/migrate to migrate/pin. In other words > if FOLL_LONGERM try and migrate the entire range first out of > ZONE_MOVABLE first. Migration invovles walking page tables and getting a > reference on the pages anyway, so if it turns out there is nothing to > migrate you haven't lost anything performance wise. > Yes. In fact, I see our emails crossed, and I just suggested the same thing in reply to your other comment (in the v2 review thread) about short vs. long term pinning. Great! :) thanks, -- John Hubbard