From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8856CC433F5 for ; Fri, 19 Nov 2021 14:47:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 39E9461546 for ; Fri, 19 Nov 2021 14:47:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 39E9461546 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=me.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id ADE4B6B007D; Fri, 19 Nov 2021 09:47:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A8DA46B007E; Fri, 19 Nov 2021 09:47:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9549B6B0080; Fri, 19 Nov 2021 09:47:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0072.hostedemail.com [216.40.44.72]) by kanga.kvack.org (Postfix) with ESMTP id 840276B007D for ; Fri, 19 Nov 2021 09:47:42 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 40EDB876F0 for ; Fri, 19 Nov 2021 14:47:32 +0000 (UTC) X-FDA: 78825958344.31.BA4E929 Received: from pv50p00im-zteg10021401.me.com (pv50p00im-zteg10021401.me.com [17.58.6.47]) by imf07.hostedemail.com (Postfix) with ESMTP id E74C710000A6 for ; Fri, 19 Nov 2021 14:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1637333250; bh=MsBqE81grX8aiFkBH4WpikzLFiloP18tSrI3NxXy328=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type; b=sG6+VfHc37rvIkjYL9ONpU9oiC7pSSmwtNr1drPJVRoKMlOU8/lHofOKsu+/S6boO 2+FLDDtJKvy+G2jrkIJ6TOylojAxhUD4ncXhtX+I0t4BZ1yqqIsHjKGanMXaG1k7Di bgEPm2oC1G/K3uFhSJLxTplqS9eIz8cOG9B6LFy0gtVt5Ym3mFARQzECzFCC3dPgG3 HlIlBW0pYWN/sCfqD7+A7jtzwtCqMBpTKaUdp93OfazhTmKApBt3muasg0RaujKSsV VcsthfIjggx1EKLHQcHRTzmazfaBB3RVNhnX67Fc+rKiuAiwbbeBtElZ/HnBV5j/W+ Tx0cnBqL1LBjQ== Received: from [192.168.1.66] (unknown [120.245.2.217]) by pv50p00im-zteg10021401.me.com (Postfix) with ESMTPSA id 296E44803A6; Fri, 19 Nov 2021 14:47:28 +0000 (UTC) Subject: Re: page_alloc.c comparison of arrays warning in function mem_init_print_info To: Arthur Marsh , akpm@linux-foundation.org Cc: linux-mm@kvack.org References: From: Song Xiongwei Message-ID: Date: Fri, 19 Nov 2021 22:47:25 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.790 definitions=2021-11-19_06:2021-11-17,2021-11-19 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2009150000 definitions=main-2111190082 X-Stat-Signature: onyp7mcizoeirszizkci48n3pta9z3oq X-Rspamd-Queue-Id: E74C710000A6 X-Rspamd-Server: rspam07 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=me.com header.s=1a1hai header.b=sG6+VfHc; spf=pass (imf07.hostedemail.com: domain of sxwjean@me.com designates 17.58.6.47 as permitted sender) smtp.mailfrom=sxwjean@me.com; dmarc=pass (policy=quarantine) header.from=me.com X-HE-Tag: 1637333249-743975 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 2021/11/19 =E4=B8=8B=E5=8D=887:00, Arthur Marsh wrote: > Hi, when seeing what build issues there were in building the current Li= nux git head kernel using gcc-12, I came across: > > CC mm/page_alloc.o > mm/page_alloc.c: In function =E2=80=98mem_init_print_info=E2=80=99: > mm/page_alloc.c:8173:27: error: comparison between two arrays [-Werror=3D= array-compare] > 8173 | if (start <=3D pos && pos < end && size > adj)= \ > | ^~ > > Are there any patches that address this? Please give a try with the patch below: From ca5ce459a256a4847fff96778e78ce1711e9e74b Mon Sep 17 00:00:00 2001 From: Xiongwei Song Date: Fri, 19 Nov 2021 22:19:59 +0800 Subject: [PATCH] mm: page_alloc: Fix building error on=20 -Werror=3Darray-compare CC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mm/page_alloc.o mm/page_alloc.c: In function =E2=80=98mem_init_print_info=E2=80=99: mm/page_alloc.c:8173:27: error: comparison between two arrays=20 [-Werror=3Darray-compare] =C2=A08173 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (start <=3D pos && pos < end && s= ize > adj) \ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | Reported-by: Arthur Marsh Signed-off-by: Xiongwei Song --- =C2=A0mm/page_alloc.c | 2 +- =C2=A01 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index c5952749ad40..8f304c3d0e19 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -8170,7 +8170,7 @@ void __init mem_init_print_info(void) =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0*/ =C2=A0#define adj_init_size(start, end, size, pos, adj) \ =C2=A0=C2=A0=C2=A0=C2=A0 do { \ -=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 if (start <=3D pos && pos < end &&= size > adj) \ +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 if (&start[0] <=3D &pos[0] && &pos= [0] < &end[0] && size > adj) \ =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 size -=3D= adj; \ =C2=A0=C2=A0=C2=A0=C2=A0 } while (0) --=20 Regards, Xiongwei > > Regards, > > Arthur. >