From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E377CC54EAA for ; Mon, 30 Jan 2023 21:56:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6442E6B0072; Mon, 30 Jan 2023 16:56:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F41B6B0073; Mon, 30 Jan 2023 16:56:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 494896B0074; Mon, 30 Jan 2023 16:56:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 39EB66B0072 for ; Mon, 30 Jan 2023 16:56:05 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 13CCF1C63BB for ; Mon, 30 Jan 2023 21:56:05 +0000 (UTC) X-FDA: 80412823890.30.4E39287 Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) by imf04.hostedemail.com (Postfix) with ESMTP id 1155440002 for ; Mon, 30 Jan 2023 21:56:02 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=oQ0WTXk7; spf=pass (imf04.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.177 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675115763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nm3u5EMP73yMHbo/gEeitsjZe3xcR1rioTdGrQDcOcw=; b=2LwAhZT/p/NuWIMXPRAk/h7IQdui7x4FWo2mFzAQUXXa+G7j5/32s4FSNLRmGZU9vNlyVO fy4Wgz1Y/YUhWDqpRMc5GpIpKcN1IAMw9o+sotCC/Ni+i2LJdtFdYSLcn5AHiQs85bIP1K IEs3UVWZqt9gcQHvFaebWwG1QV6ti88= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=oQ0WTXk7; spf=pass (imf04.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.177 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675115763; a=rsa-sha256; cv=none; b=4bLqSRsl36WPd9eoLdkqOjIrEku/Hjtw6PPM6PTgbqkPg73h5AlQf54Cxtb/Lrcb+VGJQO L6fIgxSytfx8OTyT09FRIwDJ+uvpMCvhpBC19Z5I2ZlyOdgfsHH8ABkXKdTAn7f0BwDcuP ku64xraigpQPqzxsg5XriEeky/5HTtY= Received: by mail-il1-f177.google.com with SMTP id l15so1928809ilj.5 for ; Mon, 30 Jan 2023 13:56:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Nm3u5EMP73yMHbo/gEeitsjZe3xcR1rioTdGrQDcOcw=; b=oQ0WTXk7Hm53c6o6Tthdbvt3hBywW1tg2wHnWLBm2Q41trM6Qgpe77wrzs+aHjG4PI mr+yswYaA4NYtyeBMSrTTWdoVulg/Qwh+LcrVaYFvkFDEi/3TWlTLzM8LBIIOgZKoR3j 64NdlPpQa1Ywl4HU3uH5yJfAoww0Gfl7tdmLLCi65UamJQ8nK6ExWSPxjsTMetimmR9K 0lCTIG5mI2pUNcI0tdj3TbG8741OjqOzcRw/juSMl35CgwjW8Uc1gIF+8G66z2rcxBYE mzPhDooq7Yxuzj7tQ5h5hAotg8RfvxkewfZ2SmKnsrNbfmX3npV7dp/1+zbK2BDxVW1c xlaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Nm3u5EMP73yMHbo/gEeitsjZe3xcR1rioTdGrQDcOcw=; b=ppdKwaEO7Zs0xt0gnTwYmXVBXPsOdq+7jQNO2rANFJpFpBU36IsVEUzW2Hdx2h0QCe OENcXA2Y9YVEUlukkWStWQDuuO9poxCno6RnrZeUD2berEFbSDsvFGR0ZSqfBOInjFG6 MtLs+nzBcwemaaxaVlyvXlTvNKGnTasrFUf360AgpVVy+Wjub+7+HY7aLo/BGCjDd2yr AR6rUA4CksS15+P+d+JecqMnuR3T8JvKa5MPBhar9aSqmvq4fTztQS22WWEeBRSEM4cs naekOlDVhch+XD8hio0+8k4J8SGu1xfnL7Mw2v8fvF3VTIBmDdvNqAKtNAFDPcyNgLVq mSTQ== X-Gm-Message-State: AFqh2koyEk3LhfD7XJwBKBbuFiJCN1eDbGkP3vi9uX776/UXBrdiPxKX 9Yosv8fJWalCShBH+GgowMZUCw== X-Google-Smtp-Source: AMrXdXvs+Z5KKUYemRLBxMaL4Garqnh0caexG/4IfIup1dJM6E2Qlk5jsvOCXEoH+J8JVyrOgsARUA== X-Received: by 2002:a92:2a07:0:b0:30c:1dda:42dd with SMTP id r7-20020a922a07000000b0030c1dda42ddmr7440724ile.1.1675115762047; Mon, 30 Jan 2023 13:56:02 -0800 (PST) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id s6-20020a02c506000000b003a0e665ad11sm5185712jam.13.2023.01.30.13.56.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 13:56:01 -0800 (PST) Message-ID: Date: Mon, 30 Jan 2023 14:55:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [GIT PULL] iov_iter: Improve page extraction (pin or just list) Content-Language: en-US From: Jens Axboe To: David Howells Cc: Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , David Hildenbrand , John Hubbard , Jason Gunthorpe , Logan Gunthorpe , Jeff Layton , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <3351099.1675077249@warthog.procyon.org.uk> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: 17e6s479w1py4xpr1jbxrpqut1fsmdp1 X-Rspam-User: X-Rspamd-Queue-Id: 1155440002 X-Rspamd-Server: rspam06 X-HE-Tag: 1675115762-727334 X-HE-Meta: U2FsdGVkX1//mTHlTvXJYhrqoMhR2IJJAMSInpc7kLY2ue88qaYdzfMaq4dFfN2qKbtHziYO2WuBSY94ttyY8ulYRZvQEtSTexkfS9iaMm6rXFCO6wQvQ6QmbeXm5qBV0wF98eoK+5rN3fD2X3rCCM6e3wTNEg6V2h8sleIlMJ5AUciS1tyVaRgBDSpBcxA9OfW3Klyhqp9P4+8WJjnQJYPlC6oDdh/ubEWNv1JURzY8H1km+k27CCK+dkLZOFCD9idV5vLN79jN5irbcUK5JGG2OZYzwZBthXGKHZGdtiku+6sp0vWY/99dneQyFZwBLBKtulk32VaMaBrU3gJgKl4k9yAPmnjZp5E7j0ROVSyfk04PIVjK43HD2TmwqszWc9AYtyIRwLulGrcArHg8Ou8g6xOl6mn2QkafW5RsmKBJqw0EnkdtNKjHk90pNVFkPzCQbmel1AxXlRLsSrV+WcLasFiC0Klwlvyiyl8kO3AIADGKkXrKtiRzS1u6jcEOhhpaKN8ItsEyYyhMnwJgjXjhLkDJpPr7L4BopwPv4a+YFkZH8Lbvmalk1tat0hP6GQ3R6iR7msgnT2FWRnK7AsOOaE0cXW5xL5g8+eBAnBd2HomkQHNojsYjLDUcBOEQvDKRC40d2HboGzLWlN1Kfzy+yAXHMatUHZ1YB6z9pHbjsmEFX4hN2XfUbvZtuISm7JHOpxaCeUeKph6/7C4nbdIPNSPumBFB3srcUW+vtzZuEL8F2dTP9q/3Z8fhuyxlqzKra5yYL+JYrBnp7aujy57k6bFaVLjpcoREz7MGMt1IMbR0vRCM1olmdHLtzS7Q3c+kYI1datbtJdmWAql06Od/qkLNKkAnvJgPAXz9Vf6DCynHNy4UPLdWiUceqk3qzjAhmDqMepmkgK+9RmQPn3PwcKCoh6DVX6mArtgoOSQ0x/gvDq7YOULWAdhoGwtzz6CbG9qWDOoN7317dn2 gUgj0Xke dTuZl5cniDSk80nKQhlLijpDR5umh3FR7ILZLvZCPt/Lbdl8GOcBWf90hohfVsH4YucSpY2l8aJRiHAQ76kS5MV4UznmPrGEwqPV49S8ZJsifZ3EZwu8QIgIveOF2wyedZhXB2URc4O46rH+S+bEdQvr6EfXpqniYNVg5E7N9kVfghVaMr8sLE7RA5xlHcMqtz9+R7N/ErN44JVXnpSEk7iFqkMe63NoevJQuyqbBeGUAokEF22e4qUfbDZXUXrOqGsEEr2KjhV6Wrhg4DOnd78/LNV0Sf0hOu+PT24Dwumw1MLrOam4u17YKOZFF8vtU/Isv2Ry9xEK0GJxqHu+ctPF6ExSyatA/1Y494KYIJfFbjmYfZF0MHbBRon8VZ4BziIdwCiVsED11QAu6Y+gw2wvlw4qOIJr94AsinH+QUj0IHO9I991cO3cdQ1xu2y1c8n3XH9RAIKuucGs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/30/23 2:33 PM, Jens Axboe wrote: > On 1/30/23 4:14 AM, David Howells wrote: >> Hi Jens, >> >> Could you consider pulling this patchset into the block tree? I think that >> Al's fears wrt to pinned pages being removed from page tables causing deadlock >> have been answered. Granted, there is still the issue of how to handle >> vmsplice and a bunch of other places to fix, not least skbuff handling. >> >> I also have patches to fix cifs in a separate branch that I would also like to >> push in this merge window - and that requires the first two patches from this >> series also, so would it be possible for you to merge at least those two >> rather than manually applying them? > > I've pulled this into a separate branch, but based on the block branch, > for-6.3/iov-extract. It's added to for-next as well. This does cause about a 2.7% regression for me, using O_DIRECT on a raw block device. Looking at a perf diff, here's the top: +2.71% [kernel.vmlinux] [k] mod_node_page_state +2.22% [kernel.vmlinux] [k] iov_iter_extract_pages and these two are gone: 2.14% [kernel.vmlinux] [k] __iov_iter_get_pages_alloc 1.53% [kernel.vmlinux] [k] iov_iter_get_pages rest is mostly in the noise, but mod_node_page_state() sticks out like a sore thumb. They seem to be caused by the node stat accounting done in gup.c for FOLL_PIN. Hmm? -- Jens Axboe