From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8D8DC433F5 for ; Fri, 4 Mar 2022 14:51:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B54278D0002; Fri, 4 Mar 2022 09:51:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B02CA8D0001; Fri, 4 Mar 2022 09:51:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F15C8D0002; Fri, 4 Mar 2022 09:51:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 90C108D0001 for ; Fri, 4 Mar 2022 09:51:14 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 53EA6225CB for ; Fri, 4 Mar 2022 14:51:14 +0000 (UTC) X-FDA: 79206991668.12.F09B8DA Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf07.hostedemail.com (Postfix) with ESMTP id B94ED40004 for ; Fri, 4 Mar 2022 14:50:47 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id 15-20020a17090a098f00b001bef0376d5cso8146571pjo.5 for ; Fri, 04 Mar 2022 06:50:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=qGajYq/2Y8cBdDlqrjorvnqnZd0B5kqCZ5qkXRiChPc=; b=LoKymxMnUUd4Qg39UfUGbaGqi+9wFch08Xhwa4MiFfU34YUWHwInABhQbdzbKCViwD Gs5QT18FOd33txjBj2qHeIbU+MO+F3mgnnY23mjTk9n/seq5ITaqC4pW01PBl61EsYG0 wPKey6Pmg5+nWxN2qcrQDEY0KLt8MONsgAyOjhPnM9J9mda87YUGpcpQBduSKtFFd8Y1 +CeGLWR8OFy0fVq4ttuxxyzHmqmvkjGsdWFZBnJW3RCKn9ain2xDCEs8f0p93Rf3uIVi hQujSsxi+UVZ1aE35BtKU2aoRi4mOc8UJ8Yjm9FVv86wvT22sDcRjSyJWhOMXJwbI6Hu A0wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=qGajYq/2Y8cBdDlqrjorvnqnZd0B5kqCZ5qkXRiChPc=; b=IoZZx5sUIYRUVgl1LvaYjGXzPWIQllAnw3Smzpqc0EvYFzKDQZze1RgZpQqqukGHzS LAfIaufWL3IhVp5CYseJAuAsFUgiN1D5ZBm3snS77n4a9XZgvwr5ICXhxZ/8jQwPtK8T klIyL9mk+DZ5WimyQJupJP7/n3YusGZjoHahvjRlMc32RUD+IuXN3agUFJtZX9/b1G5Y pTFGxNYISzjr1CKGbgrJ6xdMz19twTG9oT067a7AkUD4QPe38y1awzRD46MOPIwHNWzT FfdHxElbnFCp/RIVwqOqTrIFWZkTWqJhH7U3jHOdl38hstjtMIrQvWekaGyJ/8mGBF0t 0E5w== X-Gm-Message-State: AOAM533BzZejL3OLkMkg8SKc3GVr0J692a21m2aWLUR3AguqioXqhWpF ofEVZfBepyqp/TmsKQQ0Y/4f0g== X-Google-Smtp-Source: ABdhPJwZaTifOscR/tZC+QEj0ArP9SQ5w03IwxALm43ULQDKIqMbnxqU4MINzWjzl2KhNzJK/4pPVg== X-Received: by 2002:a17:902:b60f:b0:14f:ee29:5ef7 with SMTP id b15-20020a170902b60f00b0014fee295ef7mr41377789pls.106.1646405446441; Fri, 04 Mar 2022 06:50:46 -0800 (PST) Received: from ?IPV6:2409:8a28:e6d:cc00:d089:89fd:5c33:f12? ([2409:8a28:e6d:cc00:d089:89fd:5c33:f12]) by smtp.gmail.com with ESMTPSA id a11-20020a056a001d0b00b004f4057fafe2sm5885040pfx.94.2022.03.04.06.50.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Mar 2022 06:50:46 -0800 (PST) Message-ID: Date: Fri, 4 Mar 2022 22:50:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [External] Re: [PATCH 1/2] kselftest/vm: override TARGETS from arguments Content-Language: en-US To: Shuah Khan , akpm@linux-foundation.org, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220227055330.43087-1-zhouchengming@bytedance.com> From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: B94ED40004 X-Stat-Signature: a5ps3xu31tkk1tapxx7iisgtoyngt6gh X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=LoKymxMn; spf=pass (imf07.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam07 X-HE-Tag: 1646405447-398300 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/3/4 3:17 上午, Shuah Khan wrote: > On 2/26/22 10:53 PM, Chengming Zhou wrote: >> We can specify which testcases to build using TARGETS argument, >> for example: make -C tools/testing/selftests TARGETS=vm, cause >> the ordinary assignment of TARGETS in Makefile will be ignored. >> So we need to use override directive to change that. >> >> Signed-off-by: Chengming Zhou >> --- >>   tools/testing/selftests/vm/Makefile | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile >> index 1607322a112c..0b330a5b1840 100644 >> --- a/tools/testing/selftests/vm/Makefile >> +++ b/tools/testing/selftests/vm/Makefile >> @@ -53,7 +53,7 @@ CAN_BUILD_I386 := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_32bit_progra >>   CAN_BUILD_X86_64 := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_64bit_program.c) >>   CAN_BUILD_WITH_NOPIE := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_program.c -no-pie) >>   -TARGETS := protection_keys >> +override TARGETS := protection_keys >>   BINARIES_32 := $(TARGETS:%=%_32) >>   BINARIES_64 := $(TARGETS:%=%_64) >>   > > Let's not override TARGETS - rename TARGETS in this file. > VM_TARGETS? Looks like Andrew has already added this patch to the -mm tree. I think both way is ok to solve this problem. Should I rename to VM_TARGETS and send another patch? Thanks. > > thanks, > -- Shuah