From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC7B5C47DDF for ; Fri, 26 Jan 2024 01:14:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6210C6B0089; Thu, 25 Jan 2024 20:14:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D1156B008A; Thu, 25 Jan 2024 20:14:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44A556B008C; Thu, 25 Jan 2024 20:14:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 34E0D6B0089 for ; Thu, 25 Jan 2024 20:14:02 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B2607A0EE4 for ; Fri, 26 Jan 2024 01:14:01 +0000 (UTC) X-FDA: 81719690682.03.5862C15 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf20.hostedemail.com (Postfix) with ESMTP id 1F9FC1C000E for ; Fri, 26 Jan 2024 01:13:57 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706231639; a=rsa-sha256; cv=none; b=H4s8giGwAwZPsy/OXmodtdZG92jTgFhPP36bJbEpH0fsswlPDJPXKn7ooB2I7EUrZqn5+j kjLnfPNpRup0WwJ81mzEn6sqdfSmTpBqLoxUiGmdY+gJ1Ysh4IceoCbM4ZuxbjK8VVwak/ K57gNqCt2I+UHeE5J8XoBH3HhHE7rws= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706231639; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RGPyx1HP4YxxrZvXXLHZE3HprLqaFv7n8rhaUMvzjOk=; b=HEt/Rz3jsvwgBMSAOsjtPpd+k5aRGUFNkEl9rD8xtBisRuJelVs4shG3aAyQLFbRMSz9CT 6rtDVaD1ihqgE0M4zugm13AYm+74r6K2x9AnQvogXWV0wolZhTlf7LOcQdNpGTWwa6aFxR PhBrO8yP6jCdYcubl1MtpCMC1tNEAQE= Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4TLfnW06SWzsWZs; Fri, 26 Jan 2024 09:12:47 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id EEA4818007A; Fri, 26 Jan 2024 09:13:51 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 26 Jan 2024 09:13:51 +0800 Subject: Re: [PATCH v2] mm/memory-failure: fix crash in split_huge_page_to_list from soft_offline_page To: Matthew Wilcox CC: , , , References: <20240124084014.1772906-1-linmiaohe@huawei.com> <6d3f4822-8bc1-1551-b088-0a6d4c13f049@huawei.com> From: Miaohe Lin Message-ID: Date: Fri, 26 Jan 2024 09:13:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1F9FC1C000E X-Stat-Signature: jjqwbqc1rx3drm449u55xnhgjag4ixrw X-HE-Tag: 1706231637-626937 X-HE-Meta: U2FsdGVkX1/SiWCF1WLuqeseWPnoq9QVGTh9mBPzAhuwbyhX0iQlSDLRAHnnDq4DcJ6Bl2mad9Ct925dOO6IVPkmHRH28FV2+G2fhM5FHB6zJ17vNn/hQC8nhMk6uejGy43gP8XPfOC8AaluSxhOHRRYi9N7Xdc5cQFcbrF5exj84MjqAWid96m9L11rcq2481/1lp/awgg/gLYBTzijllLQwdKcN7rwYPGNhX8tXEmcjUh610fDbRUZlYan75fGJz8t19s6A6JZJfQUPmTlbs3NPwvX5jP8A8CvInGCke5s6B00zZl0PZ9bvWbLs/E1hGXqtyCH2tgJTM+2XdFfW3xfl4N00R2mDBiCMRICmR4lzUKT8UWUAW834XBlXBdZN8xM3yK+NiCP2bdBqmMi8T/HBAY3Ee3srp5+VaG8UpjzK4MbsdeoP03bk0yA+BPqX4w0aACB4LRt0WGeym0J6XCMpd7ZgpLDFGUVX+4pkjNbgcGMGWqiXEr38td4J3OuSWYVWJr1uPRX29iTnBNqZmLZnsimJhaeGsUmQ8NLQLQekhvh7FWld2by3XKZUJJXJtHE2jQ4HvP9I3FwKBnHfQxZMOiczPFxBSeHqUVrzKzCUEEnOREWdOBdPJKJ1J3u+c+E7Nwf84NvcKKKu5Dnu3VaJH9T3lTtfvWPnzEAnw9NVThrvye25EXqvZ8MV2+8PGLOw3guGKqkyPYW+FrfLOk8FnKHUl2R5OBI2cKO5kYSORcHeK7qJaHKxD0CIBH3puklNy1BQJ8+mocOHogo0HfuSs4C4R3vOcqV908AU3O12SRBRn3ahzCZjdu9PhNDN0Ki6g+hsb3kU+jFNjQYY2et9OfgOj0bcM03gBozJbQmUERBvVunaamKxiSF6VEpOeLAN+dRjxDOEgQ3PbtlHPQoVi0U3jVBa/f1e6P9sdKGKGVpHjnpK6iFsSi8n2h5q4yCTHCnWKCoaeNcWpL TtKXuhoy MnnggrFHExS5h60II/5+zjrgr3palVs++QdB2jCKPtKTxTTmuSUXvep/mS1PwsSh9U7SY1PD9D++gAeEyGPlh9Kb1yUvjLHTyhJxxp+Cm57QBLaGlmMNFfHlL8DqnM7PAvMypKAsIcHAARuYpGUOOOlJdwlKlZ8zij82ylkCcYvUZghBiDngQaAJNZA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/25 22:22, Matthew Wilcox wrote: > On Thu, Jan 25, 2024 at 07:53:25PM +0800, Miaohe Lin wrote: >> On 2024/1/24 21:15, Matthew Wilcox wrote: >>>> Call Trace: >>>> >>>> ? die+0x32/0x90 >>>> ? do_trap+0xde/0x110 >>>> ? folio_memcg+0xaf/0xd0 >>>> ? do_error_trap+0x60/0x80 >>>> ? folio_memcg+0xaf/0xd0 >>>> ? exc_invalid_op+0x53/0x70 >>>> ? folio_memcg+0xaf/0xd0 >>>> ? asm_exc_invalid_op+0x1a/0x20 >>>> ? folio_memcg+0xaf/0xd0 >>>> ? folio_memcg+0xae/0xd0 >>> >>> I might trim these ? lines out of the backtrace ... >> >> Do you mean make backtrace looks like something below? >> >> Call Trace: >> >> split_huge_page_to_list+0x4d/0x1380 >> ? sysvec_apic_timer_interrupt+0xf/0x80 >> try_to_split_thp_page+0x3a/0xf0 >> soft_offline_page+0x1ea/0x8a0 >> soft_offline_page_store+0x52/0x90 >> kernfs_fop_write_iter+0x118/0x1b0 >> vfs_write+0x30b/0x430 >> ksys_write+0x5e/0xe0 >> do_syscall_64+0xb0/0x1b0 >> entry_SYSCALL_64_after_hwframe+0x6d/0x75 >> RIP: 0033:0x7f6c60d14697 > > Yes. I'd trim the sysvec_apic_timer_interrupt+0xf/0x80 line too. > These lines aren't actually part of the call trace. They're addresses > that the unwinder found on the stack but don't actually fit the call > trace. It puts them in in case they're helpful, but marks them with a ? > to indicate that they're probably not part of the call trace. I see. Many thanks for your explanation. Will update backtrace in next version. Thanks.