From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34073C433ED for ; Tue, 18 May 2021 20:49:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CBE1461355 for ; Tue, 18 May 2021 20:49:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBE1461355 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ACULAB.COM Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4C1828E0054; Tue, 18 May 2021 16:49:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 471A38E002F; Tue, 18 May 2021 16:49:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C5518E0054; Tue, 18 May 2021 16:49:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0140.hostedemail.com [216.40.44.140]) by kanga.kvack.org (Postfix) with ESMTP id EE67F8E002F for ; Tue, 18 May 2021 16:49:39 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 90112A8C8 for ; Tue, 18 May 2021 20:49:39 +0000 (UTC) X-FDA: 78155542878.07.280CD8B Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by imf04.hostedemail.com (Postfix) with ESMTP id D390178C for ; Tue, 18 May 2021 20:49:38 +0000 (UTC) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-154-NzcuNrSXNs2GIOJ9Fn180Q-1; Tue, 18 May 2021 21:49:35 +0100 X-MC-Unique: NzcuNrSXNs2GIOJ9Fn180Q-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 18 May 2021 21:49:34 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.015; Tue, 18 May 2021 21:49:34 +0100 From: David Laight To: 'Arnd Bergmann' , "linux-arch@vger.kernel.org" CC: Arnd Bergmann , Christoph Hellwig , Alexander Viro , Andrew Morton , Borislav Petkov , Brian Gerst , Eric Biederman , Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , Linux ARM , "linux-kernel@vger.kernel.org" , Linux-MM , "kexec@lists.infradead.org" Subject: RE: [PATCH v3 2/4] mm: simplify compat_sys_move_pages Thread-Topic: [PATCH v3 2/4] mm: simplify compat_sys_move_pages Thread-Index: AQHXS1wYCu76VfkYCU+t8Sv5x7/YH6rpt7nQ Date: Tue, 18 May 2021 20:49:34 +0000 Message-ID: References: <20210517203343.3941777-1-arnd@kernel.org> <20210517203343.3941777-3-arnd@kernel.org> In-Reply-To: <20210517203343.3941777-3-arnd@kernel.org> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=ACULAB.COM; spf=pass (imf04.hostedemail.com: domain of david.laight@aculab.com designates 185.58.85.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: D390178C X-Stat-Signature: rcszim3j3n71jzqfcg9c3hpmkq1rdsoh X-HE-Tag: 1621370978-486677 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Arnd Bergmann > Sent: 17 May 2021 21:34 >=20 > The compat move_pages() implementation uses compat_alloc_user_space() > for converting the pointer array. Moving the compat handling into > the function itself is a bit simpler and lets us avoid the > compat_alloc_user_space() call. >=20 > Signed-off-by: Arnd Bergmann > --- > mm/migrate.c | 45 ++++++++++++++++++++++++++++++--------------- > 1 file changed, 30 insertions(+), 15 deletions(-) >=20 > diff --git a/mm/migrate.c b/mm/migrate.c > index b234c3f3acb7..a68d07f19a1a 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1855,6 +1855,23 @@ static void do_pages_stat_array(struct mm_struct *= mm, unsigned long nr_pages, > =09mmap_read_unlock(mm); > } >=20 > +static int put_compat_pages_array(const void __user *chunk_pages[], > +=09=09=09=09 const void __user * __user *pages, > +=09=09=09=09 unsigned long chunk_nr) > +{ Should that be get_compat_pages_array() ? =09David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)