From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx135.postini.com [74.125.245.135]) by kanga.kvack.org (Postfix) with SMTP id A60496B0031 for ; Mon, 29 Jul 2013 18:26:38 -0400 (EDT) Received: by mail-pb0-f53.google.com with SMTP id up15so4491260pbc.40 for ; Mon, 29 Jul 2013 15:26:37 -0700 (PDT) In-Reply-To: References: <1375022906-1164-1-git-send-email-waydi1@gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----5DH60NOZLVSVISDZZB1G5WQONMJ8LF" Subject: Re: [PATCH 2/2] mm: page_alloc: Add unlikely for MAX_ORDER check From: zhouxinxing Date: Tue, 30 Jul 2013 06:26:58 +0800 Message-ID: Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes , SeungHun Lee Cc: linux-mm@kvack.org ------5DH60NOZLVSVISDZZB1G5WQONMJ8LF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit unlikely indeed makes this code more elegant, however, it's difficult to tell how much the performance will be improved. David Rientjes wrote: >On Sun, 28 Jul 2013, SeungHun Lee wrote: > >> "order >= MAX_ORDER" case is occur rarely. >> >> So I add unlikely for this check. > >This needs your signed-off-by line. > >When that's done: > >Acked-by: David Rientjes > >-- >To unsubscribe, send a message with 'unsubscribe linux-mm' in >the body to majordomo@kvack.org. For more info on Linux MM, >see: http://www.linux-mm.org/ . >Don't email: email@kvack.org -- Sent from my Android device with Gmail Plus. Please excuse my brevity. ------5DH60NOZLVSVISDZZB1G5WQONMJ8LF Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit unlikely indeed makes this code more elegant, however, it's difficult to tell how much the performance will be improved.

David Rientjes <rientjes@google.com> wrote:
On Sun, 28 Jul 2013, SeungHun Lee wrote:

"order >= MAX_ORDER" case is occur rarely.

So I add unlikely for this check.

This needs your signed-off-by line.

When that's done:

Acked-by: David Rientjes <rientjes@google.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

--
Sent from my Android device with Gmail Plus. Please excuse my brevity. ------5DH60NOZLVSVISDZZB1G5WQONMJ8LF-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org