From: zhouxinxing <xinxing2zhou@gmail.com>
To: David Rientjes <rientjes@google.com>, SeungHun Lee <waydi1@gmail.com>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH 2/2] mm: page_alloc: Add unlikely for MAX_ORDER check
Date: Tue, 30 Jul 2013 06:26:58 +0800 [thread overview]
Message-ID: <f529c247-704e-4e3a-bb57-888141808eeb@email.android.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1307291511020.29771@chino.kir.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
unlikely indeed makes this code more elegant, however, it's difficult to tell how much the performance will be improved.
David Rientjes <rientjes@google.com> wrote:
>On Sun, 28 Jul 2013, SeungHun Lee wrote:
>
>> "order >= MAX_ORDER" case is occur rarely.
>>
>> So I add unlikely for this check.
>
>This needs your signed-off-by line.
>
>When that's done:
>
>Acked-by: David Rientjes <rientjes@google.com>
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Sent from my Android device with Gmail Plus. Please excuse my brevity.
[-- Attachment #2: Type: text/html, Size: 1334 bytes --]
next prev parent reply other threads:[~2013-07-29 22:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-28 14:48 SeungHun Lee
2013-07-29 18:44 ` KOSAKI Motohiro
2013-07-29 22:11 ` David Rientjes
2013-07-29 22:26 ` zhouxinxing [this message]
2013-07-29 22:45 ` Dave Hansen
2013-07-30 0:36 ` Cody P Schafer
2013-07-30 0:41 ` Cody P Schafer
2013-07-30 1:20 ` Cody P Schafer
2013-07-30 16:43 ` Dave Hansen
2013-07-31 14:45 ` 이승훈
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f529c247-704e-4e3a-bb57-888141808eeb@email.android.com \
--to=xinxing2zhou@gmail.com \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=waydi1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox