From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1737EB64DD for ; Thu, 15 Jun 2023 09:22:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F34F8E0001; Thu, 15 Jun 2023 05:22:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07CEE6B0074; Thu, 15 Jun 2023 05:22:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5F378E0001; Thu, 15 Jun 2023 05:22:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D34E26B0072 for ; Thu, 15 Jun 2023 05:22:08 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7287580B5A for ; Thu, 15 Jun 2023 09:22:08 +0000 (UTC) X-FDA: 80904440736.17.C2AB526 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf04.hostedemail.com (Postfix) with ESMTP id 0AB2F4001B for ; Thu, 15 Jun 2023 09:22:05 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686820926; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=36T94F3bcCanJq/eOHW03iGdw7hqv1XTHvNgNzBveIY=; b=Mh+3iGWfecNPnav2f/A+zXBSaCFPwsuf1sU6XCNFa9uO9QbSiS9SszTRN4RqKB0MWrdLwm AluA36WKPydo9JIlxtReY+4GLgdYwCVwX2+uc8IK1pGnNwYwzqLtlcxzV4Y4YHW1FGHSXW tebCOxoq0OsBXwwnODrhlf+gbE3Z9Iw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686820926; a=rsa-sha256; cv=none; b=sMvK+P1lCfa00F1fhQHx7E2fQe7GQtuu4io4otovhhWurM8VyWxdKSr/QuJQQjla5ZIE+x OVrLMqiFS7LGsDAbKixubELxU87Hgg7LyjTSRYcDmgE0BOK/XoO46/VuJ/yKhPfmEe+vXX jRHiEuoE9a5kgQWu0Wxou9gwv05dRWM= Received: from kwepemm600020.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4QhcB744kVz18MPq; Thu, 15 Jun 2023 17:17:03 +0800 (CST) Received: from [10.174.179.160] (10.174.179.160) by kwepemm600020.china.huawei.com (7.193.23.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 15 Jun 2023 17:22:00 +0800 Message-ID: Date: Thu, 15 Jun 2023 17:22:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] memblock: use the helper macro for_each_zone To: Mike Rapoport CC: , , , , References: <20230612125102.1674568-1-zhangpeng362@huawei.com> <20230614114627.GW52412@kernel.org> Content-Language: en-US From: "zhangpeng (AS)" In-Reply-To: <20230614114627.GW52412@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.160] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600020.china.huawei.com (7.193.23.147) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 0AB2F4001B X-Rspam-User: X-Stat-Signature: sz3mondhfyih63rijejs67jgarth343o X-Rspamd-Server: rspam01 X-HE-Tag: 1686820925-37826 X-HE-Meta: U2FsdGVkX1/eKObsuy6hKp/OO0J1WDiGKR16kxMnFCt2SKIoFH02kugkcDgnxoHaZdvPKOvICEXdq3tVOMIcsRRWJeAoQ7E9RRXgm/eE79JmoSqy/Bk+IGxnCpW6CHX8ow7nLM/V8h4UE/XquMZ6x2RT/8WXwzQqI0/NmGFx9Lqs05WzXHuVjxiiovmDfWDZ6R/a2wJ+gBoWpGfpFHhnTG3XWmhTZ3m/I0hPPnoajpUKtOU+pOgOWFFYN7B+YAhA5PLrBtB9+IwzT0mpdbAuEk0NIUvVn8jXmR/24jUZb1+FqJd6S5fSjyiNox6ijUhNVxNBq+pNqq9Z2wnIcSmWYYxMpVtScGZyua0nNyh6gacyF0oDZcpoILZ+xYf/0UvKqt0POCpon7dPNjz4rGHtrGDWkaJCjSEbpEdVc2JWVpTs4cFVo7931xnp4SqfwkmZOejQI9P2Do9UUEZfpyRys6axiKu4m/SFIBOcuBdPqcCSnm4GKkI4jC9wFfp6MO0PzVUFWBTjvgd/zCLDby7U0Y6UfeRVSpXbimmVpxf1eoD3aSWZ6Q3ho85+T5qIIEBRWgbOrLDS9SB8nhzTnKh4QUt2Gt5/PPYOaGOmxs5KAfkjZQeNkOtNfdnMXcCCigo8J9Y88sqUHamTPqn9ob4FdMI6Yp2PMBGmVrtKdT94XiGbV1jmCWzblyitSFrmA8MUlnoz5crnJ/F17VZiNK/amXy5wxHruNiLsV5dKLbCtQ+tSzIUBg3yhOr3sRBKQSu3pPILAWup/d4JRmfaFAm8at9ct1S6ZV4DX1xk49FibZEeZw+fEGuC0RUFQstZ0TAOyO96Dm2dEftscIrWZU8/hCQq1AGI6ZeCwJAgygbbiYlFAoYywSLl2aMLbi5iT0A5unGdjX9mgdijKfnOkzns5CHKaZ47LYY/mfjpTZCLWMhnBuMDNd/NRy3FR8zrsJlsDbo2JU7jNencq4iBeCL WcVj3Z8r BLoP31wVZa8JjfglQl24Pbs9itoau5t07Nx5L4A/NooUL8LNvBFPcOg3XFx+OxvrD8+o+z9nhJSfAqLLZ98smXTIK9cB3auQqr9AeeAfaKyBVaqqheqLToRfkhLH0jaX2zrL2h2aQ0yuiqc9Ij0nDcI+H7W1yiFRhQge1QKKlWJYyrQc+AsCoawN1WBlfjRbbEI3B X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/6/14 19:46, Mike Rapoport wrote: > On Mon, Jun 12, 2023 at 08:51:02PM +0800, Peng Zhang wrote: >> From: ZhangPeng >> >> Let's use the helper macro for_each_zone to iterate over all memory >> zones and reset the node managed pages. After that, we can remove the >> unused function reset_node_managed_pages. > Are you sure it's safe to use for_each_zone() in all users of > reset_all_zones_managed_pages()? > Thanks for your review. Using for_each_zone() is indeed unsafe in some users of reset_all_zones_managed_pages(). Please ignore. Thanks, Peng >> Signed-off-by: ZhangPeng >> --- >> mm/memblock.c | 14 +++----------- >> 1 file changed, 3 insertions(+), 11 deletions(-) >> >> diff --git a/mm/memblock.c b/mm/memblock.c >> index da4264528e1e..af552604c3fb 100644 >> --- a/mm/memblock.c >> +++ b/mm/memblock.c >> @@ -2122,23 +2122,15 @@ static unsigned long __init free_low_memory_core_early(void) >> >> static int reset_managed_pages_done __initdata; >> >> -static void __init reset_node_managed_pages(pg_data_t *pgdat) >> -{ >> - struct zone *z; >> - >> - for (z = pgdat->node_zones; z < pgdat->node_zones + MAX_NR_ZONES; z++) >> - atomic_long_set(&z->managed_pages, 0); >> -} >> - >> void __init reset_all_zones_managed_pages(void) >> { >> - struct pglist_data *pgdat; >> + struct zone *z; >> >> if (reset_managed_pages_done) >> return; >> >> - for_each_online_pgdat(pgdat) >> - reset_node_managed_pages(pgdat); >> + for_each_zone(z) >> + atomic_long_set(&z->managed_pages, 0); >> >> reset_managed_pages_done = 1; >> } >> -- >> 2.25.1 >>