From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 527CDC7EE23 for ; Thu, 8 Jun 2023 14:24:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 841BD6B0071; Thu, 8 Jun 2023 10:24:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F1B98E0001; Thu, 8 Jun 2023 10:24:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B8DF6B0075; Thu, 8 Jun 2023 10:24:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5A5FA6B0071 for ; Thu, 8 Jun 2023 10:24:23 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0F4BF1402C4 for ; Thu, 8 Jun 2023 14:24:23 +0000 (UTC) X-FDA: 80879800806.30.F82B67E Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf03.hostedemail.com (Postfix) with ESMTP id 14EDE20004 for ; Thu, 8 Jun 2023 14:24:19 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="b/nIIt+F"; spf=pass (imf03.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686234260; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/uJR2Sj5Mv6OnYw1x9UaPvwX8FwwLLDsTyiDOPPFMqY=; b=YbBpv8Gk4rWVuQXVcMkANdRALASD0gCcq1dMaTvKzynVp0wblXSbogV79/5yWqxEegTCyl g57BkqXCeO5ctyYR6VJWyRT0dURL1FLZs1ETmeiSM/9DZszQLYppJKqYDWH4kGjhBkj4k8 Ul0hfXQ6KlnEwW5NxOc6DvIfpMk5APE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686234260; a=rsa-sha256; cv=none; b=opnNFhUxfeSjhMJhMe28KRNT0j6JKh1zz1z3C9hhonMQArTYZlkd/UFkvjs0c0KvQGTWQV q92yOqBDva5x0xM2m2b+R1GMU/4852KVOxyYH9ZMjwEA7zzrwlJDiibRek2c4COVJrAdYR khP23ragCGJdvy3ncSu3SdvQMDrfAEo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="b/nIIt+F"; spf=pass (imf03.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686234260; x=1717770260; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=SG3mTD2g3/LZaDpzuaBaKk2YaeV+yYIzM94X6+j2SrM=; b=b/nIIt+Fr/ZBBWEfAiSlhUxJDsck6+OYPli2ytDJ6C1pZsszIC/jfAwQ WtFtGTmomtxB66MQyv4ik19h+qk1x42iQNKtz4+s2lgjnQmbIBrfnBEZo 5Ybf8D0gRei8RbjuVnYgDApS5jS7dHUdaRiSpvBvLaSH/0UhhX19OQ+0m NlwXP+71079AI96Uob1Fc5GjVlrLltaedLw7zw8tQaJszrNAkR39C6Zqb 3+xph2/apQm+pYGqK1aiL6VU5XDro+MzKt9noZMvQsSFw/V7+Wl3NQTql SH60u4np66MKUJFWPSKFn24UEYFJGtwkd7fFId6HPlcAvvt6yyOA9VJDA Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="423183126" X-IronPort-AV: E=Sophos;i="6.00,227,1681196400"; d="scan'208";a="423183126" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2023 07:05:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10734"; a="709998313" X-IronPort-AV: E=Sophos;i="6.00,226,1681196400"; d="scan'208";a="709998313" Received: from swalker-mobl1.amr.corp.intel.com (HELO [10.209.22.184]) ([10.209.22.184]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2023 07:05:49 -0700 Message-ID: Date: Thu, 8 Jun 2023 07:05:50 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v11 05/20] x86/virt/tdx: Add SEAMCALL infrastructure Content-Language: en-US To: "Huang, Kai" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "Luck, Tony" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "kirill.shutemov@linux.intel.com" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "tglx@linutronix.de" , "Yamahata, Isaku" , "linux-mm@kvack.org" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" References: <92e19d74-447f-19e0-d9ec-8a3f12f04927@intel.com> <7fa434207dfbe2a88ac7f6f6830d2f8a0f31a253.camel@intel.com> From: Dave Hansen In-Reply-To: <7fa434207dfbe2a88ac7f6f6830d2f8a0f31a253.camel@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: kcwjfs3gcrznkmuhtdrjr6enssegm5xr X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 14EDE20004 X-Rspam-User: X-HE-Tag: 1686234259-216359 X-HE-Meta: U2FsdGVkX1+uaoG7+UT6YlLkhZx/3eEtOjdkLL8FRzwhlhAw0CCPFnJfcCPReRZkeozV4MapDRHQOWwDMLN/ArqbRqwSu+x/njXj4Nd9XDn7EezOHVVb5jQsTR2VQd7RgLSc6rFJgiRk18yExzEBUfuhJMuiAjmdcFZdhYpjO+iDRzRlYhaIFHxe8GGCH1lIy6zrDY/2nMnBz9nK4EqFC0ZT9d+R8EOeHWP4o03ddHszAtFEeIEOPq+CBWIO1nP27R6tvWWysc88XzfDVA1VN0NIS3N+MbnInlMTgxj6pHEsACB5Bu3tiOwHTTs4P5VNfyk+9OeeIcbl8Lc//m3xRZAojvdJ4qBC2mQXKQwMKgq9m+Ctx/CoGbhEF+tKZwvXr0LNyfV0YS39654HLRVJ/WqBHCHPm3tNh/DkQNkyrN+P/SVzm5UuyhZMI+a6nVEJ9UCf5EXkjL3MdeVZFRIqanW7gYGFW902NTFCv33tVuw+88ghfHqothRorIkTXNiRGb7Q9P+7RWcV8TEz0OqwQUIYSU2p04ueNrhReGCXvZQPS2tWR5DozmnrSByLS0JjHNz961uURotIwW8me07Hy826IyyCwh+7rpPJT79POqXEEgAfGT+1Jnq4ERsxb1e3sd6/6OwWsTotzzMk7r3hCIP8mj4NrcfIXfKQaP+UmXVmax6yye2JdoKgYv9+xS38CWshgZfDAcVEZdCmToEMiFOs3dbUDKA6fzuzGmJLq0Tt3x4bX1xYPnndCc3RbrPEiDKwrjhiDffq1elAcZWcG/TYkr4p3Y2OIBZVjmwrDfAwQhetlrms/QWR2BrOkXREHZfdmv+i7LzUWsqmZOlBfcwWEG8246qyiBy8MUTj110kTY3juMtTl5LDBuDBMmybnp2i5F+wBCv0ElmN0saHLqyJYMoTqHsQhvOhGW+fWClpym8nK0HcHG6vuonWawcEP18bM1QIu24Nr/XL3SJ 9sh4KuHd vcUmjMmnTc8FeRTVPOAd8Qij1Gj4ePm60zgnpbXxdEGKd/AaoB6K50mvjYgtcXojwzDEAA8Wul64Lv7Qggn+uz78guhYTJLt0jztTEIy5Pi10EheBfW0FCY91unStfxK2FH45pvmxKBdghIPb8Pn+VNa6iDDMSyxwzTR7d3J5KSsLJ76X3LPTR9FZhtUDYjMvp5wX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/7/23 15:56, Huang, Kai wrote: > It's not just for the "BIOS buggy" case. The main purpose is to give an error > message when the caller mistakenly calls tdx_enable(). It's also OK to oops when there's a kernel bug, aka. caller mistake. > Also, now the machine check handler improvement patch also calls SEAMCALL to get > a given page's page type. It's totally legal that a machine check happens when > the CPU isn't in VMX operation (e.g. KVM isn't loaded), and in fact we use the > SEAMCALL return value to detect whether CPU is in VMX operation and handles such > case accordingly. Listen, I didn't say there wasn't a reason for it. I said that this patch lacked the justification. So, stop throwing things at the wall, pick the *REAL* reason, and go rewrite the patch, please.