From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2AFCC001DB for ; Sat, 12 Aug 2023 11:45:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61FEC6B0078; Sat, 12 Aug 2023 07:45:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CFF56B007B; Sat, 12 Aug 2023 07:45:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BF1A6B007D; Sat, 12 Aug 2023 07:45:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3D6096B0078 for ; Sat, 12 Aug 2023 07:45:19 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 12A6012050C for ; Sat, 12 Aug 2023 11:45:19 +0000 (UTC) X-FDA: 81115271958.04.3DAAEBC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id C383940013 for ; Sat, 12 Aug 2023 11:45:15 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SFc4VfVV; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691840715; a=rsa-sha256; cv=none; b=TcL4jQAeUUvpmmvwpTlD+8RrJ2okyCobOosySXYHBG1uYeFyeDmbZPtR/rrjFYO1QU5Alw 3gRobDLu3tSYvF8DznD5X6Oztehse2Bi7V6ioq42EgLchkRJ3LoQDih/xMFI4Urm2qADgF jQUF1z7+DMBzbVR9R7dR6c7LU8AreKM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SFc4VfVV; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691840715; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=92NxzeAoTDOFNb9+0xk9kzaodnieNGMj4J9O3ZVx+lM=; b=A6fpILXXB9o70H2uZWbv6zXEb+HtsaB8MyLD2BQ0v/RakVpOeI1ICGugGzOuLRHKLTV87Q DKgEsoMeHTdz/U4D5rgQebjMVCkcuDxUZVIA4Tf8hQETwIUE7fLyZhSSoa50ZiWL/ThrBp FEcRzxwYhb5OeIlKwThVsuxWWdUERNI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7962660BFF; Sat, 12 Aug 2023 11:45:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74B10C433CA; Sat, 12 Aug 2023 11:45:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691840713; bh=ROOEmh24vfpoOFBtgUeWYuT6gwjVQp4jttc7XkiPJYw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=SFc4VfVVrOPAjE8tTDB+t8KMlWgzVhkpMJAhtPb5wqa5yW9M0DP7sG6CDSGFzLM5C KMbwxzjnbaKFv7gir7WYU+wlcI/U3noF+Ta4bbXv/RveJKBSUpRzTKcgk9X79xz9Hr ejLXh08WBlHyi2u0WaQKrAMCA/NUEtfGiuv5xszOglUv+xVQPUCbpH6P4yIX49Utf9 TWtdzIephtODICRAQUNABhHNGtlikMXdgsCiZfkrHX8zVpGgYWqbWiTTd9azVOBhm2 bW9ioG+JdIxaWGfUCy3vroRnRuciEIaqPJiAd7Z4kiKJnui1avdOA44cfmpioeCBqo N1ipE+wnhOZDw== Message-ID: Subject: Re: [PATCH net-next 3/6] sunrpc: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage From: Jeff Layton To: David Howells , netdev@vger.kernel.org Cc: Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chuck Lever , Trond Myklebust , Anna Schumaker , linux-nfs@vger.kernel.org Date: Sat, 12 Aug 2023 07:45:11 -0400 In-Reply-To: References: <20230609100221.2620633-1-dhowells@redhat.com> <20230609100221.2620633-4-dhowells@redhat.com> <104f68073d00911668ed6ea38239ef5f1d15567d.camel@kernel.org> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C383940013 X-Stat-Signature: 9y6j6mopr4ofnbgztxawbtb8e6rzfqan X-HE-Tag: 1691840715-709232 X-HE-Meta: U2FsdGVkX1/FSikT10ijPYtczPYfUMX4o6YLYYT/mA+tyGCCcWb1xKz7fjg8kZi0yKp7Wn+0lfd89CwBRRZcYjGcF3k3U/5yjcIKY4rAyTeMyt5FPxK3JXS4LqJAb/GhiTxH8RnYAGYT/won9m1Oi28NldkBP8cMdNU8roUAZ5k/mFsw33SMnyW0vBFQhMUzwx7mFI5PzgUzOn9DQMUndwF4tgUnIqBbaq0V7pP4AnPnKtA4g5wmN0b1OX657duokfrMFcMWq3eon8jnkCkGFCkOhDN6X53oFv8KOU6FHkSuSckljQbhJ2zUThyoGZbDq8Z+MmlHC/xqMeEnq3JN5hk+qDdCO4J3iCLBQc4bGdSUxkk0TJhYtRo4ipaGUsv4GZH3B/dobHZS+BznrxuE5EjLbWMmQRsd8zM4GvH0SuJbhfTQzusj6MDG7+h036adx2CCVPJHRs1Lpm4BjVlC7LZreUvReRr1CIejwGDhfNhAnXxUWwy9YdsFWcWuqwfHyHDCiZxDRvRRG+pAMWFh7jwhOlGFek+rofJc3SsJ5YWRaQkRUcC3YCaWT+CTGR3M0fe+UHmnBxYQDuDvU8/On/IIliNA8ICuR4N8GWy60b24pCvVrxLlfCEksFK10PoTgEh3nFCMdF63TrBToZU0eXAR3LzwGj50BeRdglGmHntJd6fO+8/r1qlSymJmUufn9KuCoEu7TX1vpPO2bBrpsjOQd1oXvqkPvMKa0EMedGrPpVbEJLQsi7901He7omy8SBAPftNV5z+bV6my7cQ7RZUyVsq7OzjeRTK5U7Cw+p0hqXzHvQsAVP0YC3IpKRnLCizdNr0CNr+VX4FXz79i8yUkHrkdQze+vXvqUhven7M0hROnYZj3bOcsvaNCBK7UVSvsqZtkdM2Wt4QCG/+KpSlvXlYZpu1I7HZ1yDydz57eUyXd8kFZCaL3zEaBcMz3/aCiAVK91I0DmXHVCEK Gnp+Xv7V AO2ruTxXAvPPc5Ki7pTgSJ2QJSO1b/GbsgskHINnEr0+UyHIYrojcPCqa5r9TudZKi5DC8vQgFmhjThWwW9j0GMmw5E8/gEOqCjVIRmjkHeUU3yOzHQ5HGBwqEzfxGPM6/hiLutfBCk5i+7fxC+dN5uz14UR7ZiurWxuAF3jD2hdmJL7k7aMblMxq7mUeflSWyB82oOOLKuSK3k5Hjnf0Zsq3bCt1PNO7DIVjAYCPOQdqEbo6XSrN/mup1GB6I/wlDUT23X4D9zZR0Dje1Vaa9X5X7zGILvxpz/yaAS4aZZd/+DNz9J7mVQ0Lir/izcDE2Th03Vf9PFB4elQ9/WcY+gDFC1Vxu8765Ksz6tRqnisHrTMvbv20ZLMR9cpo3dDqytHgx/CaDMHiX2tkVJifjYa2q8T2aZJmBJIgZRv3UUhzkrjsEEgNLKaEAHlKMyy53ryEs4LEi/4ECxHSLtEsw35S63O1Tj3NCPNCIerHTsYKvUOPhXy6V8rMxjs8KXKJc8bLtkbJH2YZ/5lW0pMF+RRqaCf537ymS9FaQiYnQS1X1jzsROXrgoASIDKjzkw2K1XOirRDI2HK8x5w404DglR5YQduWMOEQR9ja8qStATqHBHjuny435uTkg51QCPJITaOEmIuBLwiyQrWydh1jS0lHBuSVoGxEVnr98OJTRmxCYFGb/dK4GJHGiI3O1+Zr1eklB0lZfIAjpzgoLB/RYKSoQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2023-08-11 at 19:07 -0400, Jeff Layton wrote: > On Fri, 2023-08-11 at 18:50 -0400, Jeff Layton wrote: > > On Fri, 2023-06-09 at 11:02 +0100, David Howells wrote: > > > When transmitting data, call down into TCP using sendmsg with > > > MSG_SPLICE_PAGES to indicate that content should be spliced rather th= an > > > performing sendpage calls to transmit header, data pages and trailer. > > >=20 > > > Signed-off-by: David Howells > > > Acked-by: Chuck Lever > > > cc: Trond Myklebust > > > cc: Anna Schumaker > > > cc: Jeff Layton > > > cc: "David S. Miller" > > > cc: Eric Dumazet > > > cc: Jakub Kicinski > > > cc: Paolo Abeni > > > cc: Jens Axboe > > > cc: Matthew Wilcox > > > cc: linux-nfs@vger.kernel.org > > > cc: netdev@vger.kernel.org > > > --- > > > include/linux/sunrpc/svc.h | 11 +++++------ > > > net/sunrpc/svcsock.c | 38 ++++++++++++------------------------= -- > > > 2 files changed, 17 insertions(+), 32 deletions(-) > > >=20 > >=20 > > I'm seeing a regression in pynfs runs with v6.5-rc5. 3 tests are failin= g > > in a similar fashion. WRT1b is one of them > >=20 > > [vagrant@jlayton-kdo-nfsd nfs4.0]$ ./testserver.py --rundeps --maketre= e --uid=3D0 --gid=3D0 localhost:/export/pynfs/4.0/ WRT1b = =20 > > ************************************************** = = =20 > > WRT1b st_write.testSimpleWrite2 : FAI= LURE = =20 > > READ returned = = =20 > > b'\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x= 00', = =20 > > expected b'\x00\x00\x00\x00\x00write data' = = =20 > > INIT st_setclientid.testValid : PAS= S = =20 > > MKFILE st_open.testOpen : PAS= S = =20 > > ************************************************** = = =20 > > Command line asked for 3 of 679 tests = = =20 > > Of those: 0 Skipped, 1 Failed, 0 Warned, 2 Passed = =20 >=20 > FWIW, here's a capture that shows the problem. See frames 109-112 in > particular. If no one has thoughts on this one, I'll plan to have a look > early next week. Since Chuck's nfsd-next branch (which is based on v6.5-rc5) wasn't showing this issue, I ran a bisect to see what fixes it, and it landed on this patch: commit ed9cd98404c8ae5d0bdd6e7ce52e458a8e0841bb Author: Chuck Lever Date: Wed Jul 19 14:31:03 2023 -0400 SUNRPC: Convert svc_tcp_sendmsg to use bio_vecs directly =20 Add a helper to convert a whole xdr_buf directly into an array of bio_vecs, then send this array instead of iterating piecemeal over the xdr_buf containing the outbound RPC message. =20 Reviewed-by: David Howells Signed-off-by: Chuck Lever I'll follow up on that thread. I think we may want to pull this patch into mainline for v6.5. --=20 Jeff Layton