From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37705ECAAD5 for ; Mon, 5 Sep 2022 07:33:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CD18801B5; Mon, 5 Sep 2022 03:33:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87CC1801B3; Mon, 5 Sep 2022 03:33:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 743BB801B5; Mon, 5 Sep 2022 03:33:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 62478801B3 for ; Mon, 5 Sep 2022 03:33:17 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C0EF9406A1 for ; Mon, 5 Sep 2022 07:33:16 +0000 (UTC) X-FDA: 79877215992.01.542B9ED Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf14.hostedemail.com (Postfix) with ESMTP id 46836100052 for ; Mon, 5 Sep 2022 07:33:16 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C962238779; Mon, 5 Sep 2022 07:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1662363194; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=39bgkAvs9u3id1sAAJvSO5eKLLioMenaUUj0S5kesmo=; b=MvNrGdBdgkHVGCownMmnvspVKGc7or3wuKuZUQFzAnte2gJ7ZGqL2ZXmohsnYwCxMkKgJ+ hnKS2oFWl8zp+cqfCQ5NO3vpm3AIGz4qU0fplToAS5cXbH1x1OcRoeOIIYx+mxjydfHZRp oBhwxztL6DGcqbz17tQqr8RXHiiUBFk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1662363194; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=39bgkAvs9u3id1sAAJvSO5eKLLioMenaUUj0S5kesmo=; b=2PBBExInd9LrA1vZbCEQnlAsHffcz2XQJ8zQA4rZyAtgIFNSjk6KncAuDOOU4ouz2RtQEu XUNZpnks5IbxWJBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 90BAB13A66; Mon, 5 Sep 2022 07:33:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id V5OZIjqmFWMCcQAAMHmgww (envelope-from ); Mon, 05 Sep 2022 07:33:14 +0000 Message-ID: Date: Mon, 5 Sep 2022 09:33:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v4 1/4] mm/slub: enable debugging memory wasting of kmalloc Content-Language: en-US To: Feng Tang Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Dmitry Vyukov , "Hansen, Dave" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Robin Murphy , John Garry , Kefeng Wang References: <20220829075618.69069-1-feng.tang@intel.com> <20220829075618.69069-2-feng.tang@intel.com> <8ff805f4-76ae-fc0f-424f-4d230c08285e@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MvNrGdBd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2PBBExIn; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662363196; a=rsa-sha256; cv=none; b=GJ4pJNI/roeGjG7L0+SGSvgeEwSxp19N2MRMwt6enTCNKBGOkV16Wm5xtN2AYZJIY/l/0q cKDhji4HjEP4iJD7JnVcoC1KhU2hvcD/P0D95IP+i24L9TEMRgX/jSCt62E+7niWNgV2C1 qY8lFFv6oFXC746bfbVDb0A6huzmp3g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662363196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=39bgkAvs9u3id1sAAJvSO5eKLLioMenaUUj0S5kesmo=; b=lzwk8S15d2AMfzzt3s+BkRfTHVOG6TtURpJ882ye9hZ59GL4YkkkMiS9HDpEuVqN725uoq LZJk6SX3dRCQEapm8gtTOac7n4CThoJ7KTDvQjnbIXg6wXKempXFJD4qW57i+GEnSQgo84 a7XWghBcm3Tlx8ZkNEAL7A60Cy1pHvM= Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MvNrGdBd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=2PBBExIn; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspamd-Server: rspam06 X-Stat-Signature: ko1wherq859fewrz5nqbpgjc3msyn59k X-Rspam-User: X-Rspamd-Queue-Id: 46836100052 X-HE-Tag: 1662363196-134822 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/5/22 09:06, Feng Tang wrote: > On Mon, Sep 05, 2022 at 02:29:51PM +0800, Vlastimil Babka wrote: >> >> How about get_partial() instantiates an on-stack structure that contains >> gfpflags, ret_slab, orig_size and passes pointer to that to all the nested >> functions. >> >> Would be similar to "struct alloc_context" in page allocation. >> Something like "struct partial_context pc"? > > Yep! This would make the parameters passing much tidier. Will try > this way. > > More aggressively is to also embed the 'kmem_cache' parameter into > it, but this may make the code look ambiguous. That one is used a lot everywhere, so it would be tedious to dereference it from a struct, and also might be a bit better code if it's in a register. > Thanks, > Feng > >