From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2F77C433EF for ; Thu, 14 Oct 2021 17:43:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 44B7A61056 for ; Thu, 14 Oct 2021 17:43:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 44B7A61056 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=virtuozzo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 707F1900003; Thu, 14 Oct 2021 13:43:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B705900002; Thu, 14 Oct 2021 13:43:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57FCA900003; Thu, 14 Oct 2021 13:43:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217]) by kanga.kvack.org (Postfix) with ESMTP id 48E0B900002 for ; Thu, 14 Oct 2021 13:43:23 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 05EFA3016E for ; Thu, 14 Oct 2021 17:43:23 +0000 (UTC) X-FDA: 78695764686.11.6EA75AA Received: from relay.sw.ru (relay.sw.ru [185.231.240.75]) by imf25.hostedemail.com (Postfix) with ESMTP id 0B1CCB00008E for ; Thu, 14 Oct 2021 17:43:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Content-Type:MIME-Version:Date:Message-ID:From: Subject; bh=eD7O+RRWLIkfKyTJ6TKMyILhSbZVJ9w0wV/dWtK5Dv0=; b=chOijwLa4Moa5XyKb NTr/9oJ/r8pthIDIG2J4jg3zwc7oEUg3K1Dt4kuMmIvnnpl51iX5bHSlyA5r+UStbj4vPx3i5rW5c VjuKA6U1viK2KmSz8Wf01Tb+ZwUo2NgiL0niYCBDTJ0/h5mPerexOJJ9uBOLSGG2iF6zgUWCtXCsc =; Received: from [172.29.1.17] by relay.sw.ru with esmtp (Exim 4.94.2) (envelope-from ) id 1mb4lB-0062ie-69; Thu, 14 Oct 2021 20:43:17 +0300 Subject: Re: [PATCH] memcg: page_alloc: skip bulk allocator for __GFP_ACCOUNT To: Johannes Weiner , Shakeel Butt Cc: Michal Hocko , Mel Gorman , Uladzislau Rezki , Roman Gushchin , Andrew Morton , Cgroups , Linux MM , LKML References: <20211013194338.1804247-1-shakeelb@google.com> From: Vasily Averin Message-ID: Date: Thu, 14 Oct 2021 20:43:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=virtuozzo.com header.s=relay header.b=chOijwLa; dmarc=pass (policy=quarantine) header.from=virtuozzo.com; spf=pass (imf25.hostedemail.com: domain of vvs@virtuozzo.com designates 185.231.240.75 as permitted sender) smtp.mailfrom=vvs@virtuozzo.com X-Stat-Signature: aufop5566bxc9ucbt6bk1xkjtsp8xuuw X-Rspamd-Queue-Id: 0B1CCB00008E X-Rspamd-Server: rspam01 X-HE-Tag: 1634233400-879658 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.10.2021 18:23, Johannes Weiner wrote: > On Thu, Oct 14, 2021 at 08:01:16AM -0700, Shakeel Butt wrote: >> Regarding xfs_buf_alloc_pages(), it is not using __GFP_ACCOUNT > > It probably should, actually. Sorry, somewhat off-topic, but we've > seen this consume quite large amounts of memory. __GFP_ACCOUNT and > vmstat tracking seems overdue for this one. If this will be required, you can use [PATCH mm v5] memcg: enable memory accounting in __alloc_pages_bulk https://lkml.org/lkml/2021/10/14/197 As far as I understand it will not be used right now, however I decided to submit it anyway, perhaps it may be needed later. Thank you, Vasily Averin