From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB525C4332B for ; Thu, 19 Mar 2020 02:06:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 822272071C for ; Thu, 19 Mar 2020 02:06:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 822272071C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 168FA6B0005; Wed, 18 Mar 2020 22:06:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 119DE6B0008; Wed, 18 Mar 2020 22:06:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02E356B000A; Wed, 18 Mar 2020 22:06:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0146.hostedemail.com [216.40.44.146]) by kanga.kvack.org (Postfix) with ESMTP id DC3EC6B0005 for ; Wed, 18 Mar 2020 22:06:37 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8997A181AEF1A for ; Thu, 19 Mar 2020 02:06:37 +0000 (UTC) X-FDA: 76610472834.24.grade32_56e8cdced040d X-HE-Tag: grade32_56e8cdced040d X-Filterd-Recvd-Size: 3298 Received: from smtprelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Mar 2020 02:06:37 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id D02E2182CED28; Thu, 19 Mar 2020 02:06:36 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: month39_56a2ada6b4e5c X-Filterd-Recvd-Size: 2114 Received: from XPS-9350 (unknown [172.58.27.183]) (Authenticated sender: joe@perches.com) by omf13.hostedemail.com (Postfix) with ESMTPA; Thu, 19 Mar 2020 02:06:35 +0000 (UTC) Message-ID: Subject: Re: [PATCH -next] mm/hugetlb.c: fix printk format warning for 32-bit phys_addr_t From: Joe Perches To: Randy Dunlap , Linux MM , Andrew Morton , LKML Date: Wed, 18 Mar 2020 19:04:43 -0700 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2020-03-18 at 14:33 -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Fix printk format warnings when phys_addr_t is 32 bits, i.e., > CONFIG_PHYS_ADDR_T_64BIT is not set/enabled. [] > ../mm/hugetlb.c:5472:73: note: format string is defined here > pr_warn("hugetlb_cma: reservation failed: err %d, node %d, [%llu, %llu)", > ~~~^ [] > --- linux-next-20200318.orig/mm/hugetlb.c > +++ linux-next-20200318/mm/hugetlb.c > @@ -5469,8 +5469,10 @@ void __init hugetlb_cma_reserve(int orde > 0, false, > "hugetlb", &hugetlb_cma[nid]); > if (res) { > - pr_warn("hugetlb_cma: reservation failed: err %d, node %d, [%llu, %llu)", > - res, nid, PFN_PHYS(min_pfn), PFN_PHYS(max_pfn)); > + phys_addr_t begpa = PFN_PHYS(min_pfn); > + phys_addr_t endpa = PFN_PHYS(max_pfn); > + pr_warn("hugetlb_cma: reservation failed: err %d, node %d, [%pap, %pap)", > + res, nid, &begpa, &endpa); You might correct the odd use of an open bracket then close parenthesis and add a new line too Perhaps: pr_warn("%s: reservation failed: err %d, node %d, [%pap, %pap]\n", __func__, res, nid, &begpa, &endpa);