From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98915EB64DA for ; Tue, 4 Jul 2023 17:58:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34FDD2800A6; Tue, 4 Jul 2023 13:58:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D83A280096; Tue, 4 Jul 2023 13:58:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 179652800A6; Tue, 4 Jul 2023 13:58:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 00D6B280096 for ; Tue, 4 Jul 2023 13:58:13 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CFE3F1A024B for ; Tue, 4 Jul 2023 17:58:13 +0000 (UTC) X-FDA: 80974688466.08.0D80DD8 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf25.hostedemail.com (Postfix) with ESMTP id 0008FA0006 for ; Tue, 4 Jul 2023 17:58:10 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="HMkq/TKt"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of rientjes@google.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688493491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CtDTa/zSYu1BtyXYBgWZdAlFvHTcMeojuniPxpUE6tA=; b=53cUtWBlyBxCPK7WkbGzDeTCG/Ytsf35cA2I6qyWqujg6SNCVXMlczf3GM0IgKsYH8K/D+ bwXVEu/9GG4m129g3BY6lHuxZkfQM/TMbVs5CVgGkC5alK3+PaGu71liL5LZLQAdNJ0i21 RDQALqkr9ZsjgfbadADtCDF5HnWvGJc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="HMkq/TKt"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of rientjes@google.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688493491; a=rsa-sha256; cv=none; b=bwjtGFmP8mhTysH0RH4CcsdLoP5NRQSsmcsOxdThtXLpa1KsyaqkJHu+0RScw3XWVni4I+ 5Xp6MYRZh2sKqX4LaXzVGbhtVbS+Ob79MTbs6zOKSgUvgeXKe4BVykwDPjtMOH2ZuwOJ9e CvVm++dnyxNhsT3uk5/JUUYh0vTpXo8= Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1b82afd519fso513155ad.1 for ; Tue, 04 Jul 2023 10:58:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688493489; x=1691085489; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=CtDTa/zSYu1BtyXYBgWZdAlFvHTcMeojuniPxpUE6tA=; b=HMkq/TKthPMoIlp8Xt1Kp+9IvRlxP2uVxW94fU1Rs1XeFolcrAwGpkhoHBhuROkt2x twdybnJM+tOmScV6iQRFKO8oZj992lBbu6CxZQuUyR+hDvab/6a5DsIxVbBjG2FUnCG/ 29UyYReZ9+xaUpv1bdXU7bM9eCLonxHp8wWgFzm+Vz3PHZ9pMKj1lXwp7KI5kTxO7hoI K2EXoPEIM1nuKW9pAss/7qb9RvajvevvxIBQAFqfNUALVdhY/W9P/lIaG4PlifV4l99l FX0lh+GMpIqKXra2FJt0BIF8lK2qX++XFi+55Q+5sOr0KFmhcrI6HrqsU0bUemx2xTJh x6dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688493489; x=1691085489; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CtDTa/zSYu1BtyXYBgWZdAlFvHTcMeojuniPxpUE6tA=; b=Ekm3QAoAZgPbB2TWNpZ/YzlFoxb/mY0yQ9n9UhmBV/DJsWuwPFgAdrNw6dQsxY8aW+ mcoe8By2WRhLTIC79hScxDOQSq5ztK2x6EWIFh8eZulKReO9/dJoCr9kdog2G3StH00+ 9LAhKKx52qmp2mu4PyzClGz4gPi8bmXniJSiVPHn6e9JaFfiA7lXzgf9uq1WWR0lDKO2 WLJcjnc35ZcAM77sPeiQOjDH4rMka2CUUUwf5TBjuPZCX9wQduPhFQH5hhotxP3XPFe9 Un8uAFX6sj6/GnqoyUw0bPxdjkbp0wgNzK0eNsk4WLdn0n/BwSv8JvKSj8SnQRsTXhB/ rHDQ== X-Gm-Message-State: ABy/qLaHIp9ZpongPDZpTB+9Lt6LUyUUMY4yw3iCqJmRTfTPxYsyxhnX dVullJOwV+E75KwJAfVM5APvPQ== X-Google-Smtp-Source: APBJJlFk3YR1aUikjR6v2zDx4YgeL6uaf8BWmv4x9KrRM1f1S1Efo4GNieq5PMBdgBHMg75l4o73Yg== X-Received: by 2002:a17:902:fb8e:b0:1b0:cea:2956 with SMTP id lg14-20020a170902fb8e00b001b00cea2956mr1117plb.29.1688493489455; Tue, 04 Jul 2023 10:58:09 -0700 (PDT) Received: from [2620:0:1008:15:17fc:1b56:71df:89b7] ([2620:0:1008:15:17fc:1b56:71df:89b7]) by smtp.gmail.com with ESMTPSA id b4-20020a170902d30400b001b8a7e1b116sm1502829plc.191.2023.07.04.10.58.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 10:58:08 -0700 (PDT) Date: Tue, 4 Jul 2023 10:58:08 -0700 (PDT) From: David Rientjes To: Matteo Rizzo cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, jannh@google.com Subject: Re: [PATCH v2] mm/slub: refactor freelist to use custom type In-Reply-To: <20230704135834.3884421-1-matteorizzo@google.com> Message-ID: References: <20230704135834.3884421-1-matteorizzo@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 0008FA0006 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: q6funf53o8mkau3rj5qdifid6zrdmx4e X-HE-Tag: 1688493490-349042 X-HE-Meta: U2FsdGVkX18GBEcHSmeOQrv5eTJbKdCCm4qsfCArmiR8RNJjsEo1rk6ZPPNYd8L9bFQyZyAF+k0cHuA8oTro5tfncA5ligJv5cDmEIuEIF7OMku2QR0VttOk2NKvzsLcgDeIqUs3xJUbzh7xVByYbwN5f2b9VqR9TCHDSgDWOVjFo9F3WCAR9a4AQZ8rwgglThzQcO1n2mgX/FgDUiuVx6b+drEGB+6/Bxoji5qq7nKNGnQkTcKSO/PimVAIwin+oQiemKj9AVDFUrP2MaSuFpEXfboSX9Sa5MVHiLpEPGt1WIceI0IJP+VBD99W0LIDnukv7WqvnncGH1Ml6sFYRuBSASrFc57Pd6jCMOnE1G6KIiMXycf1uuBXDj5KtHFB9fS4rEEQDFE/TEzJjlPgVm9ob2dM4CSsfsBuc5OLSvqhMcAr2oQvALAr64eT0u9PeU56OJ0+XPCW9CuHHYDS/PymXLUi0Hl8PpcCiclis2g0G2ae1J5/FDK6FGEPMm9hbSefDusrNvHvT5gjKth1U5N9wbx8yorNd5mwXY5Xr9UI8FkVfpXNXWiQ7auwvzgFSky75txWNR+L5DDtxnQh3MLJXgER2R87Y6TxnxDkVvDwRSWO4iNE47douIyU3ChQJcPel0+HgkLSRgVMjG+4cZEwF3KG7CSf4H6fvxQ3RABN1GESkIhY7CU2WM6/FjWh3h0vLHm2wNF4rgnczvL6odjg141z6PgHvremBvmRNw14yBOI3EmsiKLWdDQm2evc1T5EQC45E5MMxm1YIytWADuM4xgI+ROs1yIEL6CGHndMa0R9tGc20/tDcAB2JzBIr3DYR6aQkSBKkCi4a4dPYqMHKKkJ3Pc5zozNj66IQGcMS6wzPQGDyp/jJlsBPPtvA8tz3K+khLb8deX/2IYv/DxQ0KrD7sqaah3cTgv3rdl8mCPJKrcbKnXkL/4bYe6JfafOz1F2IVaFHk5n1ci AgwVvxL0 mCOHu5gooDZ13kPShlbOzt4tbUR/Mh3SVq8wJIOvpMRz7pRW0cOu9cwuGpm3paZVjtPWbhjrfZAWtsWj6IoM/tJpFe39bNw+WroTtdTUeoDWQMiAZE6AzuoAV7ZEwduRglX9tEFb2D5v+LltmEBAAgYou4Cet1ex9Gil8i45mzV/an9+BZmMMYffwVEJR7huCgCIT8b0Lv9Axae2Iun0ymApcCRLEaZy2ZciNDpQYYy3x0vHCODUkpVvAUuwumO/qesvjJ8zuEe5labkXV2raDwjD2C66gEN9Bh6u93Ji+fPCSHpBD3Hs6tlk3Nklt2I4Y5/ZrS6uGWE4zB5M/QUEPANPBerTc9sy6FDQExP7CxGVwzLM4OILG8gDsVGq1GI7FFlj0uLX6TluBMN4KR+SiuYOpS5k3R2I9yc91K9y7WXraVQ2ob5yhvGBtM6l3guBkGzsqo6sUSB3f3anmO2hOol8umB0Nwk8KIsd1g1i2DbtkadpyMDo99t1zA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000043, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 4 Jul 2023, Matteo Rizzo wrote: > From: Jann Horn > > Currently the SLUB code represents encoded freelist entries as "void*". > That's misleading, those things are encoded under > CONFIG_SLAB_FREELIST_HARDENED so that they're not actually dereferencable. > > Give them their own type, and split freelist_ptr() into one function per > direction (one for encoding, one for decoding). > > Signed-off-by: Jann Horn > Co-developed-by: Matteo Rizzo > Signed-off-by: Matteo Rizzo Acked-by: David Rientjes