From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2543CC6FD1F for ; Wed, 20 Mar 2024 14:13:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A6286B0083; Wed, 20 Mar 2024 10:13:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 956406B0085; Wed, 20 Mar 2024 10:13:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F6886B0088; Wed, 20 Mar 2024 10:13:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6F83C6B0083 for ; Wed, 20 Mar 2024 10:13:50 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 302C081442 for ; Wed, 20 Mar 2024 14:13:50 +0000 (UTC) X-FDA: 81917611020.08.655F482 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id AD8861C0020 for ; Wed, 20 Mar 2024 14:13:47 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Sgmm7iM4; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710944027; a=rsa-sha256; cv=none; b=UzLjaaBgchRnvXO/HBSbVYSSxbYtgDijOS6k3/wMM66gvfjDsn+VcrL/i7Nl94Ajkem3gf GVZGkhLpHx8G/AEZRvcTNJPQKS6JMjRBSjnvP9BEk/y9vBqgZhkUZipYb032xiBDEsyVmk o6jcx+k+Xuj8/w1aSW9zTI1U/B+2op4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Sgmm7iM4; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710944027; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SWFh6+NY0TCHwmjI+olVuTfenQq3vt0jGsa5LqXaGxU=; b=li70XbmjA7DdxR2dpZcmWktyOIxwMOy0SOtYTyxBrNkx3crTjChRy/YRavYgbZ/RS7JoaT T1UrO8lm+xnpH7OpjQ19VCEEj+3MlvOenFFR6BCDYbR7dnPGgi5P6xNU2p4hUhPZNKxAi+ C9WKds9scHjxryc94a5pB6eEn3+l3+A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710944027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SWFh6+NY0TCHwmjI+olVuTfenQq3vt0jGsa5LqXaGxU=; b=Sgmm7iM4oweAN5tStLvOT72qyW71SNluL0rgvpCkd9UPpg+zIqj5wV5Th4/nyPl4Es9Td7 fUlROtGvj+cv6DKRZAMkMvSWaalG+qYLMVs5pryNLdwYKvgZug/LJ2RTRUeNA6kqCWVQd+ xxS8zN6CSrmxydJKOxa5vSEYllX5C/I= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-66-RlKhRK7ONjK4YjptSVbpAA-1; Wed, 20 Mar 2024 10:13:42 -0400 X-MC-Unique: RlKhRK7ONjK4YjptSVbpAA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2d48d75abc0so45693921fa.2 for ; Wed, 20 Mar 2024 07:13:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710944021; x=1711548821; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SWFh6+NY0TCHwmjI+olVuTfenQq3vt0jGsa5LqXaGxU=; b=jGZTGWdoJ7Y9XN2sQwpN9DNdk++SeCgEOsER+iIRhViECq90nsU6gnbG8EeHli1BZ5 DgelIfXhgJZT7GxJ9BEwf0tJUYqbc3XQZovO/3NnMcNWEj794tucbaXsw2woWOFsUMMj cbHtoy/5dLZUQ7EoVvadL70YtQkbx++nHfTPT89cgEH0qoRBWLxw3OkMZTuMGsG3aYBn QdGS6eMwialsggKiJTZ8wQOgncyNFMKffE0QydFxQCHjZ5pU0gJHmDVqS5hMWaHaEVLz nhXSOUdwKuvKNNPv45DmPsLavHSb3zfTUaDTEea/zZV3Pv1M56WdivIxm6musOUfLC3h AI7w== X-Gm-Message-State: AOJu0YxCVin7yOinAejahWyhROQu6EDmPOeDxfhQrbvIr51A+EtBRBAr b5+Bd75ZR/wJMk1/zEDR1IPgMNnXYCuWa8pwU+j3OR1qImUmxJLLJxvkTINe7Q9Bj24VgE3vlDo wL3SQFKULafLDU1OTt/jeI4zLCJu2i1N5bWXBMNoSHMzFK5pc X-Received: by 2002:a2e:9acd:0:b0:2d4:2bee:e550 with SMTP id p13-20020a2e9acd000000b002d42beee550mr11356986ljj.28.1710944021428; Wed, 20 Mar 2024 07:13:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHxlPNAYGknobF2IlWpXtE6yUiPMvMQJQu6vzfkeiQqwiYMWWRflPDRUeUG3IGwwFkeczVWjA== X-Received: by 2002:a2e:9acd:0:b0:2d4:2bee:e550 with SMTP id p13-20020a2e9acd000000b002d42beee550mr11356970ljj.28.1710944020965; Wed, 20 Mar 2024 07:13:40 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:c400:9a2:3872:9372:fbc? (p200300cbc709c40009a2387293720fbc.dip0.t-ipconnect.de. [2003:cb:c709:c400:9a2:3872:9372:fbc]) by smtp.gmail.com with ESMTPSA id g13-20020a05600c4ecd00b0041468c50ca2sm2361629wmq.36.2024.03.20.07.13.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Mar 2024 07:13:40 -0700 (PDT) Message-ID: Date: Wed, 20 Mar 2024 15:13:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/6] mm: swap: free_swap_and_cache_nr() as batched free_swap_and_cache() To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Huang Ying , Gao Xiang , Yu Zhao , Yang Shi , Michal Hocko , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Chris Li Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240311150058.1122862-1-ryan.roberts@arm.com> <20240311150058.1122862-3-ryan.roberts@arm.com> <42ae8cdf-2352-4bb9-9b22-aed92a2c9930@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <42ae8cdf-2352-4bb9-9b22-aed92a2c9930@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: AD8861C0020 X-Stat-Signature: 6zbbs8bgr7w7e55agc36dip837ad89dt X-Rspam-User: X-HE-Tag: 1710944027-740101 X-HE-Meta: U2FsdGVkX1/YLPop77hLWxON3jxqiTGY/GU6LuxHsj/48tBBYlNlnpZAKHt5pTV+xqQHPs53vjuCne/gk4HN0YyThFRDkDVtMD67W3fm+dWWaIve2xUCxSCzeXeVbRI2sCHSpp21/bB12SVKD5AzY7Pgin7feuF/R7Cih1vN81oBFS9HgxpXZ8DK5JO5H/My1yv8m387iIixEt45M8kGOzG0l3+EDjdffFxzDmYI/12f2avhb0h0t/wd/gecQtv4GtB2pRdZWvAdklJU/06ZEk+vsLiMDGZTvAWPiEZ/3+UOKclMbaCkwX2Lx1WIxbxsbaL5I0noL7E61y0E9Aijw9/MkLAq2oH6v+VccE3ZRAwQSx6rpcHskr+Jxl+5CjuLIV5i3ZUZqudq5Xo1vkS2/j5Y70VDUoQD4YtxJqFmr2f9pEIrJRBe+GJqOrkhCpsnw33n93PBd6fX9/K8x1jhDX87aTWvQetNa1LYmwdiadkxigYw17vNZrxV56BtRwmdV6tr08EpOtddqJHnkGZgD+4NwAUXtciGbLFNfOxThfti4bRpoFTXSxZH+1uTvAtVkdRu+nlrtZMrF5lJjoVvafn7tXemkeSS9x+IcLGAfKeKd30C5E5HbErJdS8xJqER86jUqh/TB1H4YZQY6DbJ819QlPrbhNf74fkNyOU5PVBk3W65FItL4qlJR4KVFRq8b+VaLqLBgjC2W5VsAisTMD0d/kzFtqmR6eBYSAzbQ/nacjFlKNbsejO6iqATXdEhDl26mp1hSVXWNA7smXzwpyBtRbJaGKRBbn2au6sdWKhOYu8E4a5tUmTcrQwmo+HytjpjM+imhyudU099S1HoBU4uMfNpeKTkSRLdCfV4weiWlYsYQiXXsa9q4JSaCQQj7wguyBrQbINtNaHgavOw1R9+Kb+GOVfCjINSsf2tRdGu5hDm+6SV1iVzaBcSqTcbEGL5wo1AAcehgLwVXvn CvrRhIgh 7VsCWdfzpCXg5AfESMN8yPgR+h8hjP4A/xySccMDRGHt6je3bv9QXzfhdK/n90OItgvprNtV8QZaSTTFZkcpdfWsOGkGWaiVLGc78HmTGBHPMlvO+7K3zwPGZDjoH2nad5ipif7QaBnstB2pTU7eTjgsZsCqvrYZl17ARxhHzaVa70vDGsuCfjT+8NLye5GEP18tfCiQZzEfViKApnaaeWvjv2Rq2DdfGjDLFr7x4x7cfpRlH2wdvnkhwY+uoyapunmSbUU6my7SDlGuln+PcKjvuSp4TzTwXHmWuapSLncWqb3QUVhTehtNjFZkXnexeenSbIuSpQTRvpkzK6C9vtDOBPVTxceYw83XD/uAuyyR8NVVV43N6rfAH40PU/urG2tw7Ppv4T0nh3ZavvfTNvCufuo7S976Yb+izVH8VcPKzJcRZFF7+0RUdhP1EutcKHDDLVUtFce5N67+YEVBis/xJfA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.03.24 12:10, Ryan Roberts wrote: > Hi David, I'm usually lazy with review during the merge window :P > > I hate to chase, but since you provided feedback on a couple of the other > patches in the series, I wondered if you missed this one? It's the one that does > the batching of free_swap_and_cache(), which you suggested in order to prevent > needlessly taking folio locks and refs. > > If you have any feedback, it would be appreciated, otherwise I'm planning to > repost as-is next week (nobody else has posted comments against this patch > either) as part of the updated series. On my TODO list! -- Cheers, David / dhildenb