From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00526C4332F for ; Thu, 29 Dec 2022 01:14:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E91418E0002; Wed, 28 Dec 2022 20:14:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E19198E0001; Wed, 28 Dec 2022 20:14:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6C208E0002; Wed, 28 Dec 2022 20:14:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B4A2F8E0001 for ; Wed, 28 Dec 2022 20:14:52 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 89AE21A04F4 for ; Thu, 29 Dec 2022 01:14:52 +0000 (UTC) X-FDA: 80293574424.06.32442EE Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by imf24.hostedemail.com (Postfix) with ESMTP id E4558180007 for ; Thu, 29 Dec 2022 01:14:47 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IpN5GSaz; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf24.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1672276488; a=rsa-sha256; cv=fail; b=02rpsYvV7ZNnvAMDH5OChb56rlc3jwNfgChDHQfZNR1NnaGGxN1dIZyWrXWL1IUTroy9qO DTgwq/02ZVk8xdQ9fMrOIE69FH1fn7wKBGJJrKV30weITIs7ktnVRXMM4HN0qgD08c98HK peVcmIwjORKQ7YBTcrwm+fa2XuwrPsg= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IpN5GSaz; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf24.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672276488; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qi0+6l5/rXg+iQIA7Exs/OwnQjIyuEqIb610RH3KB2I=; b=ryQ1phh1Y4QoOfXK91fzFziOFtwlFMAJQnRfKi4cTH4v1vYObN3LFg3GxtFT9p3a6EuyN/ PUT+Ae89QgLLpKSv1zb4/pRuoJufV4EKfj/oGAiNL08Vs0lVEcoCK2AB9PXdg/SwxtWSHa +/fd3Xv4w2xfnPZnj+ydBAYk+3cqNOU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672276487; x=1703812487; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=JgxGjFaIKJhCOXR8gAus/aM9i9bWX22kvq0roU/bISs=; b=IpN5GSazQXdQ4QDmV7x395K3yJhzbe4Ie797dz6wD2BjvO9gh7BZmzC1 kR7wGt5vPN922JrczQ36QG4oFXwK1rvABT4wBeWjasaHC3CNA59mKpd4X 4pXYKyak4hVTB9N9bEYuX2pNvkzgastdetqAt6FQXYJu5XLb+ulwARnTn WeIOt6Mgs4JCa8IgNwHZEk+soXx994zUVzNEYSVvHD6ckWyJoPFf1wHFE qj2rZF1Z5qqPe4kfZSG/LdIve4+2eW5Ee2V84EQnLLFu3SxG383ismWD7 B8AWpj+5U79Ovr1x6IsVdEQxCzN2ZwmagNpwWEBDeZ5N50DlhOsL40mVU A==; X-IronPort-AV: E=McAfee;i="6500,9779,10574"; a="383258245" X-IronPort-AV: E=Sophos;i="5.96,282,1665471600"; d="scan'208";a="383258245" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2022 17:14:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10574"; a="655456677" X-IronPort-AV: E=Sophos;i="5.96,282,1665471600"; d="scan'208";a="655456677" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 28 Dec 2022 17:14:45 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 28 Dec 2022 17:14:45 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 28 Dec 2022 17:14:45 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.42) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 28 Dec 2022 17:14:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ddOJuvmkhwdkkIUHKOXjTsPQ6xKsTeFdki0WEZfqfsl5Sb60hDp8dn9WRtfd2RfERXcKD91cW4g1NgUeXolnfhNXTFVLyNaMLCzsN45QZ6QvBolFVOMK5tpdqHGu6tzoeZSQcJwt9pjxEg7C32srFGtZ8e6zfR3CaimKds83Q3YR4FO+s4/wj6AHW5cqXPUNpz9DEZYNC3ScIPb4rYVvVdyQClivAL7pZvnZRTCCLQTB2j562CQuspEs+TAsiYEdcEr2RebyMuBXYVvPG3U0urdegKtBf9HOYD9yGkKLB2I6+m+QdIKIoenALzY71ZrRWIgoLarOL5o9iR3x7CYoLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qi0+6l5/rXg+iQIA7Exs/OwnQjIyuEqIb610RH3KB2I=; b=HSQNp/qLTY35gLIWPlhbvw7Qjr2D2iAwnSrqGtR9zBAkCIKjUtqMqFzZgI223K4hgwogmG2XgFTJHkC3vGQMNb6p9OTV92pbDF6Q1rRYvK+Bt4/iSpNyOGh3RRj/AZIrIv8UemkiLF4h/3bmlGvBSaNLfG9WCzdPGRp1fDSVGky4zzkklxui5Mo5luOOcoI0iNf5Ezoq580R+EmxyaL8geTq5F4Pk1pOcj1gqVjmZvezC05F/3ey9yev4WjhmwgTCn1QbyFAXQkrL2fUjKIwRhrMwAnLIqUozIDIa6qCup9GKXBh8m73t+/AvB1/7MyDQhmZTUmsIKxtP3DGw9266w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by PH0PR11MB5174.namprd11.prod.outlook.com (2603:10b6:510:3b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.16; Thu, 29 Dec 2022 01:14:37 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::505b:18be:f1dd:104e]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::505b:18be:f1dd:104e%9]) with mapi id 15.20.5944.016; Thu, 29 Dec 2022 01:14:37 +0000 Message-ID: Date: Thu, 29 Dec 2022 09:14:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.1 Subject: Re: [RFC PATCH] mm/thp: check and bail out if page in deferred queue already To: Nathan Chancellor CC: , , , , , , , , References: <20221223135207.2275317-1-fengwei.yin@intel.com> Content-Language: en-US From: "Yin, Fengwei" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SI2PR01CA0053.apcprd01.prod.exchangelabs.com (2603:1096:4:193::7) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|PH0PR11MB5174:EE_ X-MS-Office365-Filtering-Correlation-Id: ec19bec8-8d2a-4beb-35fd-08dae93a0d9c X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: onswqZmwsY1v1T7hTsiBIWryy6dqrNAEba1xVNbEKWWIhx3nIkelS2EKhSFef9AHcoAZZPw8yrPDY5cXNJCpvI+BGGlqffFPdc2zYKcFwkco0h7K1ij71aOImMe1VVyrAJZUNcj+nlvViup2rkR6M50Gty4X55hip3tFpSPQM7IBs6977bVOjjb4Oh8j9dAUilYajUvLPf3gIyNB2PaHx++0mU0SQQCuvOU3eyt3r/Ao60SJ1pVGIXbeGYBoTAi9BkC6Lt8+LojCXaJVbrCEbh/X+TU6tAv8s9NRUiKr7pc9mZHIzQIkTqHAYKiw6YzG/vsH0rtJo5qy5qB3+e+gd6IXBCmCI9fYNQSoEMCMT3592AzFkXSSfTKpNgGRht5G7kwUnzzqZeyPpswIzitzI+wTanjpSYL5aD1B7DgolUTWTOKwdQKr/VE/9vLlTHJ7DqCV+js+XjM2S6/vQrNMZ4UkFok5zJh0G0F2e2j3wshum14PRh7XeuOt/gPsUp7qJF9Il2qiNR8C2iPXrVRQp2QC/eFWpq+LCnzBoKTNqBDb0SvxilsrFgDvoarRjIPot/58CHGAM81y1WHMowka2W4Tbb7EH9xp5Ef0Jj2tGYtNzhZuHs1DX/pqc0ffp3P87rZve0wuEPs30doXcxkfomDpVivO2E+KvQWtHhBohueB9vVHYjBpVjcTdh3vHqxoKeznIeS8+1X1DID2XNSD3by8pASNz2WrfJMTdAaGpKLSqtZIYk/Xh6MqGclTtbwF X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(39860400002)(366004)(346002)(136003)(451199015)(83380400001)(5660300002)(66946007)(66556008)(66476007)(41300700001)(8676002)(31686004)(8936002)(4326008)(86362001)(82960400001)(6486002)(966005)(31696002)(2616005)(6512007)(36756003)(38100700002)(26005)(186003)(2906002)(316002)(6666004)(6916009)(478600001)(53546011)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3c3THVmbmtyV3JKSENRNFJ0UVRZQlExaU5FYzc3bVlkV2kyYkN2WnJmNFBo?= =?utf-8?B?SUpIN3V5TDNKUHR2WGFjNHRRR1grdDBvRGcvYW1rVzVMbVFxRmhtcytyZGh6?= =?utf-8?B?MkVkNzZ6aEVPbkZzMmVSYkZ4SUJ6Y0cvdmV5V2lFcjBHWmZ4enRHODBUS3Jq?= =?utf-8?B?RmY1WlJtNTdSNW1KQWZYUjZQcSs5SzB2bzhPUTJFWFhOZFVPUjZUZFZzcHFK?= =?utf-8?B?ZUpGMmVPZk9XZFR3YnE1d1c0aUg1dnp3bWpTWDVkY3lKSkhvemxycnRuNTZ2?= =?utf-8?B?ZEhIbWtGVXZvQktDU1FQcWhiZ2tFTlluUlhxZThkaDcrK0t3RXo2L1RPSjJ1?= =?utf-8?B?U004L1lyQTF4VU0yVG82TjlkQy9QWDNqakpXSlBhQkhRQU1TcGtXNXg2VWdP?= =?utf-8?B?TzhDNkdCWEpYOEJBWVdYVzByYVJVSzhYWUpHTTJxR1pKOGM4dXFLcThFM3NM?= =?utf-8?B?aFE5ZTE5QUdlaDNaZHhrTEZ4TWxaeDRYL2JJWko2UjZhUHJTZ2xGbnpJZTB6?= =?utf-8?B?MFVDYXF6VTNJWlM2ZlUxQk80WGZ1Z2NiUm5Jckp6cG4zdEhJV0FJellOS0hG?= =?utf-8?B?ZlZneExkeG9QTm9KV3dDQ25USktKQVE3c2ZySGVoRjNtRG5PeGZVb2hkWHFU?= =?utf-8?B?ekkzTHBaNmNieUdhZ3BIdG5KTUVZMUNHSGtqZm8xZ2MvSjhHd2RSWFdPNE5V?= =?utf-8?B?dVI2c1g3WklnSU9VWmRGUlAzRnFUOUx1WDlNdWo4Mzcya3dtZ0I5dm9pZ3dl?= =?utf-8?B?TmRIUHJqUkRmVWZPNmt2U2F5UWpqbmNxN0VMQnFMRjM0L0dINy9KdHV0VTNX?= =?utf-8?B?SENlZXhXMTdJa3JSMXlZOTE0N3pkUCt1a3piY096QldCWG1FUC8yaGdRekRP?= =?utf-8?B?c2dGaDB0Tjk2ZWdXcWlMdTlMWjJ3WmlRK0s4T1hqWUFQeFpCeEUxb2VFTzBm?= =?utf-8?B?czdTTldDUU5ZQm1BRm5CSkdHUW1WOU1KdGdraGxGN2UwdVJWZE1KNkZWblM2?= =?utf-8?B?QlpNSWQvM21zcnNFdE8zZ0hzQW5neE1rTCtjVnVqU29PeUtrc2llbEVWc1hZ?= =?utf-8?B?aVFUcHdLU2dBL0JkQlI0WCtsTVMrYndwbWo0U2dlYWF1ZldIa1o5a2NTbFB4?= =?utf-8?B?ZG1rbG9BTjU2b2Q3VGlUN01veFRXSG9KZlBzUGNnL3ZESmFkTTI1bm83QVRH?= =?utf-8?B?dHRubjJNQmdRODlIeGhhSzZieXNPU3NNelZqVXVWcE11aTl3K09IRFpXSlVW?= =?utf-8?B?eUFqM1R3V3pGWkx1WEpJUGlMZVNwQmJ2S3pRSTRRMEs1VnFUbEsxQXFHSyti?= =?utf-8?B?UHNXNnRsNUt4dFhiS3FDaFhyQm9IVWJjOHhSbk8rSEYxUmlOWUcxbWlaWkFq?= =?utf-8?B?MW82aHJHNzExY3hickpqRXoycVd5ZURBd0FOT3ZvWUhaUWk2eG5sMXR1cmJS?= =?utf-8?B?UStYYnFrb2w3aU1HRjhFd3hQUkg0SzdFUnd5U2VXdmEySUdzODcrU1o4VktV?= =?utf-8?B?dm5kVTkzYkZlNHR2Z284YVkrWlEwQmFjYTE5b3ZkOCtPMlUyQlphbjdHcUIy?= =?utf-8?B?MnBHZkFZakltSW16SGYrWTNPMi9RNUQ1WnpQc2h0K0V0NDRpM2EwU08wV2tV?= =?utf-8?B?M204ejBzakhtRGo1VzFaOXZDcGtTV0twU3YxdFFENk9vTE8veEdFdFhzZExX?= =?utf-8?B?bmh4MXVZMWNhWG1nbXUzcXlqRFRkLzdHVmVXR3JQeEdKeFJla3c2NFZCaGww?= =?utf-8?B?TjRxdFNLaTZWTjZqcWwyRnRyYnI1S01QdlN5eEFtTzJaUDFqdjRLclJFc2Mv?= =?utf-8?B?YVZLT1RFVytJMElPL3BvM3F6R3FlQ3hGWWMvSTJWTy91aHEwVCtobGp0Mnc5?= =?utf-8?B?ZHErbC8zMVVNNHgreFBWQzhqZzRyNTFxcVJLaklIRHc4UitCSzdsKy9LSUo4?= =?utf-8?B?RUdiSnhBTW1XK1lYcjk5VmlRWGVmK1VybUFzTnlBak9LcmJLcGNxUzdWRGFI?= =?utf-8?B?Qzk4azVuWEhhNEx4U2JQU2tVd3lUcmtmMGNtU3dDVHpTUDVDcFo3N0ZDOVdp?= =?utf-8?B?TTYxaTRnb0NzeTFmeTlrQys2VUx6clhFdDV3L0JqUXVGekp0VENpT3BXYk9p?= =?utf-8?Q?Ki9b9AvAIzm3suoYKASZMfwug?= X-MS-Exchange-CrossTenant-Network-Message-Id: ec19bec8-8d2a-4beb-35fd-08dae93a0d9c X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2022 01:14:37.3949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l5nYZCFP6yDbkyZBWB1W+R4IvESNHFnoldsmpgxTfSp26+PR7MV9fljNIMtB+TCvdElB58aIBH3Nlo8PHfRocQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5174 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E4558180007 X-Stat-Signature: cdqt4bfejaor11ntsbq6ac6gsgqgxcm5 X-HE-Tag: 1672276487-670899 X-HE-Meta: U2FsdGVkX1/FQSVbX2uff1Ip90AwsYNPS0GM7w6F22QJ1kmJuHmmC5AqKyO/IeZGdXrm+zYpbgsCIC0//cLx4V535hdU9zRtIhOxGYhoOH4ytwaFPdt6MfKWRoSXcRHmmjnArE/6QI7wILvpwtV1emxigsraQvYa/X/1Te3kIv+o44Bx057I4NHIYFM1LV/rnxmpln0nyUA4RTunacCFZLxLHB4PlCXkVLJVL7TTVJy9as8QtbrTHoLSv4CIEAHCA3lr+lsFam/KuiY9r6a2S/tRXE1ePa2mFw8id4Hvr92NBiwHO2N87EWdIn7eaWZylsgTkF8yi9fCP3XB5VvD6ivXJAXUDfuqFcYYzR/ql7W41ZX51cCU9zo1WcfAZB+tfff64UkS0i8MDETR5OX1du0itORspxe7MY/ZBSt/xkdNxjTXBmkWcyrfPWdvoW+AayU09oLgY6TX39YhgmWpSYX+e2qlnFjxJbz5LSPyuIidjjohJSNNUg8NG37c8YZHXYeY6FGDB+AThCkguvbqIzzG7wSiqG96DHmDpGKEHV+AvvM3UxyPIDif7dMm8ATx6IkC9yt6xfy1GXaiLz28fD2NRxH4yz5OxjPQwJyobKkZuxwrO3hBbZO/lcZVL8Wy6ZL5fbYT+IP9NMGYCstMgVlvFfmJUGLIOWAfIGl7I2ILpmQhNvwqdmwTNzxfv0wD2dpbEVzVhT+iZat809B+QevJTh7n0ra72NfrckJ/4GdUXqV/zN0PMR5EAPqF1rtSMaHVmFg85IuLVQTdUeeI94FzJDFAV1oNtxs3oJgAucTVhO9wfEk3x3cZEDbXlrFiy3bQjv9WBcvu4uMk8+mQtCSzctfZtoZLhp91lzui5267coEeydQe7oyEQ8IURDEXAZ5jUTQKBF0uU1CoT0QqX1WHkgk8H2KRN8Xz4jwt5uWvDR8ERJL9gvQSpC2X0tzr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/28/2022 4:15 AM, Nathan Chancellor wrote: > On Fri, Dec 23, 2022 at 09:52:07PM +0800, Yin Fengwei wrote: >> Kernel build regression with LLVM was reported here: >> https://lore.kernel.org/all/Y1GCYXGtEVZbcv%2F5@dev-arch.thelio-3990X/ >> with commit f35b5d7d676e ("mm: align larger anonymous mappings on THP >> boundaries"). And the commit f35b5d7d676e was reverted. >> >> It turned out the regression is related with madvise(MADV_DONTNEED) >> was used by ld.lld. But with none PMD_SIZE aligned parameter len. >> trace-bpfcc captured: >> 531607 531732 ld.lld do_madvise.part.0 start: 0x7feca9000000, len: 0x7fb000, behavior: 0x4 >> 531607 531793 ld.lld do_madvise.part.0 start: 0x7fec86a00000, len: 0x7fb000, behavior: 0x4 >> >> If the underneath physical page is THP, the madvise(MADV_DONTNNED) can >> trigger split_queue_lock contention raised significantly. perf showed >> following data: >> 14.85% 0.00% ld.lld [kernel.kallsyms] [k] >> entry_SYSCALL_64_after_hwframe >> 11.52% >> entry_SYSCALL_64_after_hwframe >> do_syscall_64 >> __x64_sys_madvise >> do_madvise.part.0 >> zap_page_range >> unmap_single_vma >> unmap_page_range >> page_remove_rmap >> deferred_split_huge_page >> __lock_text_start >> native_queued_spin_lock_slowpath >> >> If THP can't be removed from rmap as whole THP, partial THP will be >> removed from rmap by removing sub-pages from rmap. Even the THP >> head page is added to deferred queue already, the split_queue_lock >> will be acquired and check whether the THP head page is in the queue >> already. Thus, the contention of split_queue_lock is raised. >> >> Before acquire split_queue_lock, check and bail out early if the THP >> head page is in the queue already. The checking without holding >> split_queue_lock could race with deferred_split_scan, but it doesn't >> impact the correctness here. >> >> Test result of building kernel with ld.lld: >> commit 7b5a0b664ebe (parent commit of f35b5d7d676e): >> time -f "\t%E real,\t%U user,\t%S sys" make LD=ld.lld -skj96 allmodconfig all >> 6:07.99 real, 26367.77 user, 5063.35 sys >> >> commit f35b5d7d676e: >> time -f "\t%E real,\t%U user,\t%S sys" make LD=ld.lld -skj96 allmodconfig all >> 7:22.15 real, 26235.03 user, 12504.55 sys >> >> commit f35b5d7d676e with the fixing patch: >> time -f "\t%E real,\t%U user,\t%S sys" make LD=ld.lld -skj96 allmodconfig all >> 6:08.49 real, 26520.15 user, 5047.91 sys >> >> Signed-off-by: Yin Fengwei > > I cannot say whether or not this is a good idea or not but it does > resolve the regression I reported: > > Benchmark 1: x86_64 allmodconfig (GCC + ld.lld) @ 1b929c02afd3 ("Linux 6.2-rc1") on 6.0.0-rc3-debug-00016-g7b5a0b664ebe > Time (mean ± σ): 383.003 s ± 0.680 s [User: 34737.850 s, System: 7287.079 s] > Range (min … max): 382.218 s … 383.413 s 3 runs > > Benchmark 1: x86_64 allmodconfig (GCC + ld.lld) @ 1b929c02afd3 ("Linux 6.2-rc1") on 6.0.0-rc3-debug-00017-gf35b5d7d676e > Time (mean ± σ): 437.886 s ± 1.030 s [User: 35888.658 s, System: 14048.871 s] > Range (min … max): 436.865 s … 438.924 s 3 runs > > Benchmark 1: x86_64 allmodconfig (GCC + ld.lld) @ 1b929c02afd3 ("Linux 6.2-rc1") on 6.0.0-rc3-debug-00017-gf35b5d7d676e-dirty > Time (mean ± σ): 384.371 s ± 1.004 s [User: 35402.880 s, System: 6401.691 s] > Range (min … max): 383.547 s … 385.489 s 3 runs > > Tested-by: Nathan Chancellor Thanks for testing the patch. Regards Yin, Fengwei