From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <owner-linux-mm@kvack.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D8EADC433F5
	for <linux-mm@archiver.kernel.org>; Wed, 30 Mar 2022 02:02:53 +0000 (UTC)
Received: by kanga.kvack.org (Postfix)
	id 4DD508D0002; Tue, 29 Mar 2022 22:02:53 -0400 (EDT)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id 48ECE8D0001; Tue, 29 Mar 2022 22:02:53 -0400 (EDT)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id 32EF58D0002; Tue, 29 Mar 2022 22:02:53 -0400 (EDT)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0240.hostedemail.com [216.40.44.240])
	by kanga.kvack.org (Postfix) with ESMTP id 2063D8D0001
	for <linux-mm@kvack.org>; Tue, 29 Mar 2022 22:02:53 -0400 (EDT)
Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay02.hostedemail.com (Postfix) with ESMTP id C5517A5BF7
	for <linux-mm@kvack.org>; Wed, 30 Mar 2022 02:02:52 +0000 (UTC)
X-FDA: 79299404184.20.FB9966B
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
	by imf13.hostedemail.com (Postfix) with ESMTP id 2015620009
	for <linux-mm@kvack.org>; Wed, 30 Mar 2022 02:02:51 +0000 (UTC)
Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57])
	by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KSqRB6TCdzfZMV;
	Wed, 30 Mar 2022 10:01:10 +0800 (CST)
Received: from [10.174.177.76] (10.174.177.76) by
 canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.21; Wed, 30 Mar 2022 10:02:48 +0800
Subject: Re: [PATCH 3/8] mm/vmscan: introduce helper function
 reclaim_page_list()
To: Christoph Hellwig <hch@infradead.org>
CC: <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>
References: <20220329132619.18689-1-linmiaohe@huawei.com>
 <20220329132619.18689-4-linmiaohe@huawei.com>
 <YkMQ/RX8dWxoeCi4@infradead.org>
From: Miaohe Lin <linmiaohe@huawei.com>
Message-ID: <f4c4dc9f-5726-8107-77cb-bdd0c4b2ddf2@huawei.com>
Date: Wed, 30 Mar 2022 10:02:48 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <YkMQ/RX8dWxoeCi4@infradead.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.174.177.76]
X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To
 canpemm500002.china.huawei.com (7.192.104.244)
X-CFilter-Loop: Reflected
X-Rspamd-Server: rspam05
X-Rspamd-Queue-Id: 2015620009
X-Stat-Signature: zprpiw1o6ht1xyhehy191zc1u4g5fxwx
X-Rspam-User: 
Authentication-Results: imf13.hostedemail.com;
	dkim=none;
	dmarc=pass (policy=quarantine) header.from=huawei.com;
	spf=pass (imf13.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com
X-HE-Tag: 1648605771-814137
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

On 2022/3/29 22:00, Christoph Hellwig wrote:
>> +static inline unsigned int reclaim_page_list(struct list_head *page_list, struct pglist_data *pgdat)
> 
> This is completely unreadable with the crazy long lines.

Will break this long lines.

> 
> Also why would you force inline this?

It seems inline is indeed not needed. Will change this too.

> .
> 

Many thanks for your comment.