From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CBACC6FD1D for ; Tue, 4 Apr 2023 10:07:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 981966B007B; Tue, 4 Apr 2023 06:07:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 931C26B007D; Tue, 4 Apr 2023 06:07:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F91F6B007E; Tue, 4 Apr 2023 06:07:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6CE266B007B for ; Tue, 4 Apr 2023 06:07:22 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 31A5FAC2BA for ; Tue, 4 Apr 2023 10:07:22 +0000 (UTC) X-FDA: 80643281124.05.3CD0FBB Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by imf27.hostedemail.com (Postfix) with ESMTP id 30EEC4001D for ; Tue, 4 Apr 2023 10:07:19 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TeCHuBxf; spf=pass (imf27.hostedemail.com: domain of error27@gmail.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=error27@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680602840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eM+Kd50JR+321hTmAeOgrh/Eol6OBRvSkPkfL3Sie9A=; b=h4gGe9pn23wgouRj3cZOIYpMRXxpJEs6LqXa8sUskHw5fdnHYSafL2UR+LNk/FptUR+dw3 QXzTDmQls9YNUfcx/W30XL5KJg7YwZfLEZAoYZXDs6eOpa2m/Xc/47su4NwO6zng10SavO y6oBomteBnKwmLAcx6klOZ6uxteVW/0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TeCHuBxf; spf=pass (imf27.hostedemail.com: domain of error27@gmail.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=error27@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680602840; a=rsa-sha256; cv=none; b=XKsgdsL+sfjhXE9I3XdfHT4w+4rx6RcU6+ZZ/xF727mbo7o5UJkyhQ89/lJBmn1AWGwY3L /pQLanarpL1tGwL5mgRCv1o/SVCgRf+qTGJsNcx+vLsTdjpCX8Pp2S8MPeg853Fi1NJRLd m6HGGYKl6s8FLSwLe0wvhDCFJEMC8LE= Received: by mail-wr1-f42.google.com with SMTP id l12so32163519wrm.10 for ; Tue, 04 Apr 2023 03:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680602838; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eM+Kd50JR+321hTmAeOgrh/Eol6OBRvSkPkfL3Sie9A=; b=TeCHuBxfJL2U6dWw1BNY2H/t39DC0TmM42nq7aQMT4iE40FmgkwvXamH1XAFO4sHIL YAoh4cXHAAoQVwZm7G8sOvolq00uMqi3zJA+334bME6JzzNqKizOREUAm9QPPOHPQMjU 6bYgCjV3xTIxlnRV9fvmf7cEjqasyUchUe1Ak2WYwnBgPzaCXAGk5imUEQ1rtGkUsw0t ktvZN0pap4A0322WysLkO84Csb9jNUHK7GmaW1fx9e0ToKc4i10s6+WyRkxcdPVWJf0h sfjJqeZLWttihuSVNlKXR2azmIdtBKUg9Wmy1yqYXETECF5r6qSCWmYq8DAXiLAkl7b8 wqJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680602838; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eM+Kd50JR+321hTmAeOgrh/Eol6OBRvSkPkfL3Sie9A=; b=i6lKyfTLRushkD6x6PwUYpmt+WgfCZ9jZ6gn9JcZVLROjHIW6ArmcNNO4c88vQUN+P 1pnXP/thVTgj975GZkmVzyQ6etCRpdlvHcWqG7vYroo6B1b4D2JQSq3nbWJVy5xCfaLf SJszXHfuzJKDpNwV0T5UhhOw/9Vve3I+PoMyxqr9VcoVg/m7LVyR/fJJXwbC3k0S+8NH WRIR037H6HcowadgnXT2NBWm0BAdQeCDN8l0/x8My7ul/sNhXfW1JPxsPTYmE6kCrjNR u2XBhJX5X4JHdoA/hI08bKBBkTAhMWpGeFp7+G26LNkhwU9WxQRHhI8h2iWn/zzpcImG cWPQ== X-Gm-Message-State: AAQBX9eurOyMapxX1eQ0gfYqy7FtHbX0gF0tgEnUk6EbvWHiMt90LKbf 9W0w5DFQmuvjZ7NCGNdvNmE= X-Google-Smtp-Source: AKy350ZFVFCylRWDEJICvkzv945j8Xx9k23Os8YbkI3ACNtsSoXwMGjYKQWHzqKc9++w/d11ahrNkA== X-Received: by 2002:a5d:5943:0:b0:2ce:aa0e:c60b with SMTP id e3-20020a5d5943000000b002ceaa0ec60bmr1039770wri.53.1680602838455; Tue, 04 Apr 2023 03:07:18 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id a6-20020adffb86000000b002e8e1a94b19sm5545678wrr.13.2023.04.04.03.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 03:07:17 -0700 (PDT) Date: Tue, 4 Apr 2023 13:07:14 +0300 From: Dan Carpenter To: Hans de Goede Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , kernel test robot , Orlando Chamberlain Subject: Re: sparse false-positive ? (was [linux-next:master 3256/8744] drivers/platform/x86/apple-gmux.c:224:48: sparse: sparse: incorrect type in argument 1 (different address spaces)) Message-ID: References: <202304040401.IMxt7Ubi-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: medzthhi34uz1ijyx9oemcpjsw8ewr7m X-Rspamd-Queue-Id: 30EEC4001D X-HE-Tag: 1680602839-498718 X-HE-Meta: U2FsdGVkX183/CCm7ST9YiN/VWU6G9Y6cG8C/C+ehK20CkSHb8AAiIYaR0z6oVwXsOSoeEPq6yxweWQYgGqkKvb+eBl5+RMXb1i6t6vLZzyMV0zIj0W50pis6EvZa4jBV6MPI8sE50xAqR+3vd8URl/7TGr/OucabWKEyFEPspDrzWzcvK3yLPMXmaexrHrG6nr+TO7fziROP/rsoieSIMzLR3JqIP5d8Qub4VdDRIrdp3/YIM5wqMv7izVVYG7ppa8L8iwSBlWhiKVtJ96sE534X6P8giMXsSFxOzRZnCPwZKoWyrWpWPp95PqoaHQxmej3RPWufVtraShkjQKwuVJLiBV2vGt/iYHYd6ciDXfZf96Xr3pwbaXsE7OiLg5gFvZZvdHs0z/M7kXZrkZLl3Xq3CoC6h0VBwbaOtFu+LFRvNXjG4URo3EdR1qWvHYK/g7AfAc7LMn/z/hqC+X9UuwYVjciiSV9++SWhW3FM6Ip6EhEna0Qd4rfCsLqb4mZX7BCQ6F7mIukTX0QP5BkiRN8vEvuOZeUepropoCUZ8q5wNFJlZZUCIZTnUXaiZ3lPENVnGhDElZUqzi6D5q96l24rku/dPXIOWfqb51eztXTWpZU8d2vznllPlVcAMXRZoQIWTrW0714BfcFZO87Zs6V0Mj1KObTvXmiWVhvj33Vxx8SnqxAHjy0OcptC7iRcTU+1sG5xQk4r74+EowhK726h9uXTj0Ron6H97ziH65sdZmadOXlLu4yo25toLe7hVM2Fjg70+iOM2adtuI/wv1694PcURfwacLI4Oolqcqcptye4/5jlQaVuENNzcF3GftSVqAuuOiYu/PrGNaB7VHkmYrS0oENiyLOpzZhF44T3lSfjwypalHiB4EUHWJpZHogF6dJ3P2WRhIjMDaw68QFQKWNBU5j1lXfhdOy0FblFQu25qdCjwLXDesfsGMi2zBbYB9CC3KJLTsojEE V8dpIO0x 5wiFDwd7OIw9Njki6KuruPf6qjuLN+nT7MssVszWIEC48deAIbvD+c8hBGEvAmh1pK+VfzzM38WK/iiFxP+tVgpiBsrDpJ86TaNEaLKYxtxD8xjgCLgcIW6eLzAHIA1I5QRMiONoM5WIEpj5TRkbbZAoewaqF5zO8/IfqwLmDLEp4T6dJHWf7CDyOxG5yVtHB8Z5prlNsYmbYrjBFVZjaJvVqAg+Dc6uuwtQuuZtZgqTjOQEdAPMQoCyjH+wymnsWnE8onCUi3eyDYKR1kLg5V5e8ipJgCVGJTmWS/mw5sIxsV+5xwYsakDmb0pckH3OMw/LTjWoaFUjSiIp3TBmUX2/gZKo0cLDsxhQwDA5QozlMNWPBJP40ucrYYa73A/RBDXM4q6Dnixlxx0yylKeMxBwl+EUbpI4f0JUIIKRGFhfAwmMehZq0eWdZ33Kg56zRwiz33fllaAME159r2HLbkrAhX5b1hAT2UxGJS+WYXuSxyVj4Nobt6YrT6muTy6aOKp69RQ+QmaRy0ExtXOIiX0Gm3sb1Go9phVYYR0K5MluFyzUg1Jt2YpNuT0Pk+fZUZqDquX9apz8vd1PTcydsv9v9J4OJO41iggiSveQDEC2jkcHFCd0AHIyxbhLQ9dCHIzt0A6aM9SFy7PwIpulk3hZHKBXXLNJbYbYK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 04, 2023 at 11:50:17AM +0200, Hans de Goede wrote: > Dan, > > Can you perhaps help me understand the following sparse warnings, > they seem like false-positives to me. But I'm not used to > sparse giving false-positives so I think I might be missing something > here ? > > On 4/3/23 22:39, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 31bd35b66249699343d2416658f57e97314a433a > > commit: 0c18184de990e63f708b090bcb9fc6c0fbc427cd [3256/8744] platform/x86: apple-gmux: support MMIO gmux on T2 Macs > > config: x86_64-randconfig-s023-20230403 (https://download.01.org/0day-ci/archive/20230404/202304040401.IMxt7Ubi-lkp@intel.com/config) > > compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 > > reproduce: > > # apt-get install sparse > > # sparse version: v0.6.4-39-gce1a6720-dirty > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=0c18184de990e63f708b090bcb9fc6c0fbc427cd > > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > git fetch --no-tags linux-next master > > git checkout 0c18184de990e63f708b090bcb9fc6c0fbc427cd > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 olddefconfig > > make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/x86/ > > > > If you fix the issue, kindly add following tag where applicable > > | Reported-by: kernel test robot > > | Link: https://lore.kernel.org/oe-kbuild-all/202304040401.IMxt7Ubi-lkp@intel.com/ > > > > sparse warnings: (new ones prefixed by >>) > >>> drivers/platform/x86/apple-gmux.c:224:48: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const [noderef] __iomem * @@ got unsigned char [usertype] * @@ > > drivers/platform/x86/apple-gmux.c:224:48: sparse: expected void const [noderef] __iomem * > > drivers/platform/x86/apple-gmux.c:224:48: sparse: got unsigned char [usertype] * > > So apple-gmux.c:224 for the commit these sparse warnings are about reads: > > u8 gwr = ioread8(gmux_data->iomem_base + GMUX_MMIO_COMMAND_SEND); > > Where gmux_data is a "struct apple_gmux_data *" and the iomem_base member is: > > u8 *__iomem iomem_base; > The __iomem should go before the *. u8 __iomem *iomem_base; regards, dan carpenter