From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A090C3DA59 for ; Sat, 20 Jul 2024 08:12:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 866056B0082; Sat, 20 Jul 2024 04:12:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 817556B0085; Sat, 20 Jul 2024 04:12:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DD896B0088; Sat, 20 Jul 2024 04:12:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4F1AA6B0082 for ; Sat, 20 Jul 2024 04:12:00 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F111FC0B39 for ; Sat, 20 Jul 2024 08:11:59 +0000 (UTC) X-FDA: 82359412758.26.68B995A Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf20.hostedemail.com (Postfix) with ESMTP id 408B91C001A for ; Sat, 20 Jul 2024 08:11:55 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf20.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721463076; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TTLM8oLLh2gAf/Sa8HTiVFqGc4uSxkWE+a6C4iq0TL4=; b=31jV2w9BQ9ZOlFUckL6H76lx1kwOGaG2aiPil0SABlzwduLGrp6ApTRcHGzJZTowm6f2BQ FoOMBFjiuEVwK+QebrSgyAKu5T32Z1Tvq+3JlanLuInm1pv5XdFBm5tkqR2HG8eu06GptL zQsAqceNXv/z4y9qscFgqDqRnZPzZEc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721463076; a=rsa-sha256; cv=none; b=Pr5itJiwqXDrIIdUXLpnUdKpGAmT6fWajxjNPJokSpJRTgNYAw+45VcSdZHkyd8caioShp OLG/h7aX1dGOCQsoD1E/bmId730t4yj/se0/nB4xsnhmGCI519LGu06B7D/lXT34gOIeNE a7CQk65JgSWXP3izU2b8cmeeFndbnEI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf20.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4WQzf846hyzlXjK; Sat, 20 Jul 2024 16:06:56 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 55F2F1800A4; Sat, 20 Jul 2024 16:11:52 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 20 Jul 2024 16:11:51 +0800 Message-ID: Date: Sat, 20 Jul 2024 16:11:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] memory tiering: read last_cpupid correctly in do_huge_pmd_numa_page() Content-Language: en-US To: Zi Yan , Andrew Morton , CC: David Hildenbrand , "Huang, Ying" , Baolin Wang , References: <20240719144306.258018-1-ziy@nvidia.com> From: Kefeng Wang In-Reply-To: <20240719144306.258018-1-ziy@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspamd-Queue-Id: 408B91C001A X-Stat-Signature: 5gndywiad1qrxtd6wdza4ccsce1w5f5k X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1721463115-330515 X-HE-Meta: U2FsdGVkX1/q39dZRaGMPza8/6LGdGm/VOhbjFuC17+N/tmwjsKpOBZSYe/BZeDzwCJKJ5/9bKR5TWqfDfmlPV3mQGgI9ZS1JSgTro1UtI+PxwKazO9+37J8h6yWT7JT/05aP1MzbYqtBvCdRU3oQ1Zc0yyw3fibJAcNx00N+dNjgJHxikQF7MTNoihzGL4x5l9ZCI8EYqVGc0n63ijGa9fMlazFF5YACuJtUDdrg+/5gN/6OHrEBmEJQu05c27rWzzruWSyl8bZGe0q00FSyjhSidmmySLouvoPzgOVUcvLDtUOYpHln4EeSiXHgFVsYsDadAfrkEAYV0LuTHrUfbTCbd2bp8vB5yHT8r3uj5Zprb7ZMfGgCaLNv/SIVX6fpMJE3g4SxXEinwVOz9GL6HqC1tXlIQCAyokGcyXQA0jF6RSKAfZbErqQTVdKaAq1X6GLlPiZy7CFwOAvAJ3P8g9Z03SFywYn61xyS6Hta8pazC7LS8U/2P24zaBwPDBF8U5X8QipIrgFtcugYqSVMxMDdMYxnKJ0NYhKQoxFBN5SygzUk89uZJO+YpBs7FYx6WJJsYWkJTtq94dSSsVKVqNTJ6F0xfpAO903DU3hcUbbwCudpuvHwsz5nGLANNLtmHaI9rZEokTvmXaltf2v5RlaD+8zMW6DOewHU5ZpLdpNwsNTL/E2fyqIzz7A9cH7+a2I3XpPuapzMdfikBXbclXWiARHetcn9lnad2zzStc9n09ePzMM4mQfSeEaMSC8gUQmpbETXxv0L2auK8cb8v5MDRymuXCvGcuioNlz4OmM0FzG1QiWOLccwhhmoQypFx5Kfk0rzyU2pnYTYOBsgDgWCLZuYt3lE/g5uiLXvSbIr5WJ6+eCsiyAP+bF01YAX92pVZzJkv+5rSebZndmKHJ/o1J17KhVObHbvah29evdhCPLTvxNObCdc1DXQKzPG8BRS1k/FlMAFd2PfzB i3oQUR67 SYD2MS+PG1Unsi4M3vjGQf0S+vravQo0LLcjXMXtGkyej0McM61zKJ/xeRFKcShcwFJp5OIZ9TWUc/FpjkaNjanuqoin/sCM3l55H47OJXRm1gkiyE/sSyvw7kaXVptfnTOxAIGzemKdFA2VDfZrBFvQCZ4jMskhmxNU1EN/jdWxrDfejIitcPZXXSkyJXCOkhb0FKUIkkgbcPQIsX9DLwqGa10QewWSsZQ3vuCEus5s2u9Q83HlTDYWte1dCG5R3Xwd3qG/n3F8q1VgQdCEghXtoToCcVzrn2mquh+471GibayPn71JwxL1XAswqTZVdWnJN+EnFv3vWS0RNancQMxQ46sGja76spoc77LCV2fuzeZkTzG0qmYpdLuT+hSV45hK6Sxpkc1JYRko= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/19 22:43, Zi Yan wrote: > last_cpupid is only available when memory tiering is off or the folio > is in toptier node. Complete the check to read last_cpupid when it is > available. > > Before the fix, the default last_cpupid will be used even if memory > tiering mode is turned off at runtime instead of the actual value. This > can prevent task_numa_fault() from getting right numa fault stats, but > should not cause any crash. User might see performance changes after the > fix. > > Reported-by: David Hildenbrand > Closes: https://lore.kernel.org/linux-mm/9af34a6b-ca56-4a64-8aa6-ade65f109288@redhat.com/ > Fixes: 33024536bafd ("memory tiering: hot page selection with hint page fault latency") > Signed-off-by: Zi Yan > Reviewed-by: "Huang, Ying" > Reviewed-by: Baolin Wang > Acked-by: David Hildenbrand Reviewed-by: Kefeng Wang and we better to check numabalance mode in migrate_misplaced_folio()? --- a/mm/migrate.c +++ b/mm/migrate.c @@ -2630,7 +2630,8 @@ int migrate_misplaced_folio(struct folio *folio, struct vm_area_struct *vma, putback_movable_pages(&migratepages); if (nr_succeeded) { count_vm_numa_events(NUMA_PAGE_MIGRATE, nr_succeeded); - if (!node_is_toptier(folio_nid(folio)) && node_is_toptier(node)) + if ((sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) + &&!node_is_toptier(folio_nid(folio)) && node_is_toptier(node)) mod_node_page_state(pgdat, PGPROMOTE_SUCCESS, nr_succeeded); } > --- > mm/huge_memory.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index f4be468e06a4..825317aee88e 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1712,7 +1712,8 @@ vm_fault_t do_huge_pmd_numa_page(struct vm_fault *vmf) > * For memory tiering mode, cpupid of slow memory page is used > * to record page access time. So use default value. > */ > - if (node_is_toptier(nid)) > + if (!(sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) || > + node_is_toptier(nid)) > last_cpupid = folio_last_cpupid(folio); > target_nid = numa_migrate_prep(folio, vmf, haddr, nid, &flags); > if (target_nid == NUMA_NO_NODE)