From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71447C48BEB for ; Wed, 14 Feb 2024 22:59:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F33006B009B; Wed, 14 Feb 2024 17:59:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EBCB26B009C; Wed, 14 Feb 2024 17:59:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D36606B009D; Wed, 14 Feb 2024 17:59:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BCA5A6B009B for ; Wed, 14 Feb 2024 17:59:14 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 96C891603C5 for ; Wed, 14 Feb 2024 22:59:14 +0000 (UTC) X-FDA: 81791927028.24.57A6B52 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by imf10.hostedemail.com (Postfix) with ESMTP id 7BE19C0013 for ; Wed, 14 Feb 2024 22:59:12 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=llIaJN9N; spf=none (imf10.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 198.175.65.18) smtp.mailfrom=tim.c.chen@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707951552; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fcq93C7gdofVg9DTS2SlMy7tfYdJIINLwP8jKGvNgZE=; b=cjrWVoGE1DKOV43dba4V5aaZbnQXaStg87n4M3DaKWRRFQ/3YBxjxr7xzqKTcra6Ss07be 9xgSV8Pdb0vfbILPm3lCkO77mu9YgPRr6MvxCsn8jGEcaZelU6Sc0qpeTe3d10XI2HVGEW pQRYzmPFi7hjld9Ujz69g2wO60jRPqo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707951552; a=rsa-sha256; cv=none; b=D5QXDXqgF5BJ/exy5shCzcthxIFAMWQKowNxquvIv4ZfaFrZRqStoh0Pmo2aGI6lGEp7aw GGVjAQR4zKBbTV5i1avfv/Goli3rhUdWHj5awuroHZZYmw+DHlMBLSvXXpKR1bvzlN2dq5 GSS4TZCvOkHmYbpKIJT0PAcbkJRt1t8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=llIaJN9N; spf=none (imf10.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 198.175.65.18) smtp.mailfrom=tim.c.chen@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707951552; x=1739487552; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=gUumXsY6f/GstkSVOqlmPHr63YyKvQbTJvGkcUOnWRc=; b=llIaJN9NYrbm3jL8doeju5Np09zbOWb0rGBSuo61s+QCBKMDjgjxaw+I N/DBJcYQWv0Q1M7b/7qfAwuDfow2VTIX5tE252NVCeXQnrPyeKsqZn+vR lVoIZu75RQVlpQOCWDOswv4C6TcyrxHepo0Kza1K010m5keCc1uoX2bEV k4yhDrwojeKHkrqBcGvY6Lzd0M/0GecBHDZ9oqPnVclUmpUytLnQQZmEI p2dnSPcSKGkoirrmgO1N8s44gyJcITE8qeYtF2ki7Ew8jcJhWG7Nf8QVU eWJN5eFBHORb3Hi7zkUaMZ7mMg7CuhiGMP2KksWTE5jZppKvZQvsp2eR7 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="2143116" X-IronPort-AV: E=Sophos;i="6.06,160,1705392000"; d="scan'208";a="2143116" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2024 14:59:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,160,1705392000"; d="scan'208";a="3324531" Received: from wfaimone-mobl.amr.corp.intel.com (HELO [10.209.29.231]) ([10.209.29.231]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2024 14:59:06 -0800 Message-ID: Subject: Re: [PATCH v3 00/35] Memory allocation profiling From: Tim Chen To: Suren Baghdasaryan , Yosry Ahmed Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Date: Wed, 14 Feb 2024 14:59:05 -0800 In-Reply-To: References: <20240212213922.783301-1-surenb@google.com> <4f24986587b53be3f9ece187a3105774eb27c12f.camel@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Rspamd-Queue-Id: 7BE19C0013 X-Rspam-User: X-Stat-Signature: wz6w88oe5mceuxcyj9is885hfm6pke4o X-Rspamd-Server: rspam03 X-HE-Tag: 1707951552-420197 X-HE-Meta: U2FsdGVkX18Pgx87RLNx5xEXMSRGKeAFIIFlu4nEgzEf4IF90e/BOUUdRj152srO5US/xCKjXLhiCDFTdW+WjlY6K8N+xYxnyJy5fRgbzNGRYKlLrepFKR949XxIYTxE252bjSY4qUMONnwiybPSNghD4MpZ6wTvQDPBJbKQfsdbtFprZn6hqojkVUwHjW6Q9xf7qGKH8MeDlZG/jWq8/vX4E1tXy7xBalIdQwKWSj2kaiDjEw0vYoPGGjPxjmyj8f1VJyEK6Y3+BLC1gUeH9MAEtX+GfDCWgKydmsIPzGDAXSpbBb8C5QZN2T4WY3X1Adwv5IV3a9gDg2hB+AWK/Weai3oImdhcAhqXs7AQQQed8zVBq6oIRvhY3/HPmlHtr/AZxqnHGQyCaDLSzlfQ1rYbjqwZ3e7hXye8BKmznSYyXSWWWvmVrVXjabNsAixawMimeRM/WUKbBRS7SzlBo9+kT9foP6xhqBn9q2lWKnJaPjpXg3BqZejLaqBRX9qg4pf/9ujbMSYz0b2r9CkrjV/DjCqFLY0kfe3P8U/SeuHxLxut6mWdNjq2SMdPSriHZtID6+yA8Yo7Ouo6wGOgHIenZfBObLMVWfLRIHbBFQFpkQZ2jkfvd6Gof7do1RvKqiHV5YhQeYqxOpsIEf3GZ1BqHmQ41K/Dn6cmT1Q6DVXo8w66sWF/2366myAq2xdPGtvQ79eRWnevzIv1o0XhwEmIP71KwvYP3ML5XrvoMFt2vDDpwuZMnvdqQQAQKyDRfHNPvIhzktBQax6hsMTQRl0WaAlmf1s6Xl/ueGSVHltA0V/182d70KZXTVdSCZZ8eSYMl0kSjAwnJFw3Mfy8RXTQhzvLS/CmkK2G5+QnDfOXI0XrntKc5LD5r5vMI3KubNus908W8qf1nAdX0pxJ8k4aaqpY/jrL9LBn1/bnDcSnhNDjoZCQ9klV/It7dFGIKlWBkvEJxGk5Nd7Ri2Y e/rk0uk5 XVQfmKwR4dJWis6cV6sGveZlXKzxwl5EZK3oDEux1/54p5GMN/lAcI8rjj6qhx9e6GSjjMu1HUvUgr17036755yOMBqxi6g877Epq/vvFbo+rYCKliLJRJfsIy/k/HYYjpns6AxgVvP4IdGqoObHbBwTNNEc3oYy5y+02zJlI63glReQmW8Vl8dXFstmvcZaKt8OY3bftHchFbt4dRUGNJAYpzLQ0OjFkGI6O X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2024-02-14 at 12:30 -0800, Suren Baghdasaryan wrote: > On Wed, Feb 14, 2024 at 12:17=E2=80=AFPM Yosry Ahmed wrote: > >=20 > > > > > Performance overhead: > > > > > To evaluate performance we implemented an in-kernel test executin= g > > > > > multiple get_free_page/free_page and kmalloc/kfree calls with all= ocation > > > > > sizes growing from 8 to 240 bytes with CPU frequency set to max a= nd CPU > > > > > affinity set to a specific CPU to minimize the noise. Below are r= esults > > > > > from running the test on Ubuntu 22.04.2 LTS with 6.8.0-rc1 kernel= on > > > > > 56 core Intel Xeon: > > > > >=20 > > > > > kmalloc pgalloc > > > > > (1 baseline) 6.764s 16.902s > > > > > (2 default disabled) 6.793s (+0.43%) 17.007s (+0.62%) > > > > > (3 default enabled) 7.197s (+6.40%) 23.666s (+40.02%) > > > > > (4 runtime enabled) 7.405s (+9.48%) 23.901s (+41.41%) > > > > > (5 memcg) 13.388s (+97.94%) 48.460s (+186.71%= ) > > >=20 > > > (6 default disabled+memcg) 13.332s (+97.10%) 48.105s (+184= .61%) > > > (7 default enabled+memcg) 13.446s (+98.78%) 54.963s (+225.1= 8%) > >=20 > > I think these numbers are very interesting for folks that already use > > memcg. Specifically, the difference between 6 & 7, which seems to be > > ~0.85% and ~14.25%. IIUC, this means that the extra overhead is > > relatively much lower if someone is already using memcgs. >=20 > Well, yes, percentage-wise it's much lower. If you look at the > absolute difference between 6 & 7 vs 2 & 3, it's quite close. >=20 > >=20 > > >=20 > > > (6) shows a bit better performance than (5) but it's probably noise. = I > > > would expect them to be roughly the same. Hope this helps. > > >=20 > > > >=20 Thanks for the data. It does show that turning on memcg does not cost extra overhead percentage wise. Tim