From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7545C48BC3 for ; Wed, 14 Feb 2024 22:54:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 483BC8D0014; Wed, 14 Feb 2024 17:54:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4328D8D000E; Wed, 14 Feb 2024 17:54:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D3698D0014; Wed, 14 Feb 2024 17:54:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1C8F98D000E for ; Wed, 14 Feb 2024 17:54:26 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ECFA0A25D4 for ; Wed, 14 Feb 2024 22:54:25 +0000 (UTC) X-FDA: 81791914890.09.0AE6228 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by imf15.hostedemail.com (Postfix) with ESMTP id CD1B2A0009 for ; Wed, 14 Feb 2024 22:54:22 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LXyekDva; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf15.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 192.198.163.19) smtp.mailfrom=tim.c.chen@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707951263; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GfoL0pJUNb0n2G++vABkwrKvc/KGYO3bCv1OqN/SiQo=; b=S4a4YIWAiQ/WpgbnxlfE1Ku71TFMc9ibVYJDJYH0WG56jszVM3Kci2LsbI8iBvGxMYuQbF MFvfV0uKtvQw1PM9NOjtY1MahJzV6hHtLuOxfA79zomWmhkUxJ5l+8vB7JoZOVY9vfK4wD yCd4hNYtSa+GdvP14Z9L7HDJo2D4qds= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LXyekDva; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf15.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 192.198.163.19) smtp.mailfrom=tim.c.chen@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707951263; a=rsa-sha256; cv=none; b=56IIBboCEV7GidLuoN2epV1LSzwfMsI+/hsLSYP6CRuOxZ9gurtTzpa6XRXAOILF94PyKs u4NnYq20lgbhI07+nDQfclFBeP2awUenDA7KB879rSDOJhP+BiUWb0XMtiHwuFBGsZfPKR BSkraDoMwYczEKKuHKiSFn3qK7a2R54= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707951263; x=1739487263; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=IWhUg7d/C6jHVyCqMtt1pfAI113aqF/StezZi96q7+w=; b=LXyekDvah9fgpB2GhFldHz0RFqBXvGgZpX+gj5mzOex32ZLfa8fADsoQ FzGIpW/EOjkiafB23HqzMbBvjfToCLxEUEbUIyCx9urzfCYSEop+h8A6H IbnMizdU4BL3uBpWUkeJCCXfXEYozD9i4GomUd0NxUVPlp5kmOW0od39c ln/d0g74ARqfUo0v/Y7U8gsg8Rhvo+1VH7vNRQIua0dycJ3Zl0/CeaHmy U6yVjqUrjCwHgBghT4VYLdZXrsYHQY/R6yXoou10UoAZlW6zjotRHYjTO HfCBrVPtd/VkBzOZgtjVIJeE9QW92pX9YAIeF59yjDN+h82Z9tx5kGLhA g==; X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="1895530" X-IronPort-AV: E=Sophos;i="6.06,160,1705392000"; d="scan'208";a="1895530" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2024 14:54:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,160,1705392000"; d="scan'208";a="7966142" Received: from wfaimone-mobl.amr.corp.intel.com (HELO [10.209.29.231]) ([10.209.29.231]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2024 14:54:20 -0800 Message-ID: Subject: Re: [PATCH v3] mm: swap: async free swap slot cache entries From: Tim Chen To: Chris Li Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Wei Xu , Yu Zhao , Greg Thelen , Chun-Tse Shao , Yosry Ahmed , Michal Hocko , Mel Gorman , Huang Ying , Nhat Pham , Kairui Song , Barry Song Date: Wed, 14 Feb 2024 14:54:19 -0800 In-Reply-To: References: <20240213-async-free-v3-1-b89c3cc48384@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Rspamd-Queue-Id: CD1B2A0009 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: w7yumy45xtr3qn8udkc3w7t5zeixzmzz X-HE-Tag: 1707951262-386370 X-HE-Meta: U2FsdGVkX18Ad1fIYfq3AAecXtctxhV0ma1WumCnrd4vgNm7YFx874tWb8NXXd/KwSuCMGqW6ciNW9nBQAltNz3GPOKagL+fyOIOdPQe2vWacah7oIhDzqBs1Ee2312P2JZk+csegx2LVJMF+JUBQEDYfvqOU3KHVFrKrbG7PM7FelStS/wgHgUJXwhTIDxOyfhCBrM+YVEW4aQk1akn2aOk06gCHcwspWNT9K+1qAPFm+OO5AYwODU+6NmVgy2+GFhTa+6e1MT+QvZgX5E2ceW1nR0G4/6MiKERcoWL4NmoO6qRH3v2Xts7cJJE76rtIf7GSmOQfoxmtMpQWijCHOXTak2NgHy8EohmAYiX/cTppr0IXRSidYD79HLfMDnNeHSkkVRz8QVHl/v+LWinAQLOu/Eab/UmrhVzjA7VlrCDFJlCYntdlWsrHH4opbno2vbS/7b4F6oliAhZ0E/QAp916oVkFMP/mrj8DJqJefNDuP4vfYwd9iyEq8ilzYvgDbI4vk6z4lBU1mO9wME0FfYj5JoFjG97ifnAFSdC/UEWB4CmjVdAa3dffHJTgcX3ZUtmEVf09vM+bAamVsQfdoi6IZaaOOYFlkOcE6gPnmtjXjQpdVnzrVz/X9YSfCf6hrIFC+TTQl06UP/6aUYBvlnMaBsSJsl8S+mIe+o0YLsAzPdtO6OtMPFmoG2mIX2T8ggavUuX7e+XxQABWDYos/tODf6ZUk19aPFR+TnQYgt0P+toIsgU5s7f94xMmTovPdxVhFOCiCCiDk5wGEd5xHPdWxM4tJ5NdM/j3M+jVoTO4r6iLr6ORx7pH41H44vcMLBuEnolnOZHN/9fHwoKgwoFVB3Jz7yShnhrPGaknnJF06eSr6Czyb86zDN6d8yGV89L4QraoBbC16Zy85lVt8clL0X5dIFOFXpXvnHtKJU6t+CqaJiphXQSPyMYKLpXJkBj1L6qT+2qkXw28XI ENsSMSCl uwsSOsotGAxbcxTRLl0i8DD9PKe6WYCMn80/IMJXbiNGA6e+/eEqxu+8mwM+QzvFxPnkgUhsA9K5cThDfhJ+ZBmA9CpH3CqG5+QzxW3YyZrIThSF8VPA+4F0PzgzPr766Wkc91YjhxF0/cAtmSN+gNMFocw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2024-02-14 at 10:56 -0800, Chris Li wrote: > On Tue, Feb 13, 2024 at 4:08=E2=80=AFPM Tim Chen wrote: > >=20 > >=20 > > >=20 > > > extern bool swap_slot_cache_enabled; > > > +extern uint8_t slot_cache_async_free __read_mostly; > >=20 > > Why wouldn't you enable the async_free always? > > Otherwise the patch looks fine to me. >=20 > Thanks for the feedback. >=20 > Just in case someone doesn't care about this optimization and wants to > opt out this behavior? > Anyway, I am happy to update the patch without the sysfs control file as = well. >=20 At least I couldn't see a downside to enable it always in the latest patch. I think adding an extra sysfs is unnecessary. Tim