From: Tim Chen <tim.c.chen@linux.intel.com>
To: Chris Li <chriscli@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Wei Xu <weixugc@google.com>, Yu Zhao <yuzhao@google.com>,
Greg Thelen <gthelen@google.com>,
Chun-Tse Shao <ctshao@google.com>,
Yosry Ahmed <yosryahmed@google.com>,
Michal Hocko <mhocko@suse.com>,
Mel Gorman <mgorman@techsingularity.net>,
Huang Ying <ying.huang@intel.com>, Nhat Pham <nphamcs@gmail.com>,
Kairui Song <kasong@tencent.com>,
Barry Song <v-songbaohua@oppo.com>
Subject: Re: [PATCH v3] mm: swap: async free swap slot cache entries
Date: Wed, 14 Feb 2024 14:54:19 -0800 [thread overview]
Message-ID: <f495b4844ffd9ad4340051edf8744d9d5584747b.camel@linux.intel.com> (raw)
In-Reply-To: <CAF8kJuMXjp1A1kdS_x-S_dyst8MLHwjuAEt-SfGERKVYZNmRww@mail.gmail.com>
On Wed, 2024-02-14 at 10:56 -0800, Chris Li wrote:
> On Tue, Feb 13, 2024 at 4:08 PM Tim Chen <tim.c.chen@linux.intel.com> wrote:
> >
> >
> > >
> > > extern bool swap_slot_cache_enabled;
> > > +extern uint8_t slot_cache_async_free __read_mostly;
> >
> > Why wouldn't you enable the async_free always?
> > Otherwise the patch looks fine to me.
>
> Thanks for the feedback.
>
> Just in case someone doesn't care about this optimization and wants to
> opt out this behavior?
> Anyway, I am happy to update the patch without the sysfs control file as well.
>
At least I couldn't see a downside to enable it always in the latest
patch. I think adding an extra sysfs is unnecessary.
Tim
next prev parent reply other threads:[~2024-02-14 22:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 23:20 Chris Li
2024-02-14 0:08 ` Tim Chen
2024-02-14 18:56 ` Chris Li
2024-02-14 22:54 ` Tim Chen [this message]
2024-02-15 1:03 ` Chris Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f495b4844ffd9ad4340051edf8744d9d5584747b.camel@linux.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=chriscli@google.com \
--cc=ctshao@google.com \
--cc=gthelen@google.com \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=nphamcs@gmail.com \
--cc=v-songbaohua@oppo.com \
--cc=weixugc@google.com \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox