From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6038BC3DA63 for ; Tue, 23 Jul 2024 21:37:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B45F56B007B; Tue, 23 Jul 2024 17:37:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA83E6B0082; Tue, 23 Jul 2024 17:37:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D3556B0083; Tue, 23 Jul 2024 17:37:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6C40F6B007B for ; Tue, 23 Jul 2024 17:37:01 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0092AA256E for ; Tue, 23 Jul 2024 21:37:00 +0000 (UTC) X-FDA: 82372327800.04.B67FDAD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id AA7AD4000A for ; Tue, 23 Jul 2024 21:36:58 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FPZXRdFd; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dV9Lhnw3; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721770571; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iQAkQLy5owb3Ohx4ccL2PMDh3alX5rChIh22EsOoE1k=; b=fxoyyFkljqhNYFRRuyu2kG2SpEoaNxWHbk+TUFMVcBVLQ+iIa1A7YJdCq0glaNMUeqV1xJ clbkTQXswl1+jpzX2tgd2sslTpg0DhOrBQHqp7o9xLvsbMeuG3Vos3BmhKZ6+cQlpdS3Wm ALCQ4sQAtN85X7akLQyAwRmx8efhuO8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721770571; a=rsa-sha256; cv=none; b=wknVl5B8sUek+pEGyO8AFgfdaayaOVGztPDMNwvw/h6sVIKONdH6Q2qJYd+BByibnDUPkE jGsmtoEf7A2gjZCjk9CfJI2Irc+j4L1CuHFkD/tpDq46QEuCAeii3fzc41NyQcB4lPISrB lYPE9Opm+Vq50rb9g8QBpYEaYfQGMiM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FPZXRdFd; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dV9Lhnw3; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721770617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iQAkQLy5owb3Ohx4ccL2PMDh3alX5rChIh22EsOoE1k=; b=FPZXRdFdzodE0KmeJmPBBjYEcwaG/+hwSnAhTIkNnLJqeS81A36BrIdXKO7AMZjQ7u4/Iw exIJZxTlHUWwtrG96DgX9uNSuZsEzjEMn4VkAxX4WyEjDh6y3nJYJ9745EmW1OsQ6ltsyT mLn3hlqORSPghmb/R89NNBB8XhqbP8M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721770618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iQAkQLy5owb3Ohx4ccL2PMDh3alX5rChIh22EsOoE1k=; b=dV9Lhnw3/xaExEnjUQbvifkXrRW7mWvE4kJOv6kNWC8vMaBabNc6uSHp9r1Ze2sOQkkMza I7OjzBPe5yBYkPQZYAbdspMiOuN4z4MYPOUIqTu8I5/hAuguF5sou4bruEbiOrBSH4sYzy EhgIiiajqK9E77ha0nKgR0+qp+yof54= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-486-MCJnCRQbOOK67C59VKEHHg-1; Tue, 23 Jul 2024 17:36:55 -0400 X-MC-Unique: MCJnCRQbOOK67C59VKEHHg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-427df7b6879so24671525e9.2 for ; Tue, 23 Jul 2024 14:36:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721770614; x=1722375414; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=iQAkQLy5owb3Ohx4ccL2PMDh3alX5rChIh22EsOoE1k=; b=naQ9MopL5VXKxM/bEnmUolwxcjvbEgSQvLgAso60aQY1CPLjsTSmzipLQohu7N5OcS BNlNYzLEAy4P0gTnt2lfL+jTF7HOb9KE8shhX+IyyoTSHcUy1c/dFZfh28fP0FkddnJJ Iff36fCiMVu3jGrbtX+m2UihFs/8sitRdGc3mQxGVVaQeZvgQ+PKw+wE4AK17hYl1CtG t7Ahk/SRixEviyqHUj+gF55ftDrdImbUeIPFpv2jQdUaL4/ZHodD6KaKRqCJe/9Wd998 NwOP9lm1RY2fJ9FLDfnyW11GVv1stB4sBldLtpRMPZbBBsEVkxm8JIlTj/K9ANsFm/7v SHlA== X-Forwarded-Encrypted: i=1; AJvYcCXOxdH3nRcdaIwNnpVLtroj+YrieCINfc522i36jaauU0WiZrSgDTy5pRexHR0+C8o3Jy0Gux9KHBPLUXx0shSJWvs= X-Gm-Message-State: AOJu0Yz+C+heqnEm5poOCu1UfRB/ouVS686nhCBipFxOPXSgTNllRuZA jbzwmg5ctGgHCyMguE27ZVxp3VfA9Y56kcvn4bTelyp7ezl9fi2+rAjgvJj2ddcz7DW2MrqUVgq M1gvwi+ujsZcDnyD8TSt/DvLREeVzwW9zPNZf8cA7vX+U9ZOb X-Received: by 2002:a5d:6a8a:0:b0:368:8015:8a96 with SMTP id ffacd0b85a97d-369bae135f8mr7228069f8f.16.1721770614307; Tue, 23 Jul 2024 14:36:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGKOxWZL2071+o5jNbdmX2PblEO87o9ntamxpRWAj/o2mSsVDtoU7uJhiP2p7dZSYxbVeb0dw== X-Received: by 2002:a5d:6a8a:0:b0:368:8015:8a96 with SMTP id ffacd0b85a97d-369bae135f8mr7228059f8f.16.1721770613829; Tue, 23 Jul 2024 14:36:53 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:ed00:9dc2:1adb:d133:4434? (p200300cbc72fed009dc21adbd1334434.dip0.t-ipconnect.de. [2003:cb:c72f:ed00:9dc2:1adb:d133:4434]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-368787eced0sm12397564f8f.98.2024.07.23.14.36.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jul 2024 14:36:53 -0700 (PDT) Message-ID: Date: Tue, 23 Jul 2024 23:36:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/x86/pat: Only untrack the pfn range if unmap region To: Peter Xu Cc: Yan Zhao , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Andrew Morton , Alex Williamson , Jason Gunthorpe , Al Viro , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "Kirill A . Shutemov" , "x86@kernel.org" , "Tian, Kevin" , Pei Li , David Wang <00107082@163.com>, Bert Karwatzki , Sergey Senozhatsky References: <1a0884cb-39ed-455e-a505-7c1b2a0e5225@redhat.com> <56c982c4-9863-4134-b088-8dfb4b94c531@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 1nuj5rje65949nh353y44fqib1wywx3n X-Rspamd-Queue-Id: AA7AD4000A X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721770618-751299 X-HE-Meta: U2FsdGVkX1/dKZdKIrnvJevJDnFs1G+hnSmi5QlzonMu4mlXxBTdOhh5M76yqxGzBdbLkXf6I5bIsKF/KbTSsxmXTsfeWNEzKNtLDAQFH0GhP58ycsCkLdOBNncRxZh3hudAiyW/WlU54U/9VWb/HzZDKnF/YcGCc+kN/dtfZeJl3YNe6zZYXPKv9Dw+WwMSeNIP/EkX1xkXtmVbSeJLwWkQI/VWT71p/X5NJOKkbP25yzhoV4NJwj31sBApVv3+DfBhVFeWi1eAht7orcPltDR3b1Hb38TaOsFREC532rhBSqVP0bk1TA29alNZovMoDyK2SpZjWWjr4X4dBeegOiHOJQvGpjOwsSuZNwaOoFL809eiqZrk3TPxNCgZ3sa/ytLatHHDChp10Pv37Z7Pf+qPK+m4DIGSSTpj6yp+1HUxfki5rxlunYwnZq5SR1oBR+8FKk3wXyPr2wA6vmvMMqeOVYCFp0PCin6gErAk0eaTxSicckQ68+iBwA2YeYkvdYDehTxC5noxc2+2RjLpb+3fDrLZbp8NtEdp/LDbOldUeIILAhXz2thvD+Nw2zUXaioZQ7VNZ6FcVfx0QMgsPH/hHfIgUqVkJkzB/K4wzyPlyLAsvMSDccdeREIHozmxQeD1wHJFSn0WFsJVTmgqzHilGMw1RJndzhL/C9FcQ0zy+31RocdamxeUKduBA/XJIZgGMwNJe0AnF9+UlssEJPzmE5xEJBNaL1qWnU2IKvlm/KN0+zCijIfWOGzk3Be28KYsNZ9vK/uQ50TngyRYkQTPRPydhcrYN9IMxbY0SvxDX4eKLCM1cZyyrmwr72KpRFggD6fUIF5TXGjACsH/ouvpjAI40UuPm0AR7IAWdkz85FT3dVFdkhMeVkv43OZykSDZrr0vfN9Uod2z9ppHxq1/pQwb/wJBBkHKmcY1JgGEZBv/DjdcqqrNr+fKpZUBIqmimjB5axD7rZ33FTk 2qSOQX9o xWt1b9lnRMyiQGfVwRH3uvt5h1L8T6I8Rl/zASRtsh3gUXg3oW5qWEa5aZtIevc/FgdkDBefZ4bC4hque8P4yioizvK9DvMKreu0DgUQnI3OJIXs8tEzZ4cC+kEzcJPZyzif5oOkEdjWBjzKdyr7gzKlzUcDc5sATU2dMceJnfICfUNPYeNkZ/+/qnVKJPKzVTbJ/IBUTFBZDQx9gQk+mjBlCp+ZpZRCfsBNjTlwgO7Ach1KtSsk6QNA3GIZgUeRSEEqy45hNNN6ojv1fuqJOdHvWmPQd1VVic8htZG5veYFRLoZmGYkfWqCgbMIAiHvxfksnAMIrUkf0ovUa9NS1UmH7dk8bm7lS27DrISUtJQzUV31Io+4nSpkUjzVp6Ierte2n9NGZd86SC6jtdsrU5HQ6MAwSS0Iad3NVvds6bV8IOcdITCyZvvql3eSkFb03WlHqtc+KvxdqF+LJLvd9HuDxr6P+bC4q3ovTptgMe7DZp9I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23.07.24 22:27, Peter Xu wrote: > On Mon, Jul 22, 2024 at 11:17:57AM +0200, David Hildenbrand wrote: >> What we do have is a single VMA, whereby within that VMA we place various >> different PFN ranges. (randomly looking at drivers/video/fbdev/smscufx.c) >> >> These wouldn't have triggered VM_PAT code. > > Right, it looks like VM_PAT is only applying to a whole-vma mapping, even > though I don't know how that was designed.. > > I wished vma->vm_pgoff was for storing the base PFN for VM_SHARED too: now > it only works like that for CoW mappings in remap_pfn_range_notrack(), then > it looks like VM_SHARED users of remap_pfn_range() can reuse vm_pgoff, and > I think VFIO does reuse it at least.. > > I am a bit confused on why Linux made that different for VM_SHARED, > probably since b3b9c2932c32 ("mm, x86, pat: rework linear pfn-mmap > tracking"). I wished vm_pgoff was always used for internal maintenance > (even for VM_SHARED) so this issue should be easier to solve. > > Maybe we can still re-define vm_pgoff for VM_SHARED pfnmaps? The caller > should always be able to encode information in vm_private_data anyway. > But I think that might break OOT users.. Yeah, I played with this idea when trying to remove the page table walk and storing it in the VMA, avoiding consuming more memory. The vm_pgoff usage for VM_PFNMAP mappings that I could spot looked nasty enough for me to not dare trying. I wonder if we could just let relevant users do the PAT handling manually: I'm also not sure how many remap_pfn_range users end up triggering VM_PAT code although they don't really have to (just because they happen to cover a full VMA)? One nasty thing is fork(), I was wondering if relevant users really rely on that or if we could force these VMAs to simply not get copied during fork. During fork() we have to "duplicate" the reservation ... No real solution yet :/ Getting id of the page table walk is possible (I can try digging up the patch I was able to come up with), but it feels like the wrong approach. The owner of the VMA should have that information ... -- Cheers, David / dhildenb