From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4605C43334 for ; Fri, 24 Jun 2022 09:36:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CEC2B8E0209; Fri, 24 Jun 2022 05:36:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9B4B8E0205; Fri, 24 Jun 2022 05:36:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B89F58E0209; Fri, 24 Jun 2022 05:36:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A99DF8E0205 for ; Fri, 24 Jun 2022 05:36:12 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 80D9D80C81 for ; Fri, 24 Jun 2022 09:36:12 +0000 (UTC) X-FDA: 79612623384.18.F9DF95B Received: from out199-8.us.a.mail.aliyun.com (out199-8.us.a.mail.aliyun.com [47.90.199.8]) by imf15.hostedemail.com (Postfix) with ESMTP id D657BA0022 for ; Fri, 24 Jun 2022 09:36:10 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VHGmXek_1656063365; Received: from 30.97.49.29(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VHGmXek_1656063365) by smtp.aliyun-inc.com; Fri, 24 Jun 2022 17:36:06 +0800 Message-ID: Date: Fri, 24 Jun 2022 17:36:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 3/7] migrate_pages(): fix THP failure counting for -ENOMEM To: Huang Ying , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zi Yan , Yang Shi References: <20220624025309.1033400-1-ying.huang@intel.com> <20220624025309.1033400-4-ying.huang@intel.com> From: Baolin Wang In-Reply-To: <20220624025309.1033400-4-ying.huang@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656063372; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LrUZ01vtWbuTuhuM35BhDvc5ia1efsnIu+wzY8cKCGc=; b=n9eK4fHXvdIthgOI0kq2CqRTTfAeTNnJ2MnWbZ8e/1+1+cIx+eacJDKdnhvQ6Og+7a9d+g 5HVS1MKhtI8xrGE/GUVw9aiPjaegBVa7adUkem9db9DlImcIBBbBxtVcsORwj+VagzXz2k lotvQE7sEluIYza/Q722OFk0trn81SU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656063372; a=rsa-sha256; cv=none; b=X5NI2DemCn16K4ppMzMSST3iPeBHyl4uQhQsc9w1mkrN76QuxoCeWLcP+gdtm+d4gQQUzX oBnDrfLdqe2v9aFl4e66k5/lcWFUQ7L9r47GBqn6Et5Wl/bEIB3n2+mFfHgDImwFwTENPF 0XHvcbT7gLX0iDcBTbV5eClKDgyr8ro= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 47.90.199.8 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 47.90.199.8 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D657BA0022 X-Stat-Signature: kk9n8d9kkua9gqpofouuo8zsi7se63g1 X-HE-Tag: 1656063370-97447 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/24/2022 10:53 AM, Huang Ying wrote: > In unmap_and_move(), if the new THP cannot be allocated, -ENOMEM will > be returned, and migrate_pages() will try to split the THP unless > "reason" is MR_NUMA_MISPLACED (that is, nosplit == true). But when > nosplit == true, the THP migration failure will not be counted. This > is incorrect. So in this patch, the THP migration failure will be > counted for -ENOMEM regardless of nosplit is true or false. The > nr_failed counting is fixed too, although that is not used actually. No strong opinion about the 'nr_failed' updating, like you said, we did not use it in this case. Maybe just add some comments instead of adding some unused code? Otherwise looks good to me. Reviewed-by: Baolin Wang > > Signed-off-by: "Huang, Ying" > Fixes: 5984fabb6e82 ("mm: move_pages: report the number of non-attempted pages") > Cc: Baolin Wang > Cc: Zi Yan > Cc: Yang Shi > --- > mm/migrate.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 82444e7df9f1..542533e4e3cf 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1425,11 +1425,11 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page, > /* > * When memory is low, don't bother to try to migrate > * other pages, just exit. > - * THP NUMA faulting doesn't split THP to retry. > */ > - if (is_thp && !nosplit) { > + if (is_thp) { > nr_thp_failed++; > - if (!try_split_thp(page, &thp_split_pages)) { > + /* THP NUMA faulting doesn't split THP to retry. */ > + if (!nosplit && !try_split_thp(page, &thp_split_pages)) { > nr_thp_split++; > goto retry; > } > @@ -1446,6 +1446,8 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page, > */ > list_splice_init(&thp_split_pages, from); > nr_thp_failed += thp_retry; > + if (!no_subpage_counting) > + nr_failed += retry; > goto out; > case -EAGAIN: > if (is_thp)