From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8007EC636CC for ; Thu, 16 Feb 2023 09:06:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA1FD6B0071; Thu, 16 Feb 2023 04:06:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E2B476B0072; Thu, 16 Feb 2023 04:06:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7E916B0073; Thu, 16 Feb 2023 04:06:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BA2506B0071 for ; Thu, 16 Feb 2023 04:06:40 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 82CAA1211B0 for ; Thu, 16 Feb 2023 09:06:40 +0000 (UTC) X-FDA: 80472574560.03.3F3DDC8 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf28.hostedemail.com (Postfix) with ESMTP id 31DBBC0015 for ; Thu, 16 Feb 2023 09:06:38 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=OfTlQqnf; spf=pass (imf28.hostedemail.com: domain of schnelle@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=schnelle@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676538398; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oDZWguDzkkgUlhjTXniQgW8NbcX0l1LLI9MK2woh0/c=; b=EV9KHWkuOPdlblbFNqviEHP98EtAcrGHiyA8ANXJ6W/ZpYvw2a6fQfglz3d7nPojYHWqmY Zb+eSV4hgY5vy3w5W5trLCQmqhcIDnSd8hR2pdIxidONWSvAoLVPVRGhW+SJXOZzOwXqVD HsnGRA0zvvq+NBarkT36vK4oDZKG52Y= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=OfTlQqnf; spf=pass (imf28.hostedemail.com: domain of schnelle@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=schnelle@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676538398; a=rsa-sha256; cv=none; b=SY8jQb1ZRFfzTD4llzm2ZYtn/M4YRwgAt0CkajJEg073ZTpEKMig6ihOO2+KXdx7N8Q4ZV Yq9o2IovI5VbMuWH5c/X8ZHirBFhI3q5OC4/m7jMSS8AiEYqwTmmaRuXLws4Pm3v1vtkuA tQlybXNiawo6yFzrhlDaWxStHAktGk8= Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31G7kTpT012454; Thu, 16 Feb 2023 09:06:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=oDZWguDzkkgUlhjTXniQgW8NbcX0l1LLI9MK2woh0/c=; b=OfTlQqnfR1j1VbZx81MZOPaYaTTHadETCEakTHA9nTCaDpB3fjAkVgY5bC0izpVGq0BB 0TFwNP2unVsoIGUz4yZe8QWF9pkodruFYaTVgr4kBvY0AEcVsknXsJ/bm/ZTUzuCTl9r vMvoYZOyF2kgHhF3g3FEsd6GKFvoKeyOVSFFdtFGJY0bP5b2QYCbrFQ0AVsjE0mkZLa8 R5HvpbZQuAqDIKJkzCZkcaz8unYHeenJLpu9iNzwtKLCQl7q5ffbSY5dj/VwEvXRqYcK ABhEyMgdz1BsSKZnUnw/USRcSAei9yCoAfnoKnfnt4MLWL9sJeVd2fw6Ezxvg5gU6/pL 8Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3nsf973h6c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Feb 2023 09:06:34 +0000 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 31G8pZN6002683; Thu, 16 Feb 2023 09:06:33 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3nsf973h5f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Feb 2023 09:06:33 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 31G4JYkl010684; Thu, 16 Feb 2023 09:06:32 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma04ams.nl.ibm.com (PPS) with ESMTPS id 3np2n6xe4t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Feb 2023 09:06:31 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 31G96THf48300430 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 16 Feb 2023 09:06:29 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 62F4F20049; Thu, 16 Feb 2023 09:06:29 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B58E820043; Thu, 16 Feb 2023 09:06:28 +0000 (GMT) Received: from [9.179.9.244] (unknown [9.179.9.244]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 16 Feb 2023 09:06:28 +0000 (GMT) Message-ID: Subject: Re: [PATCH 2/2] dmaengine: make QCOM_HIDMA depend on HAS_IOMEM From: Niklas Schnelle To: Baoquan He , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-s390@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org Date: Thu, 16 Feb 2023 10:06:28 +0100 In-Reply-To: <20230216073403.451455-2-bhe@redhat.com> References: <20230216073403.451455-1-bhe@redhat.com> <20230216073403.451455-2-bhe@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: jft_d8iaQoMDqmwl8QUaAms192uLi51l X-Proofpoint-GUID: ufE62dfTdphCQlr0y9mr8FaQKnSSoo71 Content-Transfer-Encoding: quoted-printable X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-16_06,2023-02-15_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 spamscore=0 phishscore=0 mlxlogscore=999 adultscore=0 mlxscore=0 impostorscore=0 clxscore=1011 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302160075 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: ht87pp7kwcdem3iho5wongh4pt8mhdtd X-Rspamd-Queue-Id: 31DBBC0015 X-HE-Tag: 1676538398-569638 X-HE-Meta: U2FsdGVkX18m0q11NRkSYxOmMYBV+yQ8PJ7nd0+d565zW3RDY1/GOGGLuveQZ18eRZ8FcnTDCxXSY3NVrdummQ+yYq4UI5xNo8y1ev2y8BQesXFmklABDpGz2jQROUOb5RTrq0W/zHc5biYX/N9izHHvyCdtKnVqmFle6XlUzak5jwlY+Mn7n15if0FctEeUJCC6M/7+B15OAKKsxMRv9gQZoDLkE7uaYd+9zfS2j0jkQS6ZtC1+U5B9NreDlNwVo6hMhlWrU4PQr4Jxj7jDTrp9Oxnfibrm9qU0d8DBgYYiI32eJDbD3N3Eimo1N0DvWA1B2sGqdeT8RDQw1d71lww/f9ZWfTS8VdBY5gIgFcocd5mvOEh8W2c3LNZLoTB1y4fp46FITVyjDD/xVFfI1Xmx54FZeVHEuMFOWHZRaCswj9bODpGEi4fDpM+wYa3mBPFZwW7AMRlrbebN8h2Kio1+kmyDZi4OiR1awjQtuwASjNwychxRjyhnymkt1M8QM5ORuKvN0u2anz80VUhVkGX/2z3J+xPQGzRWSMnXpO6KwvXmAzb6fCEwymdB6CTVlMFLyfapPIk204aqb6ydZmvu+RjgtfYusJc8FTctx+qNmiug5s37fcoximQovWA9stRJq6uuChzg7JkRXptn3ar0WcDaY/WoaXQtHGnY3JdJUCV+JGu0pwONa2Azhu/0JCAtsfbz4V2QT+2jy80fnjgQe9YFhmGXlGdPDo03uBI8Mcw1H/tLWc6iR90YDHx90zTwKC4Aeg/RSG3BVghEQQjNgrPjL8GoXAV5RoDVAnpgZh5wqqnHNF61dZH+AxktKc5yVIjSAsA1e4pMoW/fVYrf62nMTnhJwGyfIuspwZtSWauHz+8O1rNzNO4CJvOZDpqXpDYnavMd7qHB0utwA9mqkm8X6rtc8UR1YZqEMThkqBJtV+METsW8cwdL4nEL36ybJ7bMPnv50b5UIEA 85tAPJsF 6foTBfen8TvRH7F6X+zc7GjkL/fLdkN2pnJgFOQZDMzQHtExdPpMn6l8Ncr290pVmFa21tunMh26+RYWt9p8VZliOzQ1lANBJTRVHDXBnhKV98gx+u5VJBXvOdPZvEAfSbTiCD6tMXnwtPhbKeQFezuAZVYUer123QtE1l2zgAME4S4aIVKVNzmRJhCUJVgTjwzukfgLPD3XfRIv70Fqtg5ax6Y+CRRhLCcnWEpFS1riwUYDjV+NUVyNzO5lEIGl3uVcXz6oWu8Ha7ustru8Q6baWf+j2TW3mpvTCL8P4+ilNr1XB1gVTOuFt3+xps1f0+uvT77ZizBPaEPXdr6BoZWB3C+S0hbUzYI0kfCKAZtCizgU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2023-02-16 at 15:34 +0800, Baoquan He wrote: > On s390 systems (aka mainframes), it has classic channel devices for > networking and permanent storage that are currently even more common > than PCI devices. Hence it could have a fully functional s390 kernel > with CONFIG_PCI=3Dn, then the relevant iomem mapping functions > [including ioremap(), devm_ioremap(), etc.] are not available. >=20 > Here let QCOM_HIDMA depend on HAS_IOMEM so that it won't be built to > cause below compiling error if PCI is unset. >=20 > -------------------------------------------------------- > ld: drivers/dma/qcom/hidma.o: in function `hidma_probe': > hidma.c:(.text+0x4b46): undefined reference to `devm_ioremap_resource' > ld: hidma.c:(.text+0x4b9e): undefined reference to `devm_ioremap_resource' > make[1]: *** [scripts/Makefile.vmlinux:35: vmlinux] Error 1 > make: *** [Makefile:1264: vmlinux] Error 2 >=20 > Link: https://lore.kernel.org/all/Y0TcaZD4nB1w+mAQ@MiWiFi-R3L-srv/T/#u > Signed-off-by: Baoquan He > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Konrad Dybcio > Cc: Vinod Koul > Cc: linux-arm-msm@vger.kernel.org > Cc: dmaengine@vger.kernel.org > --- > drivers/dma/qcom/Kconfig | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/dma/qcom/Kconfig b/drivers/dma/qcom/Kconfig > index 3f926a653bd8..ace75d7b835a 100644 > --- a/drivers/dma/qcom/Kconfig > +++ b/drivers/dma/qcom/Kconfig > @@ -45,6 +45,7 @@ config QCOM_HIDMA_MGMT >=20=20 > config QCOM_HIDMA > tristate "Qualcomm Technologies HIDMA Channel support" > + depends on HAS_IOMEM > select DMA_ENGINE > help > Enable support for the Qualcomm Technologies HIDMA controller. Thanks for the patch! Reviewed-by: Niklas Schnelle