From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84667C7EE30 for ; Wed, 2 Jul 2025 08:29:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0451A6B00AC; Wed, 2 Jul 2025 04:29:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F37176B00AD; Wed, 2 Jul 2025 04:29:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFFCD6B00AE; Wed, 2 Jul 2025 04:29:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C88956B00AC for ; Wed, 2 Jul 2025 04:29:00 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6F0EFC06D3 for ; Wed, 2 Jul 2025 08:29:00 +0000 (UTC) X-FDA: 83618649240.21.D1C88B1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 07C13140007 for ; Wed, 2 Jul 2025 08:28:57 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JFb98nSV; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751444938; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HzbQFqLIkZ4mMZ8AYNo+jHz+PQn+lq0iEDVgmGYyPOM=; b=lUJqtEvGePZ0j/QlXIDGstxpwIZXqHVHObZFWgSHKYxoF2k0/NMFMO10vYzonISu5+8WWm EiKrd8m87tIlQi0pMKzCoVt0Rqh1P42jqCDqQBUQCYA3miXXchnOrngBgxuGBaMMxoQwTX 54H05bAMsOJIb/srR9Qx9GyzaRhqXy4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JFb98nSV; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751444938; a=rsa-sha256; cv=none; b=GJA40eTJ41z9wzVFqkoOp1g8HStebW11650dZv2SlvmlHBSm3QOQWln9cU5h/UoofqncXI WU+h3OEcMeKqM4DdTX4tOXHI8QeEF04ZcPcGF+vccIxGayldLRXY8ct6Z/qAd0fu79R97c TzAyNwLyKiFYyIdT6lQlvFXnVemf7ds= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751444937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=HzbQFqLIkZ4mMZ8AYNo+jHz+PQn+lq0iEDVgmGYyPOM=; b=JFb98nSV47F+U5wa/rPr2Qbyp7G20wSa5tkSPdHLah0sLcYSoHRnZ9RLi666WJf4pw2H+t +tjH4jObCIMyNVduvYmpzKifEcYFcpp7kdWJ3qsMW0wR6q6uGduRXkhHB99qngvLbHuG4T 4kTXz91KsYEk6S7CFV4wfxZKsgp2nRE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-224-3Z-3O6xgPM-9gjq5SJpWyA-1; Wed, 02 Jul 2025 04:28:54 -0400 X-MC-Unique: 3Z-3O6xgPM-9gjq5SJpWyA-1 X-Mimecast-MFC-AGG-ID: 3Z-3O6xgPM-9gjq5SJpWyA_1751444934 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a523ce0bb2so2251957f8f.0 for ; Wed, 02 Jul 2025 01:28:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751444933; x=1752049733; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=HzbQFqLIkZ4mMZ8AYNo+jHz+PQn+lq0iEDVgmGYyPOM=; b=vZsPsUd+WRXn4sTyl9GXrJZ1PrU6meKnEswG9wnxfJBdW63PhxygBkT7T9rgXtHo5k LDxlnN2ooPefgpjbtbrkePLLzxF4a+n4x/IYSJu/sOizvLwaHuuVcjh7N/ysvsCXcpU/ e5U65GR6eRCfvagILr1/cVNjkpzVsaOQg3C3gkhvyZVBi7PFlLuKRIw9Elc/xohetn2a OS1e5W40J+yGoN39MSIfURo+0i6VJRO3Hyt819ofChfYa6OEGxxv1OoZm6A+IOcLRWwa DmXmJtBBQ2a8dZbCo69okvtrwS8sabnQ54gbN7g3THD1mcBoi54IBbgUvx2eb5JOu8s1 JO6Q== X-Forwarded-Encrypted: i=1; AJvYcCWXIdZ5fRJGXFPVd9MycXQ48vB3UkChSB/g5ZyTKtnKCT/qZ7GKSNdn7DKO/nBL/4RCPnZE+hqSjw==@kvack.org X-Gm-Message-State: AOJu0Yy8/Be3CYF3Rfah/kOi+PS4HewBRnjLmS9sCxZBDgEahp25H6VV vr0+SN04BmOJviVZFIVxGfGMSjkVEp3mh6pLNzmLI2c9x0wAYqPUVf0idqWRiJmkIN5b/nzIgz5 TjHecUzHMBsxPAsKpesYrmadEeKe/1H2XQQDLoSpe+jFAQqCpc1hM6rAShrJl8wQ= X-Gm-Gg: ASbGncvSHb+/+EjuXRX/TM5R+0cxXW4Mzq82Z1rwJl9dxTBPj5L65JvJS/aaAWBiHKH 87gE6JASWu0a+uIAQw2m/HAaL6bmNSTfpNfB7m2CkC23TTrzfT/48E1N9YAZAsNBvBvDobZFiZG /pFXScOINfnSD5Kq2x7SKpJRePW0ZAtdZMJNTKnkbY0Fgz2onaSu1GW8bWNFtRv8GuwqoZBo4w3 rDCEu1q+Jx+wKjYOZ6wvYm2m2uuK07MKrvi/DL+GStKUnFkxSZNeSSkXDGj0MwniOIG4+XkdV+z 8GzL2Wz7Pjidvw0UUNrAWl4p+2PTD9hdCC2Q/cvTSnIwRz3QZuv+hGI= X-Received: by 2002:a05:6000:703:b0:3a4:f6ba:51c8 with SMTP id ffacd0b85a97d-3b1fe5c082fmr1259453f8f.14.1751444933499; Wed, 02 Jul 2025 01:28:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHU4GPCoUJnaI5KrpPRxbohExSM4p/V+1hC5zWtpV0MmAymkrtexckqli/iTlrYjgsiXsuFcw== X-Received: by 2002:a05:6000:703:b0:3a4:f6ba:51c8 with SMTP id ffacd0b85a97d-3b1fe5c082fmr1259424f8f.14.1751444932931; Wed, 02 Jul 2025 01:28:52 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538234b382sm222400965e9.9.2025.07.02.01.28.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 01:28:52 -0700 (PDT) Message-ID: Date: Wed, 2 Jul 2025 10:28:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: pagemap_scan ioctl: add PFN ZERO test cases To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan Cc: kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250630102443.137809-1-usama.anjum@collabora.com> <20027e0c-f43b-4d10-a4d6-41dcc38145bd@redhat.com> <6846faf7-20b5-4f08-a8f0-9946f993b0e9@collabora.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <6846faf7-20b5-4f08-a8f0-9946f993b0e9@collabora.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bXfi3MWmHWM7FcFGsAl1b0q513PCgUkImnEGeNGZ1IQ_1751444934 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: i48o9fpayaya3y9eh96rzierh338cgk7 X-Rspamd-Queue-Id: 07C13140007 X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1751444937-502085 X-HE-Meta: U2FsdGVkX1/xHqMRz61+hoFPlWTcdcIiPTLmTpqn7KZ2RFiLdByMgr24jYjyUx+fqBG9y3/BSOZ97hxW8lZ2fjItuFX7NBWA5Hkl8yFJVHTjul4ZD2D6wlMt5cPhDiaGGZ4vCNbgqLve7Y1oQZGgSq/do7Ro6wNlXloQT5cff8LCKvaDwiRLiu7vC2XRdIUoZjgmGJ3VUMvceWpbagpVQcOVDgBqCDryDHpYHasN+dEG4yrWaAddFurppyv1phBUbUZ/ZJJs3i0rZv4g7as+LkCmXowo3fZWS1CMrTkr+Yhr93AuusmESLsExJOifrhHVo9A/Nc7F1/sBhBpkrs+CBJCkjo8XD0x8MnBFUXt0LYaMJCkkXFcably8usznSJ/1En0e/CqFGpnqmPL0ANuyFGKuZASHycgd0m1qmSrhQlkKuybnbrlSl2j9oOjZyRATpZIy86xl6HSeEyQs7quJEOBEIxEUzYbEZ0CrVFOgt/Bqogc44KmC9z4050aRt2PYxlB5pfobRvpqhRySBT953R+NZNdCGtYMO+shaP16Bn2+CvjRnyFOJdE5vUIPo9eyLeim/0kw29uo9WchBe7fO3ZTZUKEUmSn+9Ij3gMiU70ebzbXLRHFLtgiNkAiLMYlQ0bfZova0B7w1+d+S/hsyp0Clu9zRaEp3d7VxhhsmYR3XRALRsbo9JjAQ1LB+1wh+8tMw+OsbsXLKekQJdNoNJSRwD7vDhFzKTVJQm+mnafayTLz8AFQ/EHqgM6f1R8Whu3HU2EF4UNkTU+fq5Va30l1moHfgKPj++wSrt0OOCHKCenK/WbkxWo5eFV03npX0F1GrspuZ4cMoTx4mthjoy/OyIl4d5OcpWvVLc40DjbLcypg3A1uiL5vbc7zhX886LGfXCM2f7Xtew9smcyuQqxm23gmTjb+QjxDps9SsUNPwxXuiRkNIrfYoIStnGwBpUrJeepJ2pFugjM+Et TC5WjC2x UGHzVuoUMX7az0RbJ8f0U7QP/zgjDcfxIF1omoT6O5Kh9k5dq3yYmkckJIthyF19tN/yQGprPC1OSiCzDWZinvteXxiS0pHQF8q8kpgKRgpqgLvBqiRxuKXUSSZ2EWaZAyVR3jkVLj5ZWPNKB7N7ct/oN1MQ05bRrZZwsLPPp6yEKWoJVaWox8ZHW0jRprLnP0V6aBrvf+mFXH9TBTejM5vQxvliOkNRiDbSmzZ4euDnuogk+oG0Qm3wvMo0sdhHzFjc7fBf1eTnxCFOTa8yvERMtVnK7bdpDhNzy6vP+DtfTnDaqW4jNvVvq+FQJii2oMjKdjZ2En50XEyWrtwbl8/dsXzxSQX/R1eLoK3Clfsj7JOkd6U/ep5P/TOkbNdJc+W+DR8ZwtDUXCrHjIAsgX+8lkl2Y0t05nwUupqke0kcY5+TeryWDNeLL/gGxBGTCJbrVkWb+knJcYQVZe8Me2IrON83nCJ0uCqsYTqK880Hnqf5u+Gk40LcbsHVKUJ0Jbs823K8rX4/CAYVhgvwCiP+1NGi2iZuZd2z2JoigASYBxZiqStxY9vgVMdsEOJRGysXrk4rshCCYm4Nb0asYU3d51uSEm9E4DgDQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.07.25 09:39, Muhammad Usama Anjum wrote: > On 7/1/25 7:51 PM, David Hildenbrand wrote: >> On 30.06.25 12:24, Muhammad Usama Anjum wrote: >>> Add test cases to test the correctness of PFN ZERO flag of pagemap_scan >>> ioctl. Test with normal pages backed memory and huge pages backed >>> memory. >> >> Just to verify: would this trigger on kernels before my fix? > Yes, it does trigger the bug without the fix. > >> >>> >>> Cc: David Hildenbrand >>> Signed-off-by: Muhammad Usama Anjum >>> --- >>> The bug has been fixed [1]. >>> >>> [1] https://lore.kernel.org/all/20250617143532.2375383-1-david@redhat.com >>> --- >>>   tools/testing/selftests/mm/pagemap_ioctl.c | 57 +++++++++++++++++++++- >>>   1 file changed, 56 insertions(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c b/tools/ >>> testing/selftests/mm/pagemap_ioctl.c >>> index 57b4bba2b45f3..6138de0087edf 100644 >>> --- a/tools/testing/selftests/mm/pagemap_ioctl.c >>> +++ b/tools/testing/selftests/mm/pagemap_ioctl.c >>> @@ -1,4 +1,5 @@ >>>   // SPDX-License-Identifier: GPL-2.0 >>> + >>>   #define _GNU_SOURCE >>>   #include >>>   #include >>> @@ -1480,6 +1481,57 @@ static void transact_test(int page_size) >>>                     extra_thread_faults); >>>   } >>>   +void zeropfn_tests(void) >>> +{ >>> +    unsigned long long mem_size; >>> +    struct page_region vec; >>> +    int i, ret; >>> +    char *mem; >>> + >>> +    /* Test with page backed memory */ >> >> What is "page backed memory" ? :) > I mean, normal memory which isn't huge page backed. I've renamed it to > Test with normal memory. > >> >>> +    mem_size = 10 * page_size; >>> +    mem = mmap(NULL, mem_size, PROT_READ, MAP_PRIVATE | MAP_ANON, -1, >>> 0); >>> +    if (mem == MAP_FAILED) >>> +        ksft_exit_fail_msg("error nomem\n"); >>> + >>> +    /* Touch each page to ensure it's mapped */ >>> +    for (i = 0; i < mem_size; i += page_size) >>> +        (void)((volatile char *)mem)[i]; >>> + >>> +    ret = pagemap_ioctl(mem, mem_size, &vec, 1, 0, >>> +                (mem_size / page_size), PAGE_IS_PFNZERO, 0, 0, >>> PAGE_IS_PFNZERO); >>> +    if (ret < 0) >>> +        ksft_exit_fail_msg("error %d %d %s\n", ret, errno, >>> strerror(errno)); >>> + >>> +    ksft_test_result(ret == 1 && LEN(vec) == (mem_size / page_size), >>> +             "%s all pages must have PFNZERO set\n", __func__); >>> + >>> +    munmap(mem, mem_size); >>> + >>> +    /* Test with huge page */ >>> +    mem_size = 10 * hpage_size; >>> +    mem = memalign(hpage_size, mem_size); >>> +    if (!mem) >>> +        ksft_exit_fail_msg("error nomem\n"); >>> + >>> +    ret = madvise(mem, mem_size, MADV_HUGEPAGE); >>> +    if (ret) >>> +        ksft_exit_fail_msg("madvise failed %d %s\n", errno, >>> strerror(errno)); >> >> Might fail on older kernels, so we usually treat this as a skip. > I'll skip it in next version. > >> >>> + >>> +    for (i = 0; i < mem_size; i += hpage_size) >>> +        (void)((volatile char *)mem)[i]; >>> + >>> +    ret = pagemap_ioctl(mem, mem_size, &vec, 1, 0, >>> +                (mem_size / page_size), PAGE_IS_PFNZERO, 0, 0, >>> PAGE_IS_PFNZERO); >>> +    if (ret < 0) >>> +        ksft_exit_fail_msg("error %d %d %s\n", ret, errno, >>> strerror(errno)); >>> + >>> +    ksft_test_result(ret == 1 && LEN(vec) == (mem_size / page_size), >>> +             "%s all huge pages must have PFNZERO set\n", __func__); >> >> Wouldn't this be able to fail if /sys/kernel/mm/transparent_hugepage/ >> use_zero_page is set to false, > I wasn't aware of it. I'll check user_zero_page first as initial condition. > >> or if mmap() gave us a suboptimally- >> aligned range? > mem = memalign(hpage_size, mem_size) is being used to allocate this. So > aligment should be correct. > >> >> You'd have to read each and every page to get the ordinary shared >> zeropage in these configs instead without making the test too complicated. > In the above for loop, we are reading each new page already. Let's > resolve this and then I'll post the v2 which is ready. > >> >>> + >>> +    free(mem); >> >> >> Shouldn't this be an munmap() ? > free() is being used to free memory allocated by memalign(). Oh, I missed that detail. I'm afraid memalign+free that might not be what you want: there is no guarantee that what you are getting hasn't been used before and is not already filled with other pages? -- Cheers, David / dhildenb