From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23EC9C433C1 for ; Fri, 19 Mar 2021 17:42:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C11E861925 for ; Fri, 19 Mar 2021 17:42:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C11E861925 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 302326B0074; Fri, 19 Mar 2021 13:42:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D9166B0075; Fri, 19 Mar 2021 13:42:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17A276B0078; Fri, 19 Mar 2021 13:42:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id F1E376B0074 for ; Fri, 19 Mar 2021 13:41:59 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AE491A2A9 for ; Fri, 19 Mar 2021 17:41:59 +0000 (UTC) X-FDA: 77937341958.13.631021B Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf29.hostedemail.com (Postfix) with ESMTP id CF6CA79D for ; Fri, 19 Mar 2021 17:41:53 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id o126so1741002lfa.0 for ; Fri, 19 Mar 2021 10:41:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UJBwv3+scWtdnjoEEcvwzg70Xr2SAona42n3GhDaRo8=; b=EGxUeaqh7gZ6zW6IxD0oLKsRXYcvjWT/cWSuO1zUBl/uag8YlM6DggPJMLLvVkNIei S2EEVQ5ik667esLxtTLddpIkIioh9MLinW0z38Ki2f541TkMMBJwnhkmITSp5n3Inr7P orIP5rLVLcCnDStiRyLf6LzKYbBpbuxaSMV5RWpbKTQzwXLLJFxXoL3WYoSuisEIUelz 7DwTG6v1bYVbYAgDjnjYK+icR7v0u5hWTeIrQKQvz2O1YgoFZPfA4SpEBT61dSOkx/au pMywlyy1DFBD3weNpN2m4kGG0CkWRvKEqH/GUJnWy4ZHkHfXazRLhQIavFCjfwrqno0l 3QHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UJBwv3+scWtdnjoEEcvwzg70Xr2SAona42n3GhDaRo8=; b=ZESPi2LpKZWGy3dnJkP23bqZL6N1L6a1RbXHFWQT4vgzJwrGKbE44ZAG0MfFSs4mZp kmk+GrDPIAgfLQlR7H4yszTf0hPxGLiH7iWxwb0pHZ/PlnSiPwsAZsGlLdsNmJk0pVAR 8StIvGiMnw076KrD5rzABpVfOIWZTJ+tm7OBijx93Qifp3D4aDxiYbjUo3HnJx/hH0rV 6tW8hBZ+DQHVzCkpQ5OAQpVfWsksQ/aHKDpJybpc4S/td71nir4M0Z57+A8xq4sE9Kbg jShiV8Z8mPsNW7YmWNQoMlFt0L/7Zd1aoASIT0r77n7vGwAE/BUcowCzYgJboeosOyRh M0EA== X-Gm-Message-State: AOAM532J2MLdmctnxxKGNVic8Jbdhf/bdY585ks+b350BJGni1N9IhnR wNSAUhNrCo3CmU6MXsOr8sI= X-Google-Smtp-Source: ABdhPJw37m3EPlJ8q46cVxOkVst/rTJG4abkNKD3e0LChybJTMCGYEWRlX9IN/R9Ei0YQjH86lSnQw== X-Received: by 2002:a19:e48:: with SMTP id 69mr1327591lfo.469.1616175702251; Fri, 19 Mar 2021 10:41:42 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-52.dynamic.spd-mgts.ru. [109.252.193.52]) by smtp.googlemail.com with ESMTPSA id 192sm847746ljj.95.2021.03.19.10.41.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Mar 2021 10:41:41 -0700 (PDT) Subject: Re: [PATCH v4] mm: cma: support sysfs From: Dmitry Osipenko To: Minchan Kim Cc: Greg Kroah-Hartman , Andrew Morton , linux-mm , LKML , joaodias@google.com, willy@infradead.org, david@redhat.com, surenb@google.com, John Hubbard , Nicolas Chauvet , "linux-tegra@vger.kernel.org" References: <33ec18ef-8652-643a-1a53-ff7c3caf4399@gmail.com> <78883205-e6da-5bc4-dcec-b6eb921567b1@gmail.com> <72db59eb-75dc-d1ed-7a83-17052e8f22a8@gmail.com> <82bde114-60c0-3fde-43f4-844522b80673@gmail.com> Message-ID: Date: Fri, 19 Mar 2021 20:41:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <82bde114-60c0-3fde-43f4-844522b80673@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Stat-Signature: 3bgm7eedyc5yhhacpkki4gkcffri4pjw X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CF6CA79D Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf29; identity=mailfrom; envelope-from=""; helo=mail-lf1-f42.google.com; client-ip=209.85.167.42 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616175713-827226 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 19.03.2021 20:29, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > +void cma_sysfs_alloc_pages_count(struct cma *cma, size_t count) > +{ > + atomic64_add(count, &cma->nr_pages_succeeded); > +} > + > +void cma_sysfs_fail_pages_count(struct cma *cma, size_t count) > +{ > + atomic64_add(count, &cma->nr_pages_failed); > +} The atomic looks good, but aren't CMA allocations already protected by the CMA core? Do we really need to worry about racing here?