From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DA40C4345F for ; Thu, 2 May 2024 13:16:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 811846B0087; Thu, 2 May 2024 09:16:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CA2D6B0089; Thu, 2 May 2024 09:16:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63A796B008A; Thu, 2 May 2024 09:16:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 44FB26B0087 for ; Thu, 2 May 2024 09:16:03 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D00C0120869 for ; Thu, 2 May 2024 13:16:02 +0000 (UTC) X-FDA: 82073503764.02.FA011C6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 95AE0120015 for ; Thu, 2 May 2024 13:15:59 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DebgjKTj; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714655759; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yJRM9yLGjCQ3X2KTtow0XulnnmVUDuYuBv4ldY/21BM=; b=qxjslBqU6my7b6CQ/1fh/sj83R1puUd+rskZUiFoVl5ozLPl5otJsRnDjiSXbM2SMraNqt xdjNoBMD/eQVrbfYwSMvTL7bf9iwgXBKv8qqj0uo5Q45n0xPr842b4GVPrgrvjaURCGcb6 abta+H4guHb2hfSUH0U8Tif6cb0e4vQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DebgjKTj; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714655759; a=rsa-sha256; cv=none; b=6rVieRRdkB759nqOXWinLkOiE6cCp/x1EHewKz8cHXiTaM4YRZuTJTOdb33Lg48otYTQmT mi49nSIfpXO8y+b3gzWTNZINLNtvXlaMaIc8m/A0w7P5vpu4Q7MUFy8mZO/Cpgu7R3jlwv 1qBciCDWjsiIrHWc4cpT8RqwJv3C/T0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714655759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yJRM9yLGjCQ3X2KTtow0XulnnmVUDuYuBv4ldY/21BM=; b=DebgjKTjoFMAT04RbWQXXNlHS2w+4SW7RQAladynqVuYtRc1Gmn8tkeP5uNqnGam76bYNx GG0UAX6g3eE/FweCbsampNIly8NbbJvQUqWXaT2AvndOYae1ioCy+0tyk2sQEZp14gFjBp yikTozw8Yf0672iPjdKLplN3nrGqrts= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-YulUEU_INF6MVVkpJrsrKg-1; Thu, 02 May 2024 09:15:56 -0400 X-MC-Unique: YulUEU_INF6MVVkpJrsrKg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-41a370b6acdso35361075e9.2 for ; Thu, 02 May 2024 06:15:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714655755; x=1715260555; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yJRM9yLGjCQ3X2KTtow0XulnnmVUDuYuBv4ldY/21BM=; b=LxOh6A2oIlycpPiRhFbEsk8355VDPWzstGz+v8AOe/ClTEbWLsySyZNjZJ6YO0jy1y CYSKIJ6/0jJsWOIej5COZgnSlCYWqbA4GFTD4ymQhJ3kjMveLSOLGjUdWsbZj7Bk7wA7 CddiGc1eJUKiw4CRDoNfLxyGqgev6LUD7F3/TOqVAh8XBmoxLRk68ZDlYoraH2Ae65J7 uIRsQr/1oHI+NJQmX3TTGqoTGbhyHyUkvt46R9kj4zber6UyTeOXHpukTzMts67D+4go 71H5n144IRqj3NBkJiejAz8mWbGmR8pgirGfYFav3eCmbIKZpx4oMGAnXtZCH52kIcpD fimA== X-Forwarded-Encrypted: i=1; AJvYcCVvcKdD87VORCZJR8TB4OgFIcXXoALPRe68ZmCoaVRUV8q4IAgBlU26VR191u1A4ED2pFxOW8NaBHFRjt0O8hLOo20= X-Gm-Message-State: AOJu0YxtUuupSHDoSKnDIrT1iDkGxjvh4b5Fhe/DMzjdczsbIev8WQ4R SHSeViwmqNsuTM4QnBEom829HdlBSwAEzrb40fuzZr/keSqHMUOBaCJuTSBdoK17hawDBKdUEFY 9Qnjhxu53TiVYmyPJLiOjCpcqMVh6Tx6Myv0EEFsr7ahavQQc X-Received: by 2002:a05:600c:5347:b0:41a:f9db:88ac with SMTP id hi7-20020a05600c534700b0041af9db88acmr4205371wmb.14.1714655755538; Thu, 02 May 2024 06:15:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHIdIVLBhB+0aie2kvkajxvjiyhxiVZplyKjASYKUxI+SOW9NeCEQX4xWLxZvFVP3TIfqcaow== X-Received: by 2002:a05:600c:5347:b0:41a:f9db:88ac with SMTP id hi7-20020a05600c534700b0041af9db88acmr4205355wmb.14.1714655755077; Thu, 02 May 2024 06:15:55 -0700 (PDT) Received: from ?IPV6:2003:cb:c71e:bf00:eba1:3ab9:ab0f:d676? (p200300cbc71ebf00eba13ab9ab0fd676.dip0.t-ipconnect.de. [2003:cb:c71e:bf00:eba1:3ab9:ab0f:d676]) by smtp.gmail.com with ESMTPSA id s7-20020a05600c384700b0041c12324eb6sm5728258wmr.22.2024.05.02.06.15.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 May 2024 06:15:54 -0700 (PDT) Message-ID: Date: Thu, 2 May 2024 15:15:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/hugetlb: align cma on allocation order, not demotion order To: Frank van der Linden , linux-mm@kvack.org, muchun.song@linux.dev, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, Roman Gushchin References: <20240430161437.2100295-1-fvdl@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240430161437.2100295-1-fvdl@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 95AE0120015 X-Rspamd-Server: rspam06 X-Stat-Signature: foqfktbbnp4z9nn6ucbxm7ojqhgyaeps X-HE-Tag: 1714655759-815333 X-HE-Meta: U2FsdGVkX18EAPiuu9HZ7t8lmmy0rQY1d3+zlYAcbGuyrpb70EcgfF5u3KvTooGjdIJmgiAiKVcrHjW+eLPB1p9iMgKrfdcNHsqimlc9PTZbUnsoQ64Llz0EZS2M5J60CY4tNdQngtsSEJlaSe18ttJrrj3mocwovhKmplScOjrQDccASKh8OM7IGICLjnbYYjx4THe/yAhApnjw+72J56LH6LrE21HYUk1C09jLANZN/6O+Pa9YkS27oo+dPlIiwLBTO2ke/BlP/lpTeu2MtiWrR2+cYRT5/+s3EJxk4nt/hRIEXbhExPXrmDpvQDDt52HBVGK95zW5vEklY0WXDnm9KENeHC7tl4HSFvFfQVlLuq48oUlkeI/AXS4JV6ds3V4yDAV+yR9nwWeiphF1epaSUsLRy7sK6nEFB81lqxoSfjzvm1CK1RWESEcYc0qgm/b4Sxzxlu+hwv+W8OD9ST6VAYYVZYGz3WSbLEvCYwNTRPeHihYLea0g6pvpgcNwq/S7jIHHXHZ00G8Ep/RxiEVPBSK2AHE4L88jCjKEOQVt/zzVty+pJhj3rgG0w87fYll0hI2mdeKpXiJqPdClwiQhAmxycYc1VB+MeeTZOIWLJfgRc374/RwqSx0UB5m1K57xysnNCZ/7NUZHr6srRU5aWiQOVhn14yDEgPljo4Z0rUgRLlqiG44NeskiJuL24UlHPtyG3QXRL3j15bMBRQ3PWl/kh2+BcbXYYxblXYNAby2wk32CGoREuLhb6OtIo6EIf04bo62q6wtbiO545cNzwpDHKPA2P0LbYKvFXBpAbumIyuHwXT73W1ab7SMpl1/YFg3J3HCg2OLDfSmcFY0EeriYPpDvsuMdkS5SDoECyzVESuibUNwuYNqizJqmnIhYUH1SC2DgaqLzZ8HOd+Nms5ZsQ/BnTbCgOaJiikkv+KKg4/wP5t9hX+yK/cm+3EdzI9Nh0HmOsmZY298 utBSsbaC BmCvqUfAH6J6oBjl6Z3+dyQwbBhNtvjCcrhnbx73OWmCAJUXf4FYy8EC6mmLDiXZuBqcZaMYn2fBVQljsLWqJzrypWduKnPwsNypFdJGvZZQn1YngDldW+1Pg0dNFujC//tM2808byqgqNLGGKSmw9yvHKKDG6Dgl2/VQ2u+7d3Rlq1ZNKMZ+ORZ/zMjk7d1x8gTY5W204bqRK+LXGpdtml5nM0pWdJLXPNE3IEZ1ACuC67TDwA5hJ/y6T/EPTLi/Iclmeh+05eQ6wNatRd6Znp8lkTcuL26VcvZ+RcWClhrgHQ5ZMxn4cW5K+v27nArPa2NVono8sNtfwv2+IEVWqPm6TJnPYKWEQ8dMLNvAM2PymGVh1NZ11z81aOAySuajkgxGq2RSw11YBWdVhLuo2qJDRpWtFherg8fUUUZAz7NxTj68VKpdwVO2KwYkXzGoluP7aWg9sdz1vu778X+VwlGjGmOGeB06RwKpq6Zg9Ybb2egKM3U4oiKVgCa0k/5qDtXZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.04.24 18:14, Frank van der Linden wrote: > Align the CMA area for hugetlb gigantic pages to their size, not the > size that they can be demoted to. Otherwise there might be misaligned > sections at the start and end of the CMA area that will never be used > for hugetlb page allocations. > > Signed-off-by: Frank van der Linden > Cc: Roman Gushchin > Fixes: a01f43901cfb ("hugetlb: be sure to free demoted CMA pages to CMA") > --- > mm/hugetlb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 5dc3f5ea3a2e..cfe7b025c576 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -7794,7 +7794,7 @@ void __init hugetlb_cma_reserve(int order) > * huge page demotion. > */ > res = cma_declare_contiguous_nid(0, size, 0, > - PAGE_SIZE << HUGETLB_PAGE_ORDER, > + PAGE_SIZE << order, > HUGETLB_PAGE_ORDER, false, name, > &hugetlb_cma[nid], nid); > if (res) { I was wondering how that worked when reviewing your other patch. Wondering why we never got a BUG report, maybe we were always lucky about the alignment we actually got? We round up size to PAGE_SIZE << order, so that's the alignment we need. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb